athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-07-01T18:29:28+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43555Remove sTGC PDO Charge pedestal2021-07-01T18:29:28+02:00Alexandre LaurierRemove sTGC PDO Charge pedestalRemove sTGC PDO pedestal added to the strip digits.
This was causing issues in the clustering algorithm.
This pedestal will need to be added back once the proper tools are written into place.
Extra note: Fixed some horrendous indentations.Remove sTGC PDO pedestal added to the strip digits.
This was causing issues in the clustering algorithm.
This pedestal will need to be added back once the proper tools are written into place.
Extra note: Fixed some horrendous indentations.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43421Migrate preInclude.Run3G4Optimiziations.py back to python 2 syntax2021-05-13T09:22:52+02:00John Derek ChapmanMigrate preInclude.Run3G4Optimiziations.py back to python 2 syntaxThe original version (backported from ~master) used python 3 `print` syntax.
FYI @tadej, @nkoehlerThe original version (backported from ~master) used python 3 `print` syntax.
FYI @tadej, @nkoehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43416Manual sweep of !43415 (Use new Run3 simulation tag in ART tests)2021-05-13T09:23:02+02:00Nicolas KoehlerManual sweep of !43415 (Use new Run3 simulation tag in ART tests)Hi,
this MR is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/43415 into ~"21.3" and ~"21.9".
Best, NicoHi,
this MR is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/43415 into ~"21.3" and ~"21.9".
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43360Sweeping !43247 from master to 21.3.
Deweight NSW hits in the TrackTruthSelector2021-05-11T03:06:48+02:00Atlas NightlybuildSweeping !43247 from master to 21.3.
Deweight NSW hits in the TrackTruthSelectorDeweight NSW hits in the TrackTruthSelector
See merge request atlas/athena!43247Deweight NSW hits in the TrackTruthSelector
See merge request atlas/athena!43247https://gitlab.cern.ch/atlas/athena/-/merge_requests/43358Sweeping !42887 from master to 21.3.
Bring FATRAS conversion child energy sha...2021-05-28T15:13:29+02:00Atlas NightlybuildSweeping !42887 from master to 21.3.
Bring FATRAS conversion child energy sharing code in-line with GEANT4Bring FATRAS conversion child energy sharing code in-line with GEANT4
See merge request atlas/athena!42887Bring FATRAS conversion child energy sharing code in-line with GEANT4
See merge request atlas/athena!42887https://gitlab.cern.ch/atlas/athena/-/merge_requests/43228Remove atlfast3 art tests2021-05-08T03:05:14+02:00Artem BasalaevRemove atlfast3 art testsRemoving ATLFAST3 art tests from 21.3, where they are not needed (21.0 is the intended branch). Removing is also motivated by the ongoing reproducibility issues with these tests: ATLASSIM-5045.
FYI @ahasibRemoving ATLFAST3 art tests from 21.3, where they are not needed (21.0 is the intended branch). Removing is also motivated by the ongoing reproducibility issues with these tests: ATLASSIM-5045.
FYI @ahasibhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43214MuonTruthAlgs: Reindentation & adding of the NSW PRD collections in the corre...2021-05-09T19:34:20+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonTruthAlgs: Reindentation & adding of the NSW PRD collections in the corresponding layoutsHi,
this is another MR to address the differences seen in the reconstruction efficiency discussed on ATLASRECTS-5610. As noted by @nkoehler, the NSW-PRD maps are not processed by the `MuonDetailedTruthMaker` algsHi,
this is another MR to address the differences seen in the reconstruction efficiency discussed on ATLASRECTS-5610. As noted by @nkoehler, the NSW-PRD maps are not processed by the `MuonDetailedTruthMaker` algshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43118Merge 21.0.125 and 21.0.126 into 21.3 branch2021-05-04T16:16:56+02:00John Derek ChapmanMerge 21.0.125 and 21.0.126 into 21.3 branchThis is the list of merge requests that were included bewtween [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125) and the previous release [release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21....This is the list of merge requests that were included bewtween [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125) and the previous release [release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.124):
- !42930 : Reporting events which passed ISF_SimEventFilter for ReSim jobs (ATLASJT-417)
- !42865 : Add property to scale xtalk between middle and back layer of LArEM
- !42861 : Sweeping !42812 from 21.3 to 21.0.
- !42789 : egamma ART change from master to rel21
- !42474 : Sweeping !42384 from 21.2 to 21.0.
- !42530 : additional histograms for egamma ART
- !42307 : Add missing Charginos package to AthSimulation project
- !42294 : Apply ZeroLifetimePositioner to all neutral mesons with oscillations: B0, B0s, D0
- !42337 : Changes to propagate Pile-up xAOD::Truth information to HITS files
- !42172 : Adding LAr cell DQ plots to UPC stream
- !42332 : TCT: Increasing memory for AthenaMP tests and updating the comparison step
- !41970 : Fix test_Sim_FullG4_ZPrime_QuasiStable.sh in AthSimulation nightlies
- !42031 : Fix for ALFA_SimHitsTestTool (ATLASSIM-5034)
This is the list of merge requests that were included bewtween [release/21.0.126](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.126) and the previous release [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125):
* !42991 : Reporting ReSim events to the jobReport (ATLASJT-417)
Link to the full diff between [release/21.0.126](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.126) and
[release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.124)
is available at https://gitlab.cern.ch/atlas/athena/compare/release/21.0.124...release/21.0.126https://gitlab.cern.ch/atlas/athena/-/merge_requests/43047Sweeping !42961 from 21.9 to 21.3.
Cleanup of eFEX tau algorithm to work with...2021-05-01T03:07:13+02:00Atlas NightlybuildSweeping !42961 from 21.9 to 21.3.
Cleanup of eFEX tau algorithm to work with cellsCleanup of eFEX tau algorithm to work with cells
See merge request atlas/athena!42961Cleanup of eFEX tau algorithm to work with cells
See merge request atlas/athena!42961https://gitlab.cern.ch/atlas/athena/-/merge_requests/42841Update sTGC Charge Threshold2021-05-10T11:16:34+02:00Alexandre LaurierUpdate sTGC Charge ThresholdUpdate the charge threshold to save digits in the sTGC digitization.
The value of 20fC for the strip charge threshold comes the sTGC experts running tests on currently finished chambers, Sun et al.
Also commented out some code in the di...Update the charge threshold to save digits in the sTGC digitization.
The value of 20fC for the strip charge threshold comes the sTGC experts running tests on currently finished chambers, Sun et al.
Also commented out some code in the digitization which does nothing for now but will be used in the future . This is why the code was not removed instead.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4281221.3 TRT_ToT_dEdx added protection for reading r22 conditions data2021-04-30T16:59:19+02:00Christian Grefe21.3 TRT_ToT_dEdx added protection for reading r22 conditions dataAdds a protection to TRT_ToT_dEdx to allow running with CondDB tags meant for r22.
The conditions data in "/TRT/Calib/ToT/ToTVectors" stores more values in r22 tags, which caused a vector to go out of bounds.Adds a protection to TRT_ToT_dEdx to allow running with CondDB tags meant for r22.
The conditions data in "/TRT/Calib/ToT/ToTVectors" stores more values in r22 tags, which caused a vector to go out of bounds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42803Manual sweep of !41219 and !41524 from master to 21.3: Run3 Geant4 simulation...2021-04-23T03:08:19+02:00John Derek ChapmanManual sweep of !41219 and !41524 from master to 21.3: Run3 Geant4 simulation optimizations scriptpreInclude script containing all the Run3 Geant4 simulation optimizations
Set the Neutron Russian Roulette threshold in the preInclude sim script to 2 MeV. This is the value used in the physics validation campaign.preInclude script containing all the Run3 Geant4 simulation optimizations
Set the Neutron Russian Roulette threshold in the preInclude sim script to 2 MeV. This is the value used in the physics validation campaign.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42750Fix the mm cross talk implementation to handle cross talk 02021-04-23T18:27:16+02:00Patrick ScholerFix the mm cross talk implementation to handle cross talk 0This MR fixes a bug in the MM digitization where running with no cross talk removes all MM hits.This MR fixes a bug in the MM digitization where running with no cross talk removes all MM hits.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42525Sweeping !42421 from 21.9 to 21.3.
Add some flags so we can work with phase II2021-04-15T03:06:07+02:00Atlas NightlybuildSweeping !42421 from 21.9 to 21.3.
Add some flags so we can work with phase IIAdd some flags so we can work with phase II
See merge request atlas/athena!42421Add some flags so we can work with phase II
See merge request atlas/athena!42421https://gitlab.cern.ch/atlas/athena/-/merge_requests/42478Include particle broker in ATLFAST3 simulator (ATLASSIM-5190)2021-04-13T03:05:48+02:00Ahmed Hasiba.hasib@cern.chInclude particle broker in ATLFAST3 simulator (ATLASSIM-5190)In contrast to `21.0`, the particle broker needs to be included in explicitly in `21.3`In contrast to `21.0`, the particle broker needs to be included in explicitly in `21.3`https://gitlab.cern.ch/atlas/athena/-/merge_requests/42475Sweeping !42384 from 21.2 to 21.3.
Fix issue with short index for IOVPayload ...2021-04-15T03:06:09+02:00Atlas NightlybuildSweeping !42384 from 21.2 to 21.3.
Fix issue with short index for IOVPayload PT conversionFix issue with short index for IOVPayload PT conversion
See merge request atlas/athena!42384Fix issue with short index for IOVPayload PT conversion
See merge request atlas/athena!42384https://gitlab.cern.ch/atlas/athena/-/merge_requests/42298cleanup of MMClusterOnTrack2021-04-08T16:24:55+02:00Patrick Scholercleanup of MMClusterOnTrackThe following changes have been applied:
- pass `stripDriftDists` and `stripDriftDistErrors` as const reference rather than by value (ATLASRECTS-5988)
- Add those variables also to the copy constructor, the default constructor and the as...The following changes have been applied:
- pass `stripDriftDists` and `stripDriftDistErrors` as const reference rather than by value (ATLASRECTS-5988)
- Add those variables also to the copy constructor, the default constructor and the assignment operatorhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42256Manual sweep of !42154 (Fix for BIS78: do not use COOL db for efficiency and ...2021-04-07T13:22:56+02:00Nicolas KoehlerManual sweep of !42154 (Fix for BIS78: do not use COOL db for efficiency and cluster size for RUN3)Hi,
since the automatic sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/42154 into ~"21.3" and ~"21.9" failed, here the manual sweep.
Best, NicoHi,
since the automatic sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/42154 into ~"21.3" and ~"21.9" failed, here the manual sweep.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42240Manual sweep of !42231 (Fix read of uninitialized member)2021-04-06T08:53:55+02:00Nicolas KoehlerManual sweep of !42231 (Fix read of uninitialized member)Hi,
this is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/42231 into ~"21.3" and ~"21.9".
Best, NicoHi,
this is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/42231 into ~"21.3" and ~"21.9".
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42184Install RunDepProfileGenerator.py script2021-04-22T19:23:31+02:00Peter OnyisiInstall RunDepProfileGenerator.py scriptInstall a script so it's easier to run without having to build the package separately
Attn @jchapmanInstall a script so it's easier to run without having to build the package separately
Attn @jchapman