athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-01-01T03:03:50+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/27885RNN track classification for HLT taus2020-01-01T03:03:50+01:00Bertrand Martin Dit LatourRNN track classification for HLT tausHello,
This MR implements the RNN track classification in the HLT tau reconstruction.
For now, we use the json file of the offline RNN training.
A quick rates estimate has been done (https://indico.cern.ch/event/862749/), and seems to g...Hello,
This MR implements the RNN track classification in the HLT tau reconstruction.
For now, we use the json file of the offline RNN training.
A quick rates estimate has been done (https://indico.cern.ch/event/862749/), and seems to give good performance.
A new configuration called 'tracktwoRNN' schedules the RNN track classification, and also uses the BDT track classifier for FTF core tracks, recently added as 'tracktwoMVABDT'.
A new Aux variable has been added in the tau EDM (new entry in an enum), because we need to store the number of charged tracks before RNN track classification, as explained in the talk linked above.
In the hypo, we reject candidates that have tracks associated before RNN classification, and which end up as 0p after RNN classification.
That way, we keep the possibility to use "real 0p" (candidates for which we loose the track) to recover some efficiency for true taus at low pt and high mu.
Some tracktwoRNN chains have been added to the MC_pp_v8 menu for performance studies.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27670NSW Pad trigger lookup2020-01-01T03:03:52+01:00Serhat IstinNSW Pad trigger lookupAdding Pad Trigger Lookup Tool
Some Tools had to be modified accordingly as well
The update is critical/urgent as we are now using the same lookup table with the padtrigger hardware. There are some work ongoing with the sector logic...Adding Pad Trigger Lookup Tool
Some Tools had to be modified accordingly as well
The update is critical/urgent as we are now using the same lookup table with the padtrigger hardware. There are some work ongoing with the sector logic integration as well. So we encourage people to start using the new mode.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27084Adding an optional pT threshold for track soft term algorithms2020-01-01T03:03:54+01:00Jon BurrAdding an optional pT threshold for track soft term algorithmsAdding in a feature allowing to place an upper pT threshold on tracks going into track soft terms in our algorithms. This also adds a couple of new triggers using these chains.
These use the string `tstceil` in them to set this proper...Adding in a feature allowing to place an upper pT threshold on tracks going into track soft terms in our algorithms. This also adds a couple of new triggers using these chains.
These use the string `tstceil` in them to set this property to 20 GeV, however if this is shown to work I think we would just make this the default. Setting this to urgent as a sampleT production is planned soon.
*EDIT:* Added a setting to disable the track <-> muon overlap removal when this track pT ceiling is enabled as these are two different ways of doing the same thing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/24917fix on jobOption configuration2019-08-24T03:05:25+02:00Chiao-Ying Linfix on jobOption configurationThe tower maker default was misconfigured to take Run2 trigger towers to constructed j/gTowers, this is to switch it back to using supercellsThe tower maker default was misconfigured to take Run2 trigger towers to constructed j/gTowers, this is to switch it back to using supercellshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24911Add FTF algs after a simple jet preselection to test ROS access etc2019-08-24T03:05:25+02:00Teng Jian KhooAdd FTF algs after a simple jet preselection to test ROS access etcSchedule three jet chains that will run FullScan FTF algs after the MET trkmht setup after a preselection based on HH->4b items, to test ROS access and CPU costs.
These chains would be relevant for ATR-19963.
FYI @jbossios @jmontej...Schedule three jet chains that will run FullScan FTF algs after the MET trkmht setup after a preselection based on HH->4b items, to test ROS access and CPU costs.
These chains would be relevant for ATR-19963.
FYI @jbossios @jmontejo @aranzazu @jmasikhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24881Test triggers for menu design2019-08-24T03:05:26+02:00Javier Montejo BerlingenTest triggers for menu design* lepton + tau run 2 with 03dRtt
* cell+pufit*trkmht triggers
* e22, mu22 tests
* lower threshold for inclusive VBF triggers* lepton + tau run 2 with 03dRtt
* cell+pufit*trkmht triggers
* e22, mu22 tests
* lower threshold for inclusive VBF triggershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24797ATR-19921: fixes to Run3 L1Topo2019-08-24T03:05:26+02:00Antonia StrubigATR-19921: fixes to Run3 L1TopoFixes to Run3 L1Topo (CJsETA21, ZAFB-DPHI and MJJ-DPHI-NFF).
ctest and menu tests passed.
tagging @aranzazu and @jmontejo for informationFixes to Run3 L1Topo (CJsETA21, ZAFB-DPHI and MJJ-DPHI-NFF).
ctest and menu tests passed.
tagging @aranzazu and @jmontejo for informationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24704update a few chains in MC_pp_v8 (ATR-19510, ATR-19355)2019-08-24T03:05:26+02:00Ligang Xiaupdate a few chains in MC_pp_v8 (ATR-19510, ATR-19355)- add the seed 'L1_3MU4' to 3mu4_L1BPH-0M10-3MU4 and 3mu4_bTau_L1BPH-0M10-3MU4 (ATR-19355)
- correct the L1 seed from "MU4" to "MU6" for 2mu6_11invm24_noos_novtx_L1DY-BOX-2MU6, 2mu6_24invm60_noos_novtx_L1DY-BOX-2MU6 (ATR-19510)- add the seed 'L1_3MU4' to 3mu4_L1BPH-0M10-3MU4 and 3mu4_bTau_L1BPH-0M10-3MU4 (ATR-19355)
- correct the L1 seed from "MU4" to "MU6" for 2mu6_11invm24_noos_novtx_L1DY-BOX-2MU6, 2mu6_24invm60_noos_novtx_L1DY-BOX-2MU6 (ATR-19510)https://gitlab.cern.ch/atlas/athena/-/merge_requests/24613ATR-19921 Run 3 L1Topo xml2019-08-24T03:05:26+02:00Antonia StrubigATR-19921 Run 3 L1Topo xmlDevelopment of Run 3 L1Topo xml on top of work described in !24552
Optimised running INVM-DPHI-NFF and ZAFB-DPHI only once checking several thresholds.
Fixing AlgoId ordering error. Cleanup of ItemDef for v8 menu and related L1...Development of Run 3 L1Topo xml on top of work described in !24552
Optimised running INVM-DPHI-NFF and ZAFB-DPHI only once checking several thresholds.
Fixing AlgoId ordering error. Cleanup of ItemDef for v8 menu and related L1 Menu_MC_pp_v8, MC_pp_v8 and Physics_pp_v8.
tagging @aranzazu for informationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24284Updates to gFEX simulation: gCaloTowers, pileup subtraction, jets without jets2019-08-24T03:05:27+02:00Ava Anne MyersUpdates to gFEX simulation: gCaloTowers, pileup subtraction, jets without jets(1) Collapse 2 layers of gTowers to create gCaloTowers
(2) Fixed pileup corrections into eta coverage per FPGA for MET algorithms
(3) Created transient containers for rho-subtracted towers that can be passed to other algorithms easily...(1) Collapse 2 layers of gTowers to create gCaloTowers
(2) Fixed pileup corrections into eta coverage per FPGA for MET algorithms
(3) Created transient containers for rho-subtracted towers that can be passed to other algorithms easily
(3) Saved the xy components for {MHT, MST} without pileup subtraction for jets without jets
@viveiros @stelzerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23967ATR-19554 new L1Calo items , ATR-19090 trkmht_FTK chains2019-06-07T03:04:17+02:00Antonia StrubigATR-19554 new L1Calo items , ATR-19090 trkmht_FTK chainsATR-19554 new L1Calo items and chains for validation, ATR-19090 additional trkmht_FTK chains, both MC_pp_v8.
ctest and menu tests passed.
Tagging @aranzazu for informationATR-19554 new L1Calo items and chains for validation, ATR-19090 additional trkmht_FTK chains, both MC_pp_v8.
ctest and menu tests passed.
Tagging @aranzazu for informationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/2310921.3 hlt integration of new L1Calo output2019-05-15T14:45:22+02:00Joerg Stelzer21.3 hlt integration of new L1Calo outputhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23046L1Topo B-physics improvements (ATR-19720)2019-05-15T14:47:25+02:00Arantxa Ruiz MartinezL1Topo B-physics improvements (ATR-19720)https://gitlab.cern.ch/atlas/athena/-/merge_requests/23006low mass DY atr 195102019-05-15T14:46:48+02:00Aparajita Dattaguptalow mass DY atr 19510For ATR-19510:
Changes for Low-mass DY triggers.
Cheers,
AparajitaFor ATR-19510:
Changes for Low-mass DY triggers.
Cheers,
Aparajitahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23005Di muon changes atr 193822019-05-15T14:44:33+02:00Aparajita DattaguptaDi muon changes atr 19382For ATR-19382
1) Adding mu20_ivarmedium_mu6noL1, mu20_ivarmedium_mu4noL1 and mu20_ivarmedium_mu62noL1 triggers in MC_pp_v8.
2) Added j0_gsc0_boffperf_split_L1RD0_FILLED in jetSlice and removed it from under if doFTK.
For ATR-1...For ATR-19382
1) Adding mu20_ivarmedium_mu6noL1, mu20_ivarmedium_mu4noL1 and mu20_ivarmedium_mu62noL1 triggers in MC_pp_v8.
2) Added j0_gsc0_boffperf_split_L1RD0_FILLED in jetSlice and removed it from under if doFTK.
For ATR-19277
1) Remove j0_gsc0_boffperf_split_L1RD0_FILLED from do_FTK and add to ps_perform_list block before if doFTK
Cheers,
Aparajitahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22912jFEX jet algorithms and MET container name fixes2019-05-16T09:34:14+02:00Ben CarlsonjFEX jet algorithms and MET container name fixesThis algorithm fixes a bug in the jFEX jet algorithm. The current local maximum finder assumes you have signed deltaPhi values, which were not returned from the helper function. That was fixed, and the absolute value explicitly added whe...This algorithm fixes a bug in the jFEX jet algorithm. The current local maximum finder assumes you have signed deltaPhi values, which were not returned from the helper function. That was fixed, and the absolute value explicitly added where needed.
During the debugging, it was also realized that because the tile energy is taken from the Run 2 container with a noise cut already applied, the way we derive noise thresholds is not really sensible. Given that during the startup, we have to share noise cuts with Run 2 anyway, it probably makes sense to not apply tile noise cuts. Those were removed for the jet algorithm anyway.
In addition, there is a minor fix to the MET Aux container name.
https://indico.cern.ch/event/815351/contributions/3402864/attachments/1833198/3005892/Carlson_Debugging_jFEXJets.pdf https://gitlab.cern.ch/atlas/athena/-/merge_requests/22876Update q221 and q431 reference files2019-04-29T11:51:12+02:00John Derek ChapmanUpdate q221 and q431 reference files!21472 altered the Trigger outputs for q221 and q431, so updating
the reference files accordingly.!21472 altered the Trigger outputs for q221 and q431, so updating
the reference files accordingly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22685Ftk clustering update2019-04-18T18:08:12+02:00Stamatios GkaitatzisFtk clustering updateThe merge request aims to improve the clustering functionality of TrigFTKSim. The following modifications have been made:
1. atlClustering is replaced by the FTKClusteringEngine class.
2. FTKClusteringPrintout is tasked with handling pr...The merge request aims to improve the clustering functionality of TrigFTKSim. The following modifications have been made:
1. atlClustering is replaced by the FTKClusteringEngine class.
2. FTKClusteringPrintout is tasked with handling printing functions which were previously part of the main clustering code.
3. Fix memory leak issues.
Apart from the clustering improvements, this merge aims to clean a part of legacy code that is not needed anymore. These modifications include the removal of the parameters x, y and z from FTKRawHit and the removal of SCTtrk which is also not going to be needed in the future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22668Correct flags, add new triggers for testing2019-04-24T21:33:34+02:00Javier Montejo BerlingenCorrect flags, add new triggers for testing* Correct the flags for ditau+VBF triggers
* Add e24+iso to test rates
* New high-multiplicity FTK triggers now under if doFTK, and removed from tight prescales
* New diphoton with L1Topo
* Reintroduce RD2_FILLED, needed for costs
*...* Correct the flags for ditau+VBF triggers
* Add e24+iso to test rates
* New high-multiplicity FTK triggers now under if doFTK, and removed from tight prescales
* New diphoton with L1Topo
* Reintroduce RD2_FILLED, needed for costs
* New dimuon triggers with `10invm80`, requires to register 10invm80 everywhere as with the other mass cuts
https://gitlab.cern.ch/atlas/athena/-/merge_requests/22626ATR-19309, FTK for every b-jet leg2019-04-17T02:23:58+02:00Antonia StrubigATR-19309, FTK for every b-jet legATR-19309, adding FTK to every b-jet jet in MC_pp_v8.
ctest and HLT_mcv8 test both passed.
tagging @aranzazu and @jmontejo for informationATR-19309, adding FTK to every b-jet jet in MC_pp_v8.
ctest and HLT_mcv8 test both passed.
tagging @aranzazu and @jmontejo for information