athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-03-10T14:32:38+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/29932Added branches to MDTSimHitTester2020-03-10T14:32:38+01:00Polina MoskvitinaAdded branches to MDTSimHitTesterSee titleSee titlehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21656Added calibration file for bookkeeping of non-physics triggers2019-03-18T16:58:35+01:00Javier Montejo BerlingenAdded calibration file for bookkeeping of non-physics triggersDuring the v8 menu cleanup all the detector, calibration and monitoring triggers have been removed. For bookkeeping purposes we have put together a reduced list of triggers that were used in 2018 into a menu.During the v8 menu cleanup all the detector, calibration and monitoring triggers have been removed. For bookkeeping purposes we have put together a reduced list of triggers that were used in 2018 into a menu.https://gitlab.cern.ch/atlas/athena/-/merge_requests/22956added e26_lhtight_nod0_ivarloose_L1EM20VH in the TrigEgamma monitoring2019-05-15T14:43:28+02:00Fernando Monticelliadded e26_lhtight_nod0_ivarloose_L1EM20VH in the TrigEgamma monitoringThis is to add e26_lhtight_nod0_ivarloose_L1EM20VH to the TrigEgammaMonitoring.
Test jobs output and roo file with this path available in my public:
/afs/cern.ch/user/f/fernando/public/ATR-19646This is to add e26_lhtight_nod0_ivarloose_L1EM20VH to the TrigEgammaMonitoring.
Test jobs output and roo file with this path available in my public:
/afs/cern.ch/user/f/fernando/public/ATR-19646https://gitlab.cern.ch/atlas/athena/-/merge_requests/22261added e/g chains with new L1 seeds for testing2019-04-02T14:15:54+02:00Fernando Monticelliadded e/g chains with new L1 seeds for testingThis is to add the chains
HLT_e26_lhtight_nod0_ivarloose_L1eEM22
HLT_e24_lhvloose_nod0_L1eEM20
HLT_g25_medium_L1eEM20
in our monitoring as requested in ATR-19610This is to add the chains
HLT_e26_lhtight_nod0_ivarloose_L1eEM22
HLT_e24_lhvloose_nod0_L1eEM20
HLT_g25_medium_L1eEM20
in our monitoring as requested in ATR-19610https://gitlab.cern.ch/atlas/athena/-/merge_requests/22892Added HLT_j35_boffperf_split_FTK*_L1J15 chains (without the _FTK suffix) in...2019-04-29T11:55:18+02:00Elemer NagyAdded HLT_j35_boffperf_split_FTK*_L1J15 chains (without the _FTK suffix) in...Added HLT_j35_boffperf_split_FTK*_L1J15 chains (without the _FTK suffix) in order to monitor these chains from v7 menu,
see ATR-19695 and ATR-19442.
All Tier 0 tests passed,
see: /afs/cern.ch/work/e/enagy/public/bjetTrigMenu_230419/run1...Added HLT_j35_boffperf_split_FTK*_L1J15 chains (without the _FTK suffix) in order to monitor these chains from v7 menu,
see ATR-19695 and ATR-19442.
All Tier 0 tests passed,
see: /afs/cern.ch/work/e/enagy/public/bjetTrigMenu_230419/run1/RunTier0Tests.loghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20749Added JVT moment to FTK jet collections, some monitoring hists2019-04-29T11:16:32+02:00Teng Jian KhooAdded JVT moment to FTK jet collections, some monitoring histsFTK/FTKRefit jet collections will now get JVT computed. Validated that this is written to AOD and implemented a couple of monitoring histograms that have been verified in AOD->NTUP_PHYSVAL.
In the process, I made a couple of other minor...FTK/FTKRefit jet collections will now get JVT computed. Validated that this is written to AOD and implemented a couple of monitoring histograms that have been verified in AOD->NTUP_PHYSVAL.
In the process, I made a couple of other minor fixes:
* Change HTLJetMonTool behaviour to warn if a jet collection is not found, but proceed with filling histograms for all collections that have been found. This facilitates testing of a few chains at a time, and will forestall cases where a single collection was misconfigured, leading to all of the jet monitoring being disabled.
* Corrected typos in jet v8 menu additions
* Removed unused variables from JetVertexTaggerTool
FYI @ckaldero @emendesg
(Partially) addresses ATR-19217, builds on ATR-16020
Tagged for sweep to master, but that will most likely fail...https://gitlab.cern.ch/atlas/athena/-/merge_requests/35043added jXERHO to trigger EDM and implemented sumET fix2020-08-10T10:09:03+02:00Bryan Kortmanadded jXERHO to trigger EDM and implemented sumET fixfixing the sumET container to be filled with MissingET for the algorithms, NoiseCut_MET, jXERHO and JWOJ.
NoiseCUT_MET:Filling when passing the noise and eta cuts and after the bool useNegTowers
jXERHO: summing after the rho substracti...fixing the sumET container to be filled with MissingET for the algorithms, NoiseCut_MET, jXERHO and JWOJ.
NoiseCUT_MET:Filling when passing the noise and eta cuts and after the bool useNegTowers
jXERHO: summing after the rho substraction -> sumET_sub += Et_sub;
JWOJ:Filling the ET_values[0] which is defined as scalar_ET. in jwoj.h this is defined as scalar_Et+=seed_Et;Ben CarlsonJon BurrBen Carlsonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29853Added MDT sim hit tester2020-03-10T14:32:38+01:00Polina MoskvitinaAdded MDT sim hit testerthis MR adds a new tester for MDT sim hits to MuonPRDTestthis MR adds a new tester for MDT sim hits to MuonPRDTesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21098Added mu26_ivarmeium_FTK in HLT muon monitoring2019-02-18T01:03:26+01:00Yohei NoguchiAdded mu26_ivarmeium_FTK in HLT muon monitoring# Description #
As reported in ATR-19222, the FTK chain (_mu26_ivarmedium_FTK_) was added in HLT muon monitoring. This also adds efficiency plot using TProfile. Half of the plots in _Efficiency_ folder are empty, but I keep these not to...# Description #
As reported in ATR-19222, the FTK chain (_mu26_ivarmedium_FTK_) was added in HLT muon monitoring. This also adds efficiency plot using TProfile. Half of the plots in _Efficiency_ folder are empty, but I keep these not to break any other codes.
# Validation #
The test webdisplay was produced: https://ynoguchi.web.cern.ch/ynoguchi/DQ/ATR-19222/test2/
Some histograms in _Common_ and _Rate_ are red there, but it's probably due to all the sub-jobs in test have not finished. I am waiting for the rest jobs finishing. Other plots (list of the monitoring chains) turned red because the chain is added, but it's reasonable (e.g. [Monitoring_Chain](https://ynoguchi.web.cern.ch/ynoguchi/DQ/ATR-19222/test2/MuonMon/Common/Monitoring_Chain.html))https://gitlab.cern.ch/atlas/athena/-/merge_requests/26970Added one factor _emscale_for_decision as requested in ATR-188242020-01-01T03:03:55+01:00Kalliopi IordanidouAdded one factor _emscale_for_decision as requested in ATR-18824Change requested in ATR-18824, added one factor _emscale_for_decision to MinMSqr and MaxMSqr as there is one EM objectChange requested in ATR-18824, added one factor _emscale_for_decision to MinMSqr and MaxMSqr as there is one EM objecthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34991Added the jXERHO METAlg do the AOD output2020-07-22T19:51:45+02:00Bryan KortmanAdded the jXERHO METAlg do the AOD outputOnly added extra branches to the AOD output of the already implemented jXERHO alg in the METAlg.cxx fileOnly added extra branches to the AOD output of the already implemented jXERHO alg in the METAlg.cxx filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24911Add FTF algs after a simple jet preselection to test ROS access etc2019-08-24T03:05:25+02:00Teng Jian KhooAdd FTF algs after a simple jet preselection to test ROS access etcSchedule three jet chains that will run FullScan FTF algs after the MET trkmht setup after a preselection based on HH->4b items, to test ROS access and CPU costs.
These chains would be relevant for ATR-19963.
FYI @jbossios @jmontej...Schedule three jet chains that will run FullScan FTF algs after the MET trkmht setup after a preselection based on HH->4b items, to test ROS access and CPU costs.
These chains would be relevant for ATR-19963.
FYI @jbossios @jmontejo @aranzazu @jmasikhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22997add FTKJobProperties with flags doTruthLinks and doDetailedTruth2019-05-15T14:45:59+02:00John Bainesadd FTKJobProperties with flags doTruthLinks and doDetailedTruthThis add FTKJobProperties with flags doTruthLinks and doDetailedTruth that are set to False by default. This fixes the problem FTKSIM-126 that additional TruthParticlesAuxDyn variables were being added when rec.doFTK was set to true.
I...This add FTKJobProperties with flags doTruthLinks and doDetailedTruth that are set to False by default. This fixes the problem FTKSIM-126 that additional TruthParticlesAuxDyn variables were being added when rec.doFTK was set to true.
It also contains a fix to only load FTK_RDO_readerAlgo when the input is BS or RDO.
This enables rec.doFTK to be set to true by default as required in ATR-19553
I have tested that the appropriate normal AOD is produced by default and the enhanced AOD output can be enabled by:
from FTK_RecExample.FTKJobProperties import FTKFlags;FTKFlags.doTruthLinks.set_Value_and_Lock(True);FTKFlags.doDetailedTruth.set_Value_and_Lock(True)
The somewhat undesirable feature is that setting a FTKFlag causes changes to the content of TruthParticlesAuxDyn. However the doDetailedTruth would only be set to True for special dedicated FTK productions, so this seems a pragmatic solution to move forward.
The doSmearing flag currently does nothing, but is these for when FTKFastSim is added in the near future.
@jahreda @rbielski if you think this looks OK I will remove the WIPhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20784Add histograms for FTK wrt to offline for TrigID PhysVal monitoring2019-02-10T00:56:09+01:00Julie KirkAdd histograms for FTK wrt to offline for TrigID PhysVal monitoringAdd histograms for FTK wrt to offline for TrigID PhysVal monitoring
modified: Trigger/TrigMonitoring/TrigIDtrkMonitoring/python/TrigIDPhysValMonitoringConfig.pyAdd histograms for FTK wrt to offline for TrigID PhysVal monitoring
modified: Trigger/TrigMonitoring/TrigIDtrkMonitoring/python/TrigIDPhysValMonitoringConfig.pyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22186add HLT chains to MC_pp_v8 (ATR-19554)2019-04-25T12:06:51+02:00Ligang Xiaadd HLT chains to MC_pp_v8 (ATR-19554)add HLT chains to MC_pp_v8 based on the new L1calo thresholds.add HLT chains to MC_pp_v8 based on the new L1calo thresholds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26842Adding all required auxdata when there is no primary vertex2020-01-01T03:03:56+01:00Jon BurrAdding all required auxdata when there is no primary vertexCloses ATR-20357Closes ATR-20357https://gitlab.cern.ch/atlas/athena/-/merge_requests/26760Adding a new package for calibration tool, and a tool for detector studies on...2020-01-01T03:03:56+01:00Stefano RosatiAdding a new package for calibration tool, and a tool for detector studies on resolution and efficienciesThe new package NSWCalibTools will contain the calibration tools for the NSW week.
A first version of a tool for time and charge resolution studies, and efficiencies, has been initially added to the package.The new package NSWCalibTools will contain the calibration tools for the NSW week.
A first version of a tool for time and charge resolution studies, and efficiencies, has been initially added to the package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23369Adding angle and chi2 to MM validation nTuple; fixing bug in NSWPRDValAlg and...2019-05-20T10:21:08+02:00Patrick ScholerAdding angle and chi2 to MM validation nTuple; fixing bug in NSWPRDValAlg and MMPrepDataMMPRDVariables: add angle and chi2; MMPrepData: changed type of get function of chi2 from int to double; NSWPRDValAlg: fix bug of SetBranchAddress by excluding branches with rdos in the nameMMPRDVariables: add angle and chi2; MMPrepData: changed type of get function of chi2 from int to double; NSWPRDValAlg: fix bug of SetBranchAddress by excluding branches with rdos in the namehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27084Adding an optional pT threshold for track soft term algorithms2020-01-01T03:03:54+01:00Jon BurrAdding an optional pT threshold for track soft term algorithmsAdding in a feature allowing to place an upper pT threshold on tracks going into track soft terms in our algorithms. This also adds a couple of new triggers using these chains.
These use the string `tstceil` in them to set this proper...Adding in a feature allowing to place an upper pT threshold on tracks going into track soft terms in our algorithms. This also adds a couple of new triggers using these chains.
These use the string `tstceil` in them to set this property to 20 GeV, however if this is shown to work I think we would just make this the default. Setting this to urgent as a sampleT production is planned soon.
*EDIT:* Added a setting to disable the track <-> muon overlap removal when this track pT ceiling is enabled as these are two different ways of doing the same thing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27232Adding ART output for bstoesd grid jobs2020-01-01T03:03:54+01:00Julie KirkAdding ART output for bstoesd grid jobsmodified: Trigger/TrigValidation/TrigAnalysisTest/test/test_mc_pp_v8_rdotobstoesd_grid.sh
modified: Trigger/TrigValidation/TrigAnalysisTest/test/test_physics_pp_v8_rdotobstoesd_grid.shmodified: Trigger/TrigValidation/TrigAnalysisTest/test/test_mc_pp_v8_rdotobstoesd_grid.sh
modified: Trigger/TrigValidation/TrigAnalysisTest/test/test_physics_pp_v8_rdotobstoesd_grid.sh