athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-04-25T13:03:03+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20769add BulkMCProd prescale to MC_pp_v8 (ATR-19369)2019-04-25T13:03:03+02:00Ligang Xiaadd BulkMCProd prescale to MC_pp_v8 (ATR-19369)add BulkMCProd prescale to MC_pp_v8add BulkMCProd prescale to MC_pp_v8https://gitlab.cern.ch/atlas/athena/-/merge_requests/20757Removal of redundant variables in JGTowerContainer2019-02-14T01:30:47+01:00Chiao-Ying LinRemoval of redundant variables in JGTowerContainerDue to the scheme of Run3 towers, the following variables are not needed anymore:
1. LAr_et
2. Tile_et
3. Tilefrac
4. Adding back in towers with ET = 0
5. Utilizing the path resolver to access noise
so they are now removed fr...Due to the scheme of Run3 towers, the following variables are not needed anymore:
1. LAr_et
2. Tile_et
3. Tilefrac
4. Adding back in towers with ET = 0
5. Utilizing the path resolver to access noise
so they are now removed from the containerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20749Added JVT moment to FTK jet collections, some monitoring hists2019-04-29T11:16:32+02:00Teng Jian KhooAdded JVT moment to FTK jet collections, some monitoring histsFTK/FTKRefit jet collections will now get JVT computed. Validated that this is written to AOD and implemented a couple of monitoring histograms that have been verified in AOD->NTUP_PHYSVAL.
In the process, I made a couple of other minor...FTK/FTKRefit jet collections will now get JVT computed. Validated that this is written to AOD and implemented a couple of monitoring histograms that have been verified in AOD->NTUP_PHYSVAL.
In the process, I made a couple of other minor fixes:
* Change HTLJetMonTool behaviour to warn if a jet collection is not found, but proceed with filling histograms for all collections that have been found. This facilitates testing of a few chains at a time, and will forestall cases where a single collection was misconfigured, leading to all of the jet monitoring being disabled.
* Corrected typos in jet v8 menu additions
* Removed unused variables from JetVertexTaggerTool
FYI @ckaldero @emendesg
(Partially) addresses ATR-19217, builds on ATR-16020
Tagged for sweep to master, but that will most likely fail...https://gitlab.cern.ch/atlas/athena/-/merge_requests/20730WIP:convert L1 e/gamma trigger to tau2019-04-09T09:41:38+02:00Yu EsumiWIP:convert L1 e/gamma trigger to tauStill work in progress, will marge to 21.3Still work in progress, will marge to 21.3https://gitlab.cern.ch/atlas/athena/-/merge_requests/20725changes for ctpid, MC_v8 cleanup and additions2019-04-25T13:09:34+02:00Aparajita Dattaguptachanges for ctpid, MC_v8 cleanup and additionsFor ATR-19268, ATR-19269, ATR-19270 and ATR-19271: added triggers in MC_pp_v8.py for Egamma, Tau, MET, Jet slices and in HI low mu menu for Jet slice.
For ATR-18849, added fixed ctpid for l1 items which had floating ctpids and added a...For ATR-19268, ATR-19269, ATR-19270 and ATR-19271: added triggers in MC_pp_v8.py for Egamma, Tau, MET, Jet slices and in HI low mu menu for Jet slice.
For ATR-18849, added fixed ctpid for l1 items which had floating ctpids and added a warning message if ctpid is not assigned.
Tagging @aranzazu and @jmontejo.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20713Add basic TriggerTest tests using the v8 menu2019-01-31T00:12:30+01:00Rafal Bielskirafal.bielski@cern.chAdd basic TriggerTest tests using the v8 menuAdding a copy of six tests running on v7 menu to use the v8 menu. This is the first part of the TriggerTest migration to the v8 menu as described in ATR-19369. The tests are with full MC menu running on MC and full Physics menu running o...Adding a copy of six tests running on v7 menu to use the v8 menu. This is the first part of the TriggerTest migration to the v8 menu as described in ATR-19369. The tests are with full MC menu running on MC and full Physics menu running on MC and on data. All in build and grid versions.
This MR is not testable in CI, because it only affects ART tests.
Tagging @hartj, @stelzer, @apolici for information.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20708TrigP1Test: further fixes for migration to 21.3 (ATR-19204)2019-04-25T13:10:47+02:00Daniele ZanziTrigP1Test: further fixes for migration to 21.3 (ATR-19204)Not testable in CINot testable in CIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20694Considering all surfaces (not only material ones) in TimedExtrapolator.cxx2019-02-05T00:04:18+01:00Olivier ArnaezConsidering all surfaces (not only material ones) in TimedExtrapolator.cxxConsidering all surfaces (not only material ones) as 'compatible' in TimedExtrapolator.cxx to restore SCT hits on both sides.
ATLASSIM-3745Considering all surfaces (not only material ones) as 'compatible' in TimedExtrapolator.cxx to restore SCT hits on both sides.
ATLASSIM-3745https://gitlab.cern.ch/atlas/athena/-/merge_requests/20693update with comments to improve resource management when running JGTowerMaker2019-04-25T13:13:27+02:00Chiao-Ying Linupdate with comments to improve resource management when running JGTowerMakerThis merge request contains the following changes:
1. JGTowerContainer is added into xAODTrigL1CaloCLIDs.cxx
2. JGTower is added to the output stream in JGTowerMakerEnable.py
3. AllCalo & TriggerTowers would only be retrieved ...This merge request contains the following changes:
1. JGTowerContainer is added into xAODTrigL1CaloCLIDs.cxx
2. JGTower is added to the output stream in JGTowerMakerEnable.py
3. AllCalo & TriggerTowers would only be retrieved once per event
4. Only the JGTowers with energy (Et!=0) output to AODhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20670JetAttrs - HLT Jet Hypothesis for Jet Moments2019-04-25T13:10:11+02:00Amanda SteinhebelJetAttrs - HLT Jet Hypothesis for Jet MomentsThe HLT jet hypothesis JetAttrs was added in this development branch. This hypothesis makes cuts on the substructure variables KtDR and jet width for large-R jets, and establishes a framework for the inclusion of more variables and more ...The HLT jet hypothesis JetAttrs was added in this development branch. This hypothesis makes cuts on the substructure variables KtDR and jet width for large-R jets, and establishes a framework for the inclusion of more variables and more complicated combinations of variable requirements. This work was done as a Qualification Task with the Jet Signature group. See the Glance page [here ](https://glance.cern.ch/atlas/membership/members/profile?view=qualification)and internal document regarding the added structures and avenues for future work [here](https://cds.cern.ch/record/2652981?).
@martyniu @khoo @ckaldero @kwhalenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20633remove InDetTrigFlags dependant protection to instantiate tools which2019-01-30T03:29:55+01:00Jiri Masikremove InDetTrigFlags dependant protection to instantiate tools whichare used without doNewTracking contextare used without doNewTracking contexthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20630latest changes from ATR-19278 and 192772019-04-25T13:10:29+02:00Mario Campanellilatest changes from ATR-19278 and 19277there have been some change on syntax in the b-jet triggers
225_bmv2c1050_FTK_L1J100_FTK -> j225_bmv2c1050_split_FTK_L1J100_FTK
j225_bmv2c1050_FTKVtx_FTK -> j225_bmv2c1050_split_FTKVtx_L1J100_FTK
j225_bmv2c1050_FTKRefit_FTK -> j225_...there have been some change on syntax in the b-jet triggers
225_bmv2c1050_FTK_L1J100_FTK -> j225_bmv2c1050_split_FTK_L1J100_FTK
j225_bmv2c1050_FTKVtx_FTK -> j225_bmv2c1050_split_FTKVtx_L1J100_FTK
j225_bmv2c1050_FTKRefit_FTK -> j225_bmv2c1050_split_FTKRefit_L1J100_FTK
2j35_bmv2c1050_split_FTK2j35_L14J15.0ETA25_FTK -> 2j35_bmv2c1050_split_FTK_2j35_L14J15.0ETA25_FTK
j35_boffperf_split -> j35_boffperf_split_L1J15
j150_boffperf_split -> j150_boffperf_split_L1J40
plus some non-FTK chains have been added
j225_boffperf_split_L1J100
j225_bmv2c1050_split_L1J100
j150_boffperf_split_j50_boffperf_split_L1J100
j150_bmv2c1050_split_j50_bmv2c1050_split_L1J100
Also other changes were performed to the following jet chains:
j0_perf_FTK -> j0_perf_ftk_L1RD0_FILLED
j0_perf_FTKRefit -> j0_perf_ftkrefit_L1RD0_FILLED
j0_gsc0_boffperf_split_ -> j0_gsc0_boffperf_split_L1RD0_FILLED
j0_gsc0_boffperf_split_FTK -> j0_gsc0_boffperf_split_FTK_L1RD0_FILLEDhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20627TrigP1Test: fix typo in web summary (ATR-19204)2019-04-25T13:12:35+02:00Daniele ZanziTrigP1Test: fix typo in web summary (ATR-19204)not testable in CInot testable in CIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20614Sweeping !20595 from master to 21.3.
Bugfix importing tools in RunTier0Test.py2019-04-25T13:12:03+02:00Atlas NightlybuildSweeping !20595 from master to 21.3.
Bugfix importing tools in RunTier0Test.pyBugfix importing tools in RunTier0Test.py
See merge request atlas/athena!20595Bugfix importing tools in RunTier0Test.py
See merge request atlas/athena!20595https://gitlab.cern.ch/atlas/athena/-/merge_requests/2059821.3 fix downloading testref2019-04-25T13:13:44+02:00Joerg Stelzer21.3 fix downloading testrefhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20596Include support triggers in low-mu v8 menu2019-04-25T13:14:05+02:00Javier Montejo BerlingenInclude support triggers in low-mu v8 menuPreviously contained only primaries, added backup and support with flags to identify them
ATR-19230Previously contained only primaries, added backup and support with flags to identify them
ATR-19230https://gitlab.cern.ch/atlas/athena/-/merge_requests/20544Sweeping !20514 from master to 21.3.
Start versioning the CI reference files ...2019-01-24T03:03:26+01:00Atlas NightlybuildSweeping !20514 from master to 21.3.
Start versioning the CI reference files for the RunTier0TestsStart versioning the CI reference files for the RunTier0Tests
See merge request atlas/athena!20514Start versioning the CI reference files for the RunTier0Tests
See merge request atlas/athena!20514https://gitlab.cern.ch/atlas/athena/-/merge_requests/20527Fixing the strip identifier in the MM RDO2019-01-24T17:16:54+01:00Stefano RosatiFixing the strip identifier in the MM RDODue to the MM digit structure, the MM strip channel identifier in the RDO's was set to a wrong value.
This was not causing problems downstream because the channel data member of the RDO was set to the
right value, but it's better to hav...Due to the MM digit structure, the MM strip channel identifier in the RDO's was set to a wrong value.
This was not causing problems downstream because the channel data member of the RDO was set to the
right value, but it's better to have consistent values.
modified: MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/MM_DigitToRDO.cxxhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20522TrigP1Test: fix in 21.3 (ATR-19204)2019-04-25T13:14:48+02:00Daniele ZanziTrigP1Test: fix in 21.3 (ATR-19204)Fixing typos and including FTK in mcV8 tests.
Not testable in CIFixing typos and including FTK in mcV8 tests.
Not testable in CIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20520ATR: 19275, 77, 78, 79 802019-04-25T13:14:27+02:00Mario CampanelliATR: 19275, 77, 78, 79 80Copy FTK triggers, already existing in Physics or MC v7, into MC_pp_v8.
ATR-19275, ATR-19277, ATR-19278, ATR-19279 and ATR-19280.Copy FTK triggers, already existing in Physics or MC v7, into MC_pp_v8.
ATR-19275, ATR-19277, ATR-19278, ATR-19279 and ATR-19280.