athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-02-13T22:46:23+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/21032Add TriggerTest ART tests for FTK with v8 menu2019-02-13T22:46:23+01:00Julie KirkAdd TriggerTest ART tests for FTK with v8 menunew file: Trigger/TrigValidation/TriggerTest/test/test_mc_pp_v8_ftk_build.sh
new file: Trigger/TrigValidation/TriggerTest/test/test_mc_pp_v8_ftk_grid.shnew file: Trigger/TrigValidation/TriggerTest/test/test_mc_pp_v8_ftk_build.sh
new file: Trigger/TrigValidation/TriggerTest/test/test_mc_pp_v8_ftk_grid.shhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21053Sweeping !20990 from master to 21.3.
Use Default List for the ART Grid Inputs...2019-02-14T03:03:13+01:00Atlas NightlybuildSweeping !20990 from master to 21.3.
Use Default List for the ART Grid Inputs in MuonRecRTTUse Default List for the ART Grid Inputs in MuonRecRTT
See merge request atlas/athena!20990Use Default List for the ART Grid Inputs in MuonRecRTT
See merge request atlas/athena!20990https://gitlab.cern.ch/atlas/athena/-/merge_requests/21063Sweeping !20930 from master to 21.32019-02-19T11:54:16+01:00Rafal Bielskirafal.bielski@cern.chSweeping !20930 from master to 21.3Trivial change dropping unnecessary brackets, which give a warning in gcc8. Cherry-picking to 21.3 to keep the code in sync.
See merge request atlas/athena!20930
(cherry picked from commit cb0dab2a28b87464433fcce1285b1d51e5f78bbb)
41c...Trivial change dropping unnecessary brackets, which give a warning in gcc8. Cherry-picking to 21.3 to keep the code in sync.
See merge request atlas/athena!20930
(cherry picked from commit cb0dab2a28b87464433fcce1285b1d51e5f78bbb)
41c113d2 TrigInDetAnalysisUser: Fix gcc8 compilation warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21064Revert athenaprivate1!166422019-02-15T15:16:02+01:00John Derek ChapmanRevert athenaprivate1!16642athenaprivate1!16642 was originally made to sweep Coverity fixes for G4HadIntProcessor.cxx (ATLASSIM-2157) from ~master to ~"21.3". These fixes seem to work fine in ~master, but cause a double-delete at the end of the job in ~"21.3" - se...athenaprivate1!16642 was originally made to sweep Coverity fixes for G4HadIntProcessor.cxx (ATLASSIM-2157) from ~master to ~"21.3". These fixes seem to work fine in ~master, but cause a double-delete at the end of the job in ~"21.3" - see ATLASSIM-4006.
This merge requests reverts these changes, so that they are not a blocker for other Fast Simulation work.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21085STgc PRD fixes and clustering tool2019-05-02T16:54:50+02:00Stefano RosatiSTgc PRD fixes and clustering toolMoving the basic simple STgc clusterization from the RDO->PRD converter to the dedicated package, in a tool.
Adding the time information that was missing from the STgc PrepRawData.
Adding the STgc cluster builder tool to the STgcClu...Moving the basic simple STgc clusterization from the RDO->PRD converter to the dedicated package, in a tool.
Adding the time information that was missing from the STgc PrepRawData.
Adding the STgc cluster builder tool to the STgcClusterization package
Moving the STgc clusterization code to the tool and applying a few fixes
Adding the Time to the STgc PrepRawData class
https://gitlab.cern.ch/atlas/athena/-/merge_requests/21098Added mu26_ivarmeium_FTK in HLT muon monitoring2019-02-18T01:03:26+01:00Yohei NoguchiAdded mu26_ivarmeium_FTK in HLT muon monitoring# Description #
As reported in ATR-19222, the FTK chain (_mu26_ivarmedium_FTK_) was added in HLT muon monitoring. This also adds efficiency plot using TProfile. Half of the plots in _Efficiency_ folder are empty, but I keep these not to...# Description #
As reported in ATR-19222, the FTK chain (_mu26_ivarmedium_FTK_) was added in HLT muon monitoring. This also adds efficiency plot using TProfile. Half of the plots in _Efficiency_ folder are empty, but I keep these not to break any other codes.
# Validation #
The test webdisplay was produced: https://ynoguchi.web.cern.ch/ynoguchi/DQ/ATR-19222/test2/
Some histograms in _Common_ and _Rate_ are red there, but it's probably due to all the sub-jobs in test have not finished. I am waiting for the rest jobs finishing. Other plots (list of the monitoring chains) turned red because the chain is added, but it's reasonable (e.g. [Monitoring_Chain](https://ynoguchi.web.cern.ch/ynoguchi/DQ/ATR-19222/test2/MuonMon/Common/Monitoring_Chain.html))https://gitlab.cern.ch/atlas/athena/-/merge_requests/21099Define MC_pp_v8_no_prescale, MC_pp_v8_CPSampleProd_mc_prescale and...2019-04-25T13:00:30+02:00Aparajita DattaguptaDefine MC_pp_v8_no_prescale, MC_pp_v8_CPSampleProd_mc_prescale and...For ATR-19369: Defined MC_pp_v8_no_prescale, MC_pp_v8_CPSampleProd_mc_prescale and MC_pp_v8_TriggerValidation_mc_prescale
in Lumi.py and TriggerFlags.py.
Tagging @aranzazu and @jmontejo : I'm not sure if I defined the alias correct...For ATR-19369: Defined MC_pp_v8_no_prescale, MC_pp_v8_CPSampleProd_mc_prescale and MC_pp_v8_TriggerValidation_mc_prescale
in Lumi.py and TriggerFlags.py.
Tagging @aranzazu and @jmontejo : I'm not sure if I defined the alias correctly on L23 in Lumi.py, adding a WIP for your review.
Thanks,
Aparajitahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21120WIP: code cleaning, keeping all towers, and pathresolver for noise file2019-02-25T22:57:03+01:00Chiao-Ying LinWIP: code cleaning, keeping all towers, and pathresolver for noise fileThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolverThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolverhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21138Merge branch 'FixATLASSIM-3988_21.0' into '21.0'2019-02-17T22:27:26+01:00John Derek ChapmanMerge branch 'FixATLASSIM-3988_21.0' into '21.0'Update diff-root tests for DigitizationTests ART jobs
See merge request atlas/athena!21070
(cherry picked from commit 224535080e3356f7a0814e90adceef65ee933884)
5fb6d953 Update diff-root tests for DigitizationTests ART jobsUpdate diff-root tests for DigitizationTests ART jobs
See merge request atlas/athena!21070
(cherry picked from commit 224535080e3356f7a0814e90adceef65ee933884)
5fb6d953 Update diff-root tests for DigitizationTests ART jobshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21139WIP: LargeR Sliding Window Jet Algorithm2019-04-09T09:06:27+02:00Sophio PataraiaWIP: LargeR Sliding Window Jet Algorithmas we have discussed I have pushed minor extension of Sliding Window Jet reconstruction algorithm/workflow, to call it twice once for small-R jet and once for large-R jet. Only different between two instances are Jet radius the rest is s...as we have discussed I have pushed minor extension of Sliding Window Jet reconstruction algorithm/workflow, to call it twice once for small-R jet and once for large-R jet. Only different between two instances are Jet radius the rest is same.
tagging @bcarlson @viveiros @ckaldero
Best regards,
Sophiehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21144Modify MM_Digitization to use MMSimHit in MM digits production. (ATLASSIM-3755)2019-02-25T14:56:37+01:00Jing ChenModify MM_Digitization to use MMSimHit in MM digits production. (ATLASSIM-3755)MMSinHit had been added into 21.3. Modify MM_Digitization package to produce digits from MMSimHit.MMSinHit had been added into 21.3. Modify MM_Digitization package to produce digits from MMSimHit.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21166Merge release/21.0.93 into 21.32019-02-18T10:10:08+01:00John Derek ChapmanMerge release/21.0.93 into 21.3This merge request merges the changes that went into the `21.0` branch between the `release/21.0.92` and `release/21.0.93` tags into the `21.3` branch.
`release/21.0.93` contains the following frozen-tier0-violating merge requests:
- ...This merge request merges the changes that went into the `21.0` branch between the `release/21.0.92` and `release/21.0.93` tags into the `21.3` branch.
`release/21.0.93` contains the following frozen-tier0-violating merge requests:
- !20005
- !20021
- !20652
MRs in https://gitlab.cern.ch/atlas/athena/tags/nightly/21.0/2019-01-28T2159, accepted since https://gitlab.cern.ch/atlas/athena/tags/nightly/21.0/2019-01-06T2159:
- !20652: Adding variable HadronConeExclTruthLabelID to heavy-ion jet collections
- !20005: Propagate xAOD::EventInfo from digitization step onwards
- !20585: printing timestamp with the full list of arguments in a safe way (ATLINFR-2731)
- !20607: 21.0 fix nightly test2
- !20613: Sweeping !20595 from master to 21.0. Bugfix importing tools in RunTier0Test.py
- !20543: Sweeping !20514 from master to 21.0. Start versioning the CI reference files for the RunTier0Tests
- !20365: Sweeping !20318 from 21.3 to 21.0. Update art-include in TriggerTest
- !20364: Sweeping !20324 from 21.3 to 21.0. TriggerTest: add a few tests running on data
- !20323: Remove non-existing input file from HI build test
- !20321: update art include for RecExOnline
- !20262: PreStepPoint quantities in StepHistogramTool
- !20219: Updates for processing of G4Commands via the G4UImanager
- !20125: Sweeping !20078 from master to 21.0. Add script to summarise results of locally-ran trigger ART tests
- !20022: additional plotting option added
- !20021: Moving eta-phi correction for HIJetRec to calibration area (ATLHI-233 and ATLINFR-2834)
- !20013: Adds an option to turn on range cuts for gamma processes (conv, phot, compt)
- !20563: Changed permissions for m16e TCT test
- !20519: Removed mc16d TCT and replaced with mc16e
The full diff between `release/21.0.93` and `release/21.0.92` is available at https://gitlab.cern.ch/atlas/athena/compare/release/21.0.92...release/21.0.93
Replaces !20965.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21170Fix passing and dereferencing of nullptr2019-02-23T17:16:18+01:00Vincent PascuzziFix passing and dereferencing of nullptrThis patch adds logic to check for a nullptr before dereferencing
the pointer. (Closes ATLASSIM-2157.)
In addition, raw pointers were converted to `std::unique_ptr` (where
applicable) and comments were added for future generations. ...This patch adds logic to check for a nullptr before dereferencing
the pointer. (Closes ATLASSIM-2157.)
In addition, raw pointers were converted to `std::unique_ptr` (where
applicable) and comments were added for future generations. Suspected
memory leak also addressed. (Fixes for !21064 and follow-up of
ATLASSIM-4006.)
[MR21170_RunTier0Tests.log](/uploads/471b75b3390f405c736f9735dc8260dc/MR21170_RunTier0Tests.log)https://gitlab.cern.ch/atlas/athena/-/merge_requests/21174TrigP1Test: fix log file names (ATR-19204)2019-02-17T22:26:56+01:00Daniele ZanziTrigP1Test: fix log file names (ATR-19204)not testable in CI.
Ping @rbielskinot testable in CI.
Ping @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21210Sweeping !21169 from master to 21.3.
fix ATR-17871Closes ATR-178712019-02-19T11:50:57+01:00Atlas NightlybuildSweeping !21169 from master to 21.3.
fix ATR-17871Closes ATR-17871fix ATR-17871
Closes ATR-17871
See merge request atlas/athena!21169fix ATR-17871
Closes ATR-17871
See merge request atlas/athena!21169https://gitlab.cern.ch/atlas/athena/-/merge_requests/21257Sweeping !21226 from master to 21.3.
Additional fixes for ATLASDQ-5082019-02-22T20:17:11+01:00Atlas NightlybuildSweeping !21226 from master to 21.3.
Additional fixes for ATLASDQ-508Additional fixes for ATLASDQ-508
See merge request atlas/athena!21226Additional fixes for ATLASDQ-508
See merge request atlas/athena!21226https://gitlab.cern.ch/atlas/athena/-/merge_requests/21296TrigP1Test: update of FTK sample with missing towers (ATR-19243, ATR-19204)2019-04-25T13:00:02+02:00Daniele ZanziTrigP1Test: update of FTK sample with missing towers (ATR-19243, ATR-19204)not testable of CInot testable of CIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21299Change for Trigger test ART test - Bphysics slice test. ATR-190602019-04-04T09:56:29+02:00Julie KirkChange for Trigger test ART test - Bphysics slice test. ATR-19060Add "SkipEvents=3" to ensure we get counts in ART build testAdd "SkipEvents=3" to ensure we get counts in ART build testhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21300Update TrigAnalysisTest ART tests2021-01-13T11:10:13+01:00Julie KirkUpdate TrigAnalysisTest ART testsChanges to TrigAnalysisTest ART tests
- fix existing FTK test
- add new FTK tests
- add NTUP_PHYSVAL test
Addresses ATR-19330Changes to TrigAnalysisTest ART tests
- fix existing FTK test
- add new FTK tests
- add NTUP_PHYSVAL test
Addresses ATR-19330https://gitlab.cern.ch/atlas/athena/-/merge_requests/21304WIP: Fix ATR-19377 L1Topo vbs alg2019-02-20T18:05:57+01:00Nicola Orlandonicola.orlando@cern.chWIP: Fix ATR-19377 L1Topo vbs algThis MR address a request for the implementation of a new L1Topo algorithm to be used in Run 3. The Jira ticket is here https://its.cern.ch/jira/browse/ATR-19377. The algorithm is a combination of two pre-existing one, DeltaRSqrIncl2 and...This MR address a request for the implementation of a new L1Topo algorithm to be used in Run 3. The Jira ticket is here https://its.cern.ch/jira/browse/ATR-19377. The algorithm is a combination of two pre-existing one, DeltaRSqrIncl2 and InvariantMassInclusive2. Adding for info menu experts @jmontejo @aranzazu @astruebi and interested L1topo sim experts @iriu @cmorenom.