athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-02-08T09:48:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/39810Manual sweep of !39809 into 21.3 and 21.9 (fix in MDT calib)2021-02-08T09:48:35+01:00Nicolas KoehlerManual sweep of !39809 into 21.3 and 21.9 (fix in MDT calib)Hi,
this is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39809: in case of BI sMDTs (added for Run3) where no MDT calibration data is available yet, currently the MDT calibration is skipped when running reconst...Hi,
this is a manual sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39809: in case of BI sMDTs (added for Run3) where no MDT calibration data is available yet, currently the MDT calibration is skipped when running reconstruction. However, instead of continuing the for loop on the MdtTubeCalibContainer, we had a return statement that caused the algorithm to get stalled.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39803NSW efficiency correction2021-02-20T12:30:19+01:00Stefano RosatiNSW efficiency correctionIntroducing a PCB-dependent efficiency for NSW detectors, read from an input file, access to the HV values per PCB.Introducing a PCB-dependent efficiency for NSW detectors, read from an input file, access to the HV values per PCB.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39802ATR-22241 - adding MET chains with new L1Calo2021-02-08T09:48:35+01:00Lidija ZivkovicATR-22241 - adding MET chains with new L1CaloAdded 5 new chains, some L1 items also added. All tests passed.Added 5 new chains, some L1 items also added. All tests passed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39794Update q431/q221 references to match !388322021-02-08T09:48:35+01:00Nicolas KoehlerUpdate q431/q221 references to match !38832Hi,
as we agreed in !38832, we did not update the q431/q221 references there, since running this locally with the new version of MuonAuxContainer would have required compiling several packages locally. Instead, we update the references ...Hi,
as we agreed in !38832, we did not update the q431/q221 references there, since running this locally with the new version of MuonAuxContainer would have required compiling several packages locally. Instead, we update the references here in a dedicated MR.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39727Sweeping !39665 from 21.9 to 21.3.
Fix leaks in sTGC_Digitization && MM_Digit...2021-02-08T09:48:36+01:00Atlas NightlybuildSweeping !39665 from 21.9 to 21.3.
Fix leaks in sTGC_Digitization && MM_DigitizationFix leaks in sTGC_Digitization && MM_Digitization
See merge request atlas/athena!39665Fix leaks in sTGC_Digitization && MM_Digitization
See merge request atlas/athena!39665https://gitlab.cern.ch/atlas/athena/-/merge_requests/39712Merge 21.0.120 and 21.0.121 into 21.32021-02-08T09:48:36+01:00John Derek ChapmanMerge 21.0.120 and 21.0.121 into 21.3This merge request merges all the changes that were made to the ~"21.0" branch between the release
[release/21.0.121](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.121) and the release
[release/21.0.119](https://gitlab.cern.ch/at...This merge request merges all the changes that were made to the ~"21.0" branch between the release
[release/21.0.121](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.121) and the release
[release/21.0.119](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.119).
Below is the full list of merge requests that were included between these two tags:
* !39271: Patch for running MC TriggerDB from SQLite (attempt 2)
* !39061: 21.0 add tfcs energy interpolation histogram
* !39248: Change to numerical more stable calculation of quasi stable particle lifetime
* !39176: Add gen particle sim quasi stable filter
* !39254: AthenaPoolCnvSvc: Re-initialize AthenaPoolCnvSvc and extract the Pool Attributes for the output file
* !39154: Fix quasi stable particle sim
* !39108: Update Simulation and Reconstruction references after CC7 update
* !38998: Added custom streamer to TFCSEnergyInterpolationPiecewiseLinear
* !38907: Revert "Merge branch '21.0-runFromSQLite' into '21.0'"
* !38799: Add a new G4FastCalo_QS simulator configuration
* !38741: xAODJiveXML: update jobOptions for jet collection names
* !38265: Patch for running MC TriggerDB from SQLite
* !38396: Fixes of Pixel Error Monitoring histograms from r22 validation
* !38036: Update Quasi-stable particle definition in GenParticleSimWhiteList
* !38095: New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation
* !37484: Fix for Monitoring of Pixel FE errors
* !38280: Upper limit for cell time cut application propagated back from master
* !38099: ATLASSIM-4945: fix for diff-root in 21.0
* !38126: Change default mpt eta window in ISF_FastCaloSimServices AdditionalConfig.py
* !37931: TRTRodDecoder bugFix: iterator increase
* !37828: Adjust cache lenght for SCT folders
* !37775: Fix ISF_EtaPhiFilter configuration for ForwardDetector Simulation (ATLASSIM-4925)
* !37622: More robust bin selection based on outEnergy in PunchThroughTools PDFcreator.cxx getRand()
* !37580: Minor fixes in D3PD jobOptions for Calibration hits
Link to the full diff between [release/21.0.121](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.121) and
[release/21.0.119](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.119)
is available at
https://gitlab.cern.ch/atlas/athena/compare/release/21.0.119...release/21.0.121https://gitlab.cern.ch/atlas/athena/-/merge_requests/39707Fix Lvl1Converter to adhere to L1 Jet naming convention2021-02-08T09:48:36+01:00Joerg StelzerFix Lvl1Converter to adhere to L1 Jet naming conventionFix Lvl1Converter to follow the naming convention for Run 3 jet thresholds described here:
https://twiki.cern.ch/twiki/bin/viewauth/Atlas/L1CaloUpgradeSimulation#Mapping_of_container_names_to_me
Addresses ATR-22412
cc @bcarlson , @jbos...Fix Lvl1Converter to follow the naming convention for Run 3 jet thresholds described here:
https://twiki.cern.ch/twiki/bin/viewauth/Atlas/L1CaloUpgradeSimulation#Mapping_of_container_names_to_me
Addresses ATR-22412
cc @bcarlson , @jbossios , @jgeisenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39695Manual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggu...2021-02-08T09:48:36+01:00Nicolas KoehlerManual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037))Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037)
Closes ATLASSIM-5037
See merge request atlas/athena!39655Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037)
Closes ATLASSIM-5037
See merge request atlas/athena!39655https://gitlab.cern.ch/atlas/athena/-/merge_requests/39635Manual sweep of !39563 (Remove every last vestige of the FTK from the RegionS...2021-02-08T09:48:36+01:00Nicolas KoehlerManual sweep of !39563 (Remove every last vestige of the FTK from the RegionSelector code)Remove every last vestige of the FTK from the RegionSelector code
See merge request atlas/athena!39563Remove every last vestige of the FTK from the RegionSelector code
See merge request atlas/athena!39563https://gitlab.cern.ch/atlas/athena/-/merge_requests/39546gFEX Rho subtracted MET with LUT noise cut2021-02-08T10:49:16+01:00Ava Anne MyersgFEX Rho subtracted MET with LUT noise cutAdd algorithms that compute Rho subtracted MET using a look up table rather than a dynamic RMS calculation. We configured the algorithm in addition to the existing, and also compute the variation using only positive towers to compute Rho.Add algorithms that compute Rho subtracted MET using a look up table rather than a dynamic RMS calculation. We configured the algorithm in addition to the existing, and also compute the variation using only positive towers to compute Rho.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39545Implementation of RMS computed with LUT for gFEX MET2021-01-07T22:12:39+01:00Ava Anne MyersImplementation of RMS computed with LUT for gFEX METhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39542WIP: gFEX LUT Rho subtracted MET2021-02-04T15:44:05+01:00Ava Anne MyersWIP: gFEX LUT Rho subtracted MET- Add an algorithm where we change dynamic RMS to RMS computed using a LUT- Add an algorithm where we change dynamic RMS to RMS computed using a LUThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39428Add NSW Pad Trigger RDO2021-03-01T16:01:09+01:00Yuval ZachAdd NSW Pad Trigger RDOThis MR adds class definitions for data coming from the pad trigger, following the data -> `DataVector` -> `IdentifiableContainer` hierarchy. Said data consists of:
* Metadata (BCID, L1ID, sector, etc.)
* Pad trigger input (i.e., a list ...This MR adds class definitions for data coming from the pad trigger, following the data -> `DataVector` -> `IdentifiableContainer` hierarchy. Said data consists of:
* Metadata (BCID, L1ID, sector, etc.)
* Pad trigger input (i.e., a list of pFEB locations at which a hit was detected)
* Pad trigger decision (band IDs, phi IDs, coincidence counts)
In addition to the data class definition, this MR also defines transient <-> persistent converters for pad trigger data containers, along with persistent representation structs, in `MuonEventTPCnv`. Additionally, it implements an AthenaPool converter under `MuonEventAthenaPool`, and registers it as a converter for `NSW_PadTriggerRawDataContainer`.
Outstanding questions:
1. Are the data classes appropriate? Is anything missing / extraneous / problematic?
2. Where should errors in conversion be handled? Should the AthenaPool converters be deemed `noexcept`, or can they throw (and terminate execution?)?
3. When attempting to read the persistent array of pFEB hit lists with ROOT's TBrowser, ROOT segfaults. Is this an issue on ROOT's side, or does AthenaPool not support arrays of vectors?
4. How should the collection's `IdentifierHash`, and the container's `hashMax`, be decided?
cc @ztarem @rozeny @gavner @rosati @lorne @nkoehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39423MM Stereo clusters fixes2021-02-08T09:48:36+01:00Stefano RosatiMM Stereo clusters fixesThis MR fixees the stereo MM clusters in the NSW segment fit.
Also, introduces the clusters calibration step at the level of 3D segment finding, that will be introduced
for all clusters.This MR fixees the stereo MM clusters in the NSW segment fit.
Also, introduces the clusters calibration step at the level of 3D segment finding, that will be introduced
for all clusters.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39375Introducing a z corection into MM digi to fix residuals2021-02-08T09:48:36+01:00Patrick ScholerIntroducing a z corection into MM digi to fix residualsThis MR introduces a shift in the z-position of the ionization track in the MM digi. This fixes a shift of the mean residuals vs theta of up to 200 um. The correction is retrieved purely empirically. Furthermore, the center gas gap thick...This MR introduces a shift in the z-position of the ionization track in the MM digi. This fixes a shift of the mean residuals vs theta of up to 200 um. The correction is retrieved purely empirically. Furthermore, the center gas gap thickness in the uTPC clusterization is fixed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39241Adding configurable number of seed layers and reducing number of seeds combin...2021-02-08T09:48:36+01:00Stefano RosatiAdding configurable number of seed layers and reducing number of seeds combinationsThe number of layers to be considered in the segment seeds building is reduced from the loose value used in the first version. CPU time is reduced, keeping the same efficiency.
Also the number of seed layers is now made configurable.The number of layers to be considered in the segment seeds building is reduced from the loose value used in the first version. CPU time is reduced, keeping the same efficiency.
Also the number of seed layers is now made configurable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39135Sweeping !39060 from 21.9 to 21.3.
Fix memory leak in mm digi2021-02-08T09:48:36+01:00Atlas NightlybuildSweeping !39060 from 21.9 to 21.3.
Fix memory leak in mm digiFix memory leak in mm digi
See merge request atlas/athena!39060Fix memory leak in mm digi
See merge request atlas/athena!39060https://gitlab.cern.ch/atlas/athena/-/merge_requests/39066Muon Run3 ART: use autoconfiguration in Reco_tf2021-02-08T09:48:37+01:00Nicolas KoehlerMuon Run3 ART: use autoconfiguration in Reco_tfHi,
when https://gitlab.cern.ch/atlas/athena/-/merge_requests/38929 is merged, everything will be automatically configured during Reco_tf also for Run3 layouts, thus, adapting ART to use it.
Best, NicoHi,
when https://gitlab.cern.ch/atlas/athena/-/merge_requests/38929 is merged, everything will be automatically configured during Reco_tf also for Run3 layouts, thus, adapting ART to use it.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39018Test lut branch2021-02-08T09:48:36+01:00Gal AvnerTest lut branchIncorporating the TR triggers into the LUT modeIncorporating the TR triggers into the LUT modehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38963Update the simulation reference after CC7 update2021-02-08T09:48:37+01:00Tadej Novaktadej.novak@cern.chUpdate the simulation reference after CC7 updateWill set to auto-merge.Will set to auto-merge.