athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-02-22T14:48:14+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/40917Update Run3 reco ART tests2021-02-22T14:48:14+01:00Nicolas KoehlerUpdate Run3 reco ART testsHi,
this MR removes 2 reference (RDOs from 21.0) ART tests since those are not needed anymore and adds one NSW-only Run3 layout test for cross-checks.
Best, NicoHi,
this MR removes 2 reference (RDOs from 21.0) ART tests since those are not needed anymore and adds one NSW-only Run3 layout test for cross-checks.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40905Update ART tests to latest Run3 layouts2021-02-21T16:21:41+01:00Nicolas KoehlerUpdate ART tests to latest Run3 layoutsHi,
this MR updates the muon ART tests to the latest Run3 layouts.
Best, NicoHi,
this MR updates the muon ART tests to the latest Run3 layouts.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40882Manual sweep of !40868: Adding TP Separation for LUCID_SimHitCollection in 21.32021-02-26T03:06:13+01:00John Derek ChapmanManual sweep of !40868: Adding TP Separation for LUCID_SimHitCollection in 21.3This had been partially implemented, but never completed. This is a sweep of !40868 from ~master to ~21.3.
Doing this now as the HepMC3 migration in ~master would otherwise prevent ~master reading LUCID hits written in ~"21.3".
FYI @as...This had been partially implemented, but never completed. This is a sweep of !40868 from ~master to ~21.3.
Doing this now as the HepMC3 migration in ~master would otherwise prevent ~master reading LUCID hits written in ~"21.3".
FYI @asbrizzi, @gcarratt, @averbytshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40878Run3 L1 Calo simulation code clean up2021-03-03T14:47:40+01:00Jon BurrRun3 L1 Calo simulation code clean upThis is the first step in the clean up of the Run 3 L1 calo floating point simulation code clean up, preparing for migration to release 22.
Main points:
- Creation of a new package `TrigT1CaloFexPerf`. In r22, `TrigT1CaloFexSim` should ...This is the first step in the clean up of the Run 3 L1 calo floating point simulation code clean up, preparing for migration to release 22.
Main points:
- Creation of a new package `TrigT1CaloFexPerf`. In r22, `TrigT1CaloFexSim` should be used for the bitwise simulation
- Code cleaned up and migrated into this package as they are understood. So far the processing of J and G towers is migrated and all MET algorithms. These give equal results to their equivalents in the older package. The eFEX algorithms were also migrated by @stelzer
- This involved creating a new xAOD class: `xAOD::GBlock` and its associated container classes. These may want the attention of @akraszna
Tagging @bcarlson as well.
Apologies for the very large number of changes in this MR. This migration involves rewriting some very complex code so it was necessary to have a lot of this infrastructure in place to test that the clean up was successful before a MR could be created.
ATR-22750
Memory leak removed and cleaned up `SCEmulation` algorithm added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4084021.3 ttmdev New Organization on folders2021-05-11T03:06:44+02:00Sergio Ivan Fernandez Luengo21.3 ttmdev New Organization on foldersA new directory has been created at the level of the 'Expert' folder called 'L1', and with this, all the L1 efficiencies histograms have been copied to all the triggers with the scripts L1TAU100, L1TAU60 and L1TAU12.A new directory has been created at the level of the 'Expert' folder called 'L1', and with this, all the L1 efficiencies histograms have been copied to all the triggers with the scripts L1TAU100, L1TAU60 and L1TAU12.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40833Porting 21.2 Isolation Variables and Selections2021-03-18T00:04:59+01:00Christopher Robyn HayesPorting 21.2 Isolation Variables and SelectionsIn order to use the updated object isolations for performance studies, several packages needed to be updated from 21.2
This MR cherry-picks all of the necessary commits in the following packages:
- Event/xAOD/xAODPrimitives
- InnerDetect...In order to use the updated object isolations for performance studies, several packages needed to be updated from 21.2
This MR cherry-picks all of the necessary commits in the following packages:
- Event/xAOD/xAODPrimitives
- InnerDetector/InDetRecTools/TrackVertexAssociationTool
- PhysicsAnalysis/AnalysisCommon/FsrUtils
- PhysicsAnalysis/AnalysisCommon/IsolationSelection
- Reconstruction/RecoAlgs/IsolationAlgs/
- Reconstruction/RecoTools/IsolationTool/
As I only attempted to bring these up to a specific moment in time and be as minimally invasive as possible to other packages, we do not have the most up-to-date commits, but these might be possible without too much trouble.
No new development was performed during these cherry-pickshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40801Include sTGC Efficiencies from HV data2021-02-22T16:31:56+01:00Alexandre LaurierInclude sTGC Efficiencies from HV dataThis MR includes a basic, preliminary framework to include HV efficiencies in the sTGC digitization.
The efficiencies are read from a .dat file and come from the latest data from completed sTGC sectors.
These are the efficiencies of the ...This MR includes a basic, preliminary framework to include HV efficiencies in the sTGC digitization.
The efficiencies are read from a .dat file and come from the latest data from completed sTGC sectors.
These are the efficiencies of the wire to hold HV which allows them to induce charge and create digits on the sTGC strips, wire and pads.
The final framework of this kind of efficiency should be handled by databases and not .dat files, but should still be applied at the digitization level.
Including @rosatihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40783New method to read HV from new inputs (micromegas)2021-05-08T10:13:56+02:00Luca MartinelliNew method to read HV from new inputs (micromegas)New inputs are available with the correct segmentation in HV for the MicroMegas (NSW)
changed the default method to read the files:
- before we don't have the infos on which HV section is (not) connected to the nominal voltage;
- now we ...New inputs are available with the correct segmentation in HV for the MicroMegas (NSW)
changed the default method to read the files:
- before we don't have the infos on which HV section is (not) connected to the nominal voltage;
- now we have the exact HV map (obtained from the cosmic stand at BB5) and the new method reads the new inputs
Changed the formula of the eff vs HV (bug fix)
cc: @rosati @pscholerLuca MartinelliLuca Martinellihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40776Adjusting nsw uncertainties2021-02-23T17:19:57+01:00Stefano RosatiAdjusting nsw uncertaintiesUncertainties on NSW clusters are loosened to avoid loosing a few % eff while waiting for other developments (fixes on clusters calibration for b-field and stgc pad positions ).Uncertainties on NSW clusters are loosened to avoid loosing a few % eff while waiting for other developments (fixes on clusters calibration for b-field and stgc pad positions ).https://gitlab.cern.ch/atlas/athena/-/merge_requests/40737fixing typo in SupercellBCIDEmAlg entries2021-03-05T20:40:57+01:00Ben Carlsonfixing typo in SupercellBCIDEmAlg entrieshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40703Sweeping !40659 from master to 21.3.
Add symmetric NSW+BIS78-A dictionary2021-02-17T03:06:40+01:00Atlas NightlybuildSweeping !40659 from master to 21.3.
Add symmetric NSW+BIS78-A dictionaryAdd symmetric NSW+BIS78-A dictionary
See merge request atlas/athena!40659Add symmetric NSW+BIS78-A dictionary
See merge request atlas/athena!40659https://gitlab.cern.ch/atlas/athena/-/merge_requests/40692Scale gain in MM digi with hv values from file2021-02-20T12:30:13+01:00Patrick ScholerScale gain in MM digi with hv values from fileThis MR enables the use of the smearing tool to change the gain in the MM digi based on the HV read from filesThis MR enables the use of the smearing tool to change the gain in the MM digi based on the HV read from fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40627Fixing the calculation of the cross talk in the Micromegas digitization2021-02-16T10:54:50+01:00Patrick ScholerFixing the calculation of the cross talk in the Micromegas digitizationThis MR fixes the simulation of the cross talk. Now the charge on the central strip is scaled down by the amount of cross talk to the neighboring strips. Before the amount of shared charge was determined on the full charge and subtracted...This MR fixes the simulation of the cross talk. Now the charge on the central strip is scaled down by the amount of cross talk to the neighboring strips. Before the amount of shared charge was determined on the full charge and subtracted from the central strip, leading to unrealistic charge ratios and negative charges on the central strip.
Adding ~urgent since new samples with this MR need to be created quicklyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40593Fix sTGC-QL3 geometry clash (ATLASSIM-5002)2021-02-17T22:06:25+01:00Alexandre LaurierFix sTGC-QL3 geometry clash (ATLASSIM-5002)Fix a geometry clash in the NSW sTGC caused by the QL3 sectors as outlined here (ATLASSIM-5002).
An update to the QL3 geometry is also done by way of updating the xml files which described the NSW. The trapezoidal shapes had two of 6 ve...Fix a geometry clash in the NSW sTGC caused by the QL3 sectors as outlined here (ATLASSIM-5002).
An update to the QL3 geometry is also done by way of updating the xml files which described the NSW. The trapezoidal shapes had two of 6 vertexes 15mm offset from the nominal values.
The two xml files are exact copies of the latest versions, except where yCutout="545.3" have been updated to yCutout="560.4".https://gitlab.cern.ch/atlas/athena/-/merge_requests/40547"Include ionization statististics in sTGC digitization"2021-03-01T14:11:51+01:00Sandeep Kaursandeep.hep@gmail.com"Include ionization statististics in sTGC digitization"include polya distribution function to parameterize ionization gain
@alaurier @dpizziinclude polya distribution function to parameterize ionization gain
@alaurier @dpizzihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40466Sweeping !40386 from master to 21.3.
Add warning to MuonPerformanceAlg in cas...2021-02-10T03:06:40+01:00Atlas NightlybuildSweeping !40386 from master to 21.3.
Add warning to MuonPerformanceAlg in case muon is of bad qualityAdd warning to MuonPerformanceAlg in case muon is of bad quality
See merge request atlas/athena!40386Add warning to MuonPerformanceAlg in case muon is of bad quality
See merge request atlas/athena!40386https://gitlab.cern.ch/atlas/athena/-/merge_requests/37445specify imf library in the TriggerTest package (ATR-22224)2021-02-08T09:48:40+01:00Yasuyuki Okumuraspecify imf library in the TriggerTest package (ATR-22224)To specify imf library in TriggerTest package to guarantee a fair comparison between SLC6 CC7 (ATR-22224).
Env variable is set in the following script, which affects ART tests in the TriggerTest package in R21.3 `Trigger/TrigValidation/...To specify imf library in TriggerTest package to guarantee a fair comparison between SLC6 CC7 (ATR-22224).
Env variable is set in the following script, which affects ART tests in the TriggerTest package in R21.3 `Trigger/TrigValidation/TriggerTest/test/exec_athena_art_trigger_validation.sh`
Best regards,
Yasu Okumurahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38237First commit of BIS RPC trigger simulation2021-05-07T11:21:06+02:00Matteo NegriniFirst commit of BIS RPC trigger simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40420Replace unsafe sprintf() in NSWL1Simulation::initialize()2021-02-10T03:06:39+01:00Yuval ZachReplace unsafe sprintf() in NSWL1Simulation::initialize()In `NSWL1Simulation::initialize()`, two calls are made to `sprintf` into a stack-allocated array. The format string is unbounded, meaning a `name()` longer than 36 characters (extremely unlikely) will result in a stack buffer overflow.
...In `NSWL1Simulation::initialize()`, two calls are made to `sprintf` into a stack-allocated array. The format string is unbounded, meaning a `name()` longer than 36 characters (extremely unlikely) will result in a stack buffer overflow.
This replaces the `sprintf` and char arrays with C++ strings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40364Sweeping !40292 from master to 21.3.
Fix muon reco ART test release2021-02-06T03:06:32+01:00Atlas NightlybuildSweeping !40292 from master to 21.3.
Fix muon reco ART test releaseFix muon reco ART test release
See merge request atlas/athena!40292Fix muon reco ART test release
See merge request atlas/athena!40292