athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-04-18T18:08:12+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/22685Ftk clustering update2019-04-18T18:08:12+02:00Stamatios GkaitatzisFtk clustering updateThe merge request aims to improve the clustering functionality of TrigFTKSim. The following modifications have been made:
1. atlClustering is replaced by the FTKClusteringEngine class.
2. FTKClusteringPrintout is tasked with handling pr...The merge request aims to improve the clustering functionality of TrigFTKSim. The following modifications have been made:
1. atlClustering is replaced by the FTKClusteringEngine class.
2. FTKClusteringPrintout is tasked with handling printing functions which were previously part of the main clustering code.
3. Fix memory leak issues.
Apart from the clustering improvements, this merge aims to clean a part of legacy code that is not needed anymore. These modifications include the removal of the parameters x, y and z from FTKRawHit and the removal of SCTtrk which is also not going to be needed in the future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21918Changes for implementing l1topo triggers and small change for ATR-173282019-04-04T14:26:26+02:00Tamara Vazquez SchroederChanges for implementing l1topo triggers and small change for ATR-17328- Taking over from MR !21702
- Resolved conflicts with 21.3
- Modified TCS::LayoutConstraints::g_maxComponents = 200
- Generate automatically unprescaled_only prescales based on the Primary tag rather than the hardcoded list
- L1Top...- Taking over from MR !21702
- Resolved conflicts with 21.3
- Modified TCS::LayoutConstraints::g_maxComponents = 200
- Generate automatically unprescaled_only prescales based on the Primary tag rather than the hardcoded list
- L1Topo changes made are for:
- ATR-19355: Implement L1Topo trigger 0INVM10-3MU4ab
- ATR-18815: Implemet L1topo trigger 0INVM10-0DR15-EM8abi-MU10ab and 0INVM10-0DR15-EM12abi-MU6ab
- ATR-17328: 1DISAMB-J25ab-0DR28-TAU20abi-TAU12abi -> 2DISAMB-J25ab-0DR28-TAU20abi-TAU12abi
- Much of the L1Topo code is commented out because of a bug on the algorithm side producing a crash. The menu implementation is correct and validated, so we want to include it (commented) and will uncomment once the L1Topo algorithm has been debugged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39545Implementation of RMS computed with LUT for gFEX MET2021-01-07T22:12:39+01:00Ava Anne MyersImplementation of RMS computed with LUT for gFEX METhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38940G fex met2020-12-07T20:41:22+01:00Ava Anne MyersG fex metAdded variant of Rho+RMS algorithm in which RMS is pulled from LUT rather than calculated in-timeAdded variant of Rho+RMS algorithm in which RMS is pulled from LUT rather than calculated in-timehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/38044Improvements to NoiseStudy algorithm2020-11-09T21:44:06+01:00Denis Oliveira DamazioImprovements to NoiseStudy algorithmFor the Supercell simulation studiesFor the Supercell simulation studieshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/37438specify imf library in the TriggerTest package (ATR-22224)2020-10-20T21:12:17+02:00Yasuyuki Okumuraspecify imf library in the TriggerTest package (ATR-22224)To specify imf library in TriggerTest package to guarantee fair comparison between SLC6 CC7 (ATR-22224).
Env variable is set in the following script, which affects ART tests in the TriggerTest package in R21.3
`Trigger/TrigValidation/Tr...To specify imf library in TriggerTest package to guarantee fair comparison between SLC6 CC7 (ATR-22224).
Env variable is set in the following script, which affects ART tests in the TriggerTest package in R21.3
`Trigger/TrigValidation/TriggerTest/test/exec_athena_art_trigger_validation.sh`
Best regards,
Yasu Okumurahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/35043added jXERHO to trigger EDM and implemented sumET fix2020-08-10T10:09:03+02:00Bryan Kortmanadded jXERHO to trigger EDM and implemented sumET fixfixing the sumET container to be filled with MissingET for the algorithms, NoiseCut_MET, jXERHO and JWOJ.
NoiseCUT_MET:Filling when passing the noise and eta cuts and after the bool useNegTowers
jXERHO: summing after the rho substracti...fixing the sumET container to be filled with MissingET for the algorithms, NoiseCut_MET, jXERHO and JWOJ.
NoiseCUT_MET:Filling when passing the noise and eta cuts and after the bool useNegTowers
jXERHO: summing after the rho substraction -> sumET_sub += Et_sub;
JWOJ:Filling the ET_values[0] which is defined as scalar_ET. in jwoj.h this is defined as scalar_Et+=seed_Et;Ben CarlsonJon BurrBen Carlsonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34994WIP:Added jXERHO to the Lvl1 Run3 performace study outputs2020-07-23T16:39:53+02:00Bryan KortmanWIP:Added jXERHO to the Lvl1 Run3 performace study outputsAdded jXERHO to the Lvl1 Run3 performace study outputsAdded jXERHO to the Lvl1 Run3 performace study outputsJon BurrJon Burrhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34991Added the jXERHO METAlg do the AOD output2020-07-22T19:51:45+02:00Bryan KortmanAdded the jXERHO METAlg do the AOD outputOnly added extra branches to the AOD output of the already implemented jXERHO alg in the METAlg.cxx fileOnly added extra branches to the AOD output of the already implemented jXERHO alg in the METAlg.cxx filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31356Bug fix SensorSimPlanarTool.cxx2020-03-23T23:43:33+01:00Eric Ballabeneeric.ballabene@cern.chBug fix SensorSimPlanarTool.cxxBug fix accounting for different pixel sizesBug fix accounting for different pixel sizeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22672atr-195762019-04-15T16:12:00+02:00Mario Campanelliatr-19576Added several chains to the Physics_v7 primary menuAdded several chains to the Physics_v7 primary menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22620WIP:fix on cpET2019-04-12T18:49:25+02:00Chiao-Ying LinWIP:fix on cpETThe CP ADC count was changed, and this is to correct the number for itThe CP ADC count was changed, and this is to correct the number for ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/22255Update MET TrigMonitor for new L1Calo Sim2019-03-29T17:21:18+01:00Renjie WangUpdate MET TrigMonitor for new L1Calo SimThis is to update TrigMonitor from MET signature for new L1Calo Sim (ATR-19610) (@rewang @astruebi) This is to update TrigMonitor from MET signature for new L1Calo Sim (ATR-19610) (@rewang @astruebi) https://gitlab.cern.ch/atlas/athena/-/merge_requests/22229Remove L1 v8 xmls2019-03-29T11:33:01+01:00Javier Montejo BerlingenRemove L1 v8 xmlsTest MR, we are fighting with conflicts in the xmls and it seems nobody uses them directly from the source tree
Includes changes from !22125 as it fixes a crash on the CITest MR, we are fighting with conflicts in the xmls and it seems nobody uses them directly from the source tree
Includes changes from !22125 as it fixes a crash on the CIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21566Tau trigger: dR combo hypo (ATR-19359)2019-03-11T17:11:15+01:00Daniele ZanziTau trigger: dR combo hypo (ATR-19359)@jmontejo @aranzazu could you please check you are happy with these changes?
I renamed the old dR hypo (for topo selection in tau signature) to dRtt and created a new dR hypo for topo selections in combined signatures.
I reused the hy...@jmontejo @aranzazu could you please check you are happy with these changes?
I renamed the old dR hypo (for topo selection in tau signature) to dRtt and created a new dR hypo for topo selections in combined signatures.
I reused the hypo code developed in ATR-16730 (https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/4193) which was not merged to 21.1.
I had to remove the L1 seed for tau20 otherwise the name of the VBF chains get too long.
I'll check the counts later and remove WIP when you OK'ed.
Does this need to go also to master?https://gitlab.cern.ch/atlas/athena/-/merge_requests/21453Changes related to jira 193822019-02-28T15:08:21+01:00Kalliopi IordanidouChanges related to jira 19382https://gitlab.cern.ch/atlas/athena/-/merge_requests/20790Test commit2019-01-31T16:05:10+01:00Ava Anne MyersTest commithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20757Removal of redundant variables in JGTowerContainer2019-02-14T01:30:47+01:00Chiao-Ying LinRemoval of redundant variables in JGTowerContainerDue to the scheme of Run3 towers, the following variables are not needed anymore:
1. LAr_et
2. Tile_et
3. Tilefrac
4. Adding back in towers with ET = 0
5. Utilizing the path resolver to access noise
so they are now removed fr...Due to the scheme of Run3 towers, the following variables are not needed anymore:
1. LAr_et
2. Tile_et
3. Tilefrac
4. Adding back in towers with ET = 0
5. Utilizing the path resolver to access noise
so they are now removed from the containerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20296Large merge to import TrigInDetAnalysis changes from final 21.1-dev to 21.32019-01-11T13:37:11+01:00Mark SuttonLarge merge to import TrigInDetAnalysis changes from final 21.1-dev to 21.3Includes the merge of code from last version of 21.1-dev to 21.3, includes
update and tidy of the copyright statement ( 2018 -> 2019 etc since these
are different between the code in any case)
Their are also some code compliance changes...Includes the merge of code from last version of 21.1-dev to 21.3, includes
update and tidy of the copyright statement ( 2018 -> 2019 etc since these
are different between the code in any case)
Their are also some code compliance changes - replacing __FILENAME_H with
PACKAGE_FILENAME_H in the include guard and so on
Add the header required for matching the full trigger objects with
the tracks needed for the full object selection
The functionality changes (ie changes to code structure) are coming from
21.1-dev / 21.1 so in principle they have been reviewed and validated already,
so really reviewing this merge request will be a major waste of time for
all concerned.
As it is so large, there might inevitably be some code compliance issues
that have been missed, but rather than waste additional time here, these
can be addressed in subsequent merge requests over the comming weeks while
we try to tidy up and consolidate the changes required by the migration
to the new branches
This is further discussed in ATR-19009 which these changes partly address.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21120WIP: code cleaning, keeping all towers, and pathresolver for noise file2019-02-25T22:57:03+01:00Chiao-Ying LinWIP: code cleaning, keeping all towers, and pathresolver for noise fileThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolverThis is the update for Run3 L1Calo simulation:
1. remove redundant variables
2. keeping all towers although they are without energy deposit
3. Noise file is accessed by pathresolver