athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-12-17T10:08:08+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/58237Merge branch 'idcalib_sean2' into '22.0' [ATR-23204]2022-12-17T10:08:08+01:00Sean GalantzanMerge branch 'idcalib_sean2' into '22.0' [ATR-23204]- Added track quality cuts based on requirements from the Alignment group. (all cuts are configurable and could be monitored)
- Removed the pt cut multiplicity in favour of eta dependent pt cuts. (configurable as well)
- Added new chain...- Added track quality cuts based on requirements from the Alignment group. (all cuts are configurable and could be monitored)
- Removed the pt cut multiplicity in favour of eta dependent pt cuts. (configurable as well)
- Added new chains that use optimised eta dependent pt cuts that should produce flat eta distributions. This was validated offline using data18 EB samples. The eta distribution before and after this cut is monitored.Sean GalantzanSean Galantzanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57233Draft: MSVertexReconstruction - Revisement2022-12-17T10:07:13+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: MSVertexReconstruction - RevisementCloses ATLASRECTS-7166Closes ATLASRECTS-7166https://gitlab.cern.ch/atlas/athena/-/merge_requests/56566Draft: Write both expert and shifter chains to the Expert histograms2022-12-17T09:59:46+01:00Mark SuttonDraft: Write both expert and shifter chains to the Expert histogramsApparently the "t0" and "shifter" mongroups are non overlapping. This should
allow the "expert" histograms to include bothApparently the "t0" and "shifter" mongroups are non overlapping. This should
allow the "expert" histograms to include bothhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58899InDetPerformanceMonitoring with LumiBlock selection2022-12-07T09:53:24+01:00Salvador Marti I Garciasalvador.marti@cern.chInDetPerformanceMonitoring with LumiBlock selectionadd lumibloc selection capabilities via jobOptions (min and max accepted lumiblock)add lumibloc selection capabilities via jobOptions (min and max accepted lumiblock)https://gitlab.cern.ch/atlas/athena/-/merge_requests/58905removed explicit tags since the tag is available in the global tag now2022-12-06T10:38:14+01:00Junpei Maedaremoved explicit tags since the tag is available in the global tag nowThe explicit tags have been remained because the tag was not available in the global tag when I had introduced new condition database. Now these tags are available in the latest global tags, I would remove the explicit tags to update the...The explicit tags have been remained because the tag was not available in the global tag when I had introduced new condition database. Now these tags are available in the latest global tags, I would remove the explicit tags to update the conditions without source changes in future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58207change Run2TTMaker dependency of l1calosvc (4). Preparing for deletion of L1...2022-11-30T16:24:14+01:00Florencia Luciana Castilloflorencia.luciana.castillo@cern.chchange Run2TTMaker dependency of l1calosvc (4). Preparing for deletion of L1CaloCondSvc in rel 22 (ATR-24777).Hello,
This MR is for changing the dependency of Run2TriggerTowerMaker on L1CaloCondSvc. Another MR toward the deletion of L1CaloCondSvc from athena 22. The jira ticket related to this issue is this one: [ATR-24777](https://its.cern.ch...Hello,
This MR is for changing the dependency of Run2TriggerTowerMaker on L1CaloCondSvc. Another MR toward the deletion of L1CaloCondSvc from athena 22. The jira ticket related to this issue is this one: [ATR-24777](https://its.cern.ch/jira/browse/ATR-24777)
Thanks, Florencia cc to @mwesselshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57667Draft: Add Xbb Truth Labelling Tool2022-11-23T13:55:26+01:00Samuel Van StroudDraft: Add Xbb Truth Labelling ToolAdd a small tool to decorate large-R jets. The tool decorates `AntiKt10UFOCSSKSoftDropBeta100Zcut10Jets` during FTAG derivations. The result is saved by default in the output files.
For the moment the labels are:
```c++
namespace Xbb {...Add a small tool to decorate large-R jets. The tool decorates `AntiKt10UFOCSSKSoftDropBeta100Zcut10Jets` during FTAG derivations. The result is saved by default in the output files.
For the moment the labels are:
```c++
namespace Xbb {
enum XbbLabel {
QCDother=0,
Top,
WBoson,
ZBoson,
Hbb,
Hcc,
};
}
```
Tagging @dguest @biliu @fdibello @vdao @arelycg @vvecchiohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58610Sweeping !58578 from master to 22.0.
Use default TRT active gas in geo model ...2022-11-23T00:16:23+01:00Atlas NightlybuildSweeping !58578 from master to 22.0.
Use default TRT active gas in geo model unless in simulation.Closes ATLASRECTS-5407Use default TRT active gas in geo model unless in simulation.
Closes ATLASRECTS-5407
See merge request atlas/athena!58578Use default TRT active gas in geo model unless in simulation.
Closes ATLASRECTS-5407
See merge request atlas/athena!58578https://gitlab.cern.ch/atlas/athena/-/merge_requests/53589hotSpotInHIST script : fix of project-tag retrieval2022-11-22T15:09:04+01:00Benjamin TrocmehotSpotInHIST script : fix of project-tag retrievalWhen migrating to release 22, the automatic retrieval of project tag of a run was broken.
This is a fix.
NB: this is a standalone script, I am the main/original developer, I tested the fix.When migrating to release 22, the automatic retrieval of project tag of a run was broken.
This is a fix.
NB: this is a standalone script, I am the main/original developer, I tested the fix.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58503Draft: Simulation/ISF/ISF_FatrasTools : manual port of changes in MR56730 to 222022-11-18T17:52:24+01:00Liza MijovicDraft: Simulation/ISF/ISF_FatrasTools : manual port of changes in MR56730 to 22MR !56730 made useful updates to ISF_FatrasTools in master. These should be in 22.0 too . This MR ports the MR56730 diff to 22.0 . It does not need to be swept to master.MR !56730 made useful updates to ISF_FatrasTools in master. These should be in 22.0 too . This MR ports the MR56730 diff to 22.0 . It does not need to be swept to master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58460Enabling onnx session to run on GPU2022-11-18T11:23:15+01:00Debottam Bakshi GuptaEnabling onnx session to run on GPUIn this MR I am creating an additional function CreateORTSessionGPU which will create an onnx session compatible to run on GPU. I am adding @keli ( also @akraszna ).In this MR I am creating an additional function CreateORTSessionGPU which will create an onnx session compatible to run on GPU. I am adding @keli ( also @akraszna ).https://gitlab.cern.ch/atlas/athena/-/merge_requests/58373Modification of V2.3 processing to work well with all clients2022-11-14T17:23:39+01:00Iurii BordulevModification of V2.3 processing to work well with all clientsThe previous merge contained algorithms for HanOutputFile
of version 2 (V2.3.1) formation. This code was modified
in this merge request. All the clients now work similarly
well with V1 and V2 HanOutputFiles.The previous merge contained algorithms for HanOutputFile
of version 2 (V2.3.1) formation. This code was modified
in this merge request. All the clients now work similarly
well with V1 and V2 HanOutputFiles.Peter OnyisiPeter Onyisihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58289New NVSI calibration2022-11-10T21:58:23+01:00Vadim KostyukhinNew NVSI calibrationUse new 2-track calibration file in NVSIUse new 2-track calibration file in NVSIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58300Update NVSI calibration2022-11-10T18:28:59+01:00Vadim KostyukhinUpdate NVSI calibrationUse new 2-track vertex calibration fileUse new 2-track vertex calibration filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58286New NVSI calibration2022-11-10T14:47:09+01:00Vadim KostyukhinNew NVSI calibrationUse news 2-track vertices calibration fileUse news 2-track vertices calibration filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58151deletion of old tools using l1caloservice (3): Old tool Run2TriggerTowerMaker...2022-11-08T10:40:55+01:00Florencia Luciana Castilloflorencia.luciana.castillo@cern.chdeletion of old tools using l1caloservice (3): Old tool Run2TriggerTowerMaker deletion. Preparing for deletion of L1CaloCondSvc in rel 22 (ATR-24777).Hello,
This is another MR related to [ATR-24777](https://its.cern.ch/jira/browse/ATR-24777). This time I am deleting Run2TriggerTowerMaker, L1CaloHVScalesMon and TransientDatabaseOverride.
Thanks, Florencia
cc to @mwesselsHello,
This is another MR related to [ATR-24777](https://its.cern.ch/jira/browse/ATR-24777). This time I am deleting Run2TriggerTowerMaker, L1CaloHVScalesMon and TransientDatabaseOverride.
Thanks, Florencia
cc to @mwesselshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58143Reenable non-isolated electron trigger with Phase-I seeds in MC menu2022-11-07T19:09:48+01:00Damiano VannicolaReenable non-isolated electron trigger with Phase-I seeds in MC menuJira 26531: Reenable non-isolated electron trigger with Phase-I seeds in MC menuJira 26531: Reenable non-isolated electron trigger with Phase-I seeds in MC menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58106Update NVSI example algorithm2022-11-04T19:55:57+01:00Vadim KostyukhinUpdate NVSI example algorithm1) Make NVSI example algorithm reentrant
2) Add CA script for the example algorithm1) Make NVSI example algorithm reentrant
2) Add CA script for the example algorithmhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57672Draft: Clean sTGC Digitization package to replace and improve VMMSim class to...2022-11-03T15:59:31+01:00Alexandre LaurierDraft: Clean sTGC Digitization package to replace and improve VMMSim class to handle VMM deadtime and strip neighborOn logicGoal is to improve the behaviour of the VMM simulation in the sTGC digitization and broadly remove redundant information and useless code/files. If possible, these changes should be used for the planned November reprocessing.
Previously,...Goal is to improve the behaviour of the VMM simulation in the sTGC digitization and broadly remove redundant information and useless code/files. If possible, these changes should be used for the planned November reprocessing.
Previously, the behaviour of the VMM was taken care of into the VMMSim class which was slow, extremely confusing and not working in some fringe cases. Previous VMM simulation would track the state of channels through dead/ready/read states for small time steps which would be computationally heavy and the code was very impractical (see confusing) to read.
We now streamline the whole sTGC DigitizationTool so that the processing of VMM deadtime and strip neighborOn logic is clear to follow.
Some important values for the VMM can now be directly controlled via the python steering scripts instead of having to manually change txt files.
The result is the removal of the whole sTGC VMMSim class. Also included in the MR is the removal of extraneous CSC files (unused), functions and redundant variables.
The changes of !57643 are already implemented in this MR as well.
The basic logic for the new deadtime simulation is as follows:
1) If two digits are within the VMM merging time window of 30ns, the 2nd digit in time is merged within the 1st one.
2) If a digit is above the VMM charge threshold it triggers the VMM to read the charge (save the digit to become RDO) and causes all following digits in the VMMDeadtime window to be lost due to the VMM being in a dead state.
The basic logic for the new strip neighborOn simulation is as follows:
1) Follows the same logic as the basic deadtime simulation outlined above.
2) If a strip is above threshold and triggers the VMM into the read state, the neighbourOn functionality also forces the neighbouring strips to read the charges to VMM even if below threshold. Practically this means that any below-threshold digit is saved to become RDO if a neighbouring strip is above threshold, saved to VMM, and within a time window defined as the VMM merging window.
Tests are currently ongoing to further validate these changes. So far the deadtime implementation works well and outperforms the VMMSim class implementation. The neighborOn logic for strips currently increases the number of strips in a cluster by AT MOST TWO for muon-only clusters, indicating a correct implementation. General number of strips per layer is increased by 20-30%. Currently awaiting on results of jobs with more statistics.
Tagging @chchauhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57910Sweeping !57882 from master to 22.0.
TrigDecisionTool: Fix thread-safety prob...2022-10-31T13:47:12+01:00Atlas NightlybuildSweeping !57882 from master to 22.0.
TrigDecisionTool: Fix thread-safety problem.TrigDecisionTool: Fix thread-safety problem.
See merge request atlas/athena!57882TrigDecisionTool: Fix thread-safety problem.
See merge request atlas/athena!57882