athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-12-01T19:51:43+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/58870Update L1Topo Sort/Select algorithms2022-12-01T19:51:43+01:00Paula Martinez SuarezUpdate L1Topo Sort/Select algorithms- Update default parameters in L1Topo Sort/Select algorithms to be compatible with Run 3 units.
- Remove unused parameters from eFex Sort/Select algorithms.
- Add LArSaturation algorithm to TopoSteeringStructure.cxx to avoid warning.
Lo...- Update default parameters in L1Topo Sort/Select algorithms to be compatible with Run 3 units.
- Remove unused parameters from eFex Sort/Select algorithms.
- Add LArSaturation algorithm to TopoSteeringStructure.cxx to avoid warning.
Local tests do not show changes in the trigger counts.
Tagging @khoo from trigger menu.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58867InDetAlignmentMonitoringRun3: Fix memory leak in IDAlignMonPVBiasesAlg2022-12-01T20:03:25+01:00Alaettin Serhan MeteInDetAlignmentMonitoringRun3: Fix memory leak in IDAlignMonPVBiasesAlgThis should fix the following memory leaks that started showing up in the standard SPOT tests after !57668 is merged:
```
--------------------------------------------------
42,912 bytes in 596 blocks are definitely lost in loss record 9...This should fix the following memory leaks that started showing up in the standard SPOT tests after !57668 is merged:
```
--------------------------------------------------
42,912 bytes in 596 blocks are definitely lost in loss record 97,689 of 99,659
at 0x4033F11: operator new(unsigned long) (vg_replace_malloc.c:422)
by 0xDE1F7FBB: Trk::TrackToVertexIPEstimator::calculate(Trk::ParametersBase<5, Trk::Charged> const*, xAOD::Vertex_v1 const&) const (TrackToVertexIPEstimator.cxx:166)
by 0xDE1F85CA: Trk::TrackToVertexIPEstimator::estimate(Trk::ParametersBase<5, Trk::Charged> const*, Trk::ParametersBase<5, Trk::Charged> const*, xAOD::Vertex_v1 const*, bool) const (TrackToVertexIPEstimator.cxx:117)
by 0xF6FCD721: IDAlignMonPVBiasesAlg::fillHistograms(EventContext const&) const (IDAlignMonPVBiasesAlg.cxx:112)
by 0x381443F6: Gaudi::Algorithm::sysExecute(EventContext const&) (Algorithm.cpp:366)
--------------------------------------------------
--------------------------------------------------
315,936 bytes in 4,388 blocks are definitely lost in loss record 99,079 of 99,659
at 0x4033F11: operator new(unsigned long) (vg_replace_malloc.c:422)
by 0xDE1F7FBB: Trk::TrackToVertexIPEstimator::calculate(Trk::ParametersBase<5, Trk::Charged> const*, xAOD::Vertex_v1 const&) const (TrackToVertexIPEstimator.cxx:166)
by 0xDE1F85CA: Trk::TrackToVertexIPEstimator::estimate(Trk::ParametersBase<5, Trk::Charged> const*, Trk::ParametersBase<5, Trk::Charged> const*, xAOD::Vertex_v1 const*, bool) const (TrackToVertexIPEstimator.cxx:117)
by 0xF6FCD721: IDAlignMonPVBiasesAlg::fillHistograms(EventContext const&) const (IDAlignMonPVBiasesAlg.cxx:112)
by 0x381443F6: Gaudi::Algorithm::sysExecute(EventContext const&) (Algorithm.cpp:366)
--------------------------------------------------
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/58866Fix for sTGC as-built conditions2022-12-02T15:25:10+01:00Stylianos AngelidakisFix for sTGC as-built conditionsSome optimizations in view of as-built conditions:
1. Bugfix: For sTGC's we measure strips in pitches, (3.2mm), not width (2.7mm).
2. Optimized the sTGC as-built transformation to handle positions between strips, as it is for MM (not to ...Some optimizations in view of as-built conditions:
1. Bugfix: For sTGC's we measure strips in pitches, (3.2mm), not width (2.7mm).
2. Optimized the sTGC as-built transformation to handle positions between strips, as it is for MM (not to put everything on the strip center).
3. Some protection for layers or cathode board elements that may not have as-built corrections at all.
4. Finally, I noticed that the B-field correction can kick a cluster position slightly out of the active area (only for clusters on the very outmost strips). It's not the job of the as-built transformation to reject those cases, just to correctly apply the transformation. Applied the necessary change for this.
Tagging @stsigarihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58863Account for pointless average z-beamspot "correction"2022-12-01T19:34:39+01:00Mark SuttonAccount for pointless average z-beamspot "correction"Changes the default parameter to enable this by default. Could remove the
ability to enable / disable but for the time being it is better to leave it
as a flag to allow for studies of the potential impact of disabling / enabling.
Might ...Changes the default parameter to enable this by default. Could remove the
ability to enable / disable but for the time being it is better to leave it
as a flag to allow for studies of the potential impact of disabling / enabling.
Might change the rate of some muon iso chains, in which case the references
will be updated. However, if the MC samples used for the tests always have the
beamspot average z at 0, then no differences should arise.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58857StgcRawDataMonitoring: implementation of shifter level plots2022-12-01T20:03:10+01:00Sebastian Julio Fuenzalida GarridoStgcRawDataMonitoring: implementation of shifter level plotsIn this development we implement more shifter plots to be included in the
release 22.0. These implementation complete the list of shifter plots proposed for the
sTGC offline monitoring (https://codimd.web.cern.ch/XCIH4Gz1RD-qq08HzGBPDg#)...In this development we implement more shifter plots to be included in the
release 22.0. These implementation complete the list of shifter plots proposed for the
sTGC offline monitoring (https://codimd.web.cern.ch/XCIH4Gz1RD-qq08HzGBPDg#).
Tagging: @carquin @chchau @estel @glamprin @makbiyik @gvasquezhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58856Return a failure in BS decoder when L1Menu items are not found2022-12-01T19:49:10+01:00Cecilia TosciriReturn a failure in BS decoder when L1Menu items are not foundTo protect from exceptions when running on data before 2022, gFex TOBs decoder now returns a failure when L1Menu items are not found. Please refer to ATR-26734.To protect from exceptions when running on data before 2022, gFex TOBs decoder now returns a failure when L1Menu items are not found. Please refer to ATR-26734.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58850Manual sweep of !58821 to 22.02022-11-30T12:02:14+01:00Joshua Falco Beirerjoshua.beirer@cern.chManual sweep of !58821 to 22.0Manual sweep of !58821 to 22.0Manual sweep of !58821 to 22.0https://gitlab.cern.ch/atlas/athena/-/merge_requests/58842DataQualityConfigurations: Modify L1Calo config for web display2022-11-30T12:03:53+01:00Kristin DonaDataQualityConfigurations: Modify L1Calo config for web displayModifying the L1Calo config for the data-quality web display. Modifications remove histograms of algorithms no longer present in athena and add MET efficiency curves produced by HLT.Modifying the L1Calo config for the data-quality web display. Modifications remove histograms of algorithms no longer present in athena and add MET efficiency curves produced by HLT.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58841TCT - changing test to be executable2022-11-29T19:24:02+01:00Peter BertaTCT - changing test to be executablehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58839Solving crash tier 0, jFEX decoders2022-12-01T19:17:58+01:00Sergi Rodriguez BoscaSolving crash tier 0, jFEX decodersThis MR is means to solve a Tier 0 crash when running some test (see ATR-26723).
I have added two firewalls, one that solves the problem mention in the JIRA, and other as a precaution to not attempt to access a vector when the size is lo...This MR is means to solve a Tier 0 crash when running some test (see ATR-26723).
I have added two firewalls, one that solves the problem mention in the JIRA, and other as a precaution to not attempt to access a vector when the size is lower than the expected to start decoding.
Adding @rbielskihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58836TrigConfStorage: support LB queries in TriggerCoolUtils and cleanup2022-12-01T19:46:49+01:00Frank WinklmeierTrigConfStorage: support LB queries in TriggerCoolUtils and cleanupAdd support for LB-based queries in the various `TriggerCoolUtil`
functions. Also remove code duplication, delete/move unused functions
and add unit test. This should have no impact on existing code.
First step in addressing ATR-26381.Add support for LB-based queries in the various `TriggerCoolUtil`
functions. Also remove code duplication, delete/move unused functions
and add unit test. This should have no impact on existing code.
First step in addressing ATR-26381.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58823LArBadChanTool fix2022-11-30T23:59:33+01:00Pavol StrizenecLArBadChanTool fixThis should fix the compiler warnings reported in ATLASRECTS-7408, created by my previous MR 58752, sorry about that.This should fix the compiler warnings reported in ATLASRECTS-7408, created by my previous MR 58752, sorry about that.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58822Manual sweep to 22.0: Update large-R labelling for Xbb2022-11-30T23:59:33+01:00Samuel Van StroudManual sweep to 22.0: Update large-R labelling for XbbManual sweep: Update large-R labelling for Xbb
See merge request atlas/athena!58643
I ported over from master the `truthlabels_SD` variabe from `StandardLargeRJets.py`. Hopefully this looks okay to @jveatch and @jcantero.Manual sweep: Update large-R labelling for Xbb
See merge request atlas/athena!58643
I ported over from master the `truthlabels_SD` variabe from `StandardLargeRJets.py`. Hopefully this looks okay to @jveatch and @jcantero.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58815[ATR-25805] Downgrade WARNING to DEBUG in TrigNavSlimmingMTAlg2022-11-29T17:52:09+01:00Tim Martin[ATR-25805] Downgrade WARNING to DEBUG in TrigNavSlimmingMTAlgDowngrade WARNING to DEBUG in conversion of trigger features to four-vectors in the DAOD due to not having a TriggerAPI to prevent inappropriate chains features being attempted to be converted.
Would suggest to re-instate this after the...Downgrade WARNING to DEBUG in conversion of trigger features to four-vectors in the DAOD due to not having a TriggerAPI to prevent inappropriate chains features being attempted to be converted.
Would suggest to re-instate this after the TriggerAPI is reincluded, it could then help to find misconfigured chains, or misconfigurations in the TriggerAPI, or highlight the need for additional bespoke handling in derivations of non-IParticle conformant trigger physics objects.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58813Add merging script for EB weights xml files (ATR-26569)2022-12-01T19:48:13+01:00Sofia CellaAdd merging script for EB weights xml files (ATR-26569)This script merges the EB weights xml files.
Each xml file has a list of weights with ids and a list of events with assigned weight (by id).
Weights' ids are different between the files and the merging script unifies the ids of the weights.This script merges the EB weights xml files.
Each xml file has a list of weights with ids and a list of events with assigned weight (by id).
Weights' ids are different between the files and the merging script unifies the ids of the weights.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58804Bug fix for L1Topo decision overflow assignment2022-11-29T17:50:33+01:00Anil Sonayanil.sonay@cern.chBug fix for L1Topo decision overflow assignmentThe assignment of overflow and decision bits was incorrect for the hardware monitoring, and fixed in this MR.The assignment of overflow and decision bits was incorrect for the hardware monitoring, and fixed in this MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58788sync R22 and R21 branches of xAODBTaggingEfficiency and CalibrationDataInterface2022-12-18T21:11:35+01:00Ilaria Luisesync R22 and R21 branches of xAODBTaggingEfficiency and CalibrationDataInterfaceThe two branches diverged 2 years ago and the changes implemented in R21 have never been imported into R22. \
Now c-tagging and Continuous2D tagging are available in R22, as well as Truth Tagging with GNN and the high-pT extrapolations ...The two branches diverged 2 years ago and the changes implemented in R21 have never been imported into R22. \
Now c-tagging and Continuous2D tagging are available in R22, as well as Truth Tagging with GNN and the high-pT extrapolations in continuous WP.
differences with R21 branch (considered the one up to date, so the reference) are reported here: [differences_R22dev_vs_R21.txt](/uploads/2fa2379763bf180faa2d3f065e6350f6/differences_R22_vs_R21.txt)https://gitlab.cern.ch/atlas/athena/-/merge_requests/58783Move Run 2 MC reco CI test to use RAWtoALL2022-12-04T18:50:29+01:00Tadej Novaktadej.novak@cern.chMove Run 2 MC reco CI test to use RAWtoALLMove Run 2 MC reco CI test to use `RAWtoALL` as we plan to deprecate two-step reconstruction. Doing this in a separate MR for less disruption.
/cc @christos @mhodgkin @jmaurerMove Run 2 MC reco CI test to use `RAWtoALL` as we plan to deprecate two-step reconstruction. Doing this in a separate MR for less disruption.
/cc @christos @mhodgkin @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58779MuonCombinedInDetExtensionAlg - Remove tool handle array2022-11-29T20:24:45+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonCombinedInDetExtensionAlg - Remove tool handle arrayLet's see whether the tool handle array might cause the problems here
Closes ATLASRECTS-7384Let's see whether the tool handle array might cause the problems here
Closes ATLASRECTS-7384https://gitlab.cern.ch/atlas/athena/-/merge_requests/58778Updated TRT CA config for cosmics [ATLASRECTS-7331]2022-11-29T15:06:42+01:00Thomas StreblerUpdated TRT CA config for cosmics [ATLASRECTS-7331]Fix circular dependency + missing condition setup for TRT CA config in cosmics
Outputs of q445 CA test checked to be unchangedFix circular dependency + missing condition setup for TRT CA config in cosmics
Outputs of q445 CA test checked to be unchanged