athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-06-10T23:06:05+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/54090r22 JetTagging: fix_tow_Run32022-06-10T23:06:05+02:00Alessandro Lapertosar22 JetTagging: fix_tow_Run3Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and t...Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and tracks multiplicity divided by <mu> (reduce pile up effect on runs with different <mu>)
Test Webdisplay: https://atlasdqm.cern.ch/webdisplay/test/56/physics_Main/run_348885/run/JetTagging/https://gitlab.cern.ch/atlas/athena/-/merge_requests/54166add L1ConfigSvcCfg in TgcMon2022-06-10T18:37:40+02:00Masato Aokiadd L1ConfigSvcCfg in TgcMonadding L1ConfigSvcCfg in the TGC monitoring tool to make the thresholdPatterns analysis workadding L1ConfigSvcCfg in the TGC monitoring tool to make the thresholdPatterns analysis workhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53990DRAFT: Switching on jEM in L1Topo2022-06-09T10:26:02+02:00Nicola Orlandonicola.orlando@cern.chDRAFT: Switching on jEM in L1TopoThis MR switches on the jEM recently developed by the L1Calo team. Most developments on L1Topo were already implemented in previous MRs (https://gitlab.cern.ch/atlas/athena/-/merge_requests/53307). Here we just fill up the relevant TOBs....This MR switches on the jEM recently developed by the L1Calo team. Most developments on L1Topo were already implemented in previous MRs (https://gitlab.cern.ch/atlas/athena/-/merge_requests/53307). Here we just fill up the relevant TOBs.
@paulama @iriu @asonay @jmharrishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54094ATR-25425 : add more monGroups for ID2022-06-08T18:58:17+02:00Stefanie MorgensternATR-25425 : add more monGroups for IDfyi @hartj , @nagano , @sutt
also ATR-24283fyi @hartj , @nagano , @sutt
also ATR-24283https://gitlab.cern.ch/atlas/athena/-/merge_requests/53566Draft: Updated EGamma ES chains and removed ES for PEB B-phys Jpsi chains2022-06-08T16:21:05+02:00Giulia GonellaDraft: Updated EGamma ES chains and removed ES for PEB B-phys Jpsi chains- Updated EGamma ES chains: removed outdated and added chains from final request.
- Removed ES for PEB B-phys Jpsi chains (still need to add respective non-PEB).
From ATR-24367.
Tagging @cjmeyer and @jodafons for EGamma
Tagging @shanis...- Updated EGamma ES chains: removed outdated and added chains from final request.
- Removed ES for PEB B-phys Jpsi chains (still need to add respective non-PEB).
From ATR-24367.
Tagging @cjmeyer and @jodafons for EGamma
Tagging @shanisch (some new ES chains are missing monGroup, following up on ATR-24367)
Note: ctest TriggerMenuMT_HLT_Dev_pp_run3_v1_ctest and test_trigAna_RDOtoRDOTrig_v1Dev_build, test_trigP1_v1Dev_decodeBS_build, test_trig_data_v1Dev_build failing before modifications for different reasons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/54068Revert "Replacement of InDetTestBLayer with InDetTestPixelLayer"2022-06-08T16:14:42+02:00Benjamin Philip KerridgeRevert "Replacement of InDetTestBLayer with InDetTestPixelLayer"This reverts merge request !53927 (Replacement of InDetTestBLayer with InDetTestPixelLayer)
See ATR-25682This reverts merge request !53927 (Replacement of InDetTestBLayer with InDetTestPixelLayer)
See ATR-25682https://gitlab.cern.ch/atlas/athena/-/merge_requests/54037Add mu3 thresholds and HLT_2mu3 (ATR-23494)2022-06-08T13:08:17+02:00Kunihiro NaganoAdd mu3 thresholds and HLT_2mu3 (ATR-23494)- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menu- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53985Adding chains to primary as requested in ATR-256572022-06-06T17:10:21+02:00Debottam Bakshi GuptaAdding chains to primary as requested in ATR-25657As mentioned in ATR-25657 this MR adds required chains in the primary menu. Adding @khoo and @sshawAs mentioned in ATR-25657 this MR adds required chains in the primary menu. Adding @khoo and @sshawhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53220Extension of TgcRawdata/TgcRdo for NSL input2022-06-04T13:20:27+02:00Toshi Sumidatoshi.sumida@cern.chExtension of TgcRawdata/TgcRdo for NSL inputto push the data from the TGC New Sector Logic (Software ROD) in Run3, more structures (constructors) neededto push the data from the TGC New Sector Logic (Software ROD) in Run3, more structures (constructors) neededhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53952Tracking overlay updates for the RDOtoRDOTrigger step2022-06-03T20:45:13+02:00William Axel LeightTracking overlay updates for the RDOtoRDOTrigger stepThe converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set...The converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set its trackOverlay flag for RDOtoRDOTrigger.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53283L1 menu setup for Phase-I LArSaturation trigger via L1Topo2022-06-03T19:10:11+02:00Teng Jian KhooL1 menu setup for Phase-I LArSaturation trigger via L1Topo@rgugel, @jodamp, I did a first try to configure a threshold for the LAr saturation algo, fixed to one of the bits on Topo1b. I admit I am not totally confident especially about the need for the additional C++ for the threshold, but not ...@rgugel, @jodamp, I did a first try to configure a threshold for the LAr saturation algo, fixed to one of the bits on Topo1b. I admit I am not totally confident especially about the need for the additional C++ for the threshold, but not for the algorithm.
Also fixed [ATR-25530] and added the CTPMON counters for BMA from [ATR-25388]https://gitlab.cern.ch/atlas/athena/-/merge_requests/53937Reco: Remove setting of TopAlg as CA sequence2022-06-03T15:50:40+02:00Frank WinklmeierReco: Remove setting of TopAlg as CA sequenceSetting the `TopAlg` as sequence is not necessary even when the CA
is used in old-style job options.
Also remove redundant setting of `configurableRun3Behavior` in tests.Setting the `TopAlg` as sequence is not necessary even when the CA
is used in old-style job options.
Also remove redundant setting of `configurableRun3Behavior` in tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53294ctau seeding2022-06-02T14:49:23+02:00Nicola Orlandonicola.orlando@cern.chctau seedingImplementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, r...Implementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, related to open issue here ATR-25462 (isolation cut is currently hard coded in the L1Topo sim)
@asonay @paulama @iriu @jmharrishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53693Add gXENC and gXERHO TOBs to the L1Topo simulation2022-06-01T21:55:33+02:00Paula Martinez SuarezAdd gXENC and gXERHO TOBs to the L1Topo simulation- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53832Adding optional skipAmbiguityCut property in Photon selector tools2022-06-01T16:13:01+02:00Fernando MonticelliAdding optional skipAmbiguityCut property in Photon selector toolsThis MR is along the lines of !53205. Am adding the optional skipAmbiguityCut property to the photon isEm selector so emulation can be performed on online photons where ambiguity is not computed and they are assumed as unambiguous photon...This MR is along the lines of !53205. Am adding the optional skipAmbiguityCut property to the photon isEm selector so emulation can be performed on online photons where ambiguity is not computed and they are assumed as unambiguous photons.
By default is set to false to keep same default behaviour
Pinging @cjmeyer @jodafons and @safarzadhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53810Draft: Remove TRTNN (eprobabilityNN) for GSF (chains) for both Online and Of...2022-05-31T05:10:34+02:00Christos Anastopouloschristos.anastopoulos@cern.chDraft: Remove TRTNN (eprobabilityNN) for GSF (chains) for both Online and OfflineRemove TRT NN for GSF ``eprobabilityNN`` Online/Offline.
I do not touch "general" tracking but the specific algorithm
that ``refits`` and calculates these for the refitted track particles.
- OAB slide 4 : https://indico.cern.ch/event...Remove TRT NN for GSF ``eprobabilityNN`` Online/Offline.
I do not touch "general" tracking but the specific algorithm
that ``refits`` and calculates these for the refitted track particles.
- OAB slide 4 : https://indico.cern.ch/event/1163021/contributions/4884896/attachments/2448758/4197405/220523_Trigger_OAB.pdf
- PC Slide 3 : https://indico.cern.ch/event/1160792/contributions/4874944/attachments/2444832/4189177/pc-intro16may2022.pdf
- See also conclusion of ATR-25224
Ping @aranzazu , @ludovica , @turra .
Now for sure I remove one unused variable
Quote from ATR-25224
>for egamma the decision is made and we wont use TRT NN PID not online nor online.
Unused but is an ``AuxDyn`` appearing in places.
So at least 2-3 "frozen" Tier-0 test prb testing exact outputs will fail...
Lets see this 1st and then take it from there ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/53803Introduced mu-jet triggers in the migration of the t0 b-jet trigger monitorin...2022-05-30T19:12:54+02:00Elemer NagyIntroduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring...Introduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring code (see ATR-20079) as discussed at ATR-25550. Corrected typo in a histogram title and changed range in another histogramIntroduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring code (see ATR-20079) as discussed at ATR-25550. Corrected typo in a histogram title and changed range in another histogramElemer NagyElemer Nagyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53610Add meson+photon triggers to the Physics menu. ATR-232392022-05-30T10:46:30+02:00Gianantonio Pezzullog.pezzullo@yale.eduAdd meson+photon triggers to the Physics menu. ATR-23239Add dipion 1/2 triggers to LS2 menuAdd dipion 1/2 triggers to LS2 menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53682Draft: Missing Muon collections from ESD/AOD, and other CA configuration fixes2022-05-26T07:46:21+02:00Edward MoyseDraft: Missing Muon collections from ESD/AOD, and other CA configuration fixesThis is an attempt to add some of the missing Muon collections in CA. It should ONLY affect CA, i.e. not alter old configuration.
This adds:
* Staus
* ExtrapolatedStauTrackParticles
* CombinedStauTrackParticles
* SlowMuons
* NCB_MuonSeg...This is an attempt to add some of the missing Muon collections in CA. It should ONLY affect CA, i.e. not alter old configuration.
This adds:
* Staus
* ExtrapolatedStauTrackParticles
* CombinedStauTrackParticles
* SlowMuons
* NCB_MuonSegments
Tested with unit tests, and also with running `q442 --CA`
Will rely on auto-sweep to master
Ping @goetz @mhodgkin @elmsheus @nstyles @rlangenbhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53648Switch to GSF by default for electron chains inside the TrigEgammaMatchingTool2022-05-25T17:16:50+02:00Edmar Egidio Purcino De SouzaSwitch to GSF by default for electron chains inside the TrigEgammaMatchingToolThis MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .This MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .Edmar Egidio Purcino De SouzaEdmar Egidio Purcino De Souza