athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-09-12T14:47:37+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/52325Draft: MuidCo recover efficiency holes in BIS782022-09-12T14:47:37+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: MuidCo recover efficiency holes in BIS78https://gitlab.cern.ch/atlas/athena/-/merge_requests/52702Draft: update of muonSelectionTool for r22 and run32022-06-21T10:47:42+02:00Marco VanadiaDraft: update of muonSelectionTool for r22 and run3 * adds a IsRun3Geo property to the tool (default false). There is a sanity check that the runnumber is actually compatible with the chosen option.
* adds ExcludeNSWFromPrecisionLayers property for the tool (default true). If true a... * adds a IsRun3Geo property to the tool (default false). There is a sanity check that the runnumber is actually compatible with the chosen option.
* adds ExcludeNSWFromPrecisionLayers property for the tool (default true). If true and in run3, it reduces the numberOfPrecisionLayers of the muon by 1 for muons with |eta|>1.05 with at least one hit in the inner station, which of course affects which muons pass the cuts on this quantity for the different WPs.
* for run3, only allows usage of Medium/Loose/HighPt WPs if not in expert mode. HighPt will only accept muons in the barrel, if not in expert mode.
* rejects SA and SAF muons for run3 if not in expert mode.
* disables ad-hoc code for CSCs for run3.
* temporary comments out BMG veto for highPt muons, since this regions should have better alignment in r22 (to be tested)
* adds some WARNINGs in the first event in case there are problems in reading the randomRunNumber from the PRW tool
* adds a couple of fatal + relative exceptions in cases the data period cannot be correctly identified
* updates the MuonSelectorToolsTester to identify if running on run2 or run3 and configures the tools accordinglyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52778Draft: Update the collisions HLT egamma han config for Run32022-06-27T15:48:19+02:00Edmar Egidio Purcino De SouzaDraft: Update the collisions HLT egamma han config for Run3This MR is to update the collisions HLT egamma hanconfig to Run3. Regex were used to map electron and photon chains to all subfolders produced by the TrigEgammaMonitoringMT framework. Discussions of this implementation are in the JIRA ti...This MR is to update the collisions HLT egamma hanconfig to Run3. Regex were used to map electron and photon chains to all subfolders produced by the TrigEgammaMonitoringMT framework. Discussions of this implementation are in the JIRA ticket ATR-25216 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando , @ebergeas and @shanisch .Edmar Egidio Purcino De SouzaEdmar Egidio Purcino De Souzahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52798Switch ringer to onnx2022-09-19T15:27:01+02:00Joao Victor Da Fonseca PintoSwitch ringer to onnxWaiting: ATLINFR-3994 to start.
ping: @cjmeyer , @Fernando , @eegidiop , @mverissi , @nnunesde , @dbakshigWaiting: ATLINFR-3994 to start.
ping: @cjmeyer , @Fernando , @eegidiop , @mverissi , @nnunesde , @dbakshigJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52868Draft: Trigger Electron LH update files2022-06-19T13:40:52+02:00Juan Lieber MarinDraft: Trigger Electron LH update filesThis is related to the ATR-25435 ticket. Aims to update the LH tunning files related to Electron Precision Step.
Pinging @cjmeyer @turra @jodafons @ludovica @aranzazu @tamartinThis is related to the ATR-25435 ticket. Aims to update the LH tunning files related to Electron Precision Step.
Pinging @cjmeyer @turra @jodafons @ludovica @aranzazu @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52940Draft: A test for preselection2022-05-24T09:06:28+02:00Dan GuestDraft: A test for preselectionBetween me, @cpollard, and @cantel, we're not quite sure if our b-tagging preselection hypo is doing the right thing. This does something silly: we return a true dips test for anything under 10 GeV. If we get chain count increases someth...Between me, @cpollard, and @cantel, we're not quite sure if our b-tagging preselection hypo is doing the right thing. This does something silly: we return a true dips test for anything under 10 GeV. If we get chain count increases something is weird.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53220Extension of TgcRawdata/TgcRdo for NSL input2022-06-04T13:20:27+02:00Toshi Sumidatoshi.sumida@cern.chExtension of TgcRawdata/TgcRdo for NSL inputto push the data from the TGC New Sector Logic (Software ROD) in Run3, more structures (constructors) neededto push the data from the TGC New Sector Logic (Software ROD) in Run3, more structures (constructors) neededhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53283L1 menu setup for Phase-I LArSaturation trigger via L1Topo2022-06-03T19:10:11+02:00Teng Jian KhooL1 menu setup for Phase-I LArSaturation trigger via L1Topo@rgugel, @jodamp, I did a first try to configure a threshold for the LAr saturation algo, fixed to one of the bits on Topo1b. I admit I am not totally confident especially about the need for the additional C++ for the threshold, but not ...@rgugel, @jodamp, I did a first try to configure a threshold for the LAr saturation algo, fixed to one of the bits on Topo1b. I admit I am not totally confident especially about the need for the additional C++ for the threshold, but not for the algorithm.
Also fixed [ATR-25530] and added the CTPMON counters for BMA from [ATR-25388]https://gitlab.cern.ch/atlas/athena/-/merge_requests/53294ctau seeding2022-06-02T14:49:23+02:00Nicola Orlandonicola.orlando@cern.chctau seedingImplementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, r...Implementation of ctau HLT seeding based on L1Topo ctau multiplicity class.
The implementation is just a draft, need to check
- Granularity of the used coordinates and pTs
- Is overall this as expected for HLT? @rbielski
#ATR-25307, related to open issue here ATR-25462 (isolation cut is currently hard coded in the L1Topo sim)
@asonay @paulama @iriu @jmharrishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53334README: Remove deleted branches, add 22.02022-05-20T15:08:56+02:00Rafal Bielskirafal.bielski@cern.chREADME: Remove deleted branches, add 22.0Removing deleted branches 21.1 and 21.3 from README list of branches and adding the new branch 22.0.
This is the first MR opened to the new branch 22.0, aimed also at testing the CI and sweep infrastructure, see ATLINFR-4546Removing deleted branches 21.1 and 21.3 from README list of branches and adding the new branch 22.0.
This is the first MR opened to the new branch 22.0, aimed also at testing the CI and sweep infrastructure, see ATLINFR-4546https://gitlab.cern.ch/atlas/athena/-/merge_requests/53341Add TRT and Pixel PID information when creating track particles (sweep from m...2022-05-18T14:25:16+02:00Goetz GayckenAdd TRT and Pixel PID information when creating track particles (sweep from master).manual sweep of MR !53027 from master to 22.0.
Add TRT and Pixel PID information directly to track particles rather
than first adding the information to the track summary, For statistically
combined muon track particles compute pixel P...manual sweep of MR !53027 from master to 22.0.
Add TRT and Pixel PID information directly to track particles rather
than first adding the information to the track summary, For statistically
combined muon track particles compute pixel PID, but only copy TRT PID
information over from the input track particles (original behaviour).
For the code path not starting from tracks only the default Pixel and
TRT PID values are set (tracks are needed to run the PID).https://gitlab.cern.ch/atlas/athena/-/merge_requests/53442METConfiguration - Write the MetMaker in proper CA2022-06-14T15:16:09+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMETConfiguration - Write the MetMaker in proper CAHi,
as discussed on !52702, we would need a full CA based METMaker configuration.
Tagging: @wbalunas, @williams, @cdelitzs, @tadej, @mvanadiaHi,
as discussed on !52702, we would need a full CA based METMaker configuration.
Tagging: @wbalunas, @williams, @cdelitzs, @tadej, @mvanadiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53566Draft: Updated EGamma ES chains and removed ES for PEB B-phys Jpsi chains2022-06-08T16:21:05+02:00Giulia GonellaDraft: Updated EGamma ES chains and removed ES for PEB B-phys Jpsi chains- Updated EGamma ES chains: removed outdated and added chains from final request.
- Removed ES for PEB B-phys Jpsi chains (still need to add respective non-PEB).
From ATR-24367.
Tagging @cjmeyer and @jodafons for EGamma
Tagging @shanis...- Updated EGamma ES chains: removed outdated and added chains from final request.
- Removed ES for PEB B-phys Jpsi chains (still need to add respective non-PEB).
From ATR-24367.
Tagging @cjmeyer and @jodafons for EGamma
Tagging @shanisch (some new ES chains are missing monGroup, following up on ATR-24367)
Note: ctest TriggerMenuMT_HLT_Dev_pp_run3_v1_ctest and test_trigAna_RDOtoRDOTrig_v1Dev_build, test_trigP1_v1Dev_decodeBS_build, test_trig_data_v1Dev_build failing before modifications for different reasons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53589hotSpotInHIST script : fix of project-tag retrieval2022-11-22T15:09:04+01:00Benjamin TrocmehotSpotInHIST script : fix of project-tag retrievalWhen migrating to release 22, the automatic retrieval of project tag of a run was broken.
This is a fix.
NB: this is a standalone script, I am the main/original developer, I tested the fix.When migrating to release 22, the automatic retrieval of project tag of a run was broken.
This is a fix.
NB: this is a standalone script, I am the main/original developer, I tested the fix.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53610Add meson+photon triggers to the Physics menu. ATR-232392022-05-30T10:46:30+02:00Gianantonio Pezzullog.pezzullo@yale.eduAdd meson+photon triggers to the Physics menu. ATR-23239Add dipion 1/2 triggers to LS2 menuAdd dipion 1/2 triggers to LS2 menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53648Switch to GSF by default for electron chains inside the TrigEgammaMatchingTool2022-05-25T17:16:50+02:00Edmar Egidio Purcino De SouzaSwitch to GSF by default for electron chains inside the TrigEgammaMatchingToolThis MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .This MR is to fix the electron keys inside the TrigEgammaMatchingTool, setting the GSF key as default for electrons.
This discussion is being done in ATR-25223 .
ping: @cjmeyer , @jodafons , @safarzad , @fernando and @jlieberm .Edmar Egidio Purcino De SouzaEdmar Egidio Purcino De Souzahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53682Draft: Missing Muon collections from ESD/AOD, and other CA configuration fixes2022-05-26T07:46:21+02:00Edward MoyseDraft: Missing Muon collections from ESD/AOD, and other CA configuration fixesThis is an attempt to add some of the missing Muon collections in CA. It should ONLY affect CA, i.e. not alter old configuration.
This adds:
* Staus
* ExtrapolatedStauTrackParticles
* CombinedStauTrackParticles
* SlowMuons
* NCB_MuonSeg...This is an attempt to add some of the missing Muon collections in CA. It should ONLY affect CA, i.e. not alter old configuration.
This adds:
* Staus
* ExtrapolatedStauTrackParticles
* CombinedStauTrackParticles
* SlowMuons
* NCB_MuonSegments
Tested with unit tests, and also with running `q442 --CA`
Will rely on auto-sweep to master
Ping @goetz @mhodgkin @elmsheus @nstyles @rlangenbhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53693Add gXENC and gXERHO TOBs to the L1Topo simulation2022-06-01T21:55:33+02:00Paula Martinez SuarezAdd gXENC and gXERHO TOBs to the L1Topo simulation- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.- Add gXENC and gXERHO TOBs to the L1Topo simulation.
- Enable the corresponding multiplicity algorithms.
- Other fixes: change histogram range for eEm and eTau isolation thresholds.
Tagging @orlando @iriu @asonay @jmharris.https://gitlab.cern.ch/atlas/athena/-/merge_requests/53803Introduced mu-jet triggers in the migration of the t0 b-jet trigger monitorin...2022-05-30T19:12:54+02:00Elemer NagyIntroduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring...Introduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring code (see ATR-20079) as discussed at ATR-25550. Corrected typo in a histogram title and changed range in another histogramIntroduced mu-jet triggers in the migration of the t0 b-jet trigger monitoring code (see ATR-20079) as discussed at ATR-25550. Corrected typo in a histogram title and changed range in another histogramElemer NagyElemer Nagyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53810Draft: Remove TRTNN (eprobabilityNN) for GSF (chains) for both Online and Of...2022-05-31T05:10:34+02:00Christos Anastopouloschristos.anastopoulos@cern.chDraft: Remove TRTNN (eprobabilityNN) for GSF (chains) for both Online and OfflineRemove TRT NN for GSF ``eprobabilityNN`` Online/Offline.
I do not touch "general" tracking but the specific algorithm
that ``refits`` and calculates these for the refitted track particles.
- OAB slide 4 : https://indico.cern.ch/event...Remove TRT NN for GSF ``eprobabilityNN`` Online/Offline.
I do not touch "general" tracking but the specific algorithm
that ``refits`` and calculates these for the refitted track particles.
- OAB slide 4 : https://indico.cern.ch/event/1163021/contributions/4884896/attachments/2448758/4197405/220523_Trigger_OAB.pdf
- PC Slide 3 : https://indico.cern.ch/event/1160792/contributions/4874944/attachments/2444832/4189177/pc-intro16may2022.pdf
- See also conclusion of ATR-25224
Ping @aranzazu , @ludovica , @turra .
Now for sure I remove one unused variable
Quote from ATR-25224
>for egamma the decision is made and we wont use TRT NN PID not online nor online.
Unused but is an ``AuxDyn`` appearing in places.
So at least 2-3 "frozen" Tier-0 test prb testing exact outputs will fail...
Lets see this 1st and then take it from there ...