athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-29T12:05:00+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70206MuonCalibTool: making calibMode configurable2024-03-29T12:05:00+01:00Luca MartinelliMuonCalibTool: making calibMode configurablemaking calibMode configurable. default value to -1
see https://its.cern.ch/jira/projects/ATLASMCP/issues/ATLASMCP-217?filter=allopenissuesmaking calibMode configurable. default value to -1
see https://its.cern.ch/jira/projects/ATLASMCP/issues/ATLASMCP-217?filter=allopenissuesLuca MartinelliLuca Martinellihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70180SUSYTools/jobOptions.py: migrated from AthFile to MetaReader2024-03-29T09:00:11+01:00Vakhtang TsulaiaSUSYTools/jobOptions.py: migrated from AthFile to MetaReaderRelated to ATEAM-528Related to ATEAM-528https://gitlab.cern.ch/atlas/athena/-/merge_requests/70064PhysicsAnalysis: required modifications to allow for online and conditional b...2024-03-27T09:03:42+01:00Sven MenkePhysicsAnalysis: required modifications to allow for online and conditional b-tagging treatment in TopPhysThe recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tag...The recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tagging systematics and MC to data scale factors in 21.1-based top analyses. The proposed changes here allow to combine one offline WP with a online WP via the provided conditional (online given offline) probabilities provided by the CP-group. The offline trigger confirmation requires furthermore to combine two offline WP (from the same tagger) with the online WP. Also this functionality is provided in the MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69859ConfigBlocks: update how options are set and remove make functions2024-03-22T08:30:18+01:00Joseph Earl LambertConfigBlocks: update how options are set and remove make functionsAll configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functi...All configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functions that only act to set arguments since this
can be done without any extra code now.
Code using the `TextConfig`, `ConfigFactory` or the block configuration using classes
should be unaffected. Code that calls the make functions that where removed
will need to be update (makeSomeConfig -> SomeBlock and no longer pass the seq).
To create the block and set all options using the factory:
```
from AnalysisAlgorithmsConfig.ConfigFactory import ConfigFactory
config = ConfigFactory()
...
configSeq += config.makeConfig('GeneratorLevelAnalysis',
saveCutBookkeepers=True,
runNumber=284500)
```
Can also pass some this way and then set others individually like before.
To create the block and set all options using the blocks:
```
from AsgAnalysisAlgorithms.AsgAnalysisConfig import GeneratorAnalysisBlock
configSeq.append( GeneratorAnalysisBlock(
saveCutBookkeepers=True,
runNumber=284500) )
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/69743Adding the SUSY6 features to LLP1, JIRA: ATLASG-26902024-03-28T11:41:18+01:00Daiya AkiyamaAdding the SUSY6 features to LLP1, JIRA: ATLASG-2690For Whom It May Concern,
The SUSY6 derivations continuation was discussed in the derivation meetings, and it was concluded that this derivation format will be merge with the LLP1 format.
For this reason, we have opened the following Ji...For Whom It May Concern,
The SUSY6 derivations continuation was discussed in the derivation meetings, and it was concluded that this derivation format will be merge with the LLP1 format.
For this reason, we have opened the following Jira Ticket: ATLASG-2690
We have chatted with the LLP1 community and haven't gotten an objection to the merger.
Let us know how you would like to proceed.
Sincerely
Ismet Siral and Daiya Akiyama on Behalf of SUSY dE/dx analysis.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69620btagging tool for json-based CDI2024-03-29T09:41:06+01:00Binbin Dongbtagging tool for json-based CDItowards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.towards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69332Draft: Add WP support and SF for LRT muons2024-03-04T12:12:02+01:00Sagar AddepalliDraft: Add WP support and SF for LRT muonsThis MR adds a dedicated support for running MuonSelectionTool on LRT muons, and also adds efficiency SF and relevant systematics for LRT muons.This MR adds a dedicated support for running MuonSelectionTool on LRT muons, and also adds efficiency SF and relevant systematics for LRT muons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69203Draft: HepMcParticleLink: Testing the adaption to GenParticle::id2024-02-29T14:08:28+01:00John Derek ChapmanDraft: HepMcParticleLink: Testing the adaption to GenParticle::idFollows !69076Follows !69076https://gitlab.cern.ch/atlas/athena/-/merge_requests/69076Draft: HepMcParticleLink: Flag whether link points to suppressed pile-up truth2024-02-23T17:38:05+01:00John Derek ChapmanDraft: HepMcParticleLink: Flag whether link points to suppressed pile-up truthFollows !69055Follows !69055https://gitlab.cern.ch/atlas/athena/-/merge_requests/69062Draft: Try to use templates in the MCtruthClassifier to avoid declatrations o...2024-03-21T23:15:45+01:00Andrii VerbytskyiDraft: Try to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69061CPAlgs config: programmatic config, enforce order, convert to YAML2024-03-15T10:41:01+01:00Joseph Earl LambertCPAlgs config: programmatic config, enforce order, convert to YAMLProvides a interface to programmatically configure the CP
algs. There is not a significant difference between using the `ConfigFactory`
and the `ConfigBuilder`. The main difference between the two is that
the you configure the builder an...Provides a interface to programmatically configure the CP
algs. There is not a significant difference between using the `ConfigFactory`
and the `ConfigBuilder`. The main difference between the two is that
the you configure the builder and not a config sequence.
Internally, the class creates a dictionary representation
of the text configuration and passes this to the text configuration
class. This allows the configuration generated to be saved as a
YAML file that can be used by the text configuration and enforces
the order the cp algs are configured in.
Decouples configuring config blocks from the underlying code. If there is a change in the `ConfigBlock`, `ConfigSequence`, etc., this will not affect users that use the `ConfigBuilder` or the text configuration.
All options and their values can be passed when calling `addBlock`. This reproduces the functionality of most of the `make` functions without the extra code for each block. Options can also be set one at a time for the last block added using `setOptionValue`.Joseph Earl LambertJoseph Earl Lamberthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68960Draft: Use std::format instead of boost::format2024-02-27T09:58:01+01:00Andrii VerbytskyiDraft: Use std::format instead of boost::formatUse std::format instead of boost::formatUse std::format instead of boost::formathttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68363Draft: Update of truth labels for large-R jets2024-02-19T11:12:05+01:00Barbora EckerovaDraft: Update of truth labels for large-R jetsUpdate of the truth label for large-R jets in R24.Update of the truth label for large-R jets in R24.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67983Draft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibMode2024-03-06T12:36:41+01:00Thomas StreblerDraft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibModeConfigures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Pl...Configures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Please consider to configure the tool via the 'MuonCalibTool' property.
```
from https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/MET/METUtilities/Root/METSignificance.cxx#L153Thomas StreblerThomas Streblerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67388Try to use C++20 starts_with2024-03-21T13:16:05+01:00Andrii VerbytskyiTry to use C++20 starts_withTry to use C++20 starts_withTry to use C++20 starts_with