athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T14:18:43+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70053AnalysisTop Main: Move maxCycle vector in parseCutBookkeepers function to be ...2024-03-22T14:18:43+01:00Thomas James StevensonAnalysisTop Main: Move maxCycle vector in parseCutBookkeepers function to be indexed correctlyAnalysisTop: Move maxCycle vector in parseCutBookkeepers function to be indexed correctly. Closes ANALYSISTO-1384AnalysisTop: Move maxCycle vector in parseCutBookkeepers function to be indexed correctly. Closes ANALYSISTO-1384https://gitlab.cern.ch/atlas/athena/-/merge_requests/69979Fix cppcheck warnings: iterateByValue2024-03-20T18:11:51+01:00Andrii VerbytskyiFix cppcheck warnings: iterateByValueFix cppcheck warnings: iterateByValue
@sroeFix cppcheck warnings: iterateByValue
@sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69373add support for the upcoming new b-tagger2024-02-29T19:45:31+01:00Binbin Dongadd support for the upcoming new b-taggerFor the upcoming new b-tagger, there is a new output class tau. Adding the support of tau class in AnalysisTop similar as in https://gitlab.cern.ch/atlas/athena/-/merge_requests/69017For the upcoming new b-tagger, there is a new output class tau. Adding the support of tau class in AnalysisTop similar as in https://gitlab.cern.ch/atlas/athena/-/merge_requests/69017https://gitlab.cern.ch/atlas/athena/-/merge_requests/68556cppcheck/clang 'perfomance' fixes2024-02-05T09:43:27+01:00Christos Anastopouloschristos.anastopoulos@cern.chcppcheck/clang 'perfomance' fixescppcheck/clang 'perfomance' fixes
Mainly use ``const ref`` to avoid unecessary copiescppcheck/clang 'perfomance' fixes
Mainly use ``const ref`` to avoid unecessary copieshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68473Updating muon trigger string for 2015 in CI and example config2024-02-01T10:09:54+01:00Steffen Kornsteffen.korn@cern.chUpdating muon trigger string for 2015 in CI and example configThis MR is a follow up on https://gitlab.cern.ch/atlas/athena/-/merge_requests/68461
It applies the same changes to the AnalysisTop CI and example configs for Run2.This MR is a follow up on https://gitlab.cern.ch/atlas/athena/-/merge_requests/68461
It applies the same changes to the AnalysisTop CI and example configs for Run2.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68461Fixing muon trigger string in AT2024-01-31T13:16:30+01:00Steffen Kornsteffen.korn@cern.chFixing muon trigger string in ATThis MR fixes a muon trigger string used for decorations.
This is motivated by the lack of the original trigger in 2015 for MC20:
https://gitlab.cern.ch/atlas-mcp/MuonTPPostProcessing/-/blob/run2_release22/MuonTPPostProcessing/data/Run...This MR fixes a muon trigger string used for decorations.
This is motivated by the lack of the original trigger in 2015 for MC20:
https://gitlab.cern.ch/atlas-mcp/MuonTPPostProcessing/-/blob/run2_release22/MuonTPPostProcessing/data/RunConf/ZTrigger/core/triggers.py
The MR touches upon [ANALYSISTO-1368](https://its.cern.ch/jira/browse/ANALYSISTO-1368?atlOrigin=eyJpIjoiYjM0MTA4MzUyYTYxNDVkY2IwMzVjOGQ3ZWQ3NzMwM2QiLCJwIjoianN3LWdpdGxhYlNNLWludCJ9).https://gitlab.cern.ch/atlas/athena/-/merge_requests/68299Adding if for Run2 vs Run3 for ftag efficiency maps2024-01-24T14:12:46+01:00Steffen Kornsteffen.korn@cern.chAdding if for Run2 vs Run3 for ftag efficiency mapsThis MR fixes an issue introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/67494
The efficiency maps are run-specific—following this [twiki](https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/BTagRecommendationsRelea...This MR fixes an issue introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/67494
The efficiency maps are run-specific—following this [twiki](https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/BTagRecommendationsRelease22#Calibration_pre_recommendations).
For shower algorithms marked as `n/a` in the twiki I have added a `doesnotexist` string to crash the code on purpose in case a wrong configuration is used in AT.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68263Add CI tests for AnalysisTop with Run 3 settings2024-02-13T20:35:57+01:00Baptiste Ravinabaptiste.ravina@cern.chAdd CI tests for AnalysisTop with Run 3 settingsSeems that these had been overlooked... better late than never!Seems that these had been overlooked... better late than never!https://gitlab.cern.ch/atlas/athena/-/merge_requests/68086Resolve cppcheck defects in TopAnalysis code2024-01-10T17:06:43+01:00Shaun RoeResolve cppcheck defects in TopAnalysis codeResolve cppcheck performance defects: pass vector/map arguments by const ref instead of value.Resolve cppcheck performance defects: pass vector/map arguments by const ref instead of value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67929Updated fast sim property for ElectronPhotonFourMomentumCorrection2024-01-26T14:34:31+01:00Thomas StreblerUpdated fast sim property for ElectronPhotonFourMomentumCorrectionUpdated property name from `useAFII` to `useFastSim` to reflect the CP alg configurations + drop metadata check in C++ in favour of python-based configuration
ping @kristin @ludovica @psommer @fnechans @christos @gunalUpdated property name from `useAFII` to `useFastSim` to reflect the CP alg configurations + drop metadata check in C++ in favour of python-based configuration
ping @kristin @ludovica @psommer @fnechans @christos @gunalhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67867Fix typo in AnalysisTop CI files2023-12-18T09:28:52+01:00Baptiste Ravinabaptiste.ravina@cern.chFix typo in AnalysisTop CI filesPath to test file was not properly updatedPath to test file was not properly updatedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67764Use more functions from MC:: namespace instead of hardcoded constants2023-12-12T11:29:59+01:00Andrii VerbytskyiUse more functions from MC:: namespace instead of hardcoded constantsUse more functions from MC:: namespace instead of hardcoded constantsUse more functions from MC:: namespace instead of hardcoded constantshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67494AT R24 Updating handling of FTAG MC/MC SFs in AnalysisTop2024-01-23T17:58:52+01:00Steffen Kornsteffen.korn@cern.chAT R24 Updating handling of FTAG MC/MC SFs in AnalysisTopThis MR adds `sherpa2212` and `amcatnloherwig7`to the AnalysisTop FTAG MC/MC shower logic.
Following recommendations from https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/BTagRecommendationsRelease22#Calibration_pre_recommendatio...This MR adds `sherpa2212` and `amcatnloherwig7`to the AnalysisTop FTAG MC/MC shower logic.
Following recommendations from https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/BTagRecommendationsRelease22#Calibration_pre_recommendations
Shower models which are no longer supported (based of these recommendations) are marked as `default`. For these missing cases, we use `default` which gives an MC/MC of 1.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67489Adding a positive SF check for JVT SFs2023-11-30T20:26:05+01:00Steffen Kornsteffen.korn@cern.chAdding a positive SF check for JVT SFsThis MR adds a check which checks whether the `JET_SF_JVT` we get from `jet->auxdataConst<float>("JET_SF_jvt")` in AnalysisTop is indeed positive before multiplying it.This MR adds a check which checks whether the `JET_SF_JVT` we get from `jet->auxdataConst<float>("JET_SF_jvt")` in AnalysisTop is indeed positive before multiplying it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67483Fixing typos in muon triggers in AT Run3 config files2023-11-30T20:14:10+01:00Steffen Kornsteffen.korn@cern.chFixing typos in muon triggers in AT Run3 config filesThis MR fixes some typos in the muon triggers in the AnalysisTop Run3 example and CI file.
The triggers are taken from this twiki:
https://twiki.cern.ch/twiki/bin/viewauth/Atlas/LowestUnprescaledThis MR fixes some typos in the muon triggers in the AnalysisTop Run3 example and CI file.
The triggers are taken from this twiki:
https://twiki.cern.ch/twiki/bin/viewauth/Atlas/LowestUnprescaledhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67473Updating MC20 and MC21 CDI pre-recommendations to AT2023-11-30T20:01:34+01:00Steffen Kornsteffen.korn@cern.chUpdating MC20 and MC21 CDI pre-recommendations to ATThis MR updates/adds calibration pre-recommendations for MC20 and MC21 DL1d to AnalysisTop.
It checks whether the config is a "run3" config in which case the recommended MC21 CDI file is set as default.
Otherwise, the recommended MC20 C...This MR updates/adds calibration pre-recommendations for MC20 and MC21 DL1d to AnalysisTop.
It checks whether the config is a "run3" config in which case the recommended MC21 CDI file is set as default.
Otherwise, the recommended MC20 CDI file is used as the default.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67458Use AtlasPID Helper functions for checking PDG codes2023-12-01T19:33:18+01:00John Derek ChapmanUse AtlasPID Helper functions for checking PDG codesMigrate some classes to use Helper functions from AtlasPID.h - towards ATLASSIM-6980Migrate some classes to use Helper functions from AtlasPID.h - towards ATLASSIM-6980https://gitlab.cern.ch/atlas/athena/-/merge_requests/67435Wrap barcode usage in PhysicsAnalysis/TopPhys (ATLASSIM-6978)2023-12-01T02:31:02+01:00John Derek ChapmanWrap barcode usage in PhysicsAnalysis/TopPhys (ATLASSIM-6978)In code where the truth particle/vertex `barcode` is only used in checks that it is identical to another barcode value, then the barcode calls can be wrapped using the HepMC::uniqueID(const T& p) templated helper function.
The idea here...In code where the truth particle/vertex `barcode` is only used in checks that it is identical to another barcode value, then the barcode calls can be wrapped using the HepMC::uniqueID(const T& p) templated helper function.
The idea here is to separate out the different conceptual usages of barcode ahead of its removal/replacement with id and the revised status scheme. See ATLASSIM-6906 for more details.
Tagging @pclark @averbytshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67433Drop barcodes from the TruthTools on TopPhys xAOD2023-11-28T18:55:48+01:00Andrii VerbytskyiDrop barcodes from the TruthTools on TopPhys xAODDrop barcodes from the TruthTools on TopPhys xAOD (ATLASSIM-6978)
@pclark @jchapmanDrop barcodes from the TruthTools on TopPhys xAOD (ATLASSIM-6978)
@pclark @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67366fix trigger decoration name issue in AnalysisTop for name containing . and -2023-11-26T16:54:55+01:00Linghua Guofix trigger decoration name issue in AnalysisTop for name containing . and -As explained in this [jira](https://its.cern.ch/jira/browse/ATR-28248), in the lastest release, the new event auxilliary decoration name no longer allows "." amd "-". This is relevant to trigger decorations, e.g. HLT_2j35_bmv2c1060_spli...As explained in this [jira](https://its.cern.ch/jira/browse/ATR-28248), in the lastest release, the new event auxilliary decoration name no longer allows "." amd "-". This is relevant to trigger decorations, e.g. HLT_2j35_bmv2c1060_split_2j35_L14J15.0ETA25
So we fixed trigger decoration name issue in AnalysisTop by changing "." to "p", "-" to "_".