athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-07T09:51:11+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/46909AnalysisTop: Add radiationhigh/low weights for new ttZ samples to jet flavor ...2021-10-07T09:51:11+02:00Thomas James StevensonAnalysisTop: Add radiationhigh/low weights for new ttZ samples to jet flavor plots codeANALYSISTO-1140 Adding the weights called " dyn= -1 muR=0.50000E+00 muF=0.50000E+00 " and " dyn= -1 muR=0.20000E+01 muF=0.20000E+01 " to the JetFlavorPlots code in AnalysisTop so that the radiationhigh/low options work for the new ttZ si...ANALYSISTO-1140 Adding the weights called " dyn= -1 muR=0.50000E+00 muF=0.50000E+00 " and " dyn= -1 muR=0.20000E+01 muF=0.20000E+01 " to the JetFlavorPlots code in AnalysisTop so that the radiationhigh/low options work for the new ttZ signals e.g. 504330.aMCPy8EG_NNPDF30NLO_A14N23LO_tteehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45169Simplify Jet derivation framework2021-07-20T03:03:00+02:00William Keaton BalunasSimplify Jet derivation frameworkWith the recent change to reconstructing all jets at the derivation step, a large part of the jet derivation framework is now needlessly complicated. Most of this is designed around the "augmentation" workflow which reads in jets from th...With the recent change to reconstructing all jets at the derivation step, a large part of the jet derivation framework is now needlessly complicated. Most of this is designed around the "augmentation" workflow which reads in jets from the AOD, copies them, modifies/decorates the copy, and then copies decorations back to the original or overwrites it with the copy (e.g. by renaming).
There's no longer any need for this copying, or for any "updating" of existing jet quantities at derivation level: we can just make correct and up-to-date versions to begin with. The `IJetDecorator` interface and `JetDecorationAlg` make for much simpler scheduling of jet moments at the DAOD step.
So, this removes a large chunk of code which is now obsolete and migrates to the simpler way of doing this instead.
- Jet re-calibration at derivation level is no longer needed (we now instead use an up-to-date calibration to being with)
- JVT no longer needs to be updated at derivation level.
- b-tagging doesn't need to be "re-done", so some of the obsolete config for that has also been removed.
- Other jet moments (e.g. PFlow fJVT, QG tagging variables, etc.) are now scheduled via `JetDecorationAlg`.
Tagging @sawyer, @cdelitzs, @mswiatlo, @dguest, @duperrin.https://gitlab.cern.ch/atlas/athena/-/merge_requests/36812AnalysisTop: small bugfix for loose leptons decoration2020-10-01T03:05:17+02:00Marco VanadiaAnalysisTop: small bugfix for loose leptons decoration1-line bugfix for loose leptons decoration reading when using the "ApplyTightSFsInLooseTree True" option in AnalysisTop CC @frschroe1-line bugfix for loose leptons decoration reading when using the "ApplyTightSFsInLooseTree True" option in AnalysisTop CC @frschroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29633AnalysisTop: Bugfix in TopEventSelectionTools for JetFlavorPlots tool given t...2020-01-22T03:02:56+01:00Matthieu RobinAnalysisTop: Bugfix in TopEventSelectionTools for JetFlavorPlots tool given the new jet collection namesANALYSISTO-915
bugfix as the 4 last characters of the jet collection names are not necessarily `Jets` anymore the new feature erases from `Jets` to the end in the jet collection name string.ANALYSISTO-915
bugfix as the 4 last characters of the jet collection names are not necessarily `Jets` anymore the new feature erases from `Jets` to the end in the jet collection name string.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28265bugfix for soft muons in AnalysisTop2019-11-28T03:03:10+01:00Marco Vanadiabugfix for soft muons in AnalysisToptrivial MR to fix bug in AnalysisTop for soft muons, see ANALYSISTO-873trivial MR to fix bug in AnalysisTop for soft muons, see ANALYSISTO-873https://gitlab.cern.ch/atlas/athena/-/merge_requests/25124AnalysisTop implementation of new b-tagging CDI file and of aMCatNLOP8 MC/MC SFs2019-07-28T03:02:24+02:00Marco VanadiaAnalysisTop implementation of new b-tagging CDI file and of aMCatNLOP8 MC/MC SFsSmall changes to AnalysisTop to:
* update b-tagging CDI file
* add aMCatNLOP8 among possible showering algorithms, see ANALYSISTO-828
* set the new TDP file XSection-MC16-13TeV.data as default
Tagging @vvecchio @tdado @omajerskSmall changes to AnalysisTop to:
* update b-tagging CDI file
* add aMCatNLOP8 among possible showering algorithms, see ANALYSISTO-828
* set the new TDP file XSection-MC16-13TeV.data as default
Tagging @vvecchio @tdado @omajerskhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/24845AnalysisTop - Updating list of nominal weights for PMGTruthWeightTool to test2019-08-20T18:34:18+02:00Ian Allan ConnellyAnalysisTop - Updating list of nominal weights for PMGTruthWeightTool to testIt has been announced some samples do not have the nominal weight in position 0. The solution is to use the PMGTruthWeightTool to access via name, which is the default approach but so far only testing for `" nominal "` or `"nominal"`, bu...It has been announced some samples do not have the nominal weight in position 0. The solution is to use the PMGTruthWeightTool to access via name, which is the default approach but so far only testing for `" nominal "` or `"nominal"`, but apparently some samples have an empty string instead. This will be missed and the default behaviour is to get the 0th event weight, which would be bugged in some samples. This will address this problem.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67458Use AtlasPID Helper functions for checking PDG codes2023-12-01T19:33:18+01:00John Derek ChapmanUse AtlasPID Helper functions for checking PDG codesMigrate some classes to use Helper functions from AtlasPID.h - towards ATLASSIM-6980Migrate some classes to use Helper functions from AtlasPID.h - towards ATLASSIM-6980https://gitlab.cern.ch/atlas/athena/-/merge_requests/66275AnalysisTop R24: update tZq parton history to be inline with R21 version2023-10-06T15:57:29+02:00Thomas James StevensonAnalysisTop R24: update tZq parton history to be inline with R21 versionAnalysisTop: Update tZq parton history for R24 such that it is inline with the version in R21.AnalysisTop: Update tZq parton history for R24 such that it is inline with the version in R21.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65492Delete ElectronPhotonShowerShapeFudgeTool package2023-09-06T10:39:21+02:00Jean-Baptiste De Vivie De RegieDelete ElectronPhotonShowerShapeFudgeTool packageThis package has been replaced by the EGammaVariableCorrection one
Closes ATLASEG-333
Tagging @ludovicaThis package has been replaced by the EGammaVariableCorrection one
Closes ATLASEG-333
Tagging @ludovicahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64446AnalysisTop (main): replace error by warning for exclusion of named btag unce...2023-07-19T14:40:46+02:00Timothee Theveneaux-PelzerAnalysisTop (main): replace error by warning for exclusion of named btag uncertainties - ANALYSISTO-1333This MR is implementing the changes in main corresponding to those made for 21.2 in !64444 . See that MR or the JIRA ticket for more details.This MR is implementing the changes in main corresponding to those made for 21.2 in !64444 . See that MR or the JIRA ticket for more details.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64444AnalysisTop: replace error by warning for exclusion of named btag uncertainti...2023-07-20T15:42:22+02:00Timothee Theveneaux-PelzerAnalysisTop: replace error by warning for exclusion of named btag uncertainties - ANALYSISTO-1333As described in the ticket, this MR replaces (twice) an error by a warning, when the AnalysisTop user tried to extract a systematic uncertainty from the eigenvector decomposition for the btagging uncertainties, when no systematic with th...As described in the ticket, this MR replaces (twice) an error by a warning, when the AnalysisTop user tried to extract a systematic uncertainty from the eigenvector decomposition for the btagging uncertainties, when no systematic with the specified name exists for one of the requested working point. The current situation prevents the user from using several working point if one of them doesn't have the systematic in question. A use-case is the Continuous "working point" which often has different systematics.
NB: this feature could/should also be added for main, but I don't think the cherry-picking would work out of the box. So I made this MR for main: !64446https://gitlab.cern.ch/atlas/athena/-/merge_requests/60490AnalysisTop: Updating to the latest R22 JetMET recommendations2023-02-09T21:44:21+01:00Tomas DadoAnalysisTop: Updating to the latest R22 JetMET recommendationshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50648AnalysisTop: fix bug with jet-electron model - ANALYSISTO-11502022-02-24T13:23:01+01:00Timothee Theveneaux-PelzerAnalysisTop: fix bug with jet-electron model - ANALYSISTO-1150I'm fixing a bug in the implementation of the jet-electron model in AnalysisTop. When I implemented this model in ANALYSISTO-1150 I made a mistake in the eventsaver: the real jet branches were incorrectly filled, and even lead to runtime...I'm fixing a bug in the implementation of the jet-electron model in AnalysisTop. When I implemented this model in ANALYSISTO-1150 I made a mistake in the eventsaver: the real jet branches were incorrectly filled, and even lead to runtime errors. This is due to the fact that the jet-electrons are not filled as jets, but not as electrons, so there is one less jet per event.
This bug was only present if the jet-electron model was used.
Tagging @cescobarNils Erik KrumnackNils Erik Krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/4971022.0-cleanup-TopPartons2022-01-20T21:44:18+01:00Shaun Roe22.0-cleanup-TopPartonsMain aim was suppression of cppcheck errors (false positives), but saw a chance for a small refactor due to repeated pattern of decoration with M, Pt, Phi; so I created a utility function to do this. In one case it was discovered that a ...Main aim was suppression of cppcheck errors (false positives), but saw a chance for a small refactor due to repeated pattern of decoration with M, Pt, Phi; so I created a utility function to do this. In one case it was discovered that a wrong variable name had previously been used, and this was corrected.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49655Update ami.py to allow for HIGG8D1 derivations to be submitted to the GRID vi...2022-01-17T10:39:27+01:00Mario Jose SousaUpdate ami.py to allow for HIGG8D1 derivations to be submitted to the GRID via the Top Framework.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49417TauAnalysisTools: clean up tau efficiency tools2022-01-06T21:42:33+01:00Bertrand Martin Dit LatourTauAnalysisTools: clean up tau efficiency toolsHello,
This MR is cleaning up the tau efficiency scale factor tools to prepare for R22 recommendations.
The initialisation procedure has been simplified.
As a follow up of !49383 , the support of R21 electron veto SFs is completely gone...Hello,
This MR is cleaning up the tau efficiency scale factor tools to prepare for R22 recommendations.
The initialisation procedure has been simplified.
As a follow up of !49383 , the support of R21 electron veto SFs is completely gone, now we only support the R22 RNN eVeto algorithm (no SF available yet).
A number of things (especially in the initializeTools_2019_summer method) are just placeholders waiting for R22 Run2 recommendations.
Enums have been cleaned up, all Run1 and R21 Run2 entries have been removed. Same for deprecated tool properties.
Tagging @qbuat , @dta , @ghamity , @ademaria .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48309AnalysisTop file names cleanup + removing obsolete files2021-11-18T10:54:03+01:00Tomas DadoAnalysisTop file names cleanup + removing obsolete filesRemoving `MC15` and `MC16` from some of the classes/files as that is very confusing,
Removing some obsolete filesRemoving `MC15` and `MC16` from some of the classes/files as that is very confusing,
Removing some obsolete fileshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47355AnalysisTop: implementing jet-electron model (21.2) - ANALYSISTO-11502021-10-20T21:48:19+02:00Timothee Theveneaux-PelzerAnalysisTop: implementing jet-electron model (21.2) - ANALYSISTO-1150This MR implements the jet-electron model in AnalysisTop. Summary of changes:
* New options in TopConfig to activate and configure the jet-electrons
* New constructor in `JetMC15`, to flag the jets with the info of whether they pass jet-...This MR implements the jet-electron model in AnalysisTop. Summary of changes:
* New options in TopConfig to activate and configure the jet-electrons
* New constructor in `JetMC15`, to flag the jets with the info of whether they pass jet-electron requirements
* If used, the `EventSaverFlatNtuple` saves the jet-electrons as electrons, and stores the remaining jets as jets
* `JET_EL_N` allows to select events containing jet-electrons, and `N_Top_W` to reject the few true ttbar or W+jets events when running on di-jet samples
More details can be found in the JIRA ticket cited in the title.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47102Configurable TTVA cuts in AnalysisTop2021-10-14T10:37:09+02:00Rafael Coelho Lopes De SaConfigurable TTVA cuts in AnalysisTop* Make TTVA selection in AnalysisTop configurable.
* Default is kept the same.* Make TTVA selection in AnalysisTop configurable.
* Default is kept the same.