athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-10-05T10:39:24+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66231AnalysisTop R24: update tZq parton history to be inline with R21 version2023-10-05T10:39:24+02:00Thomas James StevensonAnalysisTop R24: update tZq parton history to be inline with R21 versionAnalysisTop: Update tZq parton history for R24 such that it is inline with the version in R21.AnalysisTop: Update tZq parton history for R24 such that it is inline with the version in R21.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64569Draft: The first attempt to use status() instead of barcode() in Simulation2023-08-07T10:57:56+02:00Andrii VerbytskyiDraft: The first attempt to use status() instead of barcode() in SimulationThe first attempt to use status instead of barcode for the simulation.
The end goals are:
- 1) to be able to identify the origin of the particles and vertices from their status and not barcodes
- 2) to be able to use the `HepMC3::GenP...The first attempt to use status instead of barcode for the simulation.
The end goals are:
- 1) to be able to identify the origin of the particles and vertices from their status and not barcodes
- 2) to be able to use the `HepMC3::GenParticle::id()` and `HepMC3::GenVertex::id()` as unique identifiers of the particles, e.g. in `HepMCParticleLink`. In this way the usage of `barcode()` `property` of `GenParticle`a and `GenVertex` will be almost eliminated.
The 2) was already implemented by @jchapman as an option. See https://indico.cern.ch/event/1298224/contributions/5458615/attachments/2669897/4627904/Migration%20away%20from%20barcodes.pdf
The 1) requires a bit more changes and those are collected in this MR with the idea to split it later into small pieces.
Namely:
- a) Switching from the bare comparison of `status` property of particles to the classificators in `TruthUtils` ( e.g. `isStable`) See https://gitlab.cern.ch/atlas/athena/-/merge_requests/64579, https://gitlab.cern.ch/atlas/athena/-/merge_requests/64552 and similar. This is an ongoing work that touches a lot of code, but the changes are trivial.
- b) Switching from the classificators that use the `barcode()` directly as `int` to functions that use the underlying objects. See https://gitlab.cern.ch/atlas/athena/-/merge_requests/64571
This MR will also require the removal of the specification of templates `HepMC::is_simulation_particle()` for `int`.
- c) Change the definition of `isStable()`, `isPhysical()`,`isDecayed()`, i.e. ( status=1,2 particles) to take into account that particles produced in the simulation will have status `original_status + constant x times_particle_interacted`. Implemented in this MR.
- d) Drop the `Barcode` service from the `TruthSvc` and instead of increasing the barcode of each particle in the simulation increase the status of particle. Implemented in this MR.
- e) Change the references where it is needed. To be done.
@jchapman
The very beginninghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63874Use MC:: namespace instead of MC::PID:: namespace.2023-06-27T11:40:18+02:00Andrii VerbytskyiUse MC:: namespace instead of MC::PID:: namespace.Use MC:: namespace instead of MC::PID:: namespace.
@jchapmanUse MC:: namespace instead of MC::PID:: namespace.
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63718modify tau smear tool according to R22 rec2023-06-15T12:30:39+02:00Mingming Xiamodify tau smear tool according to R22 recadd "Campaign" property for tau smear tool for AnalysisTopadd "Campaign" property for tau smear tool for AnalysisTophttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63145Draft: adding Error for ECIDS since it is not supportet with R22. Also changi...2023-07-17T18:48:02+02:00Nils Julius AbichtDraft: adding Error for ECIDS since it is not supportet with R22. Also changing the...adding Error for ECIDS since it is not supportet with R22. Also changing the datatype to float for later since it has changed
**Revert draft status** when we have Run2+Run3 data+MC files for the AnalysisTop CI tests in place, with p-tag...adding Error for ECIDS since it is not supportet with R22. Also changing the datatype to float for later since it has changed
**Revert draft status** when we have Run2+Run3 data+MC files for the AnalysisTop CI tests in place, with p-tag ≥ 5658https://gitlab.cern.ch/atlas/athena/-/merge_requests/63144adding Error for ECIDS since it is not supportet with R22. Also changing the...2023-05-17T18:33:41+02:00Nils Julius Abichtadding Error for ECIDS since it is not supportet with R22. Also changing the...adding Error for ECIDS since it is not supportet with R22. Also changing the datatype to float for later since it has changedadding Error for ECIDS since it is not supportet with R22. Also changing the datatype to float for later since it has changedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62222Draft: Replace outdated code with STL2023-07-22T20:31:09+02:00Andrii VerbytskyiDraft: Replace outdated code with STLReplace outdated code with STL. Not to be merged!Replace outdated code with STL. Not to be merged!https://gitlab.cern.ch/atlas/athena/-/merge_requests/61201electron trigger SF map update2023-03-02T20:17:18+01:00Nils Julius Abichtelectron trigger SF map updateMerge request to include latest electron trigger SF mapMerge request to include latest electron trigger SF maphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59967Load more high-pt minbias is NumberOfHighPtMinBias is set too low2023-01-21T01:18:44+01:00Beojan Stanislausbeojan.stanislaus@cern.chLoad more high-pt minbias is NumberOfHighPtMinBias is set too lowShould solve issue raised in !59957Should solve issue raised in !59957https://gitlab.cern.ch/atlas/athena/-/merge_requests/59792cppcheck: Misc defects reported by cppcheck2023-01-16T01:37:07+01:00Andrii Verbytskyicppcheck: Misc defects reported by cppcheckSmall defects reported by cppcheck
Tag @sroeSmall defects reported by cppcheck
Tag @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58691Draft: Replace the substr() with resize as cppcheck suggests2022-11-27T18:38:34+01:00Andrii VerbytskyiDraft: Replace the substr() with resize as cppcheck suggestsReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelReplace the substr() with resize as cppcheck suggests
Atg @sroe @fwinkelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58535Draft: AnalysisTop: Change truth jet collection to AntiKt4TruthDressedWZJets ...2022-11-22T10:29:59+01:00Chris ScheulenDraft: AnalysisTop: Change truth jet collection to AntiKt4TruthDressedWZJets for FTAG2 formatAddresses ANALYSISTO-1260.
This MR changes the truth jet collection name used by the JetJvtEfficiency Tool used by AnalysisTop to `AntiKt4TruthDressedWZJets` for the `FTAG2` derivation format. Previously, `AntiKt4TruthJets` was used here.Addresses ANALYSISTO-1260.
This MR changes the truth jet collection name used by the JetJvtEfficiency Tool used by AnalysisTop to `AntiKt4TruthDressedWZJets` for the `FTAG2` derivation format. Previously, `AntiKt4TruthJets` was used here.Chris ScheulenChris Scheulenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56666AnalysisTop: Update Electron SF map to the newest recommendation2022-09-13T09:50:03+02:00Tomas DadoAnalysisTop: Update Electron SF map to the newest recommendationUpdates AnalysisTop to the newest recommendations for R22.
Tagging @maniemeyUpdates AnalysisTop to the newest recommendations for R22.
Tagging @maniemeyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/54090r22 JetTagging: fix_tow_Run32022-06-10T23:06:05+02:00Alessandro Lapertosar22 JetTagging: fix_tow_Run3Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and t...Fixes for b-tagging DQ towards Run 3 data taking:
- remove reference to tagger name in cxx (easier to change tagger)
- temporary skip pre-selection for early runs (avoid empty plots in low statistics runs)
- additional plots for PV and tracks multiplicity divided by <mu> (reduce pile up effect on runs with different <mu>)
Test Webdisplay: https://atlasdqm.cern.ch/webdisplay/test/56/physics_Main/run_348885/run/JetTagging/https://gitlab.cern.ch/atlas/athena/-/merge_requests/54037Add mu3 thresholds and HLT_2mu3 (ATR-23494)2022-06-08T13:08:17+02:00Kunihiro NaganoAdd mu3 thresholds and HLT_2mu3 (ATR-23494)- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menu- Add "3GeV" thresholds in TrigMuonHypoConfig
- Add a chain HLT_2mu3_L12MU3V in Dev menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53952Tracking overlay updates for the RDOtoRDOTrigger step2022-06-03T20:45:13+02:00William Axel LeightTracking overlay updates for the RDOtoRDOTrigger stepThe converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set...The converters need to be updated for the case in which both the input and output collections start with Bkg_, currently only foresees for the RDOtoRDOTrigger step. The configuration is also updated to load the EventCnvSuperTool and set its trackOverlay flag for RDOtoRDOTrigger.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51333draft: AnalysisTop: Teach the code about AF3 simulation flavour2022-04-29T13:46:08+02:00Tomas Dadodraft: AnalysisTop: Teach the code about AF3 simulation flavourAF3 samples have a new flag in the metadata - need to teach the code to recognise itAF3 samples have a new flag in the metadata - need to teach the code to recognise ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48351draft: adding bb4l MCMC SFs reading2022-04-08T11:22:35+02:00Tomas Dadodraft: adding bb4l MCMC SFs readingIt was found out that the MC/MC SFs for btagging are significantly different for the bb4l (pythia8) sample.
The CDI file only exists privately so keeping this MR as draft for nowIt was found out that the MC/MC SFs for btagging are significantly different for the bb4l (pythia8) sample.
The CDI file only exists privately so keeping this MR as draft for nowhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48116TopConfiguration: Fix gcc11 warnings.2021-11-10T17:55:08+01:00Scott SnyderTopConfiguration: Fix gcc11 warnings.Spurious copies in range-for.Spurious copies in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48115TopAnalysis: Fix gcc11 warnings.2021-11-10T17:55:12+01:00Scott SnyderTopAnalysis: Fix gcc11 warnings.Spurious copies in range-for.Spurious copies in range-for.