athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69638Add config to make Topo Towers at all eta2024-03-18T14:19:02+01:00Dylan Sheldon RankinAdd config to make Topo Towers at all etaThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorreThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorrehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66535CaloUtils: Tighten up test for bad layer position.2023-10-25T20:41:52+02:00Scott SnyderCaloUtils: Tighten up test for bad layer position.When we calculate the layer positionsm in CaloLayerCalculator, we can get
crazy values if there is near-cancelation of the cell energies.
There was some protection against this, but it was not sufficiently
comprehensive. Tighten up thes...When we calculate the layer positionsm in CaloLayerCalculator, we can get
crazy values if there is near-cancelation of the cell energies.
There was some protection against this, but it was not sufficiently
comprehensive. Tighten up these checks.
See ATLASRECTS-7775.https://gitlab.cern.ch/atlas/athena/-/merge_requests/663102023-10-06: merge of 23.0 into main2023-10-09T14:32:02+02:00Adam Edward Barton2023-10-06: merge of 23.0 into main@wlampl please check merge resolutions
```
Conflicts:
Calorimeter/CaloRec/python/CaloConfigFlags.py
Reconstruction/egamma/egammaConfig/python/egammaConfigFlags.py
```
This sweep contains the following MRs:
...@wlampl please check merge resolutions
```
Conflicts:
Calorimeter/CaloRec/python/CaloConfigFlags.py
Reconstruction/egamma/egammaConfig/python/egammaConfigFlags.py
```
This sweep contains the following MRs:
* !66288 Fixes to address ZDC non-reproducibility ~ForwardDetectors
* !66085 Auto-config various HI-Rec modes (HI, HIP, UPC) ~Calorimeter, ~Core, ~DQ, ~Egamma, ~JetEtmiss, ~Reconstruction, ~Tools, ~Tracking
* !66291 [TriggerMenu] Added L1_gLJ80p0ETA25 and L1_gXEJWOJ100 to the HI menu CTP monitoring ~Trigger, ~TriggerMenuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66102ZDC & RPD monitoring update2023-09-27T21:15:11+02:00Yuhan GuoZDC & RPD monitoring updateadded RPD & centroid monitoring; added trigger selection on ZDC monitoring histograms used for calibration; separated ZDC (physics data) and ZDC LED monitoring into different algorithmsadded RPD & centroid monitoring; added trigger selection on ZDC monitoring histograms used for calibration; separated ZDC (physics data) and ZDC LED monitoring into different algorithmshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6495023.0 zdc mc update ATLASSIM-67512023-11-14T22:50:39+01:00Chad Stephen Lantz23.0 zdc mc update ATLASSIM-6751This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.Chad Stephen LantzChad Stephen Lantzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64947Draft: Fix EtaPtFilter to avoid some missing parent links for leptons2023-08-11T10:18:04+02:00R D SchafferDraft: Fix EtaPtFilter to avoid some missing parent links for leptonsThis is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remai...This is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remains commented out in jobOpts. This uses the TruthParticleBuilder which was used in the past to go from GenEvent to TruthEvent - which is not xAOD formatted one. It also performed as a first step the filtering of the truth in a GenEvent to GenEvent step. Only the filtering is not done. This reduces the AOD by a few percent due to truth reduction. This MR also fixes a problem in the filtering where the parent child links can be lost for leptons with eta > 5.5. Note that dumpTruth.py was slighting changed to be more coherent in way one passes the CA arguments.
Pinging @zmarshal, @jchapman, @jcatmoreR D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64732Add hypo for time-significance based selection of HLT jets2023-08-18T20:42:24+02:00Christian OhmAdd hypo for time-significance based selection of HLT jetsThis MR adds the `TimeSignificanceCondition` class to select jets at the HLT based on the significance of their delay. To be developed further before being put into production, but once marked ready the additions in this should be possib...This MR adds the `TimeSignificanceCondition` class to select jets at the HLT based on the significance of their delay. To be developed further before being put into production, but once marked ready the additions in this should be possible to merge in without causing any problems.
Longer-term improvements most importantly would include picking parameters for pT-dependent time resolution from a db or similar (instead of hardcoded). Tagging @mapatzwa who did the implementation for [his MSc thesis](http://cds.cern.ch/record/2865684), and @xingguo and @miochoa as jet trigger signature coordinators (and @cantel who previously held this role).
Also tagging @sfyrla and @jmontejo for info, as they've done work on similar things recently.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64579Draft: Replace status() with functions from TruthUtils2023-08-07T10:57:27+02:00Andrii VerbytskyiDraft: Replace status() with functions from TruthUtilsReplace status() with functions from TruthUtils.
The change is needed to switch later in the Simulation/main from the barcode() to status().
Tag @jchapmanReplace status() with functions from TruthUtils.
The change is needed to switch later in the Simulation/main from the barcode() to status().
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64426CREST server URL parameter added in IOVDbSvc2023-07-17T20:30:27+02:00Mikhail MineevCREST server URL parameter added in IOVDbSvcCREST server URL parameter added in IOVDbSvc.
Using from JobOptopns:
acc.getService("IOVDbSvc").crestServer="http://crest-undertow-api.web.cern.ch:80/api-v4.0"
Default crestServer value is "http://crest-undertow-api.web.cern.ch:80/api-...CREST server URL parameter added in IOVDbSvc.
Using from JobOptopns:
acc.getService("IOVDbSvc").crestServer="http://crest-undertow-api.web.cern.ch:80/api-v4.0"
Default crestServer value is "http://crest-undertow-api.web.cern.ch:80/api-v4.0".https://gitlab.cern.ch/atlas/athena/-/merge_requests/64286Daily merge of 23.0 into main2023-07-11T23:58:41+02:00Vakhtang TsulaiaDaily merge of 23.0 into mainNo conflicts
This sweep contains the following MRs:
* !64233 SCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online case ~InnerDetector
* !64253 [Trig]RoiDescriptor: mark methods final ~Geometry, ~Trigger
* !64271 Trig...No conflicts
This sweep contains the following MRs:
* !64233 SCTRawDataProvider, TRT_RIO_Maker allow DataPool for the cache Online case ~InnerDetector
* !64253 [Trig]RoiDescriptor: mark methods final ~Geometry, ~Trigger
* !64271 TrigMinBiasMonitoring: Add new chains to MinBias monitoring + cleanup ~DQ, ~Trigger, ~TriggerMinBias
* !64268 remove seemingly unused NN code ~InnerDetector
* !64267 rm seeming unused TrkVxEdmCnv package ~InnerDetector, ~Tracking
* !64234 TRT_RodDecoder rm not very useful block of code ~InnerDetector
* !64242 C++ Standard Setting, 23.0 branch (2023.07.10.) ~Build
* !64240 GCC Clang Pragma Warning Fix, 23.0 branch (2023.07.10.) ~Core
* !64252 MuonGeoModel - Load Geo from SQLite -> Fix index shift ~MuonSpectrometer
* !64220 TrigConfIO: fix spelling of InputType in ConfigSvc ~Trigger
* !64250 Fix defects ( passed by value) reported by cppcheck ~Calorimeter, ~DQ, ~Generators, ~MuonSpectrometer, ~Trigger
* !64243 TrigInDetValidation: increase TrigInDetRdictStep timeout ~Trigger
* !64238 TrigValTools: update data23_cos input ~Trigger
* !64227 TrigEgammaFastElectronReAlgo keep only the faster default ~Egamma, ~Trigger, ~TriggerMenu
* !64216 Debug Stream recovery, addition of HLT_rejected_events histogram ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64193Fix WriteDecorHandleKey type for ftag electron barcode decorators2023-07-07T14:35:03+02:00Samuel Van StroudFix WriteDecorHandleKey type for ftag electron barcode decoratorsSee type mismatch:
- https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/SoftElectronTruthDecoratorAlg.cxx#L65
- https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/JetTagging...See type mismatch:
- https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/src/SoftElectronTruthDecoratorAlg.cxx#L65
- https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/SoftElectronTruthDecoratorAlg.h#L48-50
Thanks @dguest
Ping @dkobyliahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64090Configuration of AFP+dijet chains2023-07-03T20:20:40+02:00Luisa CarvalhoConfiguration of AFP+dijet chainsConfigure AFP+dijet chains to have very wide Y and absolute distance matchingConfigure AFP+dijet chains to have very wide Y and absolute distance matchinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64065Set FRONTIER as default database server instead of ORACLE in all TileCal pyth...2023-06-30T23:44:35+02:00Sanya SolodkovSet FRONTIER as default database server instead of ORACLE in all TileCal python scriptsUpdating all python scripts which works with COOL DB - set FRONTIER as default database serverUpdating all python scripts which works with COOL DB - set FRONTIER as default database serverhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63828Revert "Merge branch 'skip.PyUtils-20230618' into '23.0'"2023-06-21T09:38:59+02:00Walter LamplRevert "Merge branch 'skip.PyUtils-20230618' into '23.0'"This reverts merge request !63776 since we experienced fake TCT errors with today's nightlyThis reverts merge request !63776 since we experienced fake TCT errors with today's nightlyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63616Substituting hard-coded Z5/Z1 ratio values with soft-coded ones2023-06-12T20:13:45+02:00Francesco De SantisSubstituting hard-coded Z5/Z1 ratio values with soft-coded onesThe code used the ratio between the Z positions of the first layers of the outer and inner sTGC multiplet in hard-coded form. Now it computes it during initialisation and makes it subsequently available.
cc @fgraviliThe code used the ratio between the Z positions of the first layers of the outer and inner sTGC multiplet in hard-coded form. Now it computes it during initialisation and makes it subsequently available.
cc @fgravili