athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-20T03:02:58+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20003Updating copyright and private licences2018-12-20T03:02:58+01:00Edward MoyseUpdating copyright and private licencesThis should remove the mistakes that crept back in. Need to compile before accepting.This should remove the mistakes that crept back in. Need to compile before accepting.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20045AthContainersInterfaces,etc: Change getSelectedAuxIDs to return by value.2018-12-21T03:02:17+01:00Scott SnyderAthContainersInterfaces,etc: Change getSelectedAuxIDs to return by value.getSelectedAuxIDs() was returning a value by const reference, which was
problematic for thread-safety, since that requires saving a copy of the
set in the AuxSelector object. Change to returning by value.
Now that auxid_set_t is represe...getSelectedAuxIDs() was returning a value by const reference, which was
problematic for thread-safety, since that requires saving a copy of the
set in the AuxSelector object. Change to returning by value.
Now that auxid_set_t is represented by a bitmap with a move operator,
that should not be very expensive.
Also change AuxDiscoverySvc::getauxIDs() to return by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20064AthenaPoolExampleAlgorithms: Update reference files.2018-12-21T03:02:54+01:00Scott SnyderAthenaPoolExampleAlgorithms: Update reference files.Fix failures in master.Fix failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20104AthContainers, etc: Add IConstAuxStore::isDecoration().2018-12-27T03:02:24+01:00Scott SnyderAthContainers, etc: Add IConstAuxStore::isDecoration().Add an interface to test if a variable is considered a decoration.
Needed to remove an ugly const_cast in ShallowAuxContainer.Add an interface to test if a variable is considered a decoration.
Needed to remove an ugly const_cast in ShallowAuxContainer.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20122StorageSvc: Fix gcc9 warnings.2018-12-27T03:02:28+01:00Scott SnyderStorageSvc: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20129StorageSvc: Fix clang warning.2018-12-29T03:02:25+01:00Scott SnyderStorageSvc: Fix clang warning.clang warning: unused variable.clang warning: unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20195use BackFill() to fill new AuxDyn branches created late2019-01-09T03:03:00+01:00Marcin Nowakuse BackFill() to fill new AuxDyn branches created lateUpdate requested in https://its.cern.ch/jira/browse/ATEAM-499Update requested in https://its.cern.ch/jira/browse/ATEAM-499https://gitlab.cern.ch/atlas/athena/-/merge_requests/20161Advance on deserialisation of Trigger EDM from the HLTResultMT2019-01-09T03:02:53+01:00Tomasz BoldAdvance on deserialisation of Trigger EDM from the HLTResultMTThis MR adds deserialisation of the EDM collection stored in the HLTResultMT
Further debugging will follow in the next MR for the Aux data.
Unfortunatelly I have not figured out how to read actual type from the payload even if it is st...This MR adds deserialisation of the EDM collection stored in the HLTResultMT
Further debugging will follow in the next MR for the Aux data.
Unfortunatelly I have not figured out how to read actual type from the payload even if it is store there. ROOT TBufferFile API is quite convoluted.
The solution is not space efficient and identical to the exiting one.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20225Cleanup preprocessor2019-01-11T03:02:20+01:00Stewart Martin-HaughCleanup preprocessorThere were a few source files with the pattern
```
-#ifndef _CPP_STRING
#include <string>
-#endif
```
This is effectively just a second include guard around the include, which of course has its own include guard.
At the same time I r...There were a few source files with the pattern
```
-#ifndef _CPP_STRING
#include <string>
-#endif
```
This is effectively just a second include guard around the include, which of course has its own include guard.
At the same time I removed three workarounds, one for Boost < 1.3 and one for GCC versions older than 3.0.
Cheers,
Stewarthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/2004422.0-refactor-IOVDbSvc-22019-01-15T15:44:55+01:00Shaun Roe22.0-refactor-IOVDbSvc-2Refactoring IOVDbSvc; work continued after repository change to open source.
Pre-change patch file applied to the new repository (so.. many changes in one commit).
Adding new Cool functions and delegating file metadata reading to a new c...Refactoring IOVDbSvc; work continued after repository change to open source.
Pre-change patch file applied to the new repository (so.. many changes in one commit).
Adding new Cool functions and delegating file metadata reading to a new classhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20337IOVDbSvc: Remove debygging printout.2019-01-15T15:45:49+01:00Scott SnyderIOVDbSvc: Remove debygging printout.Fixes test failures in master.Fixes test failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20440Remove CURL, master branch (2019.01.18.)2019-01-22T17:50:52+01:00Attila KrasznahorkayRemove CURL, master branch (2019.01.18.)Removed the usage of `FindCURL.cmake` from CollectionUtilities.
The package probably did use CURL at one point of its file, but it doesn't use it by now. So there's no need for it to set it up for its build.
Note that this is why the c...Removed the usage of `FindCURL.cmake` from CollectionUtilities.
The package probably did use CURL at one point of its file, but it doesn't use it by now. So there's no need for it to set it up for its build.
Note that this is why the current CentOS 7 nightlies don't show a build error, even though they fail to find CURL.
http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/GITWebArea/nightlies/master/2019-01-17T2139/Athena/x86_64-centos7-gcc8-opt/Athena/cmake_config.log.html
```
-- Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)
```
Since as ATLINFR-2820 explains, this becomes an error with CMake 3.13, the simplest was just to remove this unneeded dependency from the CollectionUtilities package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20473AthenaServices: A couple bug fixes related to metadata.2019-01-22T03:02:20+01:00Scott SnyderAthenaServices: A couple bug fixes related to metadata.AttributeListKey should be a read handle, not a write handle!
Avoid spurious WARNING about AttributeList during stop().
Also update reference files in AthenaPoolExampleAlgorithms to fix test failures in master.AttributeListKey should be a read handle, not a write handle!
Avoid spurious WARNING about AttributeList during stop().
Also update reference files in AthenaPoolExampleAlgorithms to fix test failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20448Fixing some problems with multuple stream handling in AthenaMT.2019-01-26T03:02:21+01:00Peter Van GemmerenFixing some problems with multuple stream handling in AthenaMT.This MR addresses some short comings of I/O when running AthenaMT and mainly writing to multiple streams:
1) Multiple stream writing has to be serial (for now) as it modifies the TransientAddress of output objects. Therefore a mutex is ...This MR addresses some short comings of I/O when running AthenaMT and mainly writing to multiple streams:
1) Multiple stream writing has to be serial (for now) as it modifies the TransientAddress of output objects. Therefore a mutex is introduced into the ItemList interface to allow the AthenaOutputStream serialization of streaming.
2) A warning for missing AttributeList is suppressed unless it in the EventStore
3) Use of ROOT Implicit Multithreading can be disabled via PoolSvc
https://gitlab.cern.ch/atlas/athena/-/merge_requests/20606Fix Placment by ensuring that only Storage Prefix is removed from ContainerName2019-01-26T03:02:06+01:00Peter Van GemmerenFix Placment by ensuring that only Storage Prefix is removed from ContainerNameFixing a previous bug that would strip of any prefix including a ':' (such as 'xAOD::') and mess up the container structure of the output file.Fixing a previous bug that would strip of any prefix including a ':' (such as 'xAOD::') and mess up the container structure of the output file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20844TPTools: Fix gcc9 warnings.2019-02-05T03:02:04+01:00Scott SnyderTPTools: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20903Bugfix in addFoldersSplitOnline, renaming flags to configFlags2019-03-15T11:01:52+01:00Rupert TombsBugfix in addFoldersSplitOnline, renaming flags to configFlagsBugfix in addFoldersSplitOnline, renaming flags to configFlags for consistent style. Previously failed if flags.Common.isOnline was true, in evaluating the nonexistent variable configFlags.Bugfix in addFoldersSplitOnline, renaming flags to configFlags for consistent style. Previously failed if flags.Common.isOnline was true, in evaluating the nonexistent variable configFlags.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20926PersistentDataModel: Fix cppcheck warnings.2019-02-08T03:02:29+01:00Scott SnyderPersistentDataModel: Fix cppcheck warnings.cppcheck warnings: prefer prefix increment.cppcheck warnings: prefer prefix increment.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20949AthenaPoolExampleAlgorithms: Update reference files.2019-02-08T03:02:24+01:00Scott SnyderAthenaPoolExampleAlgorithms: Update reference files.Fix test failures in master.Fix test failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20008migrate PileUpEventInfo to xAOD::EvenInfo2019-02-13T03:02:35+01:00Marcin Nowakmigrate PileUpEventInfo to xAOD::EvenInfoMigrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633Migrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633