athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-11-23T12:16:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67315Update BPHY24 with JpsiV0VertexFitCfg2023-11-23T12:16:35+01:00Thomas StreblerUpdate BPHY24 with JpsiV0VertexFitCfgUse central `JpsiV0VertexFitCfg`, with equivalent configurationUse central `JpsiV0VertexFitCfg`, with equivalent configurationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67314Use central InDetTrackSelectionTool configs in derivation2023-11-28T22:23:58+01:00Thomas StreblerUse central InDetTrackSelectionTool configs in derivationSelf-explanatory. Useful in particular for Run 4 configs since the central configs have in addition
https://gitlab.cern.ch/atlas/athena/-/blob/main/InnerDetector/InDetConfig/python/InDetTrackSelectionToolConfig.py#L30
```
kwargs.set...Self-explanatory. Useful in particular for Run 4 configs since the central configs have in addition
https://gitlab.cern.ch/atlas/athena/-/blob/main/InnerDetector/InDetConfig/python/InDetTrackSelectionToolConfig.py#L30
```
kwargs.setdefault("maxAbsEta", 2.5 if flags.GeoModel.Run <= LHCPeriod.Run3 else 4.0)
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/67272Add jet fold hash2024-03-26T11:52:53+01:00Dan GuestAdd jet fold hashThis just adds a variable to flavor tagging. Nothing else should change.
We found that our flavor tagging networks were a bit overtrained on the ttbar dataset we normally use. We're considering working around this by adding a per-jet ha...This just adds a variable to flavor tagging. Nothing else should change.
We found that our flavor tagging networks were a bit overtrained on the ttbar dataset we normally use. We're considering working around this by adding a per-jet hash and training several networks, so we can avoid ever applying the tagger to a jet we trained on.
This is adding the first part: the hash. It mixes some hit and constituent info with the event number to get something pretty random.
Tagging @svanstro, @hartman, @bdong, @liganghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67271Run3 Derivations for heavy Ion group (part of my QT) v02024-03-19T09:35:52+01:00Sebastian Alonso Infante CabanasRun3 Derivations for heavy Ion group (part of my QT) v0Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migratio...Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migrations not started as of november 21 of 2023
No derivative is made to get truth data as i dont have truth data files for testinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67260Inclusion of functions to produce clusters containers related to Ringer2023-11-23T12:34:42+01:00Denis Oliveira DamazioInclusion of functions to produce clusters containers related to RingerInclusion of functions to produce clusters containers related to Ringer. These functions can be called from Pre/Post Exec in a transform.Inclusion of functions to produce clusters containers related to Ringer. These functions can be called from Pre/Post Exec in a transform.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67238Replace ConfigFactory used in block config with backend for text config so bo...2024-03-22T16:55:36+01:00Joseph Earl LambertReplace ConfigFactory used in block config with backend for text config so both are consistent.To ensure that the block and text configuration are consistent, the `TextConfig` class was refactored into a `ConfigFacotry` and and `TextConfig` classes. The `ConfigFactory` class replaces the previous `ConfigFactory` used in the block ...To ensure that the block and text configuration are consistent, the `TextConfig` class was refactored into a `ConfigFacotry` and and `TextConfig` classes. The `ConfigFactory` class replaces the previous `ConfigFactory` used in the block config so that the functions/classes for each block are the same for both and the way that they are configured are the same.
The block config implemented in `FullCPAlgorithmsTest.py` was updated to use the new back-end.
Many of the functions previously used in `TextConfig` class were moved to the `ConfigSequence` class to make interacting with the blocks and block options easier.
The `PileupReweighting` block for the text config was replaced with the code used for the block config.
The blocks stored in the `TextConfig` class are now encapsulated in a class that can create an instance of the class/function associated with the block.
Addresses the following:
- ATLASG-2612
- ATLASG-2614
- ATLASG-2615Joseph Earl LambertJoseph Earl Lamberthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67230Modifications needed for large-R DNN calibration usage2023-11-27T19:27:45+01:00Chris Malena DelitzschModifications needed for large-R DNN calibration usageThis MR enables the usage of the new large-R DNN calibration for UFO jets (soon to be a recommendation) by
- adding the necessary variables to the smart slimming list and scheduling them in the reconstruction
- avoiding FPEs in the code ...This MR enables the usage of the new large-R DNN calibration for UFO jets (soon to be a recommendation) by
- adding the necessary variables to the smart slimming list and scheduling them in the reconstruction
- avoiding FPEs in the code when running the calibration in derivations
- calculates ratios such as C2, Tau21, ... needed when running on derivations as those variables are not stored (thanks a lot to Guillaume for the implementation!)
In addition, the MR:
- removes large-R trimmed jets from JETM1 and JETM4 (not the recommended jet collection anymore)
- sets the jet collection correctly for the JvtSelectionTool and JvtEfficiencyTool. At the moment warnings appear when running derivations.
- adds small-R UFO jets to JETM3 and the corresponding smart slimming list (will be recommendations in the near future as well)
There are two other things that still require fixing but undrafting now as the MR is already quite big and smaller MRs are encouraged.
Tagging @mswiatlo @bhodkinshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67215[ATR-28532][ATR-28536] Rework how ExtraEDMList is applied2023-11-23T12:24:49+01:00Tim Martin[ATR-28532][ATR-28536] Rework how ExtraEDMList is appliedThis MR proposal lets `flags.Trigger.ExtraEDMList` work once again in `main`. And it now also propagates down to ESD, AOD - providing the flag continues to get set in the offline processing step (and even DAOD if producing DAOD_PHYSVAL, ...This MR proposal lets `flags.Trigger.ExtraEDMList` work once again in `main`. And it now also propagates down to ESD, AOD - providing the flag continues to get set in the offline processing step (and even DAOD if producing DAOD_PHYSVAL, or other DAOD with a complete trigger payload).
This resolves ATR-28532, however the mechanism was only working previously due to side-effects (mutation of a global state). Which is how it could be broken silently by a refactor in the first place. Opened ATR-28536 to follow up on this aspect.
cc @cantel and @damaziohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67195Draft: Added new TruthParticle and TruthVertex aux containers.2024-03-13T11:57:38+01:00John Derek ChapmanDraft: Added new TruthParticle and TruthVertex aux containers.Extra changes on top of !66561
Tagging @akraszna, @averbyts and @pclarkExtra changes on top of !66561
Tagging @akraszna, @averbyts and @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67185Adding Large-R jets to Physics Validation (AFT-688)2024-01-31T13:45:14+01:00Jacob Edwin CrosbyAdding Large-R jets to Physics Validation (AFT-688)I've removed the VR jet container and have replaced it with the Large-R jet container.
I've also updated the PhysVal scripts to output proper merged files and GN2Xv01 ROCs.I've removed the VR jet container and have replaced it with the Large-R jet container.
I've also updated the PhysVal scripts to output proper merged files and GN2Xv01 ROCs.Jacob Edwin CrosbyJacob Edwin Crosbyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67163AFT-692 Remove GN1 from PHYS(LITE)2023-12-14T19:45:29+01:00Binbin DongAFT-692 Remove GN1 from PHYS(LITE)Since there is no use of GN1 in analysis, removing GN1 b-tagger from PHYS(LITE) to avoid confusion.
cc @dguest, @fdibello, and @ligangSince there is no use of GN1 in analysis, removing GN1 b-tagger from PHYS(LITE) to avoid confusion.
cc @dguest, @fdibello, and @liganghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67161Protect EGElectronAmbiguityTool.cxx from null VertexContainer pointer.2023-11-16T15:31:51+01:00Jonathan LongProtect EGElectronAmbiguityTool.cxx from null VertexContainer pointer.Check if pointer is null before using it.Check if pointer is null before using it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67153Set default ConfigFile in central ElectronPhotonVariableCorrectionToolCfg2023-11-21T15:43:15+01:00Thomas StreblerSet default ConfigFile in central ElectronPhotonVariableCorrectionToolCfgFollow up to !67061
Fixes LLP1 failure https://bigpanda.cern.ch//media/filebrowser/413b46ec-1a7c-49b2-a1a8-5e922b904ed6/group.art/tarball_PandaJob_6021817939_IN2P3-LAPP/log.Derivation
```
05:02:49 Traceback (most recent call last):
05:...Follow up to !67061
Fixes LLP1 failure https://bigpanda.cern.ch//media/filebrowser/413b46ec-1a7c-49b2-a1a8-5e922b904ed6/group.art/tarball_PandaJob_6021817939_IN2P3-LAPP/log.Derivation
```
05:02:49 Traceback (most recent call last):
05:02:49 File "/srv/workDir/runargs.Derivation.py", line 39, in <module>
05:02:49 fromRunArgs(runArgs)
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkConfiguration/DerivationSkeleton.py", line 120, in fromRunArgs
05:02:49 cfg.merge(derivationConfig(flags))
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkLLP/LLP1.py", line 425, in LLP1Cfg
05:02:49 acc.merge(LLP1KernelCfg(flags, name="LLP1Kernel", StreamName = 'StreamDAOD_LLP1', TriggerListsHelper = LLP1TriggerListsHelper))
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkLLP/LLP1.py", line 115, in LLP1KernelCfg
05:02:49 acc.merge(PhotonIsEMSelectorsCfg(flags))
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 923, in merge
05:02:49 self.addPublicTool(pt) #Profit from deduplicaton here
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 634, in addPublicTool
05:02:49 deduplicate(newTool,self._publicTools)
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/Deduplication.py", line 31, in deduplicate
05:02:49 raiseWithCurrentContext(exception)
05:02:49 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/DebuggingContext.py", line 48, in raiseWithCurrentContext
05:02:49 raise type(exception)(str(exception) + '\nWith the context:\n{}'.format(Context.complete()) )
05:02:49 ValueError: conflicting settings for property ConfigFile of EGVariableCorrectionTool: cannot merge values 'EGammaVariableCorrection/TUNE23/ElPhVariableNominalCorrection.conf' and 'EGammaVariableCorrection/TUNE26/ElPhVariableNominalCorrection.conf'
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/67152Remove extra dot after VertexedClusters2023-11-16T13:29:36+01:00Thomas StreblerRemove extra dot after VertexedClustersTrying to stop the contagion to avoid running into ATLASRECTS-7807 againTrying to stop the contagion to avoid running into ATLASRECTS-7807 againhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67151Clean up extra dot in CommonJETMXContent2023-11-16T10:06:39+01:00Thomas StreblerClean up extra dot in CommonJETMXContentFix JETM2 failure in ART tests, as a follow up to https://gitlab.cern.ch/atlas/athena/-/merge_requests/66904
https://bigpanda.cern.ch//media/filebrowser/baa51c9e-16c2-4e71-b015-f97c4989aa45/group.art/tarball_PandaJob_6021818450_IL-TAU/l...Fix JETM2 failure in ART tests, as a follow up to https://gitlab.cern.ch/atlas/athena/-/merge_requests/66904
https://bigpanda.cern.ch//media/filebrowser/baa51c9e-16c2-4e71-b015-f97c4989aa45/group.art/tarball_PandaJob_6021818450_IL-TAU/log.Derivation
```
05:59:17 Traceback (most recent call last):
05:59:17 File "/srv/workDir/runargs.Derivation.py", line 39, in <module>
05:59:17 fromRunArgs(runArgs)
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkConfiguration/DerivationSkeleton.py", line 120, in fromRunArgs
05:59:17 cfg.merge(derivationConfig(flags))
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkJetEtMiss/JETM2.py", line 222, in JETM2Cfg
05:59:17 acc.merge(SetupMetaDataForStreamCfg(ConfigFlags, "DAOD_JETM2", AcceptAlgs=["JETM2Kernel"], createMetadata=[MetadataCategory.CutFlowMetaData]))
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 893, in merge
05:59:17 mergeSequences(ourSeq, otherSeq)
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 862, in mergeSequences
05:59:17 deduplicateOne(self._algorithms[c.name], c)
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/Deduplication.py", line 56, in deduplicateOne
05:59:17 raiseWithCurrentContext(exception)
05:59:17 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/DebuggingContext.py", line 48, in raiseWithCurrentContext
05:59:17 raise type(exception)(str(exception) + '\nWith the context:\n{}'.format(Context.complete()) )
05:59:17 ValueError: conflicting settings for property ItemList of OutputStreamDAOD_JETM2: ItemList AuxAttribute selection syntax error - extra dot in 'truthMatchProbability..numberOfPixelOutliers.expectInnermostPixelLayerHit.vx.ftagTruthBarcode.truthType.numberOfNextToInnermostPixelLayerHits.numberOfInnermostPixelLayerHits.btagIp_invalidIp.numberOfSCTOutliers.numberOfPixelSharedHits.ftagTruthVertexIndex.numberOfPrecisionHoleLayers.btagIp_trackDisplacement.vertexLink.numberOfSCTDoubleHoles.ftagTruthOriginLabel.numberDoF.numberOfPrecisionLayers.particleHypothesis.phi.numberOfNextToInnermostPixelLayerSharedHits.trackFitter.numberOfInnermostPixelLayerOutliers.numberOfSCTHoles.btagIp_z0SinThetaUncertainty.numberOfSCTDeadSensors.d0.numberOfInnermostPixelLayerSplitHits.numberOfNextToInnermostPixelLayerSplitHits.definingParametersCovMatrixDiag.ftagTruthTypeLabel.vy.chiSquared.truthParticleLink.numberOfPhiLayers.numberOfTRTOutliers.ftagTruthParentBarcode.numberOfInnermostPixelLayerSharedHits.numberOfSCTHits.AssoClustersUFO.btagIp_z0SinTheta.theta.vz.btagIp_d0Uncertainty.numberOfTRTHits.numberOfNextToInnermostPixelLayerOutliers.numberOfPixelSplitHits.numberOfSCTSpoiltHits.numberOfPhiHoleLayers.trackLink.btagIp_trackMomentum.numberOfPixelHits.numberOfPixelHoles.z0.truthOrigin.qOverP.definingParametersCovMatrixOffDiag.numberOfSCTSharedHits.numberOfPixelSpoiltHits.leptonID.trackProperties.numberOfPixelDeadSensors'
05:59:17 With the context:
```
FYI @cdelitzshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67150Align HLT_IDVertex_FSAux variables fro TrackingTrigger and JetTrigger Slimmin...2023-11-16T14:04:56+01:00Thomas StreblerAlign HLT_IDVertex_FSAux variables fro TrackingTrigger and JetTrigger SlimmingHelperFix Run3 PHYSVAL failure in ART test
https://bigpanda.cern.ch/art/jobs/?package=DerivationFrameworkPhysicsValidationART&branch=main/Athena/x86_64-centos7-gcc11-opt&ntag_full=2023-11-14T2101
```
23:23:29 Traceback (most recent call last...Fix Run3 PHYSVAL failure in ART test
https://bigpanda.cern.ch/art/jobs/?package=DerivationFrameworkPhysicsValidationART&branch=main/Athena/x86_64-centos7-gcc11-opt&ntag_full=2023-11-14T2101
```
23:23:29 Traceback (most recent call last):
23:23:29 File "/srv/workDir/runargs.Derivation.py", line 39, in <module>
23:23:29 fromRunArgs(runArgs)
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkConfiguration/DerivationSkeleton.py", line 120, in fromRunArgs
23:23:29 cfg.merge(derivationConfig(flags))
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkPhysicsValidation/PHYSVAL.py", line 298, in PHYSVALCfg
23:23:29 acc.merge(SetupMetaDataForStreamCfg(ConfigFlags, "DAOD_PHYSVAL", AcceptAlgs=["PHYSVALKernel"], createMetadata=[MetadataCategory.CutFlowMetaData]))
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 893, in merge
23:23:29 mergeSequences(ourSeq, otherSeq)
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 862, in mergeSequences
23:23:29 deduplicateOne(self._algorithms[c.name], c)
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/Deduplication.py", line 56, in deduplicateOne
23:23:29 raiseWithCurrentContext(exception)
23:23:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-centos7-gcc11-opt/2023-11-14T2101/Athena/24.0.16/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaConfiguration/DebuggingContext.py", line 48, in raiseWithCurrentContext
23:23:29 raise type(exception)(str(exception) + '\nWith the context:\n{}'.format(Context.complete()) )
23:23:29 ValueError: conflicting settings for property ItemList of OutputStreamDAOD_PHYSVAL: Mixing up negative and positive Aux selections is not supported: xAOD::AuxContainerBase!#HLT_IDVertex_FSAux. : {'vertexType.y.z.-.x'}
```
Aligning with https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/TrackingTriggerContent.py?ref_type=heads#L5
FYI @khoo @mmontellhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67110DerivationBPHY: Add warnings for excess candidates2023-11-20T16:07:17+01:00Adam Edward BartonDerivationBPHY: Add warnings for excess candidatesSometimes combinatoric explosions crash the shared writer. Adding warnings for easier debugging.
cc @wwalko @kfungSometimes combinatoric explosions crash the shared writer. Adding warnings for easier debugging.
cc @wwalko @kfunghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67090Protection when running over data2023-11-14T15:36:28+01:00Chris Malena DelitzschProtection when running over dataJETM2 should not be run over data due to its size (MC only derivation) but adding a protection for the configuration of truth jets in any case for good practice :smile:
Reported in ATLJETMET-1676JETM2 should not be run over data due to its size (MC only derivation) but adding a protection for the configuration of truth jets in any case for good practice :smile:
Reported in ATLJETMET-1676https://gitlab.cern.ch/atlas/athena/-/merge_requests/67089Add read dependencies to TruthCollectionMaker2023-11-15T15:23:26+01:00Stylianos AngelidakisAdd read dependencies to TruthCollectionMakerConverting some hard-coded decorations into ReadDecorHandleKeys to handle the dependence of TruthCollectionMaker on TruthClassificationDecorator.Converting some hard-coded decorations into ReadDecorHandleKeys to handle the dependence of TruthCollectionMaker on TruthClassificationDecorator.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67085Add check for data events with no PV in PhotonSelectionWrapper2023-11-14T14:06:34+01:00Thomas StreblerAdd check for data events with no PV in PhotonSelectionWrapperFix HIGG1D1 derivation to cover data events where no PV is reconstructed. In that case the sumPt2 `DecorHandle` is considered as not available (even if it is for previous events) and the current implementation leads to
```
PhotonVertexS...Fix HIGG1D1 derivation to cover data events where no PV is reconstructed. In that case the sumPt2 `DecorHandle` is considered as not available (even if it is for previous events) and the current implementation leads to
```
PhotonVertexSel... ERROR SG::ExcStoreLocked: Attempted to modify auxiliary data in a locked store: `::sumPt2' (1237)
```
Should be the last occurence of ATEAM-939