athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-02-09T15:43:39+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/50288Migrate Beam.Type to be an enum2022-02-09T15:43:39+01:00Tadej Novaktadej.novak@cern.chMigrate Beam.Type to be an enumMigrate `Beam.Type` to be an enum.Migrate `Beam.Type` to be an enum.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50271DAOD_PHYS: drop RNN tau ID thinning cut2022-02-08T09:44:21+01:00Bertrand Martin Dit LatourDAOD_PHYS: drop RNN tau ID thinning cutHello,
This MR is dropping the thinning cut on the RNN tau ID score in 21.2 DAOD_PHYS in order to ease the R22/R21 comparisons and the R22 validation (there is no tau thinning in R22).
The size increase was evaluated with the standard D...Hello,
This MR is dropping the thinning cut on the RNN tau ID score in 21.2 DAOD_PHYS in order to ease the R22/R21 comparisons and the R22 validation (there is no tau thinning in R22).
The size increase was evaluated with the standard DerivationFrameworkART tests, and found to be +2.1% for data (29.9->30.5 kb/evt) and +1.8% for ttbar MC (66.4->67.5 kb/evt).
I put the 'urgent' label because ideally we'd want to have this included in the legacy 21.2 PHYS production that is expected imminently.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50270Migrate GeoModel.Run to be an enum2022-02-08T15:42:54+01:00Tadej Novaktadej.novak@cern.chMigrate GeoModel.Run to be an enumMigrate `GeoModel.Run` to be an enum.Migrate `GeoModel.Run` to be an enum.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50162added PP8 ttbb sample with bornzerodamp cut 5 DSIDs to MCTruthClassifier2022-02-07T14:18:57+01:00Andrea Helen Knueadded PP8 ttbb sample with bornzerodamp cut 5 DSIDs to MCTruthClassifierI added two more DSIDs to the HF Classification code.I added two more DSIDs to the HF Classification code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50101Adding ART for HDBS42022-01-31T21:44:17+01:00Cristiano AlpigianiAdding ART for HDBS4This MR adds ART for the new format HDBS4, https://gitlab.cern.ch/atlas/athena/-/merge_requests/49768.This MR adds ART for the new format HDBS4, https://gitlab.cern.ch/atlas/athena/-/merge_requests/49768.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50042Update BPHY20: add BPhysBGammaFinder, modification JpsiPlus1Track for Jpsi pl...2022-08-31T17:18:42+02:00Tatiana LyubushkinaUpdate BPHY20: add BPhysBGammaFinder, modification JpsiPlus1Track for Jpsi plus eAdd BPhysBGammaFinder.h and BPhysBGammaFinder.cxx into DerivationFrameworkBPhys for reconstruction decay like Bc*->BcGamma, InDetTrackParticles are used for Gamma->e+e-. Modify JpsiPlus1Track.h and JpsiPlus1Track.cxx for using an electro...Add BPhysBGammaFinder.h and BPhysBGammaFinder.cxx into DerivationFrameworkBPhys for reconstruction decay like Bc*->BcGamma, InDetTrackParticles are used for Gamma->e+e-. Modify JpsiPlus1Track.h and JpsiPlus1Track.cxx for using an electron as the third track. Add BPHY20BcJpsiECandidates, BPHY20ConversionCandidates in BPHY20.py
cc: @tursom, @gladilinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50033Add truthMatchProbability to InDetTrackParticles EXOT282022-01-28T21:43:55+01:00Alexander LoryAdd truthMatchProbability to InDetTrackParticles EXOT28IndetTrackParticle.truthMatchProbability is required by the InDetTruthFilterTool to evaluate systematic uncertainties on track fake rates.IndetTrackParticle.truthMatchProbability is required by the InDetTruthFilterTool to evaluate systematic uncertainties on track fake rates.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50003adding PLIV isolation working points to PHYS2022-02-04T15:28:53+01:00Michael Holzbockadding PLIV isolation working points to PHYSThis MR aims to add information needed for evaluating and calibrating the [PLIV Isolation WPs](https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/PLImprovedWPs) to the DAOD_PHYS format as these are potential of interest for multiple...This MR aims to add information needed for evaluating and calibrating the [PLIV Isolation WPs](https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/PLImprovedWPs) to the DAOD_PHYS format as these are potential of interest for multiple analyzes. In a 2018 data file the increase in size/event is 0.48%
I'm waiting for @fuhe to confirm that the current implementation is complete and nothing is missing.
Tagging also @rustem, as well as @fcardill and @lpascual for the IFF.
*Edit:* @rustem confirmed privately that the additions look good and they follow exactly the instructions in the [twiki](https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/PLImprovedWPs#Required_DxAOD_variables) hence we should be fine here anyway. Hence I'll un-draft this MR and I'd like to tag @calpigia if we can can still add this into the new derivation cache.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49953implement b/c Continuous 2D tagger in FTAG2022-02-15T16:55:35+01:00Ilaria Luiseimplement b/c Continuous 2D tagger in FTAGThe MR implements the continuous "VHbb style" b/c-tagger within the FTAG central packages. \
More details on the tagger and the "Continuous2D" WP: [here](https://indico.cern.ch/event/1072234/contributions/4601330/attachments/2343095/3995...The MR implements the continuous "VHbb style" b/c-tagger within the FTAG central packages. \
More details on the tagger and the "Continuous2D" WP: [here](https://indico.cern.ch/event/1072234/contributions/4601330/attachments/2343095/3995024/HTopWS_PCBCT_Luise_10112021.pdf) \
We tested it locally and validated the output both on ATop and the CxAODFramework.
Also:
- rename of mv2c_ variables with more generic names to avoid confusion in the future
- remove mv2c100_mv2c100 2D tagger (obsolete) where not needed.
Tagging:
@fdibello @hanar on the VHbb side \
@vdao @biliu on the FTAG sidehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49875R21.2 DAOD_PHYS: add HLT MET x,y to recover events with saturated L1Calo towe...2022-01-24T15:45:06+01:00Bertrand Martin Dit LatourR21.2 DAOD_PHYS: add HLT MET x,y to recover events with saturated L1Calo towers (ATLSUSYBGF-614)Same as !49873 but for 21.2 instead of master.
This MR is adding HLT MET x,y to the DAOD_PHYS output, for two HLT MET algorithms: cell-based and mht (ATLSUSYBGF-614).
This is needed to emulate the HLT MET trigger decision in situations w...Same as !49873 but for 21.2 instead of master.
This MR is adding HLT MET x,y to the DAOD_PHYS output, for two HLT MET algorithms: cell-based and mht (ATLSUSYBGF-614).
This is needed to emulate the HLT MET trigger decision in situations where L1_XE did not fire due to a L1Calo firmware bug affecting data15-16.
Explanation given by Jon at the time: "If two towers in opposing quadrants both overflowed then the event wasn't usually written out as the overflows were allowed to cancel each other out. From 2017 this was corrected so that any tower overflow meets the trigger requirement."
The motivation for saving both cell-based and mht MET is discussed in ATR-13615. Unfortunately, mht MET is not always calculated, and there's a higher probability that cell-based MET is calculated as it's involved in many combined MET+X triggers.
The size increase is small, it's only 4 extra floats per event.
For now, it's added to PHYS only, not PHYSLITE.
Tagging @jburr , @salderwe , @miholzbo , and @calpigia , it would be great to pick this up for the upcoming 21.2 (legacy?) PHYS production. Adding the urgent label for this one.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49841BPHY8: Add option to save all muons in DAOD2022-01-26T09:43:57+01:00Wolfgang WalkowiakBPHY8: Add option to save all muons in DAODThis merge request adds the option to save all (original and calibrated) muons to
the DAOD. This option may be enabled by the statement
BPHY8_`KeepAllMuonsPtCut=0` in the `preExec` of a p-tag. It's intentional that
the default for BPHY8 ...This merge request adds the option to save all (original and calibrated) muons to
the DAOD. This option may be enabled by the statement
BPHY8_`KeepAllMuonsPtCut=0` in the `preExec` of a p-tag. It's intentional that
the default for BPHY8 is kept as is in order to not overly enlarge regularly
produced DAODs. The new option is needed for some specific special studies.
Reviewers please note that the file `BPHY8.py` is quite long due to important comments which need to be kept. Please ignore a corresponding warning by the ATLAS robot.
cc: @abartonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49837Make checkRange() from BTaggingSelectionTool more robust2022-01-25T19:09:20+01:00Jonathan BossioMake checkRange() from BTaggingSelectionTool more robustFix eta check in checkRange(). Throughout the tool, the absolute value is passed to checkRange() but if anyone uses checkRange() alone, it wouldn't check the eta range correctly.
Tagging @fsforza who identified the issue.
Tagging @thuf...Fix eta check in checkRange(). Throughout the tool, the absolute value is passed to checkRange() but if anyone uses checkRange() alone, it wouldn't check the eta range correctly.
Tagging @fsforza who identified the issue.
Tagging @thuffman @duperrin who I believe are the FTag software experts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49835BPHY12 derivation: tightened selection.2022-01-24T15:45:03+01:00Pavel ReznicekBPHY12 derivation: tightened selection.This MR makes updates BPHY12 derivation. Following the offline-analysis base requirements, the cuts in the BPHY12 derivation are tightened. The size of the derivation format goes down by a factor of 2x. It is also possible that the tight...This MR makes updates BPHY12 derivation. Following the offline-analysis base requirements, the cuts in the BPHY12 derivation are tightened. The size of the derivation format goes down by a factor of 2x. It is also possible that the tightening of the cuts would fix the crash on one data event mentioned in https://its.cern.ch/jira/browse/ATLBPHYS-193 (unfortunately, the problem is not locally reproducible, but is obviously triggered by too many candidates in the event).https://gitlab.cern.ch/atlas/athena/-/merge_requests/49768new HDBS4 derivation2022-01-31T17:31:06+01:00Mihaela Marinescunew HDBS4 derivationA new HDBS derivation for the H->Za->ll+2trk analysis.A new HDBS derivation for the H->Za->ll+2trk analysis.Cristiano AlpigianiATLAS RobotCristiano Alpigianihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49746Sweeping !49723 from master to 21.2.
Extend tau trigger single leg trigger ma...2022-01-19T21:43:58+01:00Atlas NightlybuildSweeping !49723 from master to 21.2.
Extend tau trigger single leg trigger matching list in DAOD PHYS (ATR-24269)Extend tau trigger single leg trigger matching list in DAOD PHYS (ATR-24269)
See merge request atlas/athena!49723Extend tau trigger single leg trigger matching list in DAOD PHYS (ATR-24269)
See merge request atlas/athena!49723https://gitlab.cern.ch/atlas/athena/-/merge_requests/49670BPHY8: Updated configuration of MuonCalibrationAndSmearingTool2022-01-14T21:43:49+01:00Wolfgang WalkowiakBPHY8: Updated configuration of MuonCalibrationAndSmearingToolThe configuration of the MuonCalibrationAndSmearingTool in BPHY8 has been updated according to the updated rel. 21 precision
recommendations on the TWiki [1]. BPHY8 has been test-run locally.
Reviewers: Please note that the friendly at...The configuration of the MuonCalibrationAndSmearingTool in BPHY8 has been updated according to the updated rel. 21 precision
recommendations on the TWiki [1]. BPHY8 has been test-run locally.
Reviewers: Please note that the friendly atlasbot will likely complain about the number of lines in `BPHY8.py` which are needed for documentation purposes. Please ignore this warning.
[1] https://twiki.cern.ch/twiki/bin/viewauth/AtlasProtected/MCPAnalysisGuidelinesMC16#Momentum_corrections_Precision_R (r62 as of 2022-01-13)
cc: @abartonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49663IExtrapolator rm legacy / fallback Event Context unaware methods2022-01-22T00:09:30+01:00Christos Anastopouloschristos.anastopoulos@cern.chIExtrapolator rm legacy / fallback Event Context unaware methodsIExtrapolator rm legacy / fallback Event Context unaware methods that were doing implicit/hidden retrievals/lookups.
i.e remove these kind of methods:
```
inline const Trk::TrackParameters*
Trk::IExtrapolator::extrapolate(const xAOD::...IExtrapolator rm legacy / fallback Event Context unaware methods that were doing implicit/hidden retrievals/lookups.
i.e remove these kind of methods:
```
inline const Trk::TrackParameters*
Trk::IExtrapolator::extrapolate(const xAOD::TrackParticle& particleBase,
....) const
{
return extrapolate( Gaudi::Hive::currentContext(),
particleBase...);
}
```
using the above meant as example that in a loop 1... N we do the lookup N times..
Make the retrievals explicit (visible so we can futher optimise here if we ever need/want) on the client code.
Also tried to fix the obvious "too many" lookups.
We can further reduce them but we need then to also change
method interfaces on the client side.
follow up to
* https://gitlab.cern.ch/atlas/athena/-/merge_requests/49370
* https://gitlab.cern.ch/atlas/athena/-/merge_requests/49371
* https://gitlab.cern.ch/atlas/athena/-/merge_requests/49424
ping @sroe and @tadej
I expect quite a few clients to use the methods the implicitly retrieve the ctx . Let the `CI` notify ushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49656Creation of VrtSecFuzzy2023-04-04T05:42:39+02:00Risa UshiodaCreation of VrtSecFuzzyI have added a new package "VrtSecFuzzy" under VKalVrt and modified SUSY15.py.
This is a new vertexing algorithm.
It targets DVs where not all tracks originate from one point (e.g. when they include b-hadrons).
Here are the rough proced...I have added a new package "VrtSecFuzzy" under VKalVrt and modified SUSY15.py.
This is a new vertexing algorithm.
It targets DVs where not all tracks originate from one point (e.g. when they include b-hadrons).
Here are the rough procedure of this algorithm:
1. Track preselection.
2. Track pairs likely to form seed vertices are selected using MVA (BDT algorithm), and then seeding is done for all selected track pairs.
Seeding method itself is the same as VSI.
Now, call the seeds formed by the track pairs with particulaly high BDT score "primary seeds".
3. Merge the primary seeds and their surrounding seeds in to groups.
4. If the same seeds are shared by multiple groups, merge the groups into one. -> Difine these seed groups (track groups) as DVs.
I have attached a figure showing the structure of this package and some performance plots.
[MergeRequest.pdf](/uploads/669e3e219d1b027e9c44b7401b3c3d90/MergeRequest.pdf)https://gitlab.cern.ch/atlas/athena/-/merge_requests/49641Add hardcoded trigger lists to 21.22022-01-14T15:43:46+01:00Jon BurrAdd hardcoded trigger lists to 21.2A while back (!47188) we added some hardcoded Run2 triggers that were missed by the API but used by analyses to the DF-level trigger matching in release 22. This just adds the same lists into release 21.2.
@tadej, @jcatmoreA while back (!47188) we added some hardcoded Run2 triggers that were missed by the API but used by analyses to the DF-level trigger matching in release 22. This just adds the same lists into release 21.2.
@tadej, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/49602Adding truth level conversion radius information in TOPQ1 derivation2022-01-13T09:43:22+01:00Buddhadeb MondalAdding truth level conversion radius information in TOPQ1 derivationAdding truth level conversion radius information in the TOPQ1 derivation. This was requested from the ttW charge asymmetry analysis team.Adding truth level conversion radius information in the TOPQ1 derivation. This was requested from the ttW charge asymmetry analysis team.