athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-06-19T15:42:20+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63717fixBPHY23bug&&addphitoBPHY132023-06-19T15:42:20+02:00Hao PangfixBPHY23bug&&addphitoBPHY13Fix a BPHY23 bug and add new part (phi) to BPHY13Fix a BPHY23 bug and add new part (phi) to BPHY13https://gitlab.cern.ch/atlas/athena/-/merge_requests/63712removed old b-taggers in physics validation plotting2023-06-16T18:49:51+02:00Binbin Dongremoved old b-taggers in physics validation plottingRemoved old b-tagger in physics validation to fix the issue in [ATLSWUPGR-197](https://its.cern.ch/jira/browse/ATLSWUPGR-197) which was introduced by https://gitlab.cern.ch/atlas/athena/-/merge_requests/63581
tagging @tstreble, @ligang,...Removed old b-tagger in physics validation to fix the issue in [ATLSWUPGR-197](https://its.cern.ch/jira/browse/ATLSWUPGR-197) which was introduced by https://gitlab.cern.ch/atlas/athena/-/merge_requests/63581
tagging @tstreble, @ligang, @jcrosby, @ywng.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63554Add asserts for static analyzers2023-06-10T01:14:06+02:00Adam Edward BartonAdd asserts for static analyzersStatic analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.Static analyzers think these can be null and misidentify errors, so adding asserts to show nulls aren't possible.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63517Updating JETM7 DAOD scheme with missing trigger information2023-06-12T15:42:24+02:00Carlos Moreno MartinezUpdating JETM7 DAOD scheme with missing trigger informationIncluding missing trigger information in DAOD scheme JETM7, needed for trigger matching at the analysis level.
Tagging @sschramm @vcepaitiIncluding missing trigger information in DAOD scheme JETM7, needed for trigger matching at the analysis level.
Tagging @sschramm @vcepaitihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63247Add truth track jets into STDM132023-06-06T09:42:14+02:00Miha Muskinjamiha.muskinja@cern.chAdd truth track jets into STDM13This MR adds additional truth jet collections into the STDM13 derivation. This is needed for the new charm quark fragmentation function measurement. I ran a local test over the entire `mc16_13TeV.700338.Sh_2211_Wenu_maxHTpTV2_BFilter.rec...This MR adds additional truth jet collections into the STDM13 derivation. This is needed for the new charm quark fragmentation function measurement. I ran a local test over the entire `mc16_13TeV.700338.Sh_2211_Wenu_maxHTpTV2_BFilter.recon.AOD.e8351_s3126_r9364/AOD.26349758._000141.pool.root` file. Here is the size comparison of old vs new STDM13.
# Old
```
******************************************************************************
*Tree :CollectionTree: CollectionTree *
*Entries : 19492 : Total = 10232951533 bytes File Size = 2665233715 *
* : : Tree compression factor = 3.84 *
******************************************************************************
```
# New
```
******************************************************************************
*Tree :CollectionTree: CollectionTree *
*Entries : 19492 : Total = 10478040042 bytes File Size = 2702015203 *
* : : Tree compression factor = 3.88 *
******************************************************************************
```
The size has increased by roughly 1.5%. These are the new truth-jet branches for `R = 0.4`. They are all repeated for `R = [0.6, 0.8, 1.0]`.
```
*............................................................................*
*Br 123 :AntiKt4TruthChargedJets : DataVector<xAOD::Jet_v1> *
*Entries : 19492 : Total Size= 406594 bytes File Size = 79554 *
*Baskets : 128 : Basket Size= 14848 bytes Compression= 5.07 *
*............................................................................*
*Br 148 :AntiKt4TruthChargedJetsAux. : xAOD::JetAuxContainer_v1 *
*Entries : 19492 : Total Size= 37927750 bytes File Size = 6272628 *
*Baskets : 137 : Basket Size= 1230336 bytes Compression= 6.05 *
*............................................................................*
*Br 482 :AntiKt4TruthChargedJetsAuxDyn.ConeTruthLabelID : vector<int> *
*Entries : 19492 : Total Size= 879406 bytes File Size = 168802 *
*Baskets : 128 : Basket Size= 8704 bytes Compression= 5.19 *
*............................................................................*
*Br 483 :AntiKt4TruthChargedJetsAuxDyn.HadronConeExclTruthLabelID : *
* | vector<int> *
*Entries : 19492 : Total Size= 880726 bytes File Size = 169801 *
*Baskets : 128 : Basket Size= 8704 bytes Compression= 5.17 *
*............................................................................*
*Br 484 :AntiKt4TruthChargedJetsAuxDyn.PartonTruthLabelID : vector<int> *
*Entries : 19492 : Total Size= 879670 bytes File Size = 117748 *
*Baskets : 128 : Basket Size= 8704 bytes Compression= 7.45 *
*............................................................................*
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/63202Fix absence of trigger menu information in IDTIDE metadata2023-05-23T17:10:29+02:00Marcus Vinicius Gonzalez RodriguesFix absence of trigger menu information in IDTIDE metadataAn absence of trigger menu information in DAOD_IDTIDE was reported in https://its.cern.ch/jira/browse/ATLIDTRKCP-468 when using latest r23.
This issue has now been solved.An absence of trigger menu information in DAOD_IDTIDE was reported in https://its.cern.ch/jira/browse/ATLIDTRKCP-468 when using latest r23.
This issue has now been solved.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63102restore TruthMetaData in EGAM derivations2023-05-17T20:53:21+02:00Giovanni Marchiorirestore TruthMetaData in EGAM derivationsApply to EGAM derivations same fix for PHYS as in !63100
We are waiting for a cache to do an urgent production of two new formats for egamma performance in HIApply to EGAM derivations same fix for PHYS as in !63100
We are waiting for a cache to do an urgent production of two new formats for egamma performance in HIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63100Restoring TruthMetaData to PHYS/PHYSLITE2024-03-25T13:23:57+01:00James CatmoreRestoring TruthMetaData to PHYS/PHYSLITEA side effect of !61980 is the requirement to explicitly list the metadata categories for each output stream. This wasn't done for truth metadata for PHYS/PHYSLITE. This MR rectifies this.A side effect of !61980 is the requirement to explicitly list the metadata categories for each output stream. This wasn't done for truth metadata for PHYS/PHYSLITE. This MR rectifies this.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62913Fix PHYSVAL config metadata (ATLSWUPGR-191)2023-05-09T16:12:56+02:00Thomas StreblerFix PHYSVAL config metadata (ATLSWUPGR-191)Follow up to !61980. This is apparently the only derivation format where the `createMetadata` argument was missing in the config.
Labelling as ~urgent as it makes Upgrade ART test crash in ~master (ATLSWUPGR-191)
FYI @maszymanFollow up to !61980. This is apparently the only derivation format where the `createMetadata` argument was missing in the config.
Labelling as ~urgent as it makes Upgrade ART test crash in ~master (ATLSWUPGR-191)
FYI @maszymanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62894Add PromptLeptonImprovedVeto to STDM132023-05-12T12:12:28+02:00Evgeny SoldatovAdd PromptLeptonImprovedVeto to STDM13This modifies STDM13 and adds PromptLeptonImprovedVeto isolation variables into the derivation.This modifies STDM13 and adds PromptLeptonImprovedVeto isolation variables into the derivation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62771Fix FtagDerivationConfig2023-04-29T08:36:41+02:00Thomas StreblerFix FtagDerivationConfigFix interference between !62356 and !62544Fix interference between !62356 and !62544https://gitlab.cern.ch/atlas/athena/-/merge_requests/62623Updated HION9 including R=0.4 triggers and removing jet constituents.2023-05-04T21:42:32+02:00Anabel RomeroUpdated HION9 including R=0.4 triggers and removing jet constituents.Updated HION9 to include the R=0.4 triggers and remove the jet constituents.Updated HION9 to include the R=0.4 triggers and remove the jet constituents.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62572V0Finder: Avoid unnecessary looping2023-04-24T21:42:16+02:00Adam Edward BartonV0Finder: Avoid unnecessary loopingSpeeds up some derivations
cc @bouhovaSpeeds up some derivations
cc @bouhovahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62569xAODBTaggingEfficiency: fix build failure in AnalysisBase2023-04-24T14:59:48+02:00Frank WinklmeierxAODBTaggingEfficiency: fix build failure in AnalysisBaseAdd missing include.
cc @ssnyderAdd missing include.
cc @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62562Derivations BPHY: Clean up code and warning in VertexTrackIsolation2023-04-25T15:42:40+02:00Adam Edward BartonDerivations BPHY: Clean up code and warning in VertexTrackIsolation- Removed an unnecessary warning.
- Additional clean ups- Removed an unnecessary warning.
- Additional clean upshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62403DerivationFrameworkMCTruth: adding DSIDs to the list for heavy flavour origin...2023-04-18T15:42:26+02:00Roman LysakDerivationFrameworkMCTruth: adding DSIDs to the list for heavy flavour origin classifierThere are newly produced ttbb samples with pT hard variations (https://its.cern.ch/jira/browse/ATLMCPROD-10527).
ttH analysis (ANALYSISTO-1304) needs these samples to require HF information.
This update adds the datasets IDs for ttbb s...There are newly produced ttbb samples with pT hard variations (https://its.cern.ch/jira/browse/ATLMCPROD-10527).
ttH analysis (ANALYSISTO-1304) needs these samples to require HF information.
This update adds the datasets IDs for ttbb samples from the above ticket to the filter list for the the heavy-flavour hadron decoration tools in the truth derivation framework.
tagging: @calpigia @boeriuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62402Adding loose single electron trigger to STDM trigger list2023-04-28T09:42:21+02:00Lisa Marie BaltesAdding loose single electron trigger to STDM trigger listAdding loose single electron trigger to STDM trigger list.Adding loose single electron trigger to STDM trigger list.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62042Adding R/D handles for TruthQGDecorationTool, fixing bug in TruthIsolationTool2023-04-04T15:22:07+02:00James CatmoreAdding R/D handles for TruthQGDecorationTool, fixing bug in TruthIsolationToolATLASG-2470
This MR provides read and decor handles to the TruthQGDecorationTool, a pre-requisite for running DAOD building in AthenaMT. It also fixes a bug in TruthIsolationTool introduced in !61926 where the name of the parent contain...ATLASG-2470
This MR provides read and decor handles to the TruthQGDecorationTool, a pre-requisite for running DAOD building in AthenaMT. It also fixes a bug in TruthIsolationTool introduced in !61926 where the name of the parent container was missed for the decor handles, leading to the decorations being orphaned.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61958[FTAG] add flipped GNN taggers to output and fix flipping logic2023-04-01T20:51:48+02:00Philipp Gadow[FTAG] add flipped GNN taggers to output and fix flipping logicThis MR modifies the flipped tagger logic for all GNN flavour tagging algorithms. It further adds the flipped GN1 and GN2 scores to the output in derivations, so that studies of the flipped taggers become possible.
This MR is taking the...This MR modifies the flipped tagger logic for all GNN flavour tagging algorithms. It further adds the flipped GN1 and GN2 scores to the output in derivations, so that studies of the flipped taggers become possible.
This MR is taking the changes which @yinmiao introduced in https://gitlab.cern.ch/atlas/athena/-/merge_requests/61905 and targets `23.0` (and not master). We decided to open a new MR to have it cleaner.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61914Workaround jet CA reordering by flattening the accumulator and returning depe...2023-04-19T19:25:18+02:00Tadej Novaktadej.novak@cern.chWorkaround jet CA reordering by flattening the accumulator and returning dependencies as isWorkaround jet CA reordering by introducing CA flattening:
- only for parallel sequences (we could limit ourselves even more)
- also add `popEventAlgo`
- there's one place for legacy where the CA is still unmerged, but I did not want to ...Workaround jet CA reordering by introducing CA flattening:
- only for parallel sequences (we could limit ourselves even more)
- also add `popEventAlgo`
- there's one place for legacy where the CA is still unmerged, but I did not want to refactor the config more
I did not test the output but derivations now run without complaints.
/cc @tbold @fwinkl @tamartin @wlampl @delsart @cdelitzs @jcatmore @jchapman