athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-10-10T21:46:02+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/57370BPHY13 and BPHY23 update2022-10-10T21:46:02+02:00Xin ChenBPHY13 and BPHY23 updateBPHY13: Remove "BPHY13RefittedPrimaryVertices" in the output file to avoid large vector size in the case of large number of candidates, and reduce "MaxPVrefit" to 20.
BPHY13 and BPHY23: Added "MuonSegments" in the output file for LowPt ...BPHY13: Remove "BPHY13RefittedPrimaryVertices" in the output file to avoid large vector size in the case of large number of candidates, and reduce "MaxPVrefit" to 20.
BPHY13 and BPHY23: Added "MuonSegments" in the output file for LowPt muon ID.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57322HION13 updated trigger list2022-10-07T21:44:52+02:00Minyu FengHION13 updated trigger listUpdated trigger list for HION13Updated trigger list for HION13Minyu FengMinyu Fenghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57249VKalVrt: Remove redundant line2022-10-05T21:43:08+02:00Adam Edward BartonVKalVrt: Remove redundant lineIt is probably optimized out, but this line is confusing and shouldn't be there.It is probably optimized out, but this line is confusing and shouldn't be there.https://gitlab.cern.ch/atlas/athena/-/merge_requests/57196TauP6 update2022-10-03T21:42:56+02:00Lianyou ShanTauP6 updateAdd the MetaData of H3Weight and the copy of original TauJet container, upon request from physics analyzers/users. It has been locally test with latest 21.2. Especially the increasing of dAOD size is ignoble.Add the MetaData of H3Weight and the copy of original TauJet container, upon request from physics analyzers/users. It has been locally test with latest 21.2. Especially the increasing of dAOD size is ignoble.Lianyou ShanLianyou Shanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57167Modify the selection for the derivation HDBS52022-10-13T13:43:04+02:00Boping ChenModify the selection for the derivation HDBS5Hello,
We hope to change the selection for the derivation HDBS5 to get a higher signal efficiency. This is the previous merge request for this derivation:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/56685
And the jira ticket f...Hello,
We hope to change the selection for the derivation HDBS5 to get a higher signal efficiency. This is the previous merge request for this derivation:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/56685
And the jira ticket for this new derivation:
https://its.cern.ch/jira/browse/ATLHDBSDPD-129
With this update, the data efficiency changes from 1.6% to 1.8%, and the MC dominant background efficiency increases from 10% to 11.5%. The size of each event is similar to before. Thanks!
@gninio @lpascual @calpigiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57146NewHIGG4D2AddingVRTrackJets2022-09-30T21:43:04+02:00Liangliang HanNewHIGG4D2AddingVRTrackJetsIn this merge request, we made slight changes to the current HIGG4D2 format to make it include the AntiKtVR30Rmax4Rmin02TrackJets object.
**Only 3 lines that were modified:**
1. https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAna...In this merge request, we made slight changes to the current HIGG4D2 format to make it include the AntiKtVR30Rmax4Rmin02TrackJets object.
**Only 3 lines that were modified:**
1. https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs/python/HIGG4DxSlimming.py#L184, modify: ['HIGG4D3', 'HIGG4D6'] --> ['HIGG4D2', 'HIGG4D3', 'HIGG4D6']\
2. https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs/share/HIGG4D2.py#L84 , add: DerivationFrameworkHiggs.HIGG4DxAugmentation.addVRJetsAndBTagging(DAOD_StreamID, HIGG4D2Sequence)\
3. https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore/python/AllVariablesDisallowed.py#L7 ,comment out the line 7
**We also did a local test, where we used one AOD sample (including 10000 events) as input, then locally run the derivation respectively with default HIGG4D2 format and the new HIGG4D2 format**
1. Got reasonable DAOD output after the new HIGG4D2 format derivation, and we found that the AntiKtVR30Rmax4Rmin02TrackJets was stored.
2. Concerning output file size, 11.5MB for the default HIGG4D2 format, 12.3MB for the new HIGG4D2 formatCristiano AlpigianiDaniel ScheirichCristiano Alpigianihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57030JETM6 UFO-PFlow links2022-10-10T09:55:26+02:00Jennifer RoloffJETM6 UFO-PFlow linksThis MR adds the PFOs associated to UFOs, so that the links can be used in tagging studies. @kgreif has tested the output to make sure that he is able to access the linked PFOs, and that things behave as expected.
This change is expecte...This MR adds the PFOs associated to UFOs, so that the links can be used in tagging studies. @kgreif has tested the output to make sure that he is able to access the linked PFOs, and that things behave as expected.
This change is expected to increase the size of JETM6 by around 1%, as tested on a data and MC sample. This has been discussed with the conveners, who are happy with this.
Tagging @mswiatlo @mleblanc @camacho @brle @jcantero @tnobe @cdelitzshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56976Fix cascade vertex fit2022-09-24T09:43:05+02:00Vadim KostyukhinFix cascade vertex fitFix divergence in combined track creation causing an infinite loop in productionFix divergence in combined track creation causing an infinite loop in productionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56971UFO energy per layer2023-01-26T19:22:17+01:00Jennifer RoloffUFO energy per layerThis MR provides the energy per layer information for UFOs, and adds it to JETM1. This is necessary for deriving the GSC/GNNC with these jets, which is why this is labeled urgent.
Currently, the energy per layer is computed for all UFOs...This MR provides the energy per layer information for UFOs, and adds it to JETM1. This is necessary for deriving the GSC/GNNC with these jets, which is why this is labeled urgent.
Currently, the energy per layer is computed for all UFOs where there is a cluster linked to any PFOs used to build the UFO. As far as I can tell, we have this information for neutral and combined UFOs, but not the UFOs made from charged PFO.
I have done some basic checks on the output, and it looks like the sum of the energy per layer typically adds up to around 33%, which makes sense if we are missing the charged PFO components.
Tagging @mswiatlo @mleblanc @camacho @cdelitzs @mspalla @haweberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56941DerivationBPHYS: Attempt to fix memory leak coming from InDetTrackSelectionTool2022-09-23T09:43:23+02:00Adam Edward BartonDerivationBPHYS: Attempt to fix memory leak coming from InDetTrackSelectionToolATLASDPD-1739 Sees large memory leaks coming from some cascade classes. Valgrind tests suggest it is caused by the use of the track selector tool on the stack.ATLASDPD-1739 Sees large memory leaks coming from some cascade classes. Valgrind tests suggest it is caused by the use of the track selector tool on the stack.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56937Updates to HION12 derivation for PC stream data2022-09-23T09:43:20+02:00Benjamin Jacob GilbertUpdates to HION12 derivation for PC stream dataI fixed the name of one trigger and added another so this derivation will work on files from the Heavy Ion PC stream.
Tagging @kburka for Heavy Ion derivation managementI fixed the name of one trigger and added another so this derivation will work on files from the Heavy Ion PC stream.
Tagging @kburka for Heavy Ion derivation managementBenjamin Jacob GilbertBenjamin Jacob Gilberthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56918New rho definitions and refining no pT jet container names2022-09-25T15:00:21+02:00Chris Malena DelitzschNew rho definitions and refining no pT jet container namesThis MR adds a new rho definition that the Jet/Etmiss group would like to study for R = 0.4 UFO CSSK jets and changes the names of the no pT cut containers.
The changes here should have **zero impact** on PHYS, etc and only change the ...This MR adds a new rho definition that the Jet/Etmiss group would like to study for R = 0.4 UFO CSSK jets and changes the names of the no pT cut containers.
The changes here should have **zero impact** on PHYS, etc and only change the content of specific JETMX formats.
Tagging @mswiatlo @camacho @mleblanc @haweber @mspalla
Tagging also @calpigia as he was informed already that there is another MR coming in :smile:
Marking this as urgent so that it can make it into the next release hopefully!Nils Erik KrumnackNils Erik Krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56881Updating CDI and xAODBTaggingEfficiency with new systematic strategy2023-01-10T12:49:03+01:00Waltteri LeinonenUpdating CDI and xAODBTaggingEfficiency with new systematic strategy# Updating CDI + xAODBTaggingEfficiency with new systematic strategy
This MR is taken as part of my qualification task in the flavour tagging group, AFT-578
### What's the change?
In the current eigenvector decomposition systematic str...# Updating CDI + xAODBTaggingEfficiency with new systematic strategy
This MR is taken as part of my qualification task in the flavour tagging group, AFT-578
### What's the change?
In the current eigenvector decomposition systematic strategy (`SFEigen`), bin-to-bin correlations are captured for each jet-flavor in a CDI file, and reduced to a far smaller set of so-called eigenvector variations through a PCA procedure. This update enables users to perform a "global" bin-to-bin correlation across all jet-flavors simultaneously, and extract eigenvector variations that represent these correlations.
This systematic strategy can be selected in the `xAODBTaggingEfficiencyTool` by setting the "SystematicStrategy" property of the tool to `SFGlobalEigen`, for either a fixed-cut or pseudo-continuous working point.
### How can we validate the method?
The `SystematicStrategyComparison` utility can be used with the `validate_reduction` function of the `CalibrationEigenVariations.cxx` file in order to perform these validation studies on a given (set of) CDI file(s) and working point(s). Validation studies on this method were presented in the [FTAG Software Meeting here](https://indico.cern.ch/event/1172994/). Further documentation of the work can be found in the [FTAG Documentation](https://ftag-docs.docs.cern.ch/cdi/).https://gitlab.cern.ch/atlas/athena/-/merge_requests/56807Add new links between global FE and CP Objects (Second Attempt)2022-09-22T17:03:05+02:00Mark HodgkinsonAdd new links between global FE and CP Objects (Second Attempt)This MR fixes a bug in the MET reconstruction - currently for example it takes a link from an electron to FE and looks up the FE index. Then it assumes that index is valid in the global FE container - that assumption is invalid. The MR f...This MR fixes a bug in the MET reconstruction - currently for example it takes a link from an electron to FE and looks up the FE index. Then it assumes that index is valid in the global FE container - that assumption is invalid. The MR fixes this by creating new links between global FE and electron/photon/muon/taus and then updates the MET c++ code to use these links.
Configuration is added to remove these new global links, and associated variables, from the AOD/ESD - the global FE are not written to either ESD or AOD, so any associated decorations related to this would be useless.
This MR should not violate FT0V in that the AOD contents will not change. The ESD contents, which includes MET, will change because the MET output changes. Therefore eventually when this goes to master it is expected the MET content in PHYS and PHYSLite will change @jcatmore. Can you provide an example Reco_tf command I can use to check if any additional derivation specific config changes are required (this will be the case, if neither RecExCommon nor RecoSteering are used - we would find MET crashes when it does not find these new global links)? Given we don't run derivations in 22.0, I would propose to address this in a separate MR for master once this sweeps there.
Cheers,
Markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56788PFlow Updates to Run MET in Derivations2022-09-22T10:50:18+02:00Mark HodgkinsonPFlow Updates to Run MET in DerivationsThis adds configuration needed to create new decorations that MET reconstruction needs. Some updates are also done to the muon and tau FlowElement association tools to avoid crashes when running from AOD (a workflow not exercised until n...This adds configuration needed to create new decorations that MET reconstruction needs. Some updates are also done to the muon and tau FlowElement association tools to avoid crashes when running from AOD (a workflow not exercised until now).
The new MET reconstruction is available in this MR https://gitlab.cern.ch/atlas/athena/-/merge_requests/56622 for 22.0 and will then sweep to master. Once the latter happens MET reconstruction will crash in derivations without this MR, so ideally it would go in simultaneously.
Thanks,
Markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56781Added MuonSegments container to heavy-ion derivation HION132022-09-20T09:42:57+02:00Minyu FengAdded MuonSegments container to heavy-ion derivation HION13New container "MuonSegments" added to implement muon LowPtMVA working point for analysis purpose.
Changed file: PhysicsAnalysis/DerivationFramework/DerivationFrameworkHI/share/HION13.pyNew container "MuonSegments" added to implement muon LowPtMVA working point for analysis purpose.
Changed file: PhysicsAnalysis/DerivationFramework/DerivationFrameworkHI/share/HION13.pyMinyu FengMinyu Fenghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56772Adding Run-3 jet triggers to JETM12022-09-19T17:51:43+02:00Chris Malena DelitzschAdding Run-3 jet triggers to JETM1The TriggerAPI is currently not returning all the jet triggers used in Run-3. To allow for e.g. further jet trigger studies and to get all events needed for jet calibrations, we are adding those triggers by hand for the moment such that ...The TriggerAPI is currently not returning all the jet triggers used in Run-3. To allow for e.g. further jet trigger studies and to get all events needed for jet calibrations, we are adding those triggers by hand for the moment such that those changes can be included in 23.0.5 until the TriggerAPI is fixed.
Tagging @cantel @ayana @mswiatlo @camacho @sawyer @schaarsc @calpigiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56685Create new derivation HDBS5 for H->aa->yytautau analysis2022-09-29T22:55:37+02:00Boping ChenCreate new derivation HDBS5 for H->aa->yytautau analysisThis is a request to add a new HDBS5 derivation stream in the DerivationFrameworkHDBS, aiming for the H->aa->2y+2tau analysis, where a dedicated low pT boosted ditau object is used, for the boosted topology in the final state. The reques...This is a request to add a new HDBS5 derivation stream in the DerivationFrameworkHDBS, aiming for the H->aa->2y+2tau analysis, where a dedicated low pT boosted ditau object is used, for the boosted topology in the final state. The requested derivation "inherits" from the TAUP5 derivation, where the low pT boosted ditau object is used for the first time.
Here is the Jira ticket for this request:
https://its.cern.ch/jira/browse/ATLHDBSDPD-129
Here is the original TAUP5 derivation Jira ticket, where the only difference is that we've added diphoton triggers to the existing high pT photon triggers:
https://its.cern.ch/jira/browse/ATLTAU-1389
Here is the glance page for the analysis:
https://atlas-glance.cern.ch/atlas/analysis/analyses/details.php?id=7458
We tested the derivation efficiency for DiphotonBoosted (DSID 364397), our dominant background, for mc16e only. The efficiency is about 10%, so the total number of events for mc16e would be about 9e6.
For data, we tested data18 only. The efficiency is about 1.6%.
The size of the DAOD is around 0.094MB per event for data and 0.106MB per event for MC.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56506Create new derivation HDBS5 for H->aa->yytautau analysis2022-09-13T09:07:43+02:00Boping ChenCreate new derivation HDBS5 for H->aa->yytautau analysisCreate new derivation HDBS5 for H->aa->yytautau analysis
Jira ticket for the new derivation:
https://its.cern.ch/jira/browse/ATLHDBSDPD-129
@gninio @calpigiaCreate new derivation HDBS5 for H->aa->yytautau analysis
Jira ticket for the new derivation:
https://its.cern.ch/jira/browse/ATLHDBSDPD-129
@gninio @calpigiaBoping ChenBoping Chenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/56448Fixing a bug which causes some containers to be omitted from CA-produced DAODs2022-09-02T15:44:19+02:00James CatmoreFixing a bug which causes some containers to be omitted from CA-produced DAODsThis MR fixes a bug in `TrigNavSlimmingMTConfig.py` which, whilst trying to add trigger-related containers to the slimming dictionary, in fact overwrites it. The slimming dictionary is used to map interface and aux containers and their t...This MR fixes a bug in `TrigNavSlimmingMTConfig.py` which, whilst trying to add trigger-related containers to the slimming dictionary, in fact overwrites it. The slimming dictionary is used to map interface and aux containers and their types, and only containers appearing in it will be written to the DAODs, so in princple all of the overwritten containers would be dropped from the DAOD. However, many of the overwritten containers were then restored via the ContainersOnTheFly content, but anything not in this list was finally dropped.
The MR makes two changes:
- fixes the dictionary over-write by using the `update` method
- adds several truth containers, which are now part of the common physics content, to the `ContainersOnTheFly.py` list, meaning they don't have to be explicitly added in the format definition
With this change in place the expected containers are restored. The problematic script is only used in the component accumulator version of the derivation framework, so this only impacts DAODs made by the component accumulator (still under validation), so existing production was not impacted.