athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-11T14:43:11+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67670Restore mergeIteratively2TrackVtxs in LeptonTaggers2023-12-11T14:43:11+01:00Kees BenkendorferRestore mergeIteratively2TrackVtxs in LeptonTaggersWhen the original port of LeptonTaggers was completed from r21 (!66768), the function `mergeIteratively2TrackVtxs` was removed from execution because of memory management problems. This MR fixes the memory management in `mergeIteratively...When the original port of LeptonTaggers was completed from r21 (!66768), the function `mergeIteratively2TrackVtxs` was removed from execution because of memory management problems. This MR fixes the memory management in `mergeIteratively2TrackVtxs` and restores it in execution. This should be the last major piece of LeptonTaggers that needs to be restored for now.
This MR should only be merged after !67642. I'm making this a new MR because I anticipate that the fixes will be somewhat involved, and I want to make review easy for the shifters.
Tagging @mvanadia @nbruscin @nicolaid @kzochKees BenkendorferKees Benkendorferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67649Adding small-R UFO jets with pT > 7 GeV cut to JETM3/JETM4 (incl. smart slimm...2023-12-08T10:06:26+01:00Chris Malena DelitzschAdding small-R UFO jets with pT > 7 GeV cut to JETM3/JETM4 (incl. smart slimming list)I think the title says it all :) Needed to derive consolidated Jet/Etmiss recommendations. The smart slimming list contains the same variables as the PFlow smart slimming list for the moment.
Tagging @dcamarer @mdiamantI think the title says it all :) Needed to derive consolidated Jet/Etmiss recommendations. The smart slimming list contains the same variables as the PFlow smart slimming list for the moment.
Tagging @dcamarer @mdiamanthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67643Protect vertex momentum and sumPt decoration to avoid overwriting locked store2023-12-07T14:24:24+01:00Thomas StreblerProtect vertex momentum and sumPt decoration to avoid overwriting locked storeNot needed so far as those variables are only computed once in this algorithm but adding check for safety and consistency with sumPt2. Follow up to !66883
FYI @tamartin @longjonNot needed so far as those variables are only computed once in this algorithm but adding check for safety and consistency with sumPt2. Follow up to !66883
FYI @tamartin @longjonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67642Fix decoration warnings in LeptonTaggers2023-12-08T10:21:05+01:00Kees BenkendorferFix decoration warnings in LeptonTaggersThe partial port of LeptonTaggers from r21 (!66768) continues. This MR fixes several warnings about lepton variables not being decorated, usually by restoring the decorator functionality.
This MR should only be merged after !67496
Tag...The partial port of LeptonTaggers from r21 (!66768) continues. This MR fixes several warnings about lepton variables not being decorated, usually by restoring the decorator functionality.
This MR should only be merged after !67496
Tagging @mvanadia @nbruscin @nicolaid @kzochKees BenkendorferKees Benkendorferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67628Make Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as ...2024-01-08T15:56:19+01:00Tadej Novaktadej.novak@cern.chMake Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as they are used as listMake `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC chann...Make `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC channel number handling in some derivation code as it was used incorrectly.
/cc @jchapman @nstyles @jcatmore @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67625Use AtlasPID functions for the Generator Filters2023-12-08T19:15:07+01:00Andrii VerbytskyiUse AtlasPID functions for the Generator FiltersUse AtlasPID functions for the Generator FiltersUse AtlasPID functions for the Generator Filtershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67616Derivation, remove TauMVATESJets collection - outdated2023-12-06T11:48:18+01:00Antonio De MariaDerivation, remove TauMVATESJets collection - outdatedThis MR is going to remove the "TauMVATESJets" collection and the list of additional variables in it.
This collection was used long time ago for the tau MVATES validation in special sample production, but currently should not be useful a...This MR is going to remove the "TauMVATESJets" collection and the list of additional variables in it.
This collection was used long time ago for the tau MVATES validation in special sample production, but currently should not be useful anymore. Only instance found is in MUON5 derivation, but no mention of this derivation stream in https://twiki.cern.ch/twiki/bin/view/AtlasProtected/MCPDxAOD#Trigger_list_update
MR contains also additional cleaning for TAUP derivation which have been removed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/67367
Tagging @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67600Optimise JETM7 size2023-12-08T10:34:46+01:00Vilius CepaitisOptimise JETM7 sizeThis MR optimises the content of the JETM7 derivation, bringing it to a significantly smaller size (35 kb/event) than its R21.2 equivalent (60 kb/event)This MR optimises the content of the JETM7 derivation, bringing it to a significantly smaller size (35 kb/event) than its R21.2 equivalent (60 kb/event)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67592Add GN2v01 to derivations2024-02-12T16:43:17+01:00Dan GuestAdd GN2v01 to derivationsThis adds GN2v01, our (hopefully) recommended b-tagger for 2024, to derivations (including PHYS). There should be no other changes.
Detailed notes:
- I added the b-tagging NN files to the list of b-tagging flags, so that we can experime...This adds GN2v01, our (hopefully) recommended b-tagger for 2024, to derivations (including PHYS). There should be no other changes.
Detailed notes:
- I added the b-tagging NN files to the list of b-tagging flags, so that we can experiment with these more easily.
- I also cleaned up the smart slimming lists for b-tagging a bit. They should be the same (except with the addition of GN2v01) but less copypasta.
To do:
- [x] Make sure it runs
- [x] Add the output variables to PHYS (not needed until we have the final training, but could add them preemptively)
Tagging @hartman, @svanstro, @bdong, @ligang, @fdibellohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67576Fix list assignment in LLP1 config2023-12-05T13:37:07+01:00Thomas StreblerFix list assignment in LLP1 configFixes LLP1 failure
```
05:21:44 TypeError: list or tuple expected, got {'GhostLCTopoOrigin'} in assignment to GhostConstitNames
```
Probably related to some Gaudi updateFixes LLP1 failure
```
05:21:44 TypeError: list or tuple expected, got {'GhostLCTopoOrigin'} in assignment to GhostConstitNames
```
Probably related to some Gaudi updatehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67563Replace PID functions in DeviationFramework with TruthUtils functions2023-12-06T11:46:17+01:00Andrii VerbytskyiReplace PID functions in DeviationFramework with TruthUtils functionsReplace PID functions in DeviationFramework with TruthUtils functions
@pclark @jchapmanReplace PID functions in DeviationFramework with TruthUtils functions
@pclark @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67539Wrap the single particle barcode 100012023-12-04T19:00:15+01:00Andrii VerbytskyiWrap the single particle barcode 10001Wrap the single particle barcode 10001:
- add a function that should detect single particles
- add a magic number
@jchapman @pclark @christosWrap the single particle barcode 10001:
- add a function that should detect single particles
- add a magic number
@jchapman @pclark @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67537Fix HI btagging configuration2023-12-02T05:39:27+01:00Sebastian Tapia ArayaFix HI btagging configurationcorrect configuration of btagging for Heavy-Ions reconstruction modes
Fix [ATLASRECTS-7780](https://its.cern.ch/jira/browse/ATLASRECTS-7780)correct configuration of btagging for Heavy-Ions reconstruction modes
Fix [ATLASRECTS-7780](https://its.cern.ch/jira/browse/ATLASRECTS-7780)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67511Residual Pull calculator. Use optional value instead of unique_ptr2023-12-03T16:44:57+01:00Christos Anastopouloschristos.anastopoulos@cern.chResidual Pull calculator. Use optional value instead of unique_ptrResidual Pull calculator.
Use optional value instead of unique_ptrResidual Pull calculator.
Use optional value instead of unique_ptrhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67496first test of using LeptonTaggers in MUON52023-12-07T14:24:53+01:00Marco Vanadiafirst test of using LeptonTaggers in MUON5The MR make use of LeptonTaggers defined in https://gitlab.cern.ch/atlas/athena/-/merge_requests/66768 in MUON5.
Thanks to @kbenkend the MR now fixes a bunch of warning when using LeptonTaggers.The MR make use of LeptonTaggers defined in https://gitlab.cern.ch/atlas/athena/-/merge_requests/66768 in MUON5.
Thanks to @kbenkend the MR now fixes a bunch of warning when using LeptonTaggers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67495DerivationFrameworkMCTruth: adding yet another DSIDs to the list for heavy fl...2023-12-05T10:58:42+01:00Roman LysakDerivationFrameworkMCTruth: adding yet another DSIDs to the list for heavy flavour origin classifiersimilarly as in MR67401, this MR adds 2 ttbar FSR samples to the HF list
tagging: @boeriusimilarly as in MR67401, this MR adds 2 ttbar FSR samples to the HF list
tagging: @boeriuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67481DerivationFramework: Adding TauJets_EleRM containers to DAOD_PHYS2023-12-01T19:25:56+01:00Qichen Dongqichen.dong@cern.chDerivationFramework: Adding TauJets_EleRM containers to DAOD_PHYSHi all,
Following the enablement of the `TauJets_EleRM` reconstruction in RAW2ALL. This one is to add the new containers to the DAOD_PHYS.
When trying to do this, we realised that some tracks were thinned by the `ThinTRTStandaloneTrack...Hi all,
Following the enablement of the `TauJets_EleRM` reconstruction in RAW2ALL. This one is to add the new containers to the DAOD_PHYS.
When trying to do this, we realised that some tracks were thinned by the `ThinTRTStandaloneTrackAlg` for the `TauJets_EleRM`. Resulting crashes for the downstream DAOD production. I have put in a separate MR !67480 that fix this issue.
Marked as draft before we fix that.
Cheers, DongQichen Dongqichen.dong@cern.chQichen Dongqichen.dong@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67475Use assignment operator for TruthParticle2023-12-04T18:58:10+01:00Andrii VerbytskyiUse assignment operator for TruthParticleUse assignment operator for TruthParticle
@akraszna, please have alook if that makes sense to you.Use assignment operator for TruthParticle
@akraszna, please have alook if that makes sense to you.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67459Provide an example of setting ExtraDataForDynamicConsumers in a DAOD job with...2023-12-04T04:08:02+01:00James CatmoreProvide an example of setting ExtraDataForDynamicConsumers in a DAOD job with string parsingThis amends the TEST2 example DAOD format to demonstrate how to set ExtraDataForDynamicConsumers in a job that uses ExpressionEvaluation. This is necessary when the relevant containers being accessed by ExpressionEvaluation have not been...This amends the TEST2 example DAOD format to demonstrate how to set ExtraDataForDynamicConsumers in a job that uses ExpressionEvaluation. This is necessary when the relevant containers being accessed by ExpressionEvaluation have not been read in vias ReadHandles. This applies to skims of PHYS(LITE) and some HI DAODs, for example. It doesn't apply to PHYS(LITE) and many other DAOD formats due to the scheduling of common augmentations, which have already read in the relevant containers.
The TEST2 format is just an example and is never used in production so this MR will have no impact on any data products. The relevant lines will be used as a template in other formats.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67455HF Classifier Package.2023-12-19T11:10:28+01:00Adrian Berrocal GuardiaHF Classifier Package.A package with the tools to compute and add the HF classifier has been
created. The package is used in a new derivation format called TESTHF
which is like the PHYS format with the addition of the classifier.
However, the classifier does ...A package with the tools to compute and add the HF classifier has been
created. The package is used in a new derivation format called TESTHF
which is like the PHYS format with the addition of the classifier.
However, the classifier does not seem to be added properly.
Linking to ATLASG-2374.Zach MarshallJames CatmoreZach Marshall