athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-04-29T08:36:41+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/62771Fix FtagDerivationConfig2023-04-29T08:36:41+02:00Thomas StreblerFix FtagDerivationConfigFix interference between !62356 and !62544Fix interference between !62356 and !62544https://gitlab.cern.ch/atlas/athena/-/merge_requests/45355Fix FTAG physics validation code to avoid the attempt to retrieve nonexistent...2021-07-23T03:05:14+02:00Arnaud DuperrinFix FTAG physics validation code to avoid the attempt to retrieve nonexistent aux data item SMT_mu_linkThis MR fixes the b-tagging physics validation code to avoid the attempt to retrieve nonexistent aux data item SMT_mu_link.
Tagging as urgent since it is needed by physics validation group.
On recent DAOD_PHYSVAL input with p4666, runni...This MR fixes the b-tagging physics validation code to avoid the attempt to retrieve nonexistent aux data item SMT_mu_link.
Tagging as urgent since it is needed by physics validation group.
On recent DAOD_PHYSVAL input with p4666, running the physics validation code (DAOD_PHYSVAL->NTUP_PHYSVAL) with doBtag leads to:
_PhysicsValidation 16:47:17 PhysValMonManager FATAL Standard std::exception is caught
PhysicsValidation 16:47:17 PhysValMonManager ERROR SG::ExcBadAuxVar: Attempt to retrieve nonexistent aux data item `::SMT_mu_link' (882).
PhysicsValidation 16:47:17 AthAlgSeq FATAL Standard std::excep_
SMT is deprecated, the "new" soft muon variables are all called "softMuon_*".
At the moment, SoftMu is turned off in FTAG code.
The fix has been tested on valid1:DAOD_PHYSVAL.26280787._000002.pool.root.1 using 2021-07-21T2101 (compiled with this [MR](https://gitlab.cern.ch/atlas/athena/-/merge_requests/45238)). The ouput on 500 events can be found [here](https://www.cppm.in2p3.fr/~duperrin/WORK/BtaggingValidationPackage/Fix_SoftMuLink/Histo_ttbar_doBTAG_fixMUlink/).
Tagging @jferrand who reported the issue, and @dhayden @juhofer @fbeisieg @cschiavi @vdao @sanmay @dguest for their awareness.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26814Fix H4l DSIDs2019-09-28T03:02:24+02:00Susumu OdaFix H4l DSIDshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67537Fix HI btagging configuration2023-12-02T05:39:27+01:00Sebastian Tapia ArayaFix HI btagging configurationcorrect configuration of btagging for Heavy-Ions reconstruction modes
Fix [ATLASRECTS-7780](https://its.cern.ch/jira/browse/ATLASRECTS-7780)correct configuration of btagging for Heavy-Ions reconstruction modes
Fix [ATLASRECTS-7780](https://its.cern.ch/jira/browse/ATLASRECTS-7780)https://gitlab.cern.ch/atlas/athena/-/merge_requests/45856Fix IDTIDE and IDTRKVALID content and conflicts when writing both.2021-08-24T13:32:03+02:00Goetz GayckenFix IDTIDE and IDTRKVALID content and conflicts when writing both.- fix configuration when writing both, IDTIDE and IDTRKVALID,
- fix detection whether IDTIDE or IDTRKVALID is written,
- re-add missing truth and SDO content when processing MC,
- re-add NN variables when writing IDTIDE,
- remove IDTIDE ...- fix configuration when writing both, IDTIDE and IDTRKVALID,
- fix detection whether IDTIDE or IDTRKVALID is written,
- re-add missing truth and SDO content when processing MC,
- re-add NN variables when writing IDTIDE,
- remove IDTIDE and IDTRKVALID track and truth particle decorations
from the AOD.
- remove btagging decorations from IDTIDE and IDTRKVALID.
Also addresses ATLIDTRKCP-371.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65584Fix IDTR2 config for data2023-10-06T16:36:00+02:00Thomas StreblerFix IDTR2 config for data`TrackSystematicsAlg` relies on some truth-related content so should only run on MC
FYI @jburzyns @gfrattar`TrackSystematicsAlg` relies on some truth-related content so should only run on MC
FYI @jburzyns @gfrattarhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58807Fix IDTR derivation after NVSI updates2022-12-01T21:43:11+01:00Jackson Carl BurzynskiFix IDTR derivation after NVSI updates* Fixes the CA-based `IDTR2` derivation which was broken after updates to the `NewVrtSecInclusiveAlg`.
* Fixes a typo in `NewVrtSecInclusiveAlg`
Tagging @calpigia* Fixes the CA-based `IDTR2` derivation which was broken after updates to the `NewVrtSecInclusiveAlg`.
* Fixes a typo in `NewVrtSecInclusiveAlg`
Tagging @calpigiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45396fix IDTRKVALID and IDTIDE for MC2021-07-27T03:04:10+02:00Maximilian Emanuel Goblirsch-Kolbfix IDTRKVALID and IDTIDE for MCThis MR adds two decorations to the output list for the DAOD_IDTRKVALID and IDTIDE formats, required for MC analysis.
Also address a possible typo in the IDTIDE config, and add protection in IDPVM to prevent an uninformative athena cras...This MR adds two decorations to the output list for the DAOD_IDTRKVALID and IDTIDE formats, required for MC analysis.
Also address a possible typo in the IDTIDE config, and add protection in IDPVM to prevent an uninformative athena crash in case we run on a derivation with a slimmed track content.
CC @goetz @sroe @vcairo @npettershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43500Fix in ElectronSelectorHelpers passAmbiguity2021-05-15T03:03:50+02:00Philip SommerFix in ElectronSelectorHelpers passAmbiguityThe passAmbiguity method in `ElectronSelectorHelpers` takes the requirement to cut on as a `uint8_t` bitword. Since we have nine ambiguity types in master, a `uint8_t` can't hold all possible cuts. So, let's better change that to a `uint...The passAmbiguity method in `ElectronSelectorHelpers` takes the requirement to cut on as a `uint8_t` bitword. Since we have nine ambiguity types in master, a `uint8_t` can't hold all possible cuts. So, let's better change that to a `uint16_t`.
Cheers,
Philiphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40205Fixing a bug in LHE3WeightMetadata.py2021-02-03T03:07:08+01:00Daniel ScheirichFixing a bug in LHE3WeightMetadata.pyThe inputFileSummary instance is not imported, making the try..except sequence always fail. As a consequence, the LHE3 sum-of-weights metadata are not saved. A simple fix is to import the inputFileSummary.The inputFileSummary instance is not imported, making the try..except sequence always fail. As a consequence, the LHE3 sum-of-weights metadata are not saved. A simple fix is to import the inputFileSummary.https://gitlab.cern.ch/atlas/athena/-/merge_requests/56448Fixing a bug which causes some containers to be omitted from CA-produced DAODs2022-09-02T15:44:19+02:00James CatmoreFixing a bug which causes some containers to be omitted from CA-produced DAODsThis MR fixes a bug in `TrigNavSlimmingMTConfig.py` which, whilst trying to add trigger-related containers to the slimming dictionary, in fact overwrites it. The slimming dictionary is used to map interface and aux containers and their t...This MR fixes a bug in `TrigNavSlimmingMTConfig.py` which, whilst trying to add trigger-related containers to the slimming dictionary, in fact overwrites it. The slimming dictionary is used to map interface and aux containers and their types, and only containers appearing in it will be written to the DAODs, so in princple all of the overwritten containers would be dropped from the DAOD. However, many of the overwritten containers were then restored via the ContainersOnTheFly content, but anything not in this list was finally dropped.
The MR makes two changes:
- fixes the dictionary over-write by using the `update` method
- adds several truth containers, which are now part of the common physics content, to the `ContainersOnTheFly.py` list, meaning they don't have to be explicitly added in the format definition
With this change in place the expected containers are restored. The problematic script is only used in the component accumulator version of the derivation framework, so this only impacts DAODs made by the component accumulator (still under validation), so existing production was not impacted.https://gitlab.cern.ch/atlas/athena/-/merge_requests/58419Fixing an issue introduced by recent changes to HIGG4D5 which was crashing ot...2022-11-15T21:43:26+01:00Cristiano AlpigianiFixing an issue introduced by recent changes to HIGG4D5 which was crashing other Higgs formatsThis MR fixes an issue introduced by !57982, whose purpose was to add the AntiKt4TruthDressedWZJets to HIGG4D5. However, effectively the AntiKt4TruthDressedWZJets were added by mistake to other Higgs formats causing the failure of HIGG4D...This MR fixes an issue introduced by !57982, whose purpose was to add the AntiKt4TruthDressedWZJets to HIGG4D5. However, effectively the AntiKt4TruthDressedWZJets were added by mistake to other Higgs formats causing the failure of HIGG4D6, HIGG6D2, and HDBS1 ARTs. With this MR, AntiKt4TruthDressedWZJets are added to HIGG4D5 only.
Local tests show that HIGG4D6, HIGG4D5, HDBS1 (and HIGG4D5) jobs are now running fine.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59848Fixing an oversight in a sharedWriter ART2023-01-17T21:43:01+01:00Cristiano AlpigianiFixing an oversight in a sharedWriter ARTAlthough I thought to have tripled checked the changes in !59803, I forgot to add the --CA option in one test :-/. This MR just fixes that oversight.Although I thought to have tripled checked the changes in !59803, I forgot to add the --CA option in one test :-/. This MR just fixes that oversight.https://gitlab.cern.ch/atlas/athena/-/merge_requests/54144Fixing a small issue in derivation PHYSVAL ART2022-08-15T16:24:25+02:00Cristiano AlpigianiFixing a small issue in derivation PHYSVAL ARTThis MR fixes just some file naming typos that are causing failures in the ART substeps.This MR fixes just some file naming typos that are causing failures in the ART substeps.https://gitlab.cern.ch/atlas/athena/-/merge_requests/37137Fixing a typo in DerivationFrameworkExotics2020-10-10T03:06:13+02:00Zach MarshallFixing a typo in DerivationFrameworkExoticsTypo caused by the last migration in !37023
Sorry for the trouble!Typo caused by the last migration in !37023
Sorry for the trouble!https://gitlab.cern.ch/atlas/athena/-/merge_requests/26155Fixing b-tagging bug in HIGG4D formats2019-08-28T03:03:19+02:00Daniel ScheirichFixing b-tagging bug in HIGG4D formatsATLASDPD-1334
Removed unsupported b-tagging collections and replaced by new ones:
* AntiKt4EMTopoJets_BTagging201810
* BTagging_AntiKt4EMTopo_201810
* AntiKt4EMPFlowJets_BTagging201810
* BTagging_AntiKt4EMPFlow_201810
* AntiKt4EMPFlowJ...ATLASDPD-1334
Removed unsupported b-tagging collections and replaced by new ones:
* AntiKt4EMTopoJets_BTagging201810
* BTagging_AntiKt4EMTopo_201810
* AntiKt4EMPFlowJets_BTagging201810
* BTagging_AntiKt4EMPFlow_201810
* AntiKt4EMPFlowJets_BTagging201903
* BTagging_AntiKt4EMPFlow_201903
The BTagging_AntiKt2Track collection previously stored in HIGG4D2, D3 and D6 formats removed for good.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26139Fixing b-tagging in JETMX derivations2019-08-27T03:02:43+02:00Chris Malena DelitzschFixing b-tagging in JETMX derivationsUpdating the JETM derivations to include the latest b-tagging changes according to [ATLASDPD-1334](https://its.cern.ch/jira/browse/ATLASDPD-1334). Hopefully the ART tests will run now.
Tagging a couple of people for their information: ...Updating the JETM derivations to include the latest b-tagging changes according to [ATLASDPD-1334](https://its.cern.ch/jira/browse/ATLASDPD-1334). Hopefully the ART tests will run now.
Tagging a couple of people for their information: @sschramm @cyoung @mswiatlo @jlorenz @miqueits @mleblanc @jveatch @loch @williams @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/26364Fixing b-tagging smart collections in HION42019-09-07T03:02:40+02:00Jakub KremerFixing b-tagging smart collections in HION4The b-tagging smart collections in the HION4 script are updated to
follow recent developments of the flavour tagging software and to
prevent crashes of ART tests.The b-tagging smart collections in the HION4 script are updated to
follow recent developments of the flavour tagging software and to
prevent crashes of ART tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40206Fixing bug preventing multiple jet truth labels being applied2021-02-03T16:40:50+01:00Jason Robert VeatchFixing bug preventing multiple jet truth labels being appliedThis fixes a bug that prevents more than one jet truth label definition to a collection in derivations.
Tagging @cdelitzs, @mswiatlo, @tnobe and @farooque.This fixes a bug that prevents more than one jet truth label definition to a collection in derivations.
Tagging @cdelitzs, @mswiatlo, @tnobe and @farooque.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65498Fixing CA setup in SUSY Weight Metadata2023-09-01T10:30:07+02:00Zach MarshallFixing CA setup in SUSY Weight MetadataThe CA setup wasn't quite working for the SUSY weight metadata. Tried to
make the minimal patch that would get things running again.
FYI @jcatmore , @ycao , @miholzbo , @longjonThe CA setup wasn't quite working for the SUSY weight metadata. Tried to
make the minimal patch that would get things running again.
FYI @jcatmore , @ycao , @miholzbo , @longjon