athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70028Add TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up period2024-03-27T07:32:08+01:00Antonio De MariaAdd TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up periodThis MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gi...This MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gipezzul, @martindl, @jbeaucam, @mashamim, @sshaw and @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69336Fix decoration type clash for isSplit.2024-02-29T10:45:37+01:00Goetz GayckenFix decoration type clash for isSplit.Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDa...Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDataToxAOD, PixelNtupleMaker use the
same type.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68905DerivationFrameworkJetEtMiss: update JETM1 python config with TrigEventInfoRe...2024-02-28T09:14:56+01:00Maximilian AmerlDerivationFrameworkJetEtMiss: update JETM1 python config with TrigEventInfoRecorderAlg to build `HLT_TCEventInfo_jet` when running on data22# Overview
Changes: update JETM1 python config with TrigEventInfoRecorderAlg instance when running on 2022 data to re-build HLT_TCEventInfo_jet with NumPV decoration. Checks `ConfigFlag` values to ensure running on 2022 data and not on M...# Overview
Changes: update JETM1 python config with TrigEventInfoRecorderAlg instance when running on 2022 data to re-build HLT_TCEventInfo_jet with NumPV decoration. Checks `ConfigFlag` values to ensure running on 2022 data and not on MC.
This change is needed to ensure that the number of primary vertices reconstructed in the HLT is available in JETM1. Previously it was not possible to access this observable because the `trackParticleLinks` for `HLT_IDVertex_FS` aren't stored for the jet trigger content configured in `DerivationFrameworkCore`.
The changes will be required for ongoing Trigger-Level Analysis searches where custom Insitu jet energy scale corrections must be derived on data22 and data23.
Tagging @mmontell @tofitsch
# Size estimates (from running 1000 event tests with `Derivation_tf.py`)
All size estimates from `checkFile.py`
| Data type | Old JETM1 (kB/evt) | Modified JETM1 (kB/evt) | Difference (kB/evt) |
| ------ | ------ | ------ | ------ |
| MC23 (dijet) | 185.481 | 185.481 | ~0 |
| data22 (run 437548) | 32.603 | 32.624 | +0.021 |
| data23 (run 453713) | 38.765 | 38.765 | ~0 |
Negligible increase in size with tests run so far (maybe more events are needed to check?).
**Note: since the change should only affect data22, we expect no size differences on data23 & MC**
# Testing
## Checking content in DAODs with `checkFile.py`
```
[mamerl@lxplus977 test_JETM12022withTCEventInfoandRenounceAll]$ cat run_*/checkFile*.txt | grep "TCEventInfo" --with-filename
(standard input):## opening file [DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_data22/DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root
(standard input): 10.747 kb 1.597 kb 0.003 kb 0.000 497 (B) HLT_TCEventInfo_jet
(standard input): 9.882 kb 1.892 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 11.929 kb 2.004 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
(standard input): 27.284 kb 2.119 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAux.
(standard input): 9.882 kb 2.514 kb 0.005 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input):## opening file [DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_data23/DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root
(standard input): 6.954 kb 1.207 kb 0.004 kb 0.000 308 (B) HLT_TCEventInfo_jet
(standard input): 6.368 kb 1.401 kb 0.005 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 17.212 kb 1.469 kb 0.005 kb 0.000 308 (B) HLT_TCEventInfo_jetAux.
(standard input): 6.368 kb 1.779 kb 0.006 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input): 7.837 kb 3.131 kb 0.010 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
(standard input):## opening file [DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_mc23/DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root
(standard input): 21.099 kb 3.203 kb 0.003 kb 0.000 1000 (B) HLT_TCEventInfo_jet
(standard input): 54.356 kb 4.258 kb 0.004 kb 0.000 1000 (B) HLT_TCEventInfo_jetAux.
(standard input): 20.505 kb 5.952 kb 0.006 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 20.505 kb 6.529 kb 0.007 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input): 24.681 kb 10.018 kb 0.010 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
[mamerl@lxplus977 test_JETM12022withTCEventInfoandRenounceAll]$
```
All required attributes for `HLT_TCEventInfo_jet` exist
## Checking values of Aux elements on `HLT_TCEventInfo_jet`
### data22 test
```
root [0]
Attaching file DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x414c1c0
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 8 * 33.216655 * 0 * 33.216655 *
* 1 * 0 * 8 * 33.216655 * 0 * 33.216655 *
* 2 * 0 * 7 * 33.216655 * 0 * 33.216655 *
* 3 * 0 * 15 * 33.216655 * 0 * 33.216655 *
* 4 * 0 * 7 * 33.216655 * 0 * 33.216655 *
* 5 * 0 * 12 * 33.216655 * 0 * 33.216655 *
* 6 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 7 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 8 * 0 * 15 * 33.216655 * 0 * 33.216655 *
* 9 * 0 * 17 * 33.216655 * 0 * 33.216655 *
* 10 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 11 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 12 * 0 * 16 * 33.216655 * 0 * 33.216655 *
* 13 * 0 * 9 * 33.216655 * 0 * 33.216655 *
* 14 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 15 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 16 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 17 * 0 * 16 * 33.216655 * 0 * 33.216655 *
* 18 * 0 * 5 * 33.216655 * 0 * 33.216655 *
* 19 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 20 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 21 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 22 * 0 * 10 * 33.216655 * 0 * 33.216655 *
* 23 * 0 * 19 * 33.216655 * 0 * 33.216655 *
* 24 * 0 * 10 * 33.216655 * 0 * 33.216655 *
```
Note:
- `HLT_TCEventInfo_jetAuxDyn.NumPV` is filled as required
- `HLT_TCEventInfo_jetAuxDyn.AvgMu` is identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` → this is likely related to the tools setup (LB Mu tool) in the DerivationFramework / Athena context when running `Derivation_tf.py`
- `HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow` is empty (`0` everywhere) i.e. not filled
### data23 test
```
root [0]
Attaching file DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x439b150
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 13 * 35.380664 * 4420.1367 * 35.340515 *
* 1 * 0 * * * * 35.340515 *
* 2 * 0 * 15 * 35.380664 * 6362.5913 * 35.340515 *
* 3 * 0 * 14 * 35.380664 * 4907.5698 * 35.340515 *
* 4 * 0 * 11 * 35.380664 * 3518.6750 * 35.340515 *
* 5 * 0 * 16 * 35.380664 * 8282.9228 * 35.340515 *
* 6 * 0 * 22 * 35.380664 * 6873.4531 * 35.340515 *
* 7 * 0 * 13 * 35.380664 * 2783.1154 * 35.340515 *
* 8 * 0 * 15 * 35.380664 * 4346.9038 * 35.340515 *
* 9 * 0 * * * * 35.340515 *
* 10 * 0 * 14 * 35.380664 * 4867.6264 * 35.340515 *
* 11 * 0 * 18 * 35.380664 * 5058.1831 * 35.340515 *
* 12 * 0 * 11 * 35.380664 * 3905.0180 * 35.340515 *
* 13 * 0 * 12 * 35.380664 * 3506.6855 * 35.340515 *
* 14 * 0 * 8 * 35.380664 * 6581.5629 * 35.340515 *
* 15 * 0 * 16 * 35.380664 * 5168.9941 * 35.340515 *
* 16 * 0 * 13 * 35.380664 * 3372.4897 * 35.340515 *
* 17 * 0 * 13 * 35.380664 * 4090.0913 * 35.340515 *
* 18 * 0 * 8 * 35.380664 * 4835.6259 * 35.340515 *
* 19 * 0 * 17 * 35.380664 * 6507.3862 * 35.340515 *
* 20 * 0 * * * * 35.340515 *
* 21 * 0 * 9 * 35.380664 * 8573.375 * 35.340515 *
* 22 * 0 * 14 * 35.380664 * 6553.0869 * 35.340515 *
* 23 * 0 * 20 * 35.380664 * 8837.2695 * 35.340515 *
* 24 * 0 * 11 * 35.380664 * 5107.9179 * 35.340515 *
```
Note:
- All required `HLT_TCEventInfo_jetAuxDyn` attributes exist & are filled
- The `HLT_TCEventInfo_jetAuxDyn.AvgMu` is NOT identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` - indicates that the code is retrieving the existing TCEventInfo object in the AOD, not re-building the object
### mc23[_valid] test (note: these are old samples with the LAr pile-up issue identified in MC23)
```
root [0]
Attaching file DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x3cc83a0
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 14 * 45 * 9215.3632 * 45 *
* 1 * 0 * 16 * 45 * 3964.0888 * 45 *
* 2 * 0 * 19 * 44 * 5687.5585 * 44 *
* 3 * 0 * 17 * 45 * 8419.6777 * 45 *
* 4 * 0 * 19 * 44 * 9308.8652 * 44 *
* 5 * 0 * 18 * 45 * 13655.557 * 45 *
* 6 * 0 * 22 * 44 * 4839.5996 * 44 *
* 7 * 0 * 25 * 45 * 9061.6445 * 45 *
* 8 * 0 * 25 * 45 * 9512.0195 * 45 *
* 9 * 0 * 24 * 45 * 12075.797 * 45 *
* 10 * 0 * 16 * 44 * 14746.839 * 44 *
* 11 * 0 * 15 * 44 * 5786.2646 * 44 *
* 12 * 0 * 17 * 44 * 8471.5908 * 44 *
* 13 * 0 * 28 * 44 * 12345.287 * 44 *
* 14 * 0 * 16 * 44 * 5851.1669 * 44 *
* 15 * 0 * 29 * 44 * 8467.7617 * 44 *
* 16 * 0 * 11 * 42.999996 * 3358.1669 * 42.999996 *
* 17 * 0 * 13 * 42.999996 * 4736.9277 * 42.999996 *
* 18 * 0 * 11 * 44 * 5612.0869 * 44 *
* 19 * 0 * 13 * 44 * 6328.5634 * 44 *
* 20 * 0 * 20 * 44 * 13085.851 * 44 *
* 21 * 0 * 19 * 44 * 10142.033 * 44 *
* 22 * 0 * 20 * 45 * 7533.3999 * 45 *
* 23 * 0 * 23 * 42.999996 * 7394.0141 * 42.999996 *
* 24 * 0 * 19 * 42.999996 * 7133.0888 * 42.999996 *
```
Note:
- All required `HLT_TCEventInfo_jetAuxDyn` attributes exist & are filled
- The `HLT_TCEventInfo_jetAuxDyn.AvgMu` is identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` - this is expected on MChttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68468Fixed clang warnings in two packages2024-01-31T12:18:15+01:00Vakhtang TsulaiaFixed clang warnings in two packages1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variables1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variableshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68165Fix missing mcChannelNumber in EXOT152024-01-15T22:42:52+01:00Alexander BasanFix missing mcChannelNumber in EXOT15Application of GRL to data events caused mcChannelNumber to disappear. Fix this by checking the SkipTriggerRequirement as for the EXOT15MCThinningTool. Add AntiKt4EMTopoJets_BTagging201810 and BTagging_AntiKt4EMTopo_201810 containers to ...Application of GRL to data events caused mcChannelNumber to disappear. Fix this by checking the SkipTriggerRequirement as for the EXOT15MCThinningTool. Add AntiKt4EMTopoJets_BTagging201810 and BTagging_AntiKt4EMTopo_201810 containers to enable BTagging.
This is for a study to extend the CalRatio analysis to include tops in the final state. Currently being done in R21.
Currently there’s no b-tagging information in EXOT15, and when adding it, we found a bug affecting mcChannel, introduced some releases ago.
@hpotti @chekanovhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67641BPHY22: added container with two-tracks candidates2023-12-11T09:18:50+01:00Laily SultanaliyevaBPHY22: added container with two-tracks candidatesNow container BPHY22DiTrkCandidates is stored in the output DAODs.Now container BPHY22DiTrkCandidates is stored in the output DAODs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67004update tune for fudge factors (now include also electron corrections)2023-11-12T08:54:46+01:00Giovanni Marchioriupdate tune for fudge factors (now include also electron corrections)Use TUNE26 e/gamma corrections for R22 to benefit from electron FFs.
Propagate these also to DNN selectors (not only LH).
See [https://its.cern.ch/jira/browse/ATLASG-2627](https://its.cern.ch/jira/browse/ATLASG-2627 "Follow link")Use TUNE26 e/gamma corrections for R22 to benefit from electron FFs.
Propagate these also to DNN selectors (not only LH).
See [https://its.cern.ch/jira/browse/ATLASG-2627](https://its.cern.ch/jira/browse/ATLASG-2627 "Follow link")https://gitlab.cern.ch/atlas/athena/-/merge_requests/67003Working with 422 clusters2023-11-09T19:26:36+01:00Dylan Sheldon RankinWorking with 422 clustershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66896Yinmiao23.02023-11-03T10:52:48+01:00Yinmiao WangYinmiao23.0Add a flip strategy SIMPLE_FLIP, which flip the sign of detector signed IPs (d0, z0SinTheta) and lifetime-signed IPs(IP3D_signed_d0_significance, IP3D_signed_z0_significance).Add a flip strategy SIMPLE_FLIP, which flip the sign of detector signed IPs (d0, z0SinTheta) and lifetime-signed IPs(IP3D_signed_d0_significance, IP3D_signed_z0_significance).https://gitlab.cern.ch/atlas/athena/-/merge_requests/66360Draft: add DiTau BDT score to TauCP list of variables available for derivations2023-11-27T13:16:14+01:00Antonio De MariaDraft: add DiTau BDT score to TauCP list of variables available for derivationsTagging @martindlTagging @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65557adding fixes for closeBy correction for combining PHYS with LLP1 and FTAG2023-09-04T20:30:52+02:00R D Schafferadding fixes for closeBy correction for combining PHYS with LLP1 and FTAGFix for adding in CloseByIsolation correction when running multiple derivation formats. See [ATLASG-2539](https://its.cern.ch/jira/browse/ATLASG-2539).
Temporarily removed the writing out of information to be able to do CloseByIso corre...Fix for adding in CloseByIsolation correction when running multiple derivation formats. See [ATLASG-2539](https://its.cern.ch/jira/browse/ATLASG-2539).
Temporarily removed the writing out of information to be able to do CloseByIso correction when reading the derivations.R D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65123adding GN2 taggers to physval derivation2023-08-18T16:01:32+02:00Ying Wun Yvonne Ngadding GN2 taggers to physval derivationTagging @jcrosbyTagging @jcrosbyYing Wun Yvonne NgYing Wun Yvonne Nghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64947Draft: Fix EtaPtFilter to avoid some missing parent links for leptons2023-08-11T10:18:04+02:00R D SchafferDraft: Fix EtaPtFilter to avoid some missing parent links for leptonsThis is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remai...This is a continuation of [!64793](https://gitlab.cern.ch/atlas/athena/-/merge_requests/64793#note_7000903).
This implements the missing truth filtering via EtaPtFilter. This is done only for the CA Hits to AOD production, i.e. it remains commented out in jobOpts. This uses the TruthParticleBuilder which was used in the past to go from GenEvent to TruthEvent - which is not xAOD formatted one. It also performed as a first step the filtering of the truth in a GenEvent to GenEvent step. Only the filtering is not done. This reduces the AOD by a few percent due to truth reduction. This MR also fixes a problem in the filtering where the parent child links can be lost for leptons with eta > 5.5. Note that dumpTruth.py was slighting changed to be more coherent in way one passes the CA arguments.
Pinging @zmarshal, @jchapman, @jcatmoreR D SchafferR D Schafferhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64749Draft: Updates in MCTruthClassifier to avoid explicit barcode usage2023-08-09T14:07:02+02:00Andrii VerbytskyiDraft: Updates in MCTruthClassifier to avoid explicit barcode usage- Updates in MCTruthClassifier to avoid explicit barcode usage
- Use shared pointers in the interface
@jchapman- Updates in MCTruthClassifier to avoid explicit barcode usage
- Use shared pointers in the interface
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64569Draft: The first attempt to use status() instead of barcode() in Simulation2023-08-07T10:57:56+02:00Andrii VerbytskyiDraft: The first attempt to use status() instead of barcode() in SimulationThe first attempt to use status instead of barcode for the simulation.
The end goals are:
- 1) to be able to identify the origin of the particles and vertices from their status and not barcodes
- 2) to be able to use the `HepMC3::GenP...The first attempt to use status instead of barcode for the simulation.
The end goals are:
- 1) to be able to identify the origin of the particles and vertices from their status and not barcodes
- 2) to be able to use the `HepMC3::GenParticle::id()` and `HepMC3::GenVertex::id()` as unique identifiers of the particles, e.g. in `HepMCParticleLink`. In this way the usage of `barcode()` `property` of `GenParticle`a and `GenVertex` will be almost eliminated.
The 2) was already implemented by @jchapman as an option. See https://indico.cern.ch/event/1298224/contributions/5458615/attachments/2669897/4627904/Migration%20away%20from%20barcodes.pdf
The 1) requires a bit more changes and those are collected in this MR with the idea to split it later into small pieces.
Namely:
- a) Switching from the bare comparison of `status` property of particles to the classificators in `TruthUtils` ( e.g. `isStable`) See https://gitlab.cern.ch/atlas/athena/-/merge_requests/64579, https://gitlab.cern.ch/atlas/athena/-/merge_requests/64552 and similar. This is an ongoing work that touches a lot of code, but the changes are trivial.
- b) Switching from the classificators that use the `barcode()` directly as `int` to functions that use the underlying objects. See https://gitlab.cern.ch/atlas/athena/-/merge_requests/64571
This MR will also require the removal of the specification of templates `HepMC::is_simulation_particle()` for `int`.
- c) Change the definition of `isStable()`, `isPhysical()`,`isDecayed()`, i.e. ( status=1,2 particles) to take into account that particles produced in the simulation will have status `original_status + constant x times_particle_interacted`. Implemented in this MR.
- d) Drop the `Barcode` service from the `TruthSvc` and instead of increasing the barcode of each particle in the simulation increase the status of particle. Implemented in this MR.
- e) Change the references where it is needed. To be done.
@jchapman
The very beginninghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64320Draft: Unification truthutils2023-07-20T14:29:26+02:00Andrii VerbytskyiDraft: Unification truthutilsUnification truthutilsUnification truthutils