athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-03-15T15:43:40+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/21601Add ATLAS_CHECK_THREAD_SAFETY to SiDigitization package2019-03-15T15:43:40+01:00Susumu OdaAdd ATLAS_CHECK_THREAD_SAFETY to SiDigitization packageAdd ATLAS_CHECK_THREAD_SAFETY to SiDigitization package and add std::atomic to m_sielement in SiChargedDiodeCollection class.
https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/CheckerGccPlugins
RunTier0Tests.py was fine. [Run...Add ATLAS_CHECK_THREAD_SAFETY to SiDigitization package and add std::atomic to m_sielement in SiChargedDiodeCollection class.
https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/CheckerGccPlugins
RunTier0Tests.py was fine. [RunTier0Tests.SiDigitization.log](/uploads/cac3057d489518d9f699cd8f979dcbe1/RunTier0Tests.SiDigitization.log)https://gitlab.cern.ch/atlas/athena/-/merge_requests/21606Migrate Tile Digi to use IAtRNGSvc for AthenaMT2019-03-15T15:44:48+01:00Hass AbouzeidMigrate Tile Digi to use IAtRNGSvc for AthenaMTChanging the method in which random numbers are retrieved for the Tile
Sim code in order for reproducible output when running in
AthenaMT.
cc @jchapman
Marking as WIP until folks are reasonably happy.Changing the method in which random numbers are retrieved for the Tile
Sim code in order for reproducible output when running in
AthenaMT.
cc @jchapman
Marking as WIP until folks are reasonably happy.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21639Update packages:TrigEgammaAnalysisTools from archive/21.0-TrigMC to...2019-03-06T10:29:05+01:00Joao Victor Da Fonseca PintoUpdate packages:TrigEgammaAnalysisTools from archive/21.0-TrigMC to...Command used to build the workspace:
setupATLAS
lsetup git
asetup Athena,master,latest
git clone https://:@gitlab.cern.ch:8443/jodafons/athena.git
cd athena
git remote add upstream https://:@gitlab.cern.ch:8443/atlas/athena.git
git-pack...Command used to build the workspace:
setupATLAS
lsetup git
asetup Athena,master,latest
git clone https://:@gitlab.cern.ch:8443/jodafons/athena.git
cd athena
git remote add upstream https://:@gitlab.cern.ch:8443/atlas/athena.git
git-package-pseudomerge.py
--packages Trigger/TrigAnalysis/TrigEgammaAnalysisTools
--source archive/21.0-TrigMC
--target upstream/master
--stage 1 (and 2 after fix all conflicts)
All conflicts were solved comparing the master and TrigMC. Most part of AcceptData strategy are taken from the master branch. Used the ctest and some trigger monitoring scripts (my script) to test everything.
This MR fixed the problem related in ATR-19448
See the discussion about the pseudo merge in: ATR-19005
Tagging: @fernando and @thrynova (ringer MT task) and @wsfreundhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21652Rename SiLorentzAngleSvc package to SiLorentzAngleTool package (ATLASRECTS-4048)2019-03-15T15:47:14+01:00Susumu OdaRename SiLorentzAngleSvc package to SiLorentzAngleTool package (ATLASRECTS-4048)Rename SiLorentzAngleSvc package to SiLorentzAngleTool package because SiLorentzAngleSvc was converted to SiLorentzAngleTool.
https://its.cern.ch/jira/browse/ATLASRECTS-4048
RunTier0Tests.py was fine. [RunTier0Tests.log](/uploads/0...Rename SiLorentzAngleSvc package to SiLorentzAngleTool package because SiLorentzAngleSvc was converted to SiLorentzAngleTool.
https://its.cern.ch/jira/browse/ATLASRECTS-4048
RunTier0Tests.py was fine. [RunTier0Tests.log](/uploads/0c40276cea46c3246f974f8a769a8545/RunTier0Tests.log)https://gitlab.cern.ch/atlas/athena/-/merge_requests/21730Dropped redundant dependency on the EventInfo package from ZDC_SimuDigitization2019-03-15T15:44:07+01:00Vakhtang TsulaiaDropped redundant dependency on the EventInfo package from ZDC_SimuDigitizationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21731Dropped redundant dependency on the EventInfo package from AFP_Digitization2019-03-15T15:42:55+01:00Vakhtang TsulaiaDropped redundant dependency on the EventInfo package from AFP_Digitizationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21732Dropped redundant dependency on the EventInfo package from ALFA_Digitization2019-03-15T15:43:44+01:00Vakhtang TsulaiaDropped redundant dependency on the EventInfo package from ALFA_Digitizationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21733Dropped redundant dependency on the EventInfo package from TGC_Digitization2019-03-15T15:43:59+01:00Vakhtang TsulaiaDropped redundant dependency on the EventInfo package from TGC_DigitizationAlso moved all headers over to the src directory. It's a component package.Also moved all headers over to the src directory. It's a component package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21758Write out the event tag at the digitization step2020-08-05T03:04:02+02:00Tadej Novaktadej.novak@cern.chWrite out the event tag at the digitization stepWrite out the event tag at the digitization step.
Also provide some additional fixes by @rbielski to prevent legacy trigger to fail.
For RC: do not squash this MR as multiple changes are added here to make the whole reco chain run....Write out the event tag at the digitization step.
Also provide some additional fixes by @rbielski to prevent legacy trigger to fail.
For RC: do not squash this MR as multiple changes are added here to make the whole reco chain run.
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21772Improve sTGC resolution and bug fixes2019-04-29T23:00:53+02:00Alexandre LaurierImprove sTGC resolution and bug fixesImprovements to NSW-sTGC digitization.
Change the resolution dependance on the incidence angle to a more recent, better model as described by @kluit . Cleaning up general code and adding functionalities to stop using hard-coded values.
...Improvements to NSW-sTGC digitization.
Change the resolution dependance on the incidence angle to a more recent, better model as described by @kluit . Cleaning up general code and adding functionalities to stop using hard-coded values.
@cchau @rosati @wleighthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21799MDT_Digitization: Fix clang warnings.2019-03-15T15:46:00+01:00Scott SnyderMDT_Digitization: Fix clang warnings.clang warnings: Missing override keywords.clang warnings: Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21828xAOD::EventInfo conversion fix in PileUpEventLoopMgr (ATLASSIM-4081)2020-10-07T15:12:36+02:00Tadej Novaktadej.novak@cern.chxAOD::EventInfo conversion fix in PileUpEventLoopMgr (ATLASSIM-4081)This MR fixes missing beamspot and pile-up info when converting `EventInfo` to `xAOD::EventInfo` in `PileUpEventLoopMgr`.
Attaching overlay diff-root for reference: [diff-root-overlay-d1498.RDO.log](/uploads/4386e84891613f3334cbff4e07...This MR fixes missing beamspot and pile-up info when converting `EventInfo` to `xAOD::EventInfo` in `PileUpEventLoopMgr`.
Attaching overlay diff-root for reference: [diff-root-overlay-d1498.RDO.log](/uploads/4386e84891613f3334cbff4e07aef5a9/diff-root-overlay-d1498.RDO.log)
/cc @amorley @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/21829PileUpComps: cmake fix2019-03-15T15:43:17+01:00Scott SnyderPileUpComps: cmake fixRemove unneeded dependency on xAODEventInfoCnv.Remove unneeded dependency on xAODEventInfoCnv.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21869Delete uneeded copies of pointers in sTGC Digitization (ATLASSIM-3832)2019-04-04T09:56:08+02:00Chav Chhiv ChauDelete uneeded copies of pointers in sTGC Digitization (ATLASSIM-3832)Many pointers in sTgcDigitizationTool.cxx are unnecessary and could potentially cause memory leak. So the merge request deleted the copies of pointers following the discussion in ATLASSIM-3832.Many pointers in sTgcDigitizationTool.cxx are unnecessary and could potentially cause memory leak. So the merge request deleted the copies of pointers following the discussion in ATLASSIM-3832.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21873Fix crashes related to reading 21.0 RDOs where pile-up GenEvents were not rec...2019-03-15T15:46:09+01:00John Derek ChapmanFix crashes related to reading 21.0 RDOs where pile-up GenEvents were not recorded.This fixes two crashes related to reading 21.0 RDOs where pile-up GenEvents were not recorded.
As described in ATLASRECTS-4874. (The test job in question still crashes, but at a later point
so far the reason for this third crash has not ...This fixes two crashes related to reading 21.0 RDOs where pile-up GenEvents were not recorded.
As described in ATLASRECTS-4874. (The test job in question still crashes, but at a later point
so far the reason for this third crash has not been determined.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/21904Apply MMSimHit in MM fast digitization (ATLASSIM-3755)2019-03-18T17:00:11+01:00Jing ChenApply MMSimHit in MM fast digitization (ATLASSIM-3755)A new hit EDM MMSimHit had been added and used in regular digitization. Modified MuonFastDigitization package to apply MMSimHit in MM fast digitization.A new hit EDM MMSimHit had been added and used in regular digitization. Modified MuonFastDigitization package to apply MMSimHit in MM fast digitization.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21916ComponentAccumulator configuration for SCT digitization2019-03-19T03:02:14+01:00Rupert TombsComponentAccumulator configuration for SCT digitizationDefine new style replacements for PixelDigitizationConfig.py.
ToolSetup dependencies also converted to new style.
ConfigFlags initialisation set up for Digitization and Overlay, with legacy keys inserted.
Also makes minor updates to B...Define new style replacements for PixelDigitizationConfig.py.
ToolSetup dependencies also converted to new style.
ConfigFlags initialisation set up for Digitization and Overlay, with legacy keys inserted.
Also makes minor updates to BCM_Digitization.
Add ConditionsStore StoreGateSvc in tests.
Tests for all new modules.
This duplicates most of https://gitlab.cern.ch/atlas/athena/merge_requests/21340, but without Pixel digitization which has ongoing issues.https://gitlab.cern.ch/atlas/athena/-/merge_requests/21947Sweeping !21904 from 21.3 to 21.9.
Apply MMSimHit in MM fast digitization (AT...2019-03-18T17:00:01+01:00Atlas NightlybuildSweeping !21904 from 21.3 to 21.9.
Apply MMSimHit in MM fast digitization (ATLASSIM-3755)Apply MMSimHit in MM fast digitization (ATLASSIM-3755)
See merge request atlas/athena!21904Apply MMSimHit in MM fast digitization (ATLASSIM-3755)
See merge request atlas/athena!21904https://gitlab.cern.ch/atlas/athena/-/merge_requests/21948Sweeping !21904 from 21.3 to master.
Apply MMSimHit in MM fast digitization (...2019-03-19T03:02:31+01:00Atlas NightlybuildSweeping !21904 from 21.3 to master.
Apply MMSimHit in MM fast digitization (ATLASSIM-3755)Apply MMSimHit in MM fast digitization (ATLASSIM-3755)
See merge request atlas/athena!21904Apply MMSimHit in MM fast digitization (ATLASSIM-3755)
See merge request atlas/athena!21904https://gitlab.cern.ch/atlas/athena/-/merge_requests/21956Sweeping !21869 from 21.3 to 21.9.
Delete uneeded copies of pointers in sTGC ...2019-03-18T16:28:49+01:00Atlas NightlybuildSweeping !21869 from 21.3 to 21.9.
Delete uneeded copies of pointers in sTGC Digitization (ATLASSIM-3832)Delete uneeded copies of pointers in sTGC Digitization (ATLASSIM-3832)
See merge request atlas/athena!21869Delete uneeded copies of pointers in sTGC Digitization (ATLASSIM-3832)
See merge request atlas/athena!21869