athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-11-04T17:30:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/28731: add radiation damage effects in fast pixel digitization2020-11-04T17:30:35+01:00Tommaso Lari: add radiation damage effects in fast pixel digitizationAdd radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or mea...Add radiation damage effects as a scaling in the charge in the fast pixel digitization, before comparing to threshold values (so pixel cells or entire clusters might be lost). The scaling factors are derived from full digitization or measurements, values for end of 2017, end of run2, and a couple end of run3 scenarios are available. The default is no radiation damage though, it can be changed from job option. Also revising the charge to TOT conversion and the amount of energy loss fluctuations. The default position smearing is changed so that cluster size and other observable are very close to previous output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32530WIP: Only use CutFlowSvc when needed2020-10-30T18:19:38+01:00Tadej Novaktadej.novak@cern.chWIP: Only use CutFlowSvc when neededCurrently abusing the CI to try to find all the use cases of CutFlowSvc.Currently abusing the CI to try to find all the use cases of CutFlowSvc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34724Remove non-ascii characters from codes. Mostly comments are affected.2020-09-21T16:11:20+02:00Andrii VerbytskyiRemove non-ascii characters from codes. Mostly comments are affected.This is a general cleanup MR.
In this MR the non-acsii charactes are removed from the *.cxx, *.h and *.f files.
The search fro files with non-ascii (almost) characters was performed with:
```
find . -type f -not -path "./.git/*"...This is a general cleanup MR.
In this MR the non-acsii charactes are removed from the *.cxx, *.h and *.f files.
The search fro files with non-ascii (almost) characters was performed with:
```
find . -type f -not -path "./.git/*" -name "*.h" -exec grep -lP '[^\0-\x7f]' {} \;
```
- Most of the replaced characters are in comments and originate from a copy-pasted documentation (e.g. from PDF files).
- Some are just math symbols greek letters/umlauts/ characters with grave/acute accents, etc.
- Some charactes are "special empty spaces" or quotes.
- Virtually all the occurances are in the comments. Some exceptions are attempts to cout:: greek letters.
The author names with umlauts/grave/acute accents were left "as is".Edward MoyseEdward Moysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/30605Solve the initialization problem between PixelCabling and SiRegionSelectorTab...2020-09-18T04:22:55+02:00Soshi TsunoSolve the initialization problem between PixelCabling and SiRegionSelectorTable (ATLASRECTS-4788)Current SiRegionSelectorTable access conditions data (PixelCabling) already at initialization() step, which is not by design for new conditions migration. The quick fix was implemented that the PixelCabling store the conditions data at i...Current SiRegionSelectorTable access conditions data (PixelCabling) already at initialization() step, which is not by design for new conditions migration. The quick fix was implemented that the PixelCabling store the conditions data at initialization() step, but the event time stamp is not know at this stage (initialization()), the conditions data was needed to overwrite "every event" at execute() step. This will be a big overhead of the execution speed.
Now, reviewing the SiRegionSelectorTable, it was found that this function did not use "online identifier" from the PixelCabling, therefore, this SiRegionSelectorTable is not necessary to retrieve the information from conditions DB (via PixelCabling).
Thus, for online identifier, dummy value is set without accessing conditions DB.
Made sure this did not change the result for T0 test (q221, q431).
This is also relevant to ATLASRECTS-5321.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34638PixelDigitization: Conditions dependency fixes2020-07-15T15:32:54+02:00Scott SnyderPixelDigitization: Conditions dependency fixesDon't declare dependencies on conditions objects that we won't read.Don't declare dependencies on conditions objects that we won't read.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34482WIP: Make sure DataHandle initialize is called when not used2020-07-07T12:38:29+02:00Adam Edward BartonWIP: Make sure DataHandle initialize is called when not usedDataHandles should be initialized with `false` if they are not used.DataHandles should be initialized with `false` if they are not used.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34214TRT_Digitization+InDetLowBetaFinder+InDetOverlay: cmake fixes2020-06-29T22:34:01+02:00Scott SnyderTRT_Digitization+InDetLowBetaFinder+InDetOverlay: cmake fixesLibrary dependency fixes.Library dependency fixes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/33291Digitization: Update references.2020-06-01T14:24:51+02:00Scott SnyderDigitization: Update references.Fix failures in master.Fix failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31807WIP: All view data loaded explicitly2020-05-01T00:22:20+02:00Benjamin Michael WynneWIP: All view data loaded explicitlyIntending to change the Gaudi scheduler to remove the assumption that event-level data is present in views (was causing more problems than it solved). Gaudi MR: https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1064
Requires explici...Intending to change the Gaudi scheduler to remove the assumption that event-level data is present in views (was causing more problems than it solved). Gaudi MR: https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1064
Requires explicit loading of event-level data using ViewDataVerifier algorithms where it is needed. These changes should specify enough to get a full HLT job running. Note that SGInputLoader now needs some explicit data requests where it would have resolved them automatically.
Also changed AddressRemapSvc to ignore VDVs (as it already ignores SGInputLoader, and for the same reason).
Note there's a weird situation where some conditions data is loaded with SGIL. Discussed in JIRA: https://its.cern.ch/jira/browse/ATR-21220
Also needed to make the "verifier" part of VDV less strict, since it fails routinely for objects like StoreGateSvc+CaloBCIDAverage, see JIRA: https://its.cern.ch/jira/browse/ATR-21198https://gitlab.cern.ch/atlas/athena/-/merge_requests/27075WIP: Enable writing of mini-EventInfo in RDO in Digitization.py2020-04-14T12:24:51+02:00Marcin NowakWIP: Enable writing of mini-EventInfo in RDO in Digitization.pyThis was temporarily disabled during PileUpEventInfo migration for some reason. I think it can be turned on again now.This was temporarily disabled during PileUpEventInfo migration for some reason. I think it can be turned on again now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30675WIP: Migrate ComponentAccumulator to GaudiConfig22020-04-09T10:51:31+02:00Walter LamplWIP: Migrate ComponentAccumulator to GaudiConfig2First attempt to migrate ComponentAccumulator-based configurations to use the GaudiConfig2 configurable python classes.First attempt to migrate ComponentAccumulator-based configurations to use the GaudiConfig2 configurable python classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30819Remove two TRT Services2020-04-06T15:21:20+02:00Peter HansenRemove two TRT ServicesATLASRECTS-3310 , ATLASRECTS-5053 and ATLASRECTS-5158
The two services, TRT_CalDbSvc and TRT_StrawStatusSummarySvc, are here completely removed from Athena.
As a result, all access to calibration and status conditions go via the two co...ATLASRECTS-3310 , ATLASRECTS-5053 and ATLASRECTS-5158
The two services, TRT_CalDbSvc and TRT_StrawStatusSummarySvc, are here completely removed from Athena.
As a result, all access to calibration and status conditions go via the two corresponding AlgTools. These hold no cached data, have only read access methods and are made private to all clients to boot.
The I/O functionality of the removed Services are picked up by two new AlgTools, TRT_CalibTxtConverterTool and TRT_StatusTxtConverterTool. These are only used to upload new data to CondDb or to dump the CondDb to text file
(so evtMax=1 and hence thread safety is not an issue here).https://gitlab.cern.ch/atlas/athena/-/merge_requests/31356Bug fix SensorSimPlanarTool.cxx2020-03-23T23:43:33+01:00Eric Ballabeneeric.ballabene@cern.chBug fix SensorSimPlanarTool.cxxBug fix accounting for different pixel sizesBug fix accounting for different pixel sizeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29523Fix unit test (ATLASRECTS-5264)2020-01-16T10:13:11+01:00Soshi TsunoFix unit test (ATLASRECTS-5264)Unit test of SiSPSeededTracksStandaloneFromESD was failed.
This is due to missing conditions. Now it is updated in job option.Unit test of SiSPSeededTracksStandaloneFromESD was failed.
This is due to missing conditions. Now it is updated in job option.https://gitlab.cern.ch/atlas/athena/-/merge_requests/29342Sweeping !29286 from 21.0 to master.
Add message for the scale factor applied...2020-01-13T04:32:17+01:00Atlas NightlybuildSweeping !29286 from 21.0 to master.
Add message for the scale factor applied to fractional charged particlesAdd message for the scale factor applied to fractional charged particles
See merge request atlas/athena!29286Add message for the scale factor applied to fractional charged particles
See merge request atlas/athena!29286https://gitlab.cern.ch/atlas/athena/-/merge_requests/29313Add message for the scale factor applied to fractional charged particles2020-01-10T09:10:45+01:00Quanyin LiAdd message for the scale factor applied to fractional charged particlesManually merged to master.Manually merged to master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/29092Manual Sweep to Master2019-12-19T21:59:25+01:00Dylan PizziManual Sweep to MasterSweeping previous merge request 76746e00b5 to MasterSweeping previous merge request 76746e00b5 to Masterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/29085TRT modification for fractional charged particles2019-12-19T16:52:32+01:00Quanyin LiTRT modification for fractional charged particlesModify the charge dependence of TRT for fractional charged particlesModify the charge dependence of TRT for fractional charged particleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28453RPC digitization for fractional charged particles2019-12-03T14:22:54+01:00Quanyin LiRPC digitization for fractional charged particlesAdd a correction factor of RPC efficiency for fractional charged particles.Add a correction factor of RPC efficiency for fractional charged particles.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28016Muon track building: more private tools2019-11-15T17:32:32+01:00Edward MoyseMuon track building: more private toolsMake more muon tools private, and move to the new gaudi property declaration.
Add some more configuration to MooCandidateMatchingTool, now that tools are private.
MuPatCandidateTool - the segmentExtender points to a tool which appare...Make more muon tools private, and move to the new gaudi property declaration.
Add some more configuration to MooCandidateMatchingTool, now that tools are private.
MuPatCandidateTool - the segmentExtender points to a tool which apparently doesn't exist! It is always disabled in jobOpts (for obvious reasons) so I just removed it.