athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-01-17T03:07:52+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/39762Sweeping !39695 from 21.3 to 21.9.
Manual sweep of !39655 (Switch from CLHEP:...2021-01-17T03:07:52+01:00Atlas NightlybuildSweeping !39695 from 21.3 to 21.9.
Manual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037))Manual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037))
See merge request atlas/athena!39695Manual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037))
See merge request atlas/athena!39695https://gitlab.cern.ch/atlas/athena/-/merge_requests/39747add configuration to run beam spot size reweighting in digitization2021-01-20T03:02:37+01:00Michael Duehrssen-Deblingadd configuration to run beam spot size reweighting in digitizationThis MR adds flags to digitizationFlags and configuration to run a beam spot size reweighting in z as part of a digitization job and store the weight in xAOD::EventInfoThis MR adds flags to digitizationFlags and configuration to run a beam spot size reweighting in z as part of a digitization job and store the weight in xAOD::EventInfohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39735fix memory leaks in MM and sTGC digitization2021-01-19T03:05:53+01:00Nicholas Stylesfix memory leaks in MM and sTGC digitizationManual sweep of !39665 from 21.9 - fixing some heap allocations which were resulting in some large leaks when profiled in 21.9.
- Use ```Emplace``` instead of pushing back a ```new```'d pointer which was not cleaned up in ```MM_Digitiza...Manual sweep of !39665 from 21.9 - fixing some heap allocations which were resulting in some large leaks when profiled in 21.9.
- Use ```Emplace``` instead of pushing back a ```new```'d pointer which was not cleaned up in ```MM_Digitization```.
- Use ```unique_ptr```s in ```sTgcDigitization```.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39727Sweeping !39665 from 21.9 to 21.3.
Fix leaks in sTGC_Digitization && MM_Digit...2021-02-08T09:48:36+01:00Atlas NightlybuildSweeping !39665 from 21.9 to 21.3.
Fix leaks in sTGC_Digitization && MM_DigitizationFix leaks in sTGC_Digitization && MM_Digitization
See merge request atlas/athena!39665Fix leaks in sTGC_Digitization && MM_Digitization
See merge request atlas/athena!39665https://gitlab.cern.ch/atlas/athena/-/merge_requests/39695Manual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggu...2021-02-08T09:48:36+01:00Nicolas KoehlerManual sweep of !39655 (Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037))Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037)
Closes ATLASSIM-5037
See merge request atlas/athena!39655Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037)
Closes ATLASSIM-5037
See merge request atlas/athena!39655https://gitlab.cern.ch/atlas/athena/-/merge_requests/39665Fix leaks in sTGC_Digitization && MM_Digitization2021-03-28T18:54:57+02:00Nicholas StylesFix leaks in sTGC_Digitization && MM_DigitizationAs above - large leaks as a result of non-deleted ```new```'ed objects discussed in ATLSWUPGR-113
FYI @cohm @tadej @alaurier @jojungge @nkoehlerAs above - large leaks as a result of non-deleted ```new```'ed objects discussed in ATLSWUPGR-113
FYI @cohm @tadej @alaurier @jojungge @nkoehlerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39661TMDB simulation in RDOtoRDO_Trigger step2021-03-24T15:24:21+01:00Masato AokiTMDB simulation in RDOtoRDO_Trigger stepAs mentioned in ATR-22575, we want to run the TMDB (tile-muon digitizer board) simulation in the RDOtoRDO_Trigger step for the Run 2 MC reprocessing. As the Tile-muon coincidence was enabled only in the 2018 data-taking, this modificatio...As mentioned in ATR-22575, we want to run the TMDB (tile-muon digitizer board) simulation in the RDOtoRDO_Trigger step for the Run 2 MC reprocessing. As the Tile-muon coincidence was enabled only in the 2018 data-taking, this modification has to be done in MC16e.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39659Activate IBL special charge calibration (ATLASSIM-5035)2021-02-20T03:02:31+01:00Soshi TsunoActivate IBL special charge calibration (ATLASSIM-5035)Pixel group agreed to use this IBL special charge correction both in default (no radiation damage) and radiation damage digitizer. Thus, the default value should be True.
This change will affect simulation (q221 etc) but not data.Pixel group agreed to use this IBL special charge correction both in default (no radiation damage) and radiation damage digitizer. Thus, the default value should be True.
This change will affect simulation (q221 etc) but not data.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39655Switch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization...2021-02-08T09:48:36+01:00Nicolas KoehlerSwitch from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in Muon Digitization code (ATLASSIM-5037)Hi,
this MR moves from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in the Muon Digitization code (fixes ATLASSIM-5037).
Best, NicoHi,
this MR moves from CLHEP::RandGauss to CLHEP::RandGaussZiggurat in the Muon Digitization code (fixes ATLASSIM-5037).
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39631TGCDigitization : Set actual gate time windows for TGC chambers in Digitization2021-01-19T03:07:35+01:00Natsu TeramuraTGCDigitization : Set actual gate time windows for TGC chambers in DigitizationThis is the follow-up request from !39555. The next reprocessing for digitization will use master branch, not 21.0.
As described in ATLASRECTS-5871, to fix the gate time windows for the patch panel of TGC inner station, I added new memb...This is the follow-up request from !39555. The next reprocessing for digitization will use master branch, not 21.0.
As described in ATLASRECTS-5871, to fix the gate time windows for the patch panel of TGC inner station, I added new member variables that are specific gate time windows for inner station to TGCDigitization package. The compilation is fine, no errors. Also, I have tested with single muon MC. I could found the BCID distribution I expected.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39555Draft: TGCDigitization : Set actual gate time windows for TGC chambers in Dig...2021-01-12T12:48:40+01:00Natsu TeramuraDraft: TGCDigitization : Set actual gate time windows for TGC chambers in DigitizationAs described in ATLASRECTS-5871, to fix the gate time windows for the patch panel of TGC inner station, I added new member variables that are specific gate time windows for inner station to TGCDigitization package. The compilation is fin...As described in ATLASRECTS-5871, to fix the gate time windows for the patch panel of TGC inner station, I added new member variables that are specific gate time windows for inner station to TGCDigitization package. The compilation is fine, no errors or warnings. Also, I have tested with single muon MC. I could found the BCID distribution I expected.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39530Fix syntax in DigitizationPUConfigNew_test.py (ATLASSIM-5031)2021-01-09T03:03:37+01:00John Derek ChapmanFix syntax in DigitizationPUConfigNew_test.py (ATLASSIM-5031)Replace `ConfigFlags.Digitization.PU.RunAndLumiOverrideList` with `ConfigFlags.Input.RunAndLumiOverrideList` in `DigitizationPUConfigNew_test.py`
Fixes bug introduced in !37867 - see ATLASSIM-5031Replace `ConfigFlags.Digitization.PU.RunAndLumiOverrideList` with `ConfigFlags.Input.RunAndLumiOverrideList` in `DigitizationPUConfigNew_test.py`
Fixes bug introduced in !37867 - see ATLASSIM-5031https://gitlab.cern.ch/atlas/athena/-/merge_requests/39457FastTRT_Digitization+InDetEtaDependentCuts+GeoModelEnvelopes: Fix clang warni...2021-01-06T03:03:13+01:00Scott SnyderFastTRT_Digitization+InDetEtaDependentCuts+GeoModelEnvelopes: Fix clang warnings.Don't use fabs() with an integer argument; use std::abs instead.
If a dtor is declared final, then the class itself must also be final.Don't use fabs() with an integer argument; use std::abs instead.
If a dtor is declared final, then the class itself must also be final.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39442Sweep: Introducing a z corection into MM digi to fix residuals2021-01-06T03:02:30+01:00Patrick ScholerSweep: Introducing a z corection into MM digi to fix residualssweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39375sweep of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39375https://gitlab.cern.ch/atlas/athena/-/merge_requests/39431Sweeping !39375 from 21.3 to 21.9.
Introducing a z corection into MM digi to ...2021-01-05T03:03:41+01:00Atlas NightlybuildSweeping !39375 from 21.3 to 21.9.
Introducing a z corection into MM digi to fix residualsIntroducing a z corection into MM digi to fix residuals
See merge request atlas/athena!39375Introducing a z corection into MM digi to fix residuals
See merge request atlas/athena!39375https://gitlab.cern.ch/atlas/athena/-/merge_requests/39413Fix ATLASRECTS-5797 Duplicated c++ includes in InnerDetector packages2020-12-29T03:02:32+01:00Susumu OdaFix ATLASRECTS-5797 Duplicated c++ includes in InnerDetector packagesCloses ATLASRECTS-579Closes ATLASRECTS-579https://gitlab.cern.ch/atlas/athena/-/merge_requests/39408Changes are needed to run pixel...2021-01-12T03:04:03+01:00Tommaso LariChanges are needed to run pixel...Changes are needed to run pixel digitization with radiation damage without crashes, getting correct hits in long columns, and running faster. See ATLPHYSVAL-654 for discussion.Changes are needed to run pixel digitization with radiation damage without crashes, getting correct hits in long columns, and running faster. See ATLPHYSVAL-654 for discussion.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39375Introducing a z corection into MM digi to fix residuals2021-02-08T09:48:36+01:00Patrick ScholerIntroducing a z corection into MM digi to fix residualsThis MR introduces a shift in the z-position of the ionization track in the MM digi. This fixes a shift of the mean residuals vs theta of up to 200 um. The correction is retrieved purely empirically. Furthermore, the center gas gap thick...This MR introduces a shift in the z-position of the ionization track in the MM digi. This fixes a shift of the mean residuals vs theta of up to 200 um. The correction is retrieved purely empirically. Furthermore, the center gas gap thickness in the uTPC clusterization is fixed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/39328Distance solution, move inline to .icc and use default.2020-12-20T03:03:36+01:00Christos Anastopouloschristos.anastopoulos@cern.chDistance solution, move inline to .icc and use default.Distance solution, move inline to .icc and use default.
Also fix SCT_Digitization to used std::log, std::sqrt
Repeat of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39259 but trying to fix the SCT_Digitization issues.
Mentio...Distance solution, move inline to .icc and use default.
Also fix SCT_Digitization to used std::log, std::sqrt
Repeat of https://gitlab.cern.ch/atlas/athena/-/merge_requests/39259 but trying to fix the SCT_Digitization issues.
Mentioning @fwinkl and @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39242HGTD digitization classes initialization2021-03-24T16:30:21+01:00Tao WangHGTD digitization classes initializationThis Merge Request aims to provide the basic structure for HGTD Digitization Tool so that the tool can be run from `Reco_tf.py` script.
This can provide the basis for future digitization and reconstruction development for HGTD.This Merge Request aims to provide the basic structure for HGTD Digitization Tool so that the tool can be run from `Reco_tf.py` script.
This can provide the basis for future digitization and reconstruction development for HGTD.Tao WangTao Wang