athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-12T13:38:15+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67771MuonTruthAlgs,MuonDigitization,MuonDigitContainer,MuonCnv,MSVertexReconstruct...2023-12-12T13:38:15+01:00Christos Anastopouloschristos.anastopoulos@cern.chMuonTruthAlgs,MuonDigitization,MuonDigitContainer,MuonCnv,MSVertexReconstruction : clang-tidyMuonTruthAlgs,MuonDigitization,MuonDigitContainer,MuonCnv,MSVertexReconstruction : clang-tidyMuonTruthAlgs,MuonDigitization,MuonDigitContainer,MuonCnv,MSVertexReconstruction : clang-tidyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66446Adding 2023 timing simulation model2023-12-11T17:23:09+01:00Soshi TsunoAdding 2023 timing simulation modelBased on the 2023 timing data, the simulation is also tuned.
So far, this parameterization is not used. But MC reprocessing is scheduled, this tuning is activated (currently mc23 uses 2022-based tune).Based on the 2023 timing data, the simulation is also tuned.
So far, this parameterization is not used. But MC reprocessing is scheduled, this tuning is activated (currently mc23 uses 2022-based tune).https://gitlab.cern.ch/atlas/athena/-/merge_requests/67731PileUpComps: cmake fix2023-12-11T15:50:44+01:00Scott SnyderPileUpComps: cmake fixFix spelling of Boost cmake variable.Fix spelling of Boost cmake variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/676952023-12-08: merge of 23.0 into main2023-12-11T14:26:36+01:00gitlab-api2023-12-08: merge of 23.0 into mainThis sweep contains the following MRs:
* !67681 Patching MC23d configuration ~Digitization, ~Simulation, ~Tools
* !67627 23.0 zdc sd class ATLASSIM-6751 ~ForwardDetectors, ~Simulation
* !67629 Fixed ordering bug in the random numbers ...This sweep contains the following MRs:
* !67681 Patching MC23d configuration ~Digitization, ~Simulation, ~Tools
* !67627 23.0 zdc sd class ATLASSIM-6751 ~ForwardDetectors, ~Simulation
* !67629 Fixed ordering bug in the random numbers given to the GAN in FastCaloGAN ~Simulation
I had a few conflicts:
* Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
* Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
* Both these were deleted in HEAD and modified in upstream/23.0. I kept them deleted.
* Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
* Minor internal conflict, which I just resolved.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67681Patching MC23d configuration2023-12-08T11:10:53+01:00John Derek ChapmanPatching MC23d configurationSome issues were found in the first version of the MC23d configuration in !67101.
One of which could not be worked around. Unfortunately a `23.0.32.2,Athena` build will be required.
This merge request should fix them.
NB The `MC23dSimu...Some issues were found in the first version of the MC23d configuration in !67101.
One of which could not be worked around. Unfortunately a `23.0.32.2,Athena` build will be required.
This merge request should fix them.
NB The `MC23dSimulationNoIoV`, `MC23dSimulationSingleIoV`, `MC23dSimulationMultipleIoV` and
`MC23cSimulationMultipleIoVCalibrationHits` functions were not added as the simulation step will not
be re-run for MC23d. MC23c HITS will be used.
Tagging @tadej, @ewelina, @jferrand, @jmaurer, @dta, @ahabouel, @dsouth, @zmarshal, @jcatmore, @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67101MC23d Campaign configuration (ATLASSIM-6953)2023-12-07T16:08:37+01:00John Derek ChapmanMC23d Campaign configuration (ATLASSIM-6953)This merged request adds the revised pile-up profiles for MC23d and the corresponding Campaign configurations.
Currently a placeholder until we get the multi-beamspot profile.This merged request adds the revised pile-up profiles for MC23d and the corresponding Campaign configurations.
Currently a placeholder until we get the multi-beamspot profile.https://gitlab.cern.ch/atlas/athena/-/merge_requests/676062023-12-05: merge of 23.0 into main2023-12-06T16:24:02+01:00gitlab-api2023-12-05: merge of 23.0 into mainThis sweep contains the following MRs:
* !67101 MC23d Campaign configuration (ATLASSIM-6953) ~Digitization, ~Simulation, ~Tools
* !67571 restored L1 functionality for ZDCCalib files ~ForwardDetectors
* !67419 23.0 zdc hit class ATLASS...This sweep contains the following MRs:
* !67101 MC23d Campaign configuration (ATLASSIM-6953) ~Digitization, ~Simulation, ~Tools
* !67571 restored L1 functionality for ZDCCalib files ~ForwardDetectors
* !67419 23.0 zdc hit class ATLASSIM-6751 ~ForwardDetectors, ~Simulation
* !67293 Implementation of L1 TRT fast-OR simulation - ATR-28372 ~Trigger
I had to manually merge !67293 as there was a clash in `TriggerConfigFlags`https://gitlab.cern.ch/atlas/athena/-/merge_requests/67550Optimizations in the InnerDetector code related to barcodes2023-12-06T11:45:54+01:00Andrii VerbytskyiOptimizations in the InnerDetector code related to barcodesOptimizations in the InnerDetector code related to barcodesOptimizations in the InnerDetector code related to barcodeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67456retune sTGC digi parameters2023-12-05T15:15:30+01:00Patrick Scholerretune sTGC digi parametersRe-tuning some parameters in the sTGC digitization following the study in ATLASRECTS-7815
Tagging @cheidegg to let him know that we take the default value for the threshold from a job option and not from the database anymore
As a bonus ...Re-tuning some parameters in the sTGC digitization following the study in ATLASRECTS-7815
Tagging @cheidegg to let him know that we take the default value for the threshold from a job option and not from the database anymore
As a bonus this fixes a bug in the sTGC SDO positioning introduced in !66810 because of excellent math. Thanks to @mvozak for spotting the weird behavior of the SDOs.
As another bonus this fixes the author flag that is returned by the caruana stgc cluster builder to reflect the possibility that the reco falls back to the centroid reconstruction
cc @alainbhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67539Wrap the single particle barcode 100012023-12-04T19:00:15+01:00Andrii VerbytskyiWrap the single particle barcode 10001Wrap the single particle barcode 10001:
- add a function that should detect single particles
- add a magic number
@jchapman @pclark @christosWrap the single particle barcode 10001:
- add a function that should detect single particles
- add a magic number
@jchapman @pclark @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67551Cleanup related to barcodes in LArCalorimeter2023-12-04T18:48:17+01:00Andrii VerbytskyiCleanup related to barcodes in LArCalorimeterCleanup related to barcodes in LArCalorimeter
@jchapman @pclarkCleanup related to barcodes in LArCalorimeter
@jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67321changing mmg digi smearing setup for the mc2023-12-01T22:47:57+01:00Matous Vozakchanging mmg digi smearing setup for the mcThis MR is to update the digitisation of the MMG based on the resolution studies. more info can be found at ATLASRECTS-7814This MR is to update the digitisation of the MMG based on the resolution studies. more info can be found at ATLASRECTS-7814Matous VozakMatous Vozakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67526main-cleanup-property-PixelDigitization2023-12-01T20:41:39+01:00Shaun Roemain-cleanup-property-PixelDigitizationAddresses proposal 11 of ATLASRECTS-7721:
In the current situation, setting 'doNoise' to true for the ITk results in an exception because no default noise value is set for the ITk. In addition, for existing pixel frontends, the thermal n...Addresses proposal 11 of ATLASRECTS-7721:
In the current situation, setting 'doNoise' to true for the ITk results in an exception because no default noise value is set for the ITk. In addition, for existing pixel frontends, the thermal noise is _always_ set to 160 (and never set in job options), so there is no need to differentiate by layer. This MR encodes these facts as a new member variable in the FrontEndSimTool baseclass and prevents the exception for the ITk, and should also be quicker than retrieving it from the conditions store.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67523Cleaning HepMcParticleLink class ahead of barcode migration (ATLASSIM-6798)2023-12-01T20:20:47+01:00John Derek ChapmanCleaning HepMcParticleLink class ahead of barcode migration (ATLASSIM-6798)Basically just renaming some variables for clarity, while working through the logic of this class.Basically just renaming some variables for clarity, while working through the logic of this class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67506TileSimAlgs+ISF_FastCaloSimParametrization: Fix cppcheck warning.2023-12-01T02:30:32+01:00Scott SnyderTileSimAlgs+ISF_FastCaloSimParametrization: Fix cppcheck warning.Uninitialized variables.Uninitialized variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67460Fix for ITk Pixel radiation damage simulation due to wrong units conversion2023-11-30T19:56:02+01:00Tomas DadoFix for ITk Pixel radiation damage simulation due to wrong units conversionA minor fix for the future ITk Pixel radiation damage where wrong units were used.
This is not used in any production, it is only used for studies of the performance for the ITkA minor fix for the future ITk Pixel radiation damage where wrong units were used.
This is not used in any production, it is only used for studies of the performance for the ITkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67464Simplify some static arrays2023-11-30T19:10:08+01:00Adam Edward BartonSimplify some static arraysWe can avoid initializing heap memory.We can avoid initializing heap memory.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67466Update TRT digitization overrides to latest values2023-11-29T19:21:35+01:00Christian GrefeUpdate TRT digitization overrides to latest valuesThis just updates some default overrides for TRT digitization tuning. No impact on default reconstruction.This just updates some default overrides for TRT digitization tuning. No impact on default reconstruction.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66810sTgcDigitization - Add conditions algorithm to load efficiencies & use the de...2023-11-29T18:54:17+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chsTgcDigitization - Add conditions algorithm to load efficiencies & use the detector manager from the conditions store* Write database infrastructure to tune the sTgc efficiencies via external efficiency numbers. Tagging @pscholer, @cheidegg. The current (deactivated) file [sTGC_Digitization_EffChamber](https://gitlab.cern.ch/atlas/athena/-/blob/main/Mu...* Write database infrastructure to tune the sTgc efficiencies via external efficiency numbers. Tagging @pscholer, @cheidegg. The current (deactivated) file [sTGC_Digitization_EffChamber](https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonDigitization/sTGC_Digitization/share/sTGC_Digitization_EffChamber.dat) looks very bizzar to me
* Use double instead of float everywhere
* Use the MuonGM::DetectorManager from the conditions store instead of the one of the detector store
* Avoid multiple copies of digits and SDO objects
* Fix bugs in the vmm-hit merging & in the neighbour logic
Asking for explicit approval of @pscholer, @alainb ~"review-pending-expert"https://gitlab.cern.ch/atlas/athena/-/merge_requests/67439Tuning BIS78 RPC Time Over Threshold distributions based on experimental...2023-11-28T20:39:03+01:00Matteo NegriniTuning BIS78 RPC Time Over Threshold distributions based on experimental...Tuning BIS78 RPC Time Over Threshold distributions based on experimental values as reported in ATLASRECTS-7820Tuning BIS78 RPC Time Over Threshold distributions based on experimental values as reported in ATLASRECTS-7820