athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-11-09T03:02:36+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/27780Remove duplicated LArADC2MeV configuration2019-11-09T03:02:36+01:00Rupert TombsRemove duplicated LArADC2MeV configurationRemove semi-duplicated configuration `LArADC2MeVCondAlgCfg`, which currently exists in both `LArCalorimeter/LArRecUtils/python/LArRecUtilsConfig.py` and its own `LArCalorimeter/LArRecUtils/python/LArADC2MeVCondAlgConfig.py`.
Propagate...Remove semi-duplicated configuration `LArADC2MeVCondAlgCfg`, which currently exists in both `LArCalorimeter/LArRecUtils/python/LArRecUtilsConfig.py` and its own `LArCalorimeter/LArRecUtils/python/LArADC2MeVCondAlgConfig.py`.
Propagate fixes to dependencies.
Test material for LArRawChannels is updated, as discussed in !27182.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27683Simulation python3 fixes2019-11-05T03:01:59+01:00John Derek ChapmanSimulation python3 fixesThis merge request attempts to fix flak8 warning and python 3-incompatible syntax in the following packages:
* Simulation/Digitization
* Simulation/G4Atlas/G4AtlasAlg
* Simulation/G4Atlas/G4AtlasServices
* Simulation/G4Atlas/G4AtlasT...This merge request attempts to fix flak8 warning and python 3-incompatible syntax in the following packages:
* Simulation/Digitization
* Simulation/G4Atlas/G4AtlasAlg
* Simulation/G4Atlas/G4AtlasServices
* Simulation/G4Atlas/G4AtlasTools
The fixes are for the old-style configuration for these packages, which will be dropped once we finish the migration of the Sim/Digi configuration to `ComponentAccumulator`, but they will allow a python 3-based nightly to be more functional in the meantime.
Relates to ATLINFR-3221.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27554Made the output do* flags depend on the output file names2019-11-21T03:03:03+01:00Tomasz BoldMade the output do* flags depend on the output file namesIn this MR the doWriteXYZ and XYZFileName file name flags are by default related.
I.e. if the file name is nonempty then respective "do" is set to true.
Tagging @rbielski as this is followup of !27215
@wlampl @emoyseIn this MR the doWriteXYZ and XYZFileName file name flags are by default related.
I.e. if the file name is nonempty then respective "do" is set to true.
Tagging @rbielski as this is followup of !27215
@wlampl @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27482Updates in STGC digitization2020-04-13T20:38:36+02:00Stefano RosatiUpdates in STGC digitizationA few fixes in the usage of the smearing in STGC digitization, and in the smearing toolA few fixes in the usage of the smearing in STGC digitization, and in the smearing toolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27438Write out event tag for MT premixing2019-10-25T03:02:46+02:00Tadej Novaktadej.novak@cern.chWrite out event tag for MT premixingWrite out event tag for MT premixing (currently still disabled for normal premixing).
/cc @jchapmanWrite out event tag for MT premixing (currently still disabled for normal premixing).
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27413Add MC16 pile-up premixing ART tests2019-10-24T03:02:57+02:00Tadej Novaktadej.novak@cern.chAdd MC16 pile-up premixing ART testsAdd MC16 pile-up premixing ART tests both for standard and MT pre-mixed RDO.
/cc @jchapmanAdd MC16 pile-up premixing ART tests both for standard and MT pre-mixed RDO.
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27410Change print xyz to print(xyz) in Python files in SCT packages for Python 32019-10-24T03:02:29+02:00Susumu OdaChange print xyz to print(xyz) in Python files in SCT packages for Python 3Change print xyz to print(xyz) in Python files in SCT packages for Python 3Change print xyz to print(xyz) in Python files in SCT packages for Python 3https://gitlab.cern.ch/atlas/athena/-/merge_requests/27322Remove LArBadChanTool references2019-10-29T03:02:11+01:00Pavol StrizenecRemove LArBadChanTool referencesTitle says it, this should remove any references to (already non-existing) LArBadChanTool from many jO.Title says it, this should remove any references to (already non-existing) LArBadChanTool from many jO.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27320Cleanup of the beamspot service usage2019-11-02T03:02:27+01:00Anthony MorleyCleanup of the beamspot service usageStarting cleanup of the beamspot service usageStarting cleanup of the beamspot service usagehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27319Set Cardinality of ID and MS Digitization Algorithms in Overlay jobs2019-10-23T03:02:56+02:00John Derek ChapmanSet Cardinality of ID and MS Digitization Algorithms in Overlay jobsUpdate the syntax of the various digitization Algorithms to meet
current standards and set them to be clonable.
This is a step towards dropping the individual Algorithms and just use
a common Algorithm for running a single PileUpTool.
S...Update the syntax of the various digitization Algorithms to meet
current standards and set them to be clonable.
This is a step towards dropping the individual Algorithms and just use
a common Algorithm for running a single PileUpTool.
Set the Cardinality of ID and MS digitization Algorithms in Overlay
jobs to be equal to the number of threads.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27303First attempt at writing Digitization/Parameters based on ConfigFlags2019-10-23T03:02:14+02:00John Derek ChapmanFirst attempt at writing Digitization/Parameters based on ConfigFlagsAdd new module to write `Digitization/Parameters` in file metadata in `ComponentAccumulator`-based
configuration of digitization jobs. It should be expanded in the future as more `ConfigFlags` are added.Add new module to write `Digitization/Parameters` in file metadata in `ComponentAccumulator`-based
configuration of digitization jobs. It should be expanded in the future as more `ConfigFlags` are added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27279Make FE masking possible without further information needed in the DB2019-11-04T13:31:15+01:00Kira AbelingMake FE masking possible without further information needed in the DBMasking is used to tell athena in detector simulation that certain (pixel) modules or parts of it are not working. Those masks are stored in the COOL database.
The mask itself consists of three entries: the module hash-ID, the module...Masking is used to tell athena in detector simulation that certain (pixel) modules or parts of it are not working. Those masks are stored in the COOL database.
The mask itself consists of three entries: the module hash-ID, the module status and the front-end status. While the module status is either 0 (working) or 1 (dead), the front-end status is encoded to include all front-ends of a module in a single number. For this the binary representation (e.g. 1111 for four front-ends masked or 0101 for two of four front-ends masked) is translated into an integer (e.g. 15 or 5). Furthermore, the old code required the same information again but in detached and inverted binary representation. Such that the database entry for the examples from above would look like this:
```
hashID MStatus FEStatus
XXXXXX 0 15 1 1 1 1
XXXXXX 0 5 1 0 1 0
```
Unless there is the usage for a front-end status that is neither 0 (working) nor 1 (dead) this is redundant information that needed to be stored in the DB which also increases the DB size not negligibly.
The proposed "fix" is to simply set the the front-end status to 1 if the binary representation of the integer front-end status suggests that the front-end should be masked.
Locally, all Tier0 tests have been passed. It is under discussion, if this change should be propagated to master.
FYI @nstyles , @nreadiof , @ncalace , @tstreble , @tidreyer https://gitlab.cern.ch/atlas/athena/-/merge_requests/27253Avoid double inclusion of PixelChargeCalibCondAlg2019-10-19T03:02:24+02:00Tulay Cuhadar DonszelmannAvoid double inclusion of PixelChargeCalibCondAlgDue to double adding of the PixelChargeCalibCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari , @vpascuzzDue to double adding of the PixelChargeCalibCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari , @vpascuzzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27197Conditions migration (PixelDistortionTool: ATLASRECTS-4719)2019-10-26T03:02:14+02:00Soshi TsunoConditions migration (PixelDistortionTool: ATLASRECTS-4719)The PixelDistortionTool is migrated to new PixelConditionsAlgorithm / PixelDistortionData.
Therefore, PixelDistortionTool is no longer necessary, thus deleted.The PixelDistortionTool is migrated to new PixelConditionsAlgorithm / PixelDistortionData.
Therefore, PixelDistortionTool is no longer necessary, thus deleted.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27186Avoid double inclusion of PixelConfigCondAlg2019-10-16T03:02:13+02:00Tulay Cuhadar DonszelmannAvoid double inclusion of PixelConfigCondAlgThe problem is discussed in https://its.cern.ch/jira/browse/ATLASSIM-4320.
Due to double adding of the PixelConfigCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari, @vpascuzzThe problem is discussed in https://its.cern.ch/jira/browse/ATLASSIM-4320.
Due to double adding of the PixelConfigCondAlg, FastChain tests fail in master. The fix is provided for that.
Adding @jchapman, @tlari, @vpascuzzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27172Updates to NSW smearing tool and adding usage to digitization2020-04-11T09:26:47+02:00Stefano RosatiUpdates to NSW smearing tool and adding usage to digitizationCompleting the NSW smearing tool, and adding its usage to the MM and STGC digitization tools.
Also some cleanup of the digitization code.
Please note that the majority of the changes in the MM_DigitizationTool are just fixes in the c...Completing the NSW smearing tool, and adding its usage to the MM and STGC digitization tools.
Also some cleanup of the digitization code.
Please note that the majority of the changes in the MM_DigitizationTool are just fixes in the code indentation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/27168LArPileUpTool , static -> static const2019-10-15T03:01:58+02:00Christos Anastopouloschristos.anastopoulos@cern.chLArPileUpTool , static -> static constJust change a few ``static`` to ``static const``Just change a few ``static`` to ``static const``https://gitlab.cern.ch/atlas/athena/-/merge_requests/27136Manual sweep of: Adding switch to MM Digi to toggle VMM neighbor logic2019-10-12T03:02:15+02:00Patrick ScholerManual sweep of: Adding switch to MM Digi to toggle VMM neighbor logicManual merge of https://gitlab.cern.ch/atlas/athena/merge_requests/26913 from 21.3 to masterManual merge of https://gitlab.cern.ch/atlas/athena/merge_requests/26913 from 21.3 to masterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/27036Replace used PixelConditionsSummarySvc by PixelConditionsSummaryTool and...2019-10-09T03:02:15+02:00Susumu OdaReplace used PixelConditionsSummarySvc by PixelConditionsSummaryTool and...Replace used PixelConditionsSummarySvc by PixelConditionsSummaryTool and remove unused PixelConditionsSummarySvc.Replace used PixelConditionsSummarySvc by PixelConditionsSummaryTool and remove unused PixelConditionsSummarySvc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/26931Updating the NSW smearing and efficiency tool2020-01-01T03:03:55+01:00Stefano RosatiUpdating the NSW smearing and efficiency toolAdding more smearing functions, improving the granularity.
Adding configuration to the digitization.Adding more smearing functions, improving the granularity.
Adding configuration to the digitization.