athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-26T07:24:07+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69213Clean up more legacy config from RunDependentSimComps2024-02-26T07:24:07+01:00John Derek ChapmanClean up more legacy config from RunDependentSimCompsRemoving more legacy configuration code from the `RunDependentSimComps` package.Removing more legacy configuration code from the `RunDependentSimComps` package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69203Draft: HepMcParticleLink: Testing the adaption to GenParticle::id2024-02-29T14:08:28+01:00John Derek ChapmanDraft: HepMcParticleLink: Testing the adaption to GenParticle::idFollows !69076Follows !69076https://gitlab.cern.ch/atlas/athena/-/merge_requests/69196Remove unused SCT_ModuleDistortions package2024-02-24T13:54:59+01:00Thomas StreblerRemove unused SCT_ModuleDistortions packageRemove unused SCT_ModuleDistortions package (only interfaced for configs which were actually never enabled). Would require proper CA configs otherwise
FYI @jchapman @tadej @sroeRemove unused SCT_ModuleDistortions package (only interfaced for configs which were actually never enabled). Would require proper CA configs otherwise
FYI @jchapman @tadej @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69155Add BRAN module digitization2024-03-04T11:53:06+01:00Chad Stephen LantzAdd BRAN module digitizationAdded digitization of the BRAN module in the ZDC simulationAdded digitization of the BRAN module in the ZDC simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/6913524.0-coverity-ZDC_SimEvent2024-02-24T14:13:23+01:00Shaun Roe24.0-coverity-ZDC_SimEventResolving coverity defect 19683 (memory leak) reported in ATLASSIM-7080 by removing a 'copy constructor' taking bare pointer argument. While there, removed slightly dangerous Add, Equals methods (which seem anyway to be unused).
Explicit...Resolving coverity defect 19683 (memory leak) reported in ATLASSIM-7080 by removing a 'copy constructor' taking bare pointer argument. While there, removed slightly dangerous Add, Equals methods (which seem anyway to be unused).
Explicitly targeting 24.0 as bugfix (will be swept to main?).https://gitlab.cern.ch/atlas/athena/-/merge_requests/691252024-02-22: merge of 24.0 into main2024-02-22T13:48:48+01:00Frank Winklmeier2024-02-22: merge of 24.0 into mainThis sweep contains the following MRs:
* !69102 TrigInDetConfig: remove usage of ConfigurableCABehavior ~Trigger, ~TriggerID
* !69114 Update test_q443.sh to use correct CA option ~Tools
* !69103 TriggerMenuMT: remove legacy menu suppo...This sweep contains the following MRs:
* !69102 TrigInDetConfig: remove usage of ConfigurableCABehavior ~Trigger, ~TriggerID
* !69114 Update test_q443.sh to use correct CA option ~Tools
* !69103 TriggerMenuMT: remove legacy menu support from MET.ConfigHelpers ~JetEtmiss, ~Trigger, ~TriggerMenu
* !69090 clean up in the tau chains and addition of PhI items in the P1 Menu, ATR-28842 ATR-28839 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69029 Clean up legacy configs in DerivationFrameworkJetEtMiss + JetJvtEfficiency ~Derivation, ~JetEtmiss, ~Reconstruction
* !69084 Clean up legacy MET monitoring ~DQ, ~JetEtmiss, ~Reconstruction
* !69085 Clean up legacy METUtilities ~JetEtmiss, ~Reconstruction
* !69086 Clean up legacy METReconstruction ~JetEtmiss, ~Reconstruction
* !69083 Clean up legacy RecBackgroundAlgs ~Reconstruction
* !69025 SCT_ConditionsTools legacy config clean up ~DQ, ~InnerDetector
* !69074 DecisionHandling+TrigPartialEventBuilding: remove support for legacy menu ~Trigger
* !68989 Implement HLT tau preselection ~BTagging, ~DQ, ~JetEtmiss, ~Tau, ~Trigger, ~TriggerEDM, ~TriggerJet, ~TriggerMenu, ~changes-trigger-counts
* !69068 ATR-28783: Cleanup after legacy removal on release 24.0 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69065 Add TrigInDetAnalysis 2D efficiencies and the completed error calculation ~Trigger
* !69082 gFEX MET fix ~L1Calo, ~Trigger
* !69026 xAODTrigMuonCnv legacy config clean up ~EDM, ~MuonSpectrometer, ~Trigger
* !69073 TriggerMenuMT: remove legacy JSON generation code ~Trigger, ~TriggerMenu
* !69072 Fixing out-of-bounds warning in static analysis ~L1Calo, ~Trigger
* !69067 TriggerMenuMT: further cleanup of legacy code ~JetEtmiss, ~Trigger, ~TriggerMenu
* !69045 Only setup trigger acceleration tool and service for running FTF in GPU mode ~ITk, ~Trigger, ~TriggerID
* !69058 Reverting back to MT for muon and ttbar ITk FTF trigger tests ~ITk, ~Trigger
* !69057 Correct tag for the online folder /MDT/Onl/MM/CABLING ~MuonSpectrometer
* !68940 Configure monitoring for BeamSpot post-processing script ~DQ, ~InnerDetector
* !69036 Activate IDPVM ART test for release 24 ~InnerDetector, ~Tracking
* !68999 Remove old style VP1 configuration ~EventDisplay
* !69024 SCT_Cabling legacy config clean up ~InnerDetector
* !69022 InDetPrepRawDataToxAOD legacy config clean up ~InnerDetector
* !69021 PixelRawDataByteStreamCnv legacy config clean up ~InnerDetector
* !69020 SiClusterizationTool legacy config clean up ~InnerDetector
* !69019 IDPVM legacy config clean up ~InnerDetector, ~JetEtmiss, ~Tracking
* !69005 LUCID_Digitization: Clean-up obsolete job options ~Digitization, ~ForwardDetectors
* !69004 RPC_Digitization: Clean-up obsolete job options ~Digitization, ~MuonSpectrometer
* !68993 Remove legacy Campaigns and RunDependentSimData/Comps job options ~Digitization, ~Simulation, ~Tools
* !69027 PixelConditionsTools legacy config clean up ~InnerDetector
* !69038 Clean up legacy configs in egammaPerformance ~DQ, ~Egamma, ~Reconstruction
* !68975 Removal of legacy config for DAOD production - part 5 ~Derivation, ~Tools
* !69028 TRT_ConditionsAlgs legacy config clean up ~InnerDetector
* !69035 Fix HitAnalysis configs import ~Simulation
The following MRs have been reverted:
* !69049 MuonPhaseII -- Remove unit tests ~MuonSpectrometer, ~Upgrade, ~sweep:ignorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69076Draft: HepMcParticleLink: Flag whether link points to suppressed pile-up truth2024-02-23T17:38:05+01:00John Derek ChapmanDraft: HepMcParticleLink: Flag whether link points to suppressed pile-up truthFollows !69055Follows !69055https://gitlab.cern.ch/atlas/athena/-/merge_requests/69014Deactivate Run2 Digitization and Overlay ART jobs for 23.0 branch2024-02-21T13:18:07+01:00John Derek ChapmanDeactivate Run2 Digitization and Overlay ART jobs for 23.0 branchRun2 Digitization and Overlay will not be run in 23.0.X releases in production at this point, so disabling the corresponding ART tests for this branch to save CPU.
NB No need to sweep these changes to other branches.
Tagging @tadejRun2 Digitization and Overlay will not be run in 23.0.X releases in production at this point, so disabling the corresponding ART tests for this branch to save CPU.
NB No need to sweep these changes to other branches.
Tagging @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69005LUCID_Digitization: Clean-up obsolete job options2024-02-22T10:49:24+01:00John Derek ChapmanLUCID_Digitization: Clean-up obsolete job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69004RPC_Digitization: Clean-up obsolete job options2024-02-22T10:49:24+01:00John Derek ChapmanRPC_Digitization: Clean-up obsolete job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68992test_Digi_tf_mc21a_MP_presampling_reproducibility.sh - fix typo (ATLASSIM-7059)2024-02-19T22:14:15+01:00John Derek Chapmantest_Digi_tf_mc21a_MP_presampling_reproducibility.sh - fix typo (ATLASSIM-7059)Fixing this test for now, but will soon replace it with an mc23e configuration (when available).
(This fix is only needed for the main branch.)Fixing this test for now, but will soon replace it with an mc23e configuration (when available).
(This fix is only needed for the main branch.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68987DigitizationTests(MT) Fixes to failing tests. ATLASSIM-70592024-02-18T19:45:23+01:00John Derek ChapmanDigitizationTests(MT) Fixes to failing tests. ATLASSIM-7059Fixes for some failing DigitizationTests(MT) ART scripts.
Tagging @zhubacekFixes for some failing DigitizationTests(MT) ART scripts.
Tagging @zhubacekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68976Restructure core Digitization packages2024-03-01T20:36:13+01:00John Derek ChapmanRestructure core Digitization packages```
Simulation/Digitization -> Simulation/Digitization/DigitizationConfig
Simulation/G4Utilities/MCTruthSimAlgs -> Simulation/Digitization/MCTruthSimAlgs
```
Perhaps also move the following in a follow-up MR?
```
Control/PileUpComps -> S...```
Simulation/Digitization -> Simulation/Digitization/DigitizationConfig
Simulation/G4Utilities/MCTruthSimAlgs -> Simulation/Digitization/MCTruthSimAlgs
```
Perhaps also move the following in a follow-up MR?
```
Control/PileUpComps -> Simulation/Digitization/PileUpComps
Control/PileUpTools -> Simulation/Digitization/PileUpTools
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/68974Remove more obsolete Simulation code2024-02-17T19:10:10+01:00John Derek ChapmanRemove more obsolete Simulation codeDrop obsolete packages:
```
Simulation/SimulationJobOptions
Simulation/ISF/ISF_Example
```
Clear up of more obsolete code (including some C++!) from the DigitizationTests package.Drop obsolete packages:
```
Simulation/SimulationJobOptions
Simulation/ISF/ISF_Example
```
Clear up of more obsolete code (including some C++!) from the DigitizationTests package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68909Remove legacy Tile Digitization configuration2024-02-15T20:24:57+01:00John Derek ChapmanRemove legacy Tile Digitization configurationRemove legacy Tile Digitization configurationRemove legacy Tile Digitization configurationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68908Removal of most legacy LArDigitization configuration2024-02-15T20:20:29+01:00John Derek ChapmanRemoval of most legacy LArDigitization configurationRemoval of most legacy LArDigitization configuration. Leaving LArDigitizationFlags for now.Removal of most legacy LArDigitization configuration. Leaving LArDigitizationFlags for now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68873Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)2024-02-14T18:04:16+01:00John Derek ChapmanFix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)
This merge request only affects ART scripts, so will not change CI test outputs.Fix RDOMerge_tf.py syntax in mc23 presampling tests (ATLASSIM-7084)
This merge request only affects ART scripts, so will not change CI test outputs.