athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68774Remove legacy skeletons for HITtoRDO and RDOMerge2024-02-14T16:10:27+01:00John Derek ChapmanRemove legacy skeletons for HITtoRDO and RDOMergeThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmoreThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6495023.0 zdc mc update ATLASSIM-67512023-11-14T22:50:39+01:00Chad Stephen Lantz23.0 zdc mc update ATLASSIM-6751This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.This is a complete overhaul of the ZDC simulation packages. Due to the scope of the changes it was infeasible to break this into smaller pieces.Chad Stephen LantzChad Stephen Lantzhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66773Draft: main-cleanup3-PixelDigitization2023-10-30T08:58:34+01:00Shaun RoeDraft: main-cleanup3-PixelDigitizationBuilding on earlier MRs, this implements proposals 20-22 of ATLASRECTS-7721:
* delete all calls to getFEI4ChargScaling _sic_ (this scaling factor is always set to 1.0)
* remove "if getUseFEI4SpecialScalingFunction", as this bool is...Building on earlier MRs, this implements proposals 20-22 of ATLASRECTS-7721:
* delete all calls to getFEI4ChargScaling _sic_ (this scaling factor is always set to 1.0)
* remove "if getUseFEI4SpecialScalingFunction", as this bool is always true
* replace use of PixelModuleData::getFEI4ToTSigma(int tot) with a local function, as this simply returns an element in a vector which is never changed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776Draft: Revert "Merge branch 'main-cleanup-PixelToTPIDTool' into 'main'"2023-10-27T16:24:44+02:00Vakhtang TsulaiaDraft: Revert "Merge branch 'main-cleanup-PixelToTPIDTool' into 'main'"This reverts merge request !66709
The MR is reverted to fix the failure of the `MuonCombinedRecoConfigTest` as discussed on ATLASRECTS-7791This reverts merge request !66709
The MR is reverted to fix the failure of the `MuonCombinedRecoConfigTest` as discussed on ATLASRECTS-7791https://gitlab.cern.ch/atlas/athena/-/merge_requests/64539Draft: Replace boost with STL, please do not review, will not be merged in th...2023-10-10T13:25:31+02:00Andrii VerbytskyiDraft: Replace boost with STL, please do not review, will not be merged in the present state.Replace boost with STLReplace boost with STLhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61489Draft: Make noerror.sh check for all kinds of FPEs2023-08-04T20:06:30+02:00Tadej Novaktadej.novak@cern.chDraft: Make noerror.sh check for all kinds of FPEsMake `noerror.sh` check for all kinds of FPEs. Not sure why we only checked for `INVALID` but not the rest.
Maybe @fwinkl remembers the motivation.Make `noerror.sh` check for all kinds of FPEs. Not sure why we only checked for `INVALID` but not the rest.
Maybe @fwinkl remembers the motivation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62222Draft: Replace outdated code with STL2023-07-22T20:31:09+02:00Andrii VerbytskyiDraft: Replace outdated code with STLReplace outdated code with STL. Not to be merged!Replace outdated code with STL. Not to be merged!https://gitlab.cern.ch/atlas/athena/-/merge_requests/63976Draft: 23.0 zdc utils2023-06-30T22:45:15+02:00Chad Stephen LantzDraft: 23.0 zdc utilsAdd ZdcUtils which currently contains a set of waveform classes to be used for both analysis and MC digitization. This directory will eventually contain utilities to automate detector configuration for better reproducibility of MC and re...Add ZdcUtils which currently contains a set of waveform classes to be used for both analysis and MC digitization. This directory will eventually contain utilities to automate detector configuration for better reproducibility of MC and reco/analysis.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60401Annealing for robust fit2023-06-14T23:51:26+02:00Vadim KostyukhinAnnealing for robust fitUse small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.Use small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60737Draft: An interesting test with ParticleLink2023-06-06T16:40:20+02:00Andrii VerbytskyiDraft: An interesting test with ParticleLinkAn interesting test with ParticleLink
Will that work better? Will that work at all?
@tadej @jchapman @christosAn interesting test with ParticleLink
Will that work better? Will that work at all?
@tadej @jchapman @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62221Draft: Optimization in Simulation2023-06-06T16:29:38+02:00Andrii VerbytskyiDraft: Optimization in SimulationOptimization in SimulationOptimization in Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63115Daily merge of 23.0 into master2023-05-18T19:48:57+02:00Vakhtang TsulaiaDaily merge of 23.0 into masterConflicts:
- `SiClusterizationTool/ClusterMakerTool`. The conflict was caused by !62853 and !62051. It required manual resolution. @cvarni and @smh could you please check that everything is OK there.
- `ActsTrkClusterizationToolsConfig.p...Conflicts:
- `SiClusterizationTool/ClusterMakerTool`. The conflict was caused by !62853 and !62051. It required manual resolution. @cvarni and @smh could you please check that everything is OK there.
- `ActsTrkClusterizationToolsConfig.py`. The file has been deleted in the ~master and modified in the ~23.0. So, I ignored the latter modifications. Hopefully, this was the right thing to do.
This sweep contains the following MRs:
* !63107 Adding noalg eEM9 ~Trigger, ~TriggerMenu
* !63079 Correction to m_trigDec feature container for muon matching ~DQ, ~Trigger
* !63075 Reconstruction - Remove scheduler warning from TTVA tools ~JetEtmiss, ~Reconstruction, ~Tau
* !63072 DerivationFrameworkTruth - Declare truth classifier dependencies & breakup kernels ~Derivation, ~Tau
* !63065 Moving noise filling to the jTower creation ~Trigger
* !62853 Retrieve PixelCalibData ReadCondHandles once per call ~ACTS, ~Digitization, ~InnerDetector, ~Tracking
* !63021 xAODRootAccess: Don't check names of aux variables read from the input. ~Core
* !63069 add inner-coincidence plots to TGC offline DQ ~DQ, ~MuonSpectrometer, ~Trigger
* !62930 New NSW container to dump the trigger processor ~Analysis, ~Build, ~EDM, ~MuonSpectrometer, ~Run3-DataReco-output-changed, ~Tools, ~Trigger, ~frozen-tier0-violating
* !63063 ATR-26675, ATR-26776: Switch Topo3 to AlfaCtpIn by ConfigFlag ~Trigger, ~TriggerMenu
* !63064 Muctpi DQM ~DQ, ~Trigger
* !62983 TrigValidation: update ART inputs (data23 cosmics, MC23a RDOs) ~Trigger, ~changes-trigger-counts
* !63030 Remove barcodes from the reconstruction ~Egamma, ~JetEtmiss, ~Reconstruction
* !63018 Remove barcodes from InnerDetector/InDetValidation ~InnerDetector, ~JetEtmiss
* !63041 quick fix in large-R jet collection name ~Analysis, ~BTagging, ~Derivation, ~JetEtmiss
* !63056 CalibMomentumProvider - Remove PRW tool ~Analysis
* !63058 TrfTestsART: Update conditionstag to CONDBR2-BLKPA-RUN2-11 ~Tools
* !63062 Remove obsolete DigitizationTests and DigitizationTestsMT ART jobs (ATLASSIM-6559) ~Digitization, ~Simulation
* !63052 JetSelectorTools - Declare photon dressing ~Analysis, ~BTagging, ~JetEtmiss
* !62970 OrUtils - Declare data dependencies ~Analysis
* !63055 bug fixes in TGC trigger data decoder ~MuonSpectrometerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63010Update R22 derivations to use large-R jet pre-recommendations calibration2023-05-11T18:48:28+02:00Matt LeBlancUpdate R22 derivations to use large-R jet pre-recommendations calibrationHi, we're just updating some places in the derivation framework to now use the R22 pre-recommendations for large-R jet JES and JMS, now that it's available. This means using this file: `JES_MC20PreRecommendation_R10_UFO_CSSK_SoftDrop_JMS...Hi, we're just updating some places in the derivation framework to now use the R22 pre-recommendations for large-R jet JES and JMS, now that it's available. This means using this file: `JES_MC20PreRecommendation_R10_UFO_CSSK_SoftDrop_JMS_R21Insitu_10Mar2023.config`
More info here:
https://twiki.cern.ch/twiki/bin/view/AtlasProtected/ApplyJetCalibrationR22#R_1_0_unified_flow_object_UFO_je
:beers: MLBhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62533createTagMetaInfoFS update2023-04-24T16:04:56+02:00Mikhail MineevcreateTagMetaInfoFS updateSmall update:
- added a possibility to set CREST server root endpoint in the constructor,
- updated createTagMetaInfoFs.Small update:
- added a possibility to set CREST server root endpoint in the constructor,
- updated createTagMetaInfoFs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60432Add linear extrapolation in old charge calibration (ATLASRECTS-7337)2023-04-13T09:55:21+02:00Soshi TsunoAdd linear extrapolation in old charge calibration (ATLASRECTS-7337)Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calib...Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calibration.
For (1), the default is false. Thus, no impact at all for this MR. In the time of the reprocessing of RUN1/RUN2 data, it will be activated.
For (2), the new format /PIXEL/ChargeCalibration also keeps contents from /PIXEL/PixCalib/. The /PIXEL/PixCalib/ is obsoleted and it is not practical any more to maintain because maintaining both folders simply leads double burden.
Supposing the contents in both conditions DB are identical used in this CI test, the results should be identical.