athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-06-06T16:29:38+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/62221Draft: Optimization in Simulation2023-06-06T16:29:38+02:00Andrii VerbytskyiDraft: Optimization in SimulationOptimization in SimulationOptimization in Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62134AF3: mirror showers for positrons and negative hadrons2023-04-05T19:17:28+02:00Christopher YoungAF3: mirror showers for positrons and negative hadronsWhen we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the cod...When we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the code.
These changes are pretty small but might help some electron ID agreement. Tests of the change on the angle of topoclusters are shown here;
https://indico.cern.ch/event/1274181/
indicating that this will be a small change to the physics but is in the correct direction.
Note that this will change the AF3 nightly output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62107DetDescSvc - Some clean up2023-04-15T12:54:42+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDetDescSvc - Some clean up`DetDescrCnvSvc`:
* Use ATH_MSG messaging macros
* Add switches to toggle all muon sub detectors seperately
* Useage of ATH_CHECK macros
`DetDescrConverter`:
* Remove commented code
`IdDictDetDescrCnv`:
* Inherit from `AthMessaging`
*...`DetDescrCnvSvc`:
* Use ATH_MSG messaging macros
* Add switches to toggle all muon sub detectors seperately
* Useage of ATH_CHECK macros
`DetDescrConverter`:
* Remove commented code
`IdDictDetDescrCnv`:
* Inherit from `AthMessaging`
* Factor common structures into seperate methods
`MuonIdHelperSvc`:
* Toggle the remaining subdetectors from the description
Tagging: @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62095Draft: Use const reference in printout functions in AtlasHepMC2023-04-11T19:57:22+02:00Andrii VerbytskyiDraft: Use const reference in printout functions in AtlasHepMCUse const reference in printout functions in AtlasHepMC
Thanks to @cvarni for the suggestion!
Tag @jchapman @pclarkUse const reference in printout functions in AtlasHepMC
Thanks to @cvarni for the suggestion!
Tag @jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62009Draft: Update GenEvent.h to make fillAttribute() safer.2023-04-03T11:32:04+02:00Andrii VerbytskyiDraft: Update GenEvent.h to make fillAttribute() safer.Update GenEvent.h to make fillAttribute() safer: the fillAttribute() will operate only on the event to which the barcodes are attached.
Tag @ssnyder @jchapmanUpdate GenEvent.h to make fillAttribute() safer: the fillAttribute() will operate only on the event to which the barcodes are attached.
Tag @ssnyder @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61979Draft: Optimize HepMC::barcode_to_X using the const references2023-06-06T16:32:43+02:00Andrii VerbytskyiDraft: Optimize HepMC::barcode_to_X using the const referencesOptimize HepMC::barcode_to_X using the const references
Tag @jchapmanOptimize HepMC::barcode_to_X using the const references
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61736Some improvements in the printouts in TruthParticleID2023-04-11T13:50:04+02:00Andrii VerbytskyiSome improvements in the printouts in TruthParticleIDSome improvements in the printouts in TruthParticleID
@jchapman , please have a look.Some improvements in the printouts in TruthParticleID
@jchapman , please have a look.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61164Superchic: remove the wrong definition of LHAPDF. It causes crash of ART tests.2023-03-02T16:26:32+01:00Ewelina Maria LobodzinskaSuperchic: remove the wrong definition of LHAPDF. It causes crash of ART tests.LHAPATH is already defined in atlasexternal,
manual sweep,
analogous MR was already merged for master: https://gitlab.cern.ch/atlas/athena/-/merge_requests/60911LHAPATH is already defined in atlasexternal,
manual sweep,
analogous MR was already merged for master: https://gitlab.cern.ch/atlas/athena/-/merge_requests/60911https://gitlab.cern.ch/atlas/athena/-/merge_requests/60896Draft: Simplerplinks22023-04-11T19:56:32+02:00Andrii VerbytskyiDraft: Simplerplinks2Try to find out how may places need an explicit constructor with particlesTry to find out how may places need an explicit constructor with particleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60534Draft: Mark HepMC3 attributes as parsed to speedup the access2023-02-13T15:31:26+01:00Andrii VerbytskyiDraft: Mark HepMC3 attributes as parsed to speedup the accessMark HepMC3 attributes as parsed to speedup the access
Tag @jchapman @tadejMark HepMC3 attributes as parsed to speedup the access
Tag @jchapman @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60432Add linear extrapolation in old charge calibration (ATLASRECTS-7337)2023-04-13T09:55:21+02:00Soshi TsunoAdd linear extrapolation in old charge calibration (ATLASRECTS-7337)Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calib...Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calibration.
For (1), the default is false. Thus, no impact at all for this MR. In the time of the reprocessing of RUN1/RUN2 data, it will be activated.
For (2), the new format /PIXEL/ChargeCalibration also keeps contents from /PIXEL/PixCalib/. The /PIXEL/PixCalib/ is obsoleted and it is not practical any more to maintain because maintaining both folders simply leads double burden.
Supposing the contents in both conditions DB are identical used in this CI test, the results should be identical.https://gitlab.cern.ch/atlas/athena/-/merge_requests/60401Annealing for robust fit2023-06-14T23:51:26+02:00Vadim KostyukhinAnnealing for robust fitUse small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.Use small annealing in vertex fits with robust option depending on the fit iteration number.
This should speed up convergence and help to avoid fake minima.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59967Load more high-pt minbias is NumberOfHighPtMinBias is set too low2023-01-21T01:18:44+01:00Beojan Stanislausbeojan.stanislaus@cern.chLoad more high-pt minbias is NumberOfHighPtMinBias is set too lowShould solve issue raised in !59957Should solve issue raised in !59957https://gitlab.cern.ch/atlas/athena/-/merge_requests/5984923.0-clang15-GeneratorObjectsTPCnv2023-01-17T17:13:31+01:00Shaun Roe23.0-clang15-GeneratorObjectsTPCnvSuppress unknown pragma warning for clang by using GCC/Clang pragma to suppress -Wunknown-pragmas.
Pertains to ATLASRECTS-7430, tagging @ssnyder, @jchapman for info.Suppress unknown pragma warning for clang by using GCC/Clang pragma to suppress -Wunknown-pragmas.
Pertains to ATLASRECTS-7430, tagging @ssnyder, @jchapman for info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59650Draft: Should be faster fastcalosim2023-04-13T17:23:54+02:00Andrii VerbytskyiDraft: Should be faster fastcalosimShould be faster fastcalosim. Do not merge. Draft.
Tag @jchapman
To be discussed if this is needed.Should be faster fastcalosim. Do not merge. Draft.
Tag @jchapman
To be discussed if this is needed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59134Use double for vertex weights2022-12-10T16:03:41+01:00Andrii VerbytskyiUse double for vertex weightsUse double for vertex weights.
Tag @jchapmanUse double for vertex weights.
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58993Draft: Photospp_i: thread-checker fixes and cleanup2022-12-08T09:39:50+01:00Frank WinklmeierDraft: Photospp_i: thread-checker fixes and cleanup- mark statics as not thread-safe
- remove unused `DelayInitialisation` property/feature
- remove import of namespace
- minor cleanups- mark statics as not thread-safe
- remove unused `DelayInitialisation` property/feature
- remove import of namespace
- minor cleanupshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58944Update version.txt to 22.6.262022-12-05T16:54:35+01:00Ewelina Maria LobodzinskaUpdate version.txt to 22.6.26update the release version to 22.6.26update the release version to 22.6.26https://gitlab.cern.ch/atlas/athena/-/merge_requests/58937Draft: Commented lines in the process file can still affect the guess of ktdu...2023-03-17T10:26:37+01:00Javier Montejo BerlingenDraft: Commented lines in the process file can still affect the guess of ktdurham scale, fixingSpotted unwanted behaviour where the ktdurham scale is set wrongly because it reads SUSY particles showing up in commented lineSpotted unwanted behaviour where the ktdurham scale is set wrongly because it reads SUSY particles showing up in commented linehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/58810Draft: Move Track Fit Quality from ptr to value2022-12-01T19:11:20+01:00Christos Anastopouloschristos.anastopoulos@cern.chDraft: Move Track Fit Quality from ptr to valueMove Track Fit Quality from ptr to valueMove Track Fit Quality from ptr to value