athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-11-11T11:42:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/39716Make McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robust2021-11-11T11:42:35+01:00John Derek ChapmanMake McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robustThis commit makes `McEventCollectionCnv_p5_test` and `McEventCollectionCnv_p4_test` more robust by:
- checking all properties of the `GenEvent`.
- `GenVertex` positions not at `(0,0,0)` to properly test TP conversion of those variables....This commit makes `McEventCollectionCnv_p5_test` and `McEventCollectionCnv_p4_test` more robust by:
- checking all properties of the `GenEvent`.
- `GenVertex` positions not at `(0,0,0)` to properly test TP conversion of those variables.
- some double-precision properties are only stored with single-precision in the persistent version, so must be cast to `float` before being compared.
The current versions of `McEventCollectionCnv_p5` and `McEventCollectionCnv_p4` flip the order of the `GenParticles`
associated with each `GenVertex` after T1->P1->T2 conversion. Running though this twice
is sufficient to regain agreement (i.e. T1->P1->T2->P2->T3. T1 == T3 != T2).https://gitlab.cern.ch/atlas/athena/-/merge_requests/48122Fix Starlight interface2021-11-10T21:43:33+01:00Andrii VerbytskyiFix Starlight interfaceFix Starlight interface: set seed to random number gererator.
Tag @ewelina, @mdyndalFix Starlight interface: set seed to random number gererator.
Tag @ewelina, @mdyndalhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48092Port of fixes from HepMC3 branch into master2021-11-09T21:43:17+01:00Andrii VerbytskyiPort of fixes from HepMC3 branch into masterPort of fixes from HepMC3 branch into master.
In this MR:
- Instead of removing bad particles try to apply some heuristics: check if broken particles can be fixed adding one vertex that would constitute to 1->, 2->1 or 1-> splitting/me...Port of fixes from HepMC3 branch into master.
In this MR:
- Instead of removing bad particles try to apply some heuristics: check if broken particles can be fixed adding one vertex that would constitute to 1->, 2->1 or 1-> splitting/merging. Essentially this is a workaround for a generator bug.
- Remove the particles with bad pdg ID from the event record.
Tag @ewelina @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47418Update Starlight_i.cxx2021-11-09T15:44:33+01:00Andrii VerbytskyiUpdate Starlight_i.cxxThis is an update that "fixes" the crash in Starlight_i.cxx due to an absent random generator engine.
Observed in
``
test_gen_starlight.sh
``
in ART tests.
Tag @ewelinaThis is an update that "fixes" the crash in Starlight_i.cxx due to an absent random generator engine.
Observed in
``
test_gen_starlight.sh
``
in ART tests.
Tag @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48076GeneratorFilters: Fix clang warnings.2021-11-09T15:43:36+01:00Scott SnyderGeneratorFilters: Fix clang warnings.Unused private data members.Unused private data members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48086Set cross-sections for events produced with EPOS and QGSjet2021-11-09T15:43:18+01:00Andrii VerbytskyiSet cross-sections for events produced with EPOS and QGSjetSet cross-sections for events produced with EPOS and QGSjet
Warning: this MR affects both master-HepMC3 and master-HepMC2 branches. This is a bugfix.
Tag @cgutscho @ewelinaSet cross-sections for events produced with EPOS and QGSjet
Warning: this MR affects both master-HepMC3 and master-HepMC2 branches. This is a bugfix.
Tag @cgutscho @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48089Sweeping !48079 from 21.6 to master.
PowhegControl: fixes for ttjMiNNLOPS - A...2021-11-09T15:42:47+01:00Atlas NightlybuildSweeping !48079 from 21.6 to master.
PowhegControl: fixes for ttjMiNNLOPS - AGENE-2055PowhegControl: fixes for ttjMiNNLOPS - AGENE-2055
See merge request atlas/athena!48079PowhegControl: fixes for ttjMiNNLOPS - AGENE-2055
See merge request atlas/athena!48079https://gitlab.cern.ch/atlas/athena/-/merge_requests/48079PowhegControl: fixes for ttjMiNNLOPS - AGENE-20552021-11-09T14:20:23+01:00Timothee Theveneaux-PelzerPowhegControl: fixes for ttjMiNNLOPS - AGENE-2055Following the discussion in AGENE-2055 I'm trying to fix ttjMiNNLOPS by updating the LD_LIBRARY_PATH with the necessary pointers to dynamic libraries, before the job runs. This requires to switch back to `ATLASOTF-05-01` for the Powheg i...Following the discussion in AGENE-2055 I'm trying to fix ttjMiNNLOPS by updating the LD_LIBRARY_PATH with the necessary pointers to dynamic libraries, before the job runs. This requires to switch back to `ATLASOTF-05-01` for the Powheg installation. I also made some improvement in the default settings for the MadSpin decay of this process.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48053Corrected errors in the ART test2021-11-08T21:43:25+01:00Luzhan YueCorrected errors in the ART testAdded source Rivet command where previously missed and caused the yoda library was not recognized.
Corrected the output file nameAdded source Rivet command where previously missed and caused the yoda library was not recognized.
Corrected the output file namehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48054Corrected erros on the ART test2021-11-08T15:45:24+01:00Luzhan YueCorrected erros on the ART testhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48034Update FixHepMC.cxx2021-11-08T15:42:51+01:00Andrii VerbytskyiUpdate FixHepMC.cxxShould finally fix https://its.cern.ch/jira/browse/AGENE-2092
Tag @ewelinaShould finally fix https://its.cern.ch/jira/browse/AGENE-2092
Tag @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47989Update Herwig7HepMC.cxx to define legacy preprocessor directiv2021-11-07T21:42:14+01:00Andrii VerbytskyiUpdate Herwig7HepMC.cxx to define legacy preprocessor directivShould fix https://its.cern.ch/jira/browse/AGENE-2091
Tag @ewelina @cgutscho @jchapman
Best regards,
AndriiShould fix https://its.cern.ch/jira/browse/AGENE-2091
Tag @ewelina @cgutscho @jchapman
Best regards,
Andriihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47974Update test_05_Zmumu_ph.sh2021-11-06T03:44:39+01:00Luzhan YueUpdate test_05_Zmumu_ph.shhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47991Generators: catch missing cross-sections in HepMC GenEvent2021-11-06T03:41:57+01:00Christian GutschowGenerators: catch missing cross-sections in HepMC GenEventFollow-up from !47983
This is to catch cases where the HepMC GenEvent is missing the generator cross-section and report failure.
Allows to bypass the failure report for debugging purposes.
cc @ewelina @averbytsFollow-up from !47983
This is to catch cases where the HepMC GenEvent is missing the generator cross-section and report failure.
Allows to bypass the failure report for debugging purposes.
cc @ewelina @averbytshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47975Update test_05_Zmumu_ph.sh to test the showering of Herwig2021-11-05T21:43:38+01:00Luzhan YueUpdate test_05_Zmumu_ph.sh to test the showering of HerwigNow the ART tester is testing the showering of Herwig instead of stopped after producing the txt file.Now the ART tester is testing the showering of Herwig instead of stopped after producing the txt file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47953Update FixHepMC.cxx to fix https://its.cern.ch/jira/browse/AGENE-20982021-11-05T03:45:39+01:00Andrii VerbytskyiUpdate FixHepMC.cxx to fix https://its.cern.ch/jira/browse/AGENE-2098Update FixHepMC.cxx to fix https://its.cern.ch/jira/browse/AGENE-2098
Tag @jchapmanUpdate FixHepMC.cxx to fix https://its.cern.ch/jira/browse/AGENE-2098
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47927allowing starlight interface to run with tauola++ afterburner2021-11-04T21:49:04+01:00Mateusz Dyndalallowing starlight interface to run with tauola++ afterburnerThis fix is to prevent STARlight crash when running yy->tautau process together with Tauola++ interface for tau decays. Extra flag is added to change the initial state particles (photons) to electrons in temporary Lhe record. This trick ...This fix is to prevent STARlight crash when running yy->tautau process together with Tauola++ interface for tau decays. Extra flag is added to change the initial state particles (photons) to electrons in temporary Lhe record. This trick was suggested by Tauola++ authors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47934Fix the way to write beam particles in MCEventCollection for HepMC3 branch2021-11-04T21:47:12+01:00Andrii VerbytskyiFix the way to write beam particles in MCEventCollection for HepMC3 branchFix the way to write beam particles in MCEventCollection for HepMC3 branch.
Tag @ewelina @jchapman
Should fix https://its.cern.ch/jira/browse/AGENE-2097
This is a squashed version of https://gitlab.cern.ch/atlas/athena/-/merge_reques...Fix the way to write beam particles in MCEventCollection for HepMC3 branch.
Tag @ewelina @jchapman
Should fix https://its.cern.ch/jira/browse/AGENE-2097
This is a squashed version of https://gitlab.cern.ch/atlas/athena/-/merge_requests/47919https://gitlab.cern.ch/atlas/athena/-/merge_requests/47365add missing generators and tools versions2021-11-04T21:45:11+01:00Ewelina Maria Lobodzinskaadd missing generators and tools versionsmissing version setup in environmental variables is added for some generators and toolsmissing version setup in environmental variables is added for some generators and toolshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47908Update TestHepMC.cxx2021-11-03T21:46:15+01:00Andrii VerbytskyiUpdate TestHepMC.cxxUpdate TestHepMC.cxx to prevent huge printout in case of wrong beam particles.
Tag @ewelinaUpdate TestHepMC.cxx to prevent huge printout in case of wrong beam particles.
Tag @ewelina