athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-01T08:18:09+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68256Draft: Adding an example JO showing how to use the new Pythia8 UserHook2024-02-01T08:18:09+01:00Safa Gaidsafa.gaid@cern.chDraft: Adding an example JO showing how to use the new Pythia8 UserHookI added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.I added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68205Pythia8_i: Don't create stuff in a Gaudi component ctor.2024-02-08T17:08:04+01:00Scott SnyderPythia8_i: Don't create stuff in a Gaudi component ctor.Move the creation of the pythia instance from the ctor of the Gaudi component
to the initialize step. Otherwise that gets run at times we don't really
want it to, such as during genconf.Move the creation of the pythia instance from the ctor of the Gaudi component
to the initialize step. Otherwise that gets run at times we don't really
want it to, such as during genconf.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68185Updating error message to match cut value in EvgenJobTransforms2024-01-18T11:20:23+01:00Zach MarshallUpdating error message to match cut value in EvgenJobTransformsTitle says it all — just a typo in the error message.Title says it all — just a typo in the error message.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68184Generators: handle Sherpa 3 in createLibs-job of sherpaTarCreator2024-01-17T15:17:58+01:00Erik BachmannGenerators: handle Sherpa 3 in createLibs-job of sherpaTarCreatorSmall fix for the sherpaTarCreator: several parameters needed for the createLibs-job were only set for Sherpa 2
cc @ewelina @fsiegertSmall fix for the sherpaTarCreator: several parameters needed for the createLibs-job were only set for Sherpa 2
cc @ewelina @fsiegerthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68173LCG_104c_ATLAS_5 new layer with sereval new Generators versions2024-01-17T17:37:42+01:00Ewelina Maria LobodzinskaLCG_104c_ATLAS_5 new layer with sereval new Generators versionsnew layer LCG_104c_ATLAS_5 containing:
SFGen
madgraph5amc-3.5.3.atlas4
pythia8-310
herwig++-7.3.0 and thepeg-2.3.0
thep8i-2.0.3
evtgen-2.2.1new layer LCG_104c_ATLAS_5 containing:
SFGen
madgraph5amc-3.5.3.atlas4
pythia8-310
herwig++-7.3.0 and thepeg-2.3.0
thep8i-2.0.3
evtgen-2.2.1https://gitlab.cern.ch/atlas/athena/-/merge_requests/68167Pythia8_i: fixed clang warning2024-01-16T13:08:09+01:00Vakhtang TsulaiaPythia8_i: fixed clang warningMissing override keywordMissing override keywordhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68110adding new UserHook to compute CKKWL merging DJRs for Pythia82024-01-15T11:04:07+01:00Safa Gaidsafa.gaid@cern.chadding new UserHook to compute CKKWL merging DJRs for Pythia8Added a new UserHook and a common JO for Pythia8. The UserHook is responsible for computing the merging scales called the DJRs and storing them as ROOT histograms. The code will help ATLAS users do deduce whether the merging scheme is wo...Added a new UserHook and a common JO for Pythia8. The UserHook is responsible for computing the merging scales called the DJRs and storing them as ROOT histograms. The code will help ATLAS users do deduce whether the merging scheme is working properly and if the merging scale aligns correctly with their study.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68100Adding to the README file the tutorial on the CKKWL merging UserHook for Pythia82024-01-10T18:50:51+01:00Safa Gaidsafa.gaid@cern.chAdding to the README file the tutorial on the CKKWL merging UserHook for Pythia8Included the tutorial into the README file of Pythia8. The steps explain the use of the new Pythia8 UserHook and the interpretation of the output. The code will be implemented in a separated merge request afterward.Included the tutorial into the README file of Pythia8. The steps explain the use of the new Pythia8 UserHook and the interpretation of the output. The code will be implemented in a separated merge request afterward.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67788Adding a new UserHook to compute the DJRs for CKKW_L merging scheme and the t...2024-01-10T19:28:11+01:00Safa Gaidsafa.gaid@cern.chAdding a new UserHook to compute the DJRs for CKKW_L merging scheme and the tutorial about the use of the UserHookI Added a new UserHook for Pythia8 to compute the DJRs for the CKKW_L merging algorithm.
Furthermore, in the Pythia8_i README, I integrated a tutorial providing a detailed explanation of the steps for using the UserHook and interpreting ...I Added a new UserHook for Pythia8 to compute the DJRs for the CKKW_L merging algorithm.
Furthermore, in the Pythia8_i README, I integrated a tutorial providing a detailed explanation of the steps for using the UserHook and interpreting the resulting histograms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67776enabling variation of beam energy in LHE event record mode2023-12-13T11:30:11+01:00Mateusz Dyndalenabling variation of beam energy in LHE event record modeThis MR fixes the ValidationException for the beam particles energy mismatch when running Starlight in .LHE mode.This MR fixes the ValidationException for the beam particles energy mismatch when running Starlight in .LHE mode.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67768GeneratorObjectsTPCnv: cmake fix2023-12-12T11:48:57+01:00Scott SnyderGeneratorObjectsTPCnv: cmake fixDependency on GenInterfaces should be public.Dependency on GenInterfaces should be public.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67751Update version.txt to 23.6.232023-12-11T17:14:51+01:00Ewelina Maria LobodzinskaUpdate version.txt to 23.6.23update to 23.6.23update to 23.6.23https://gitlab.cern.ch/atlas/athena/-/merge_requests/67739Replace checks on hard-coded PDG code values with MC:: functions2023-12-11T17:24:39+01:00Andrii VerbytskyiReplace checks on hard-coded PDG code values with MC:: functionsReplace hardcoded constants with MC:: functions
@jchapman @pclarkReplace hardcoded constants with MC:: functions
@jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67708Adding Contur package for BSM interpretation using SM measurements2023-12-11T16:20:39+01:00Peng WangAdding Contur package for BSM interpretation using SM measurementsAdded Contur_i directory to help with setting up the right environment for CONTUR package (produces particle-level exclusion using SM measurements.)
Contur should be compiled after event generation and Rivet as an "off-line" afterburner...Added Contur_i directory to help with setting up the right environment for CONTUR package (produces particle-level exclusion using SM measurements.)
Contur should be compiled after event generation and Rivet as an "off-line" afterburner.
Addresses [this JIRA Ticket](https://its.cern.ch/jira/browse/AGENE-2158)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67674new LCG layer LCG_104c_ATLAS_32023-12-08T09:59:38+01:00Ewelina Maria Lobodzinskanew LCG layer LCG_104c_ATLAS_3A change to new LCG layer requested and discussed in https://sft.its.cern.ch/jira/browse/SPI-2465
Contains:
Pythia308,
installation of MCFM and also a re-installation of Sherpa 2.2.14p1 (+ MPI-enabled Sherpa) with the additional...A change to new LCG layer requested and discussed in https://sft.its.cern.ch/jira/browse/SPI-2465
Contains:
Pythia308,
installation of MCFM and also a re-installation of Sherpa 2.2.14p1 (+ MPI-enabled Sherpa) with the additional —enable-mcfm flag in both cases .
GRPC: done
Madgraph5amc 3.5.2 with patches reviewed and updated by zmarshal
apfel 3.1.0 with new CMake build system.
yoda-1.9.9 + rivet-3.1.9
@elmsheus @nstyles @jchapman @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67667Adding barcodes back into the GeneratorObjects and GeneratorObjectsTPCnv unit...2023-12-08T15:11:54+01:00John Derek ChapmanAdding barcodes back into the GeneratorObjects and GeneratorObjectsTPCnv unit tests.This will become important as the barcode migration (ATLASSIM-6906) continues and we need to
confirm that legacy persistent formats are treated correctly.
NB As the migration progesses barcode support will be dropped from `McEventCollec...This will become important as the barcode migration (ATLASSIM-6906) continues and we need to
confirm that legacy persistent formats are treated correctly.
NB As the migration progesses barcode support will be dropped from `McEventCollection_p7` and
a barcode-independent `HepMcParticleLink_p3` will be introduced.
Tagging @averbyts and @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67653TruthUtils: Hepmc2 fix2023-12-08T10:33:22+01:00Scott SnyderTruthUtils: Hepmc2 fixWith hepmc2, particles get passed by pointer.
If we try to pass by const reference, we can get thread-safety checker
warnings.
Fixes warning seen in MCTruth.With hepmc2, particles get passed by pointer.
If we try to pass by const reference, we can get thread-safety checker
warnings.
Fixes warning seen in MCTruth.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67648Use MC:: namespace explicitly for MuDstarFilter2023-12-07T14:25:48+01:00Andrii VerbytskyiUse MC:: namespace explicitly for MuDstarFilterUse MC:: namespace explicitly for MuDstarFilterUse MC:: namespace explicitly for MuDstarFilterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67628Make Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as ...2024-01-08T15:56:19+01:00Tadej Novaktadej.novak@cern.chMake Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as they are used as listMake `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC chann...Make `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC channel number handling in some derivation code as it was used incorrectly.
/cc @jchapman @nstyles @jcatmore @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67625Use AtlasPID functions for the Generator Filters2023-12-08T19:15:07+01:00Andrii VerbytskyiUse AtlasPID functions for the Generator FiltersUse AtlasPID functions for the Generator FiltersUse AtlasPID functions for the Generator Filters