athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T01:35:29+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70178Move secondary track pass flags to global tracking flags2024-03-28T01:35:29+01:00Thomas StreblerMove secondary track pass flags to global tracking flagsRelevant for ATLASRECTS-7947
The secondary tracking pass flags are actually identical for all passes in most cases.
The `RobustReco` is removed with !70177 so they can be promoted to global tracking flags.Relevant for ATLASRECTS-7947
The secondary tracking pass flags are actually identical for all passes in most cases.
The `RobustReco` is removed with !70177 so they can be promoted to global tracking flags.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70175Clean up some backtracking tracking pass flags2024-03-28T01:46:19+01:00Thomas StreblerClean up some backtracking tracking pass flagsEither removing flags set to default C++ values and unlikely to be changed or promoting them to global flags.
Should reduce by 6*31 the amount of tracking flags.
Relevant for ATLASRECTS-7947Either removing flags set to default C++ values and unlikely to be changed or promoting them to global flags.
Should reduce by 6*31 the amount of tracking flags.
Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70161Clean up TRT-only tracking pass flags2024-03-27T22:07:44+01:00Thomas StreblerClean up TRT-only tracking pass flagsEither setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947Either setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70152Draft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)2024-03-27T19:00:21+01:00John Derek ChapmanDraft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the i...The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the initial HepMcParticleLink member variables of the transient hit classes generated from the persistent classes to know whether they should be linking to an event other than the first event in the McEventCollection (The hard-scatter GenEvent is always first in the McEventCollection). This meant that calls to `HepMcParticleLink::id()` would return zero as the links often appear to be invalid.
This second version of the migration is less aggressive as it allows the possibility of barcode-based inputs. It avoids the issue seen in ATLSWUPGR-242 according to my local tests, but I will avoid marking the merge request as ready until we have a CI test to catch such an issue.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70146Draft: Improve consistency of InDetSimEventTPCnv behaviour.2024-03-27T09:46:05+01:00John Derek ChapmanDraft: Improve consistency of InDetSimEventTPCnv behaviour.In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge...In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge request attempts to make the behaviour of `SiHitCollectionCnv_p3/4`and `TRT_HitCollectionCnv_p4/5`
consistent with `HepMcParticleLinkCnv_p2/3`.
Relates to ATLASSIM-6999.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70056Draft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.2024-03-25T18:35:35+01:00John Derek ChapmanDraft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69954Draft: Improvements to HepMcParticleLink and extension of unit tests for SiHi...2024-03-22T19:14:55+01:00John Derek ChapmanDraft: Improvements to HepMcParticleLink and extension of unit tests for SiHitCollectionCnv.Further robustness improvements for `HepMcParticleLink` in the case that position-based constructors are used and
constructors using the event number=0 workaround. (Fixes unit test failures in the dbg build.)
Updated `HepMcParticleLink_...Further robustness improvements for `HepMcParticleLink` in the case that position-based constructors are used and
constructors using the event number=0 workaround. (Fixes unit test failures in the dbg build.)
Updated `HepMcParticleLink_test` to test the `==` operator for a HepMcParticleLink instances created with wider set of possible constructor arguments.
Updated `SiHitCollectionCnv_pX_test` unit tests to check the behaviour with SiHits using barcode/id = 0 (typically delta-rays). This has implications for HITS file compression if it doesn't work properly, so is worth testing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69854Db implementation strip veto2024-03-22T08:40:53+01:00Bhupesh DixitDb implementation strip vetoAdded a readme that describes the process and the steps for masking the Strip Modules.Added a readme that describes the process and the steps for masking the Strip Modules.Nicholas StylesNicholas Styleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69203Draft: HepMcParticleLink: Testing the adaption to GenParticle::id2024-02-29T14:08:28+01:00John Derek ChapmanDraft: HepMcParticleLink: Testing the adaption to GenParticle::idFollows !69076Follows !69076https://gitlab.cern.ch/atlas/athena/-/merge_requests/69076Draft: HepMcParticleLink: Flag whether link points to suppressed pile-up truth2024-02-23T17:38:05+01:00John Derek ChapmanDraft: HepMcParticleLink: Flag whether link points to suppressed pile-up truthFollows !69055Follows !69055https://gitlab.cern.ch/atlas/athena/-/merge_requests/68311Draft: Transition of ID alignment workflow to Component Accumulator configura...2024-03-12T14:13:53+01:00David BrunnerDraft: Transition of ID alignment workflow to Component Accumulator configurationThe current legacy configuration of the workflow for ID alignment is in the non-Athena repo: https://gitlab.cern.ch/atlas-idalignment/InDetAlignExample
The aim of this merge request is to move the configuration back into Athena and upda...The current legacy configuration of the workflow for ID alignment is in the non-Athena repo: https://gitlab.cern.ch/atlas-idalignment/InDetAlignExample
The aim of this merge request is to move the configuration back into Athena and update it to Component Accumulator configuration. Currently most of the transition to CA is finished, the setup is running on dummy configuration without breaking. Development is still ongoing to get a realistic setup running.
cc @nstyles @bruckman @kuhl @martis