athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-25T14:46:45+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70077Revert merge request !69655 (ATLSWUPGR-242)2024-03-25T14:46:45+01:00John Derek ChapmanRevert merge request !69655 (ATLSWUPGR-242)Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68388fix failing acts art test2024-01-29T10:57:07+01:00Carlo Varnicarlo.varni@cern.chfix failing acts art testThis fixes a problem in one of our acts art testsThis fixes a problem in one of our acts art testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67671MuonTrackingGeometry material updates2024-01-22T15:06:55+01:00Sarka TodorovaMuonTrackingGeometry material updatesCollects updates and bugfixes in the handling of the detector material.
Targets: ATLASRECTS-7840Collects updates and bugfixes in the handling of the detector material.
Targets: ATLASRECTS-7840Sarka TodorovaSarka Todorovahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67628Make Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as ...2024-01-08T15:56:19+01:00Tadej Novaktadej.novak@cern.chMake Input.RunNumber, Input.LumiBlockNumber and Input.TimeStamp in plural as they are used as listMake `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC chann...Make `Input.RunNumber`, `Input.LumiBlockNumber` and `Input.TimeStamp` in plural as they are used as list.
The validation of the type will be implemented in a separate MR.
This also fixes run number argument parsing in reco and MC channel number handling in some derivation code as it was used incorrectly.
/cc @jchapman @nstyles @jcatmore @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66967fix for gcc11 compilation of SiSpacePointsSeedMakerEventData (ATLINFR-5141)2023-11-08T17:09:53+01:00Walter Lamplfix for gcc11 compilation of SiSpacePointsSeedMakerEventData (ATLINFR-5141)Should fix the compilation failure observed at
http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/PRODUCTIONWebArea/ardoc_web_areamain64BC7G11AthenaOpt/ARDOC_Log_2023-11-07T2101/InnerDetector_InDetRecTools_SiZ...Should fix the compilation failure observed at
http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/PRODUCTIONWebArea/ardoc_web_areamain64BC7G11AthenaOpt/ARDOC_Log_2023-11-07T2101/InnerDetector_InDetRecTools_SiZvertexTool_xk.html
cc @christos @elmsheus @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66880Update to Gaudi v382024-01-30T12:16:59+01:00Frank WinklmeierUpdate to Gaudi v38Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This most...Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This mostly affects `CondInputLoader.Load` and the Algorithm's `ExtraInputs/Outputs` property. For details see https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1503 but in practice it means that code like
```py
MyAlg.ExtraInputs += ['foo']
```
has been updated to
```py
MyAlg.ExtraInputs.add('foo')
```
For the moment only `std::unordered_set` is mapped to a Python `set`. Regular `std::set` remains as Python `list` to maintain insertion order.
For backwards compatibility, we allow implicit conversion from `list`, i.e. the following still works:
```py
MyAlg.ExtraInputs = ['foo'] # implicitly converted to {'foo'}
```
In addition some minor `const` interface changes in `DataHandle` that propagate to our `VarHandleKey`.
cc @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66842main-bugfix-PixelDigitization2023-11-01T16:22:50+01:00Shaun Roemain-bugfix-PixelDigitizationAddresses ATLASSIM-6930; updates legacy configuration so that run1 sim test should pass. Tested locally with test_Digi_tf_mc15_2012_ttbar_no_pileup.sh.Addresses ATLASSIM-6930; updates legacy configuration so that run1 sim test should pass. Tested locally with test_Digi_tf_mc15_2012_ttbar_no_pileup.sh.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66781Fix Muon combined config unit test2023-10-30T18:18:02+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chFix Muon combined config unit testCloses ATLASRECTS-7791
Tagging: @sroe. That should probably superseed https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776Closes ATLASRECTS-7791
Tagging: @sroe. That should probably superseed https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776https://gitlab.cern.ch/atlas/athena/-/merge_requests/66775Bump Acts Tag to v30.3.22023-10-28T09:42:05+02:00Carlo Varnicarlo.varni@cern.chBump Acts Tag to v30.3.2This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.ce...This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.cern.ch/atlas/athena/-/merge_requests/66290https://gitlab.cern.ch/atlas/athena/-/merge_requests/65921Add another error we have to mask coming from the acts track finding algo2023-10-06T16:38:23+02:00Carlo Varnicarlo.varni@cern.chAdd another error we have to mask coming from the acts track finding algothe title says it alreadythe title says it alreadyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65321SCT heavyions webdisplay config cleanup2023-09-19T21:55:32+02:00Cristiano SebastianiSCT heavyions webdisplay config cleanupClean up of the configuration file of the DQ webdisplay in preparation for the heavyions run. Many names mismatch and obsolete histograms.
Tag: @grancagnClean up of the configuration file of the DQ webdisplay in preparation for the heavyions run. Many names mismatch and obsolete histograms.
Tag: @grancagnhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64906make HI options as in Run 22023-08-10T18:04:46+02:00Jiri Masikmake HI options as in Run 2minimal fix for ATR-28062 - remove EnableHI specific options from the trigger config and always use BeamLine perigeeExpression in the trigger
ATR-26732
cc @tstreble - it can be done simpler by moving the base methods to use ActiveConfi...minimal fix for ATR-28062 - remove EnableHI specific options from the trigger config and always use BeamLine perigeeExpression in the trigger
ATR-26732
cc @tstreble - it can be done simpler by moving the base methods to use ActiveConfig but I chose to do the simplest to minimize iterations needed this week - I'll update it when I'm back to workhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6447223.0 Fix TRT DriftCircles for cosmics2023-07-23T08:59:30+02:00Christian Grefe23.0 Fix TRT DriftCircles for cosmicsRemoves a superfluous check of permanent straw status, which drops all valid drift circles.
Fixes ATLASRECTS-7565 and ATLASDQ-1100.Removes a superfluous check of permanent straw status, which drops all valid drift circles.
Fixes ATLASRECTS-7565 and ATLASDQ-1100.https://gitlab.cern.ch/atlas/athena/-/merge_requests/6430123.0-bugfix-PixelConditionsData2023-07-18T13:15:08+02:00Shaun Roe23.0-bugfix-PixelConditionsDataAddresses ATLASSIM-6660 and the comments made in https://gitlab.cern.ch/atlas/athena/-/merge_requests/64185.
In the (rare) case that charge calibration resulted in a large charge result from the legacy fit (in excess of 1e5), and a line...Addresses ATLASSIM-6660 and the comments made in https://gitlab.cern.ch/atlas/athena/-/merge_requests/64185.
In the (rare) case that charge calibration resulted in a large charge result from the legacy fit (in excess of 1e5), and a linear fit was resorted to but *failed* due to the divisor in the calculation being zero, the existing logic in rel.23 returned the legacy fit result anyway. In my refactoring, I had inadvertently changed that to return the 'invalid' value of 0.0.
Logic is here introduced which reverts to the previous behaviour.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64180ART scripts/tests change master-> main. For 23.02023-07-07T17:00:44+02:00Christos Anastopouloschristos.anastopoulos@cern.chART scripts/tests change master-> main. For 23.0Art master-> main for 23.0 ART
This should just touch art tests
changing :
``# art-include: master/xxxxxx`` -> ``# art-include: main/xxxxx``
ping @akraszna @fwinkl @tadejArt master-> main for 23.0 ART
This should just touch art tests
changing :
``# art-include: master/xxxxxx`` -> ``# art-include: main/xxxxx``
ping @akraszna @fwinkl @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/64144fix config error in TRT_dEdxTool2023-07-07T15:59:14+02:00Jiri Masikfix config error in TRT_dEdxToolfix ATLASRECTS-7681 - a mistake introduced in !64038fix ATLASRECTS-7681 - a mistake introduced in !64038https://gitlab.cern.ch/atlas/athena/-/merge_requests/64140Rename master -> main in readmes and other txt files2023-07-05T18:24:38+02:00Tadej Novaktadej.novak@cern.chRename master -> main in readmes and other txt filesRename `master` -> `main` in readmes and other txt files.
/cc @jcatmore @nstyles @fwinklRename `master` -> `main` in readmes and other txt files.
/cc @jcatmore @nstyles @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6398423.0-bugfix-PixelConditionsData2023-06-29T17:13:11+02:00Shaun Roe23.0-bugfix-PixelConditionsDataDetect and suppress divide-by-zero (no warning issued). Addresses ATLASRECTS-7668 the simplest possible way.Detect and suppress divide-by-zero (no warning issued). Addresses ATLASRECTS-7668 the simplest possible way.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63532InDetConversionFinderTools: Fix pi calculation bugs2023-06-07T13:29:18+02:00Adam Edward BartonInDetConversionFinderTools: Fix pi calculation bugsFix foolish error in !63487Fix foolish error in !63487https://gitlab.cern.ch/atlas/athena/-/merge_requests/63482Add algorithm to run the Acts ambiguity resolution2023-08-02T14:25:22+02:00Goetz GayckenAdd algorithm to run the Acts ambiguity resolutionAdded an athena algorithm which runs the Acts ambiguity resolution algorithm. The algorithm requires as input an Acts TrackContainer and produces an Acts TrackContainer. The algorithm does not perform a conversion to Trk::Tracks.Added an athena algorithm which runs the Acts ambiguity resolution algorithm. The algorithm requires as input an Acts TrackContainer and produces an Acts TrackContainer. The algorithm does not perform a conversion to Trk::Tracks.