athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69619Fix import in TRTCalibrationMgrConfig.py2024-03-07T23:14:31+01:00Thomas StreblerFix import in TRTCalibrationMgrConfig.pyThis could lead to error in case `AlignTrkTools` is set but `FitTools` is not.
FYI @serodrigThis could lead to error in case `AlignTrkTools` is set but `FitTools` is not.
FYI @serodrighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69299Also count the first hit associated to a truth particle.2024-02-29T10:54:07+01:00Goetz GayckenAlso count the first hit associated to a truth particle.The truth dectorator alg currently ignores the first pixel and strip/SCT hit when counting the number of silicon hits associated to truth particles. This MR fixes this problem.The truth dectorator alg currently ignores the first pixel and strip/SCT hit when counting the number of silicon hits associated to truth particles. This MR fixes this problem.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69336Fix decoration type clash for isSplit.2024-02-29T10:45:37+01:00Goetz GayckenFix decoration type clash for isSplit.Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDa...Multiple components apply xAOD decorations named isSplit. Since a
single type is registered for each decoration all components must use
the same type for identically named decorations. This patch ensures
that PixelCluster_v1, PixelPrepDataToxAOD, PixelNtupleMaker use the
same type.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69133Draft: Inner Detector alignment monitoring (Run3) new npixhits_per_track_barr...2024-02-26T11:18:56+01:00Clara Carrion MartinezDraft: Inner Detector alignment monitoring (Run3) new npixhits_per_track_barrel histogramInner Detector alignement monitoring (Run3) new npixhits_per_track_barrel histogram and misspelling correctionsInner Detector alignement monitoring (Run3) new npixhits_per_track_barrel histogram and misspelling correctionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68866Draft: almost complete removal of InDetRecExample - leave only the minimum fo...2024-02-16T08:31:10+01:00Nicholas StylesDraft: almost complete removal of InDetRecExample - leave only the minimum for some unit testsFollowing on from !68501, testing to see if temporarily leaving behind `InDetJobProperties` allows unit tests to succeed (until they too are removed or updated).Following on from !68501, testing to see if temporarily leaving behind `InDetJobProperties` allows unit tests to succeed (until they too are removed or updated).https://gitlab.cern.ch/atlas/athena/-/merge_requests/68774Remove legacy skeletons for HITtoRDO and RDOMerge2024-02-14T16:10:27+01:00John Derek ChapmanRemove legacy skeletons for HITtoRDO and RDOMergeThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmoreThis is the next step in clean-up the legacy digitization configuration.
Calls to `Digi_tf.py`and `RDOMerge_tf.py`without the `--CA`option will fail.
Tagging @tadej, @nstyles, @jcatmorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68562Add new SCT Lorentz angle histograms2024-02-10T13:21:19+01:00Shigeki HiroseAdd new SCT Lorentz angle histogramsWe would like to apply the following changes to SCTLorentzMonAlg: 1) update the track selection to make it fully consistent with previously published papers, and 2) add several histograms for the purpose of better monitoring of Lorentz a...We would like to apply the following changes to SCTLorentzMonAlg: 1) update the track selection to make it fully consistent with previously published papers, and 2) add several histograms for the purpose of better monitoring of Lorentz angle evolution of the SCT.
These changes have been discussed with @csebasti as the SCT offline coordinator and @grancagn as the SCT DQ coordinator and approved by them.
Let us know if you find any issues or need further information / verification.
Best regards,
Shigekihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68589Draft: Added flag regarding HILoose WP to IDPVM.2024-02-07T16:21:38+01:00Luthien MlynarskiDraft: Added flag regarding HILoose WP to IDPVM.Added 'doHILoose' to IDPVM for Heavy Ion loose working point.
This is a part of QP: https://its.cern.ch/jira/browse/ATLIDTRKCP-516Added 'doHILoose' to IDPVM for Heavy Ion loose working point.
This is a part of QP: https://its.cern.ch/jira/browse/ATLIDTRKCP-516Noemi CalaceTomasz BoldAlexis VallierCarlo Varnicarlo.varni@cern.chATLAS RobotNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65901Draft: TrigEgamma:Migrating Electron precision tracks to ca2024-01-18T09:56:00+01:00Debottam Bakshi GuptaDraft: TrigEgamma:Migrating Electron precision tracks to caMigrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)Migrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/65986Draft: Moving GSF refit to ca2024-01-18T09:53:58+01:00Debottam Bakshi GuptaDraft: Moving GSF refit to caMoving GSF refit to ca (linking the jira ATR-26736 created for this)Moving GSF refit to ca (linking the jira ATR-26736 created for this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/65126Externals Update, main branch (2023.08.18.)2023-12-05T17:46:20+01:00Attila KrasznahorkayExternals Update, main branch (2023.08.18.)Updated all projects to use [atlasexternals-2.0.166](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.166). The list of changes wrt. [atlasexternals-2.0.165](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.165) is the follow...Updated all projects to use [atlasexternals-2.0.166](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.166). The list of changes wrt. [atlasexternals-2.0.165](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.165) is the following (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.165...2.0.166):
- Updated to [GeoModel](https://gitlab.cern.ch/GeoModelDev/GeoModel) version `4.5.0` (part of the C\+\+20 migration, thanks to @tsulaia);
- Updated [COOL](https://gitlab.cern.ch/lcgcool/cool) and [CORAL](https://gitlab.cern.ch/lcgcoral/coral) to version `3.3.14` (part of the C\+\+20 migration, thanks to @elmsheus);
- Updated [Coin3D](https://www.coin3d.org/) to hash `5297f6c` (part of the C\+\+20 migration, thanks to @rbianchi);
- Made the [Gaudi](https://gitlab.cern.ch/gaudi/Gaudi) build itself set up [Vc](https://github.com/VcDevel/Vc) for the build/runtime environment (part of the [LCG_104](https://lcginfo.cern.ch/release/104/) migration, thanks to @elmsheus);
- Made `AtlasCompilerSettings.cmake` explicitly check whether the compiler understands `-march=x86-64-v2` before it would set it up;
* Making it possible to still use GCC <11 with our code, for instance for building [AnalysisBase](Projects/AnalysisBase).
I also took a patch from @tsulaia's repository for making [StripGeoModelXml](InnerDetector/InDetDetDescr/StripGeoModelXml) compatible with the GeoModel updates.
Since a lot of externals changed versions, let's do a full suite of tests. But hopefully no reference files will need to be changed.
For the RC: Merging this should **not** require a cleanup of the nodes. :thinking:https://gitlab.cern.ch/atlas/athena/-/merge_requests/66965ATLINFR-5141 : Let's keep it simple for gcc112023-11-08T15:07:52+01:00Christos Anastopouloschristos.anastopoulos@cern.chATLINFR-5141 : Let's keep it simple for gcc11ATLINFR-5141 : Let's keep it simple for gcc11.
Since we have only 2 special cases lets be explicit.ATLINFR-5141 : Let's keep it simple for gcc11.
Since we have only 2 special cases lets be explicit.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66944InDetByteStreamErrors+TrigSteeringEvent+TrkEventUtils: Add some missing dicti...2023-11-06T21:12:27+01:00Scott SnyderInDetByteStreamErrors+TrigSteeringEvent+TrkEventUtils: Add some missing dictionary entries..For use by PyDumper.For use by PyDumper.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66773Draft: main-cleanup3-PixelDigitization2023-10-30T08:58:34+01:00Shaun RoeDraft: main-cleanup3-PixelDigitizationBuilding on earlier MRs, this implements proposals 20-22 of ATLASRECTS-7721:
* delete all calls to getFEI4ChargScaling _sic_ (this scaling factor is always set to 1.0)
* remove "if getUseFEI4SpecialScalingFunction", as this bool is...Building on earlier MRs, this implements proposals 20-22 of ATLASRECTS-7721:
* delete all calls to getFEI4ChargScaling _sic_ (this scaling factor is always set to 1.0)
* remove "if getUseFEI4SpecialScalingFunction", as this bool is always true
* replace use of PixelModuleData::getFEI4ToTSigma(int tot) with a local function, as this simply returns an element in a vector which is never changed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776Draft: Revert "Merge branch 'main-cleanup-PixelToTPIDTool' into 'main'"2023-10-27T16:24:44+02:00Vakhtang TsulaiaDraft: Revert "Merge branch 'main-cleanup-PixelToTPIDTool' into 'main'"This reverts merge request !66709
The MR is reverted to fix the failure of the `MuonCombinedRecoConfigTest` as discussed on ATLASRECTS-7791This reverts merge request !66709
The MR is reverted to fix the failure of the `MuonCombinedRecoConfigTest` as discussed on ATLASRECTS-7791