athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:30:33+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/6940624.0 TRT high threshold tune2024-03-28T11:30:33+01:00Christian Grefe24.0 TRT high threshold tuneSignificantly improves the modelling of the number of TRT high-threshold hits, by updating the digitisation parameters.
The threshold values were tuned by comparing MC with Run 3 low-mu data. The pile-up dependence is taken into account ...Significantly improves the modelling of the number of TRT high-threshold hits, by updating the digitisation parameters.
The threshold values were tuned by comparing MC with Run 3 low-mu data. The pile-up dependence is taken into account in the pile-up overlay correction values. These have been tuned using several Run 3 runs at usual pile-up conditions.
A summary of the results was presented in the Simulation Group Meeting on Feb. 13: https://indico.cern.ch/event/1381473/contributions/5806705/attachments/2800131/4884883/TRT_mc23e_tune_2014_02_13.pdf
More details can be found in these slides by @hadenizl: https://indico.cern.ch/event/1335684/contributions/5622451/attachments/2795220/4876744/TrtDays_7Feb2024_haluk.pdf
The impact on tracking is negligible. A significant change is expected for the number of TRT HT hits and derived quantities like eProbability_HT, which is used for example in electron identification, photon reconstruction and tau electron veto. In https://its.cern.ch/jira/browse/ATLPHYSVAL-1008 the impact has been validated: everything looks as expected.
If possible, this change should go into the release for MC23e, since it significantly improves the modelling of electron identification observables. No significant side effects have been observed in the PhysVal checks.
Tagging: @beddall, @ludovica, @kristin, @ademaria, @sineadf, @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52633Introduce flat container to replace the CaloClusterROI collection.2024-03-28T11:20:08+01:00Goetz GayckenIntroduce flat container to replace the CaloClusterROI collection.Originally there was the CaloClusterROI_Selector which creates CaloClusterROIs
from selected calorimeter clusters. These objects are used in several algorithms.
However none of the algorithms uses these CaloClusterROI objects directly. ...Originally there was the CaloClusterROI_Selector which creates CaloClusterROIs
from selected calorimeter clusters. These objects are used in several algorithms.
However none of the algorithms uses these CaloClusterROI objects directly. Most
algorithms create flat vectors from the CaloClusterROI_Collection. The latter
is done once per event which leads to lock contention in the InDetDenseEnvAmbiTrackSelectionTool.
This MR replace the CaloClusterROIs by something that can be directly used by
the client algorithms. This avoids executing the same coordinate transformations
and creation of the flat vectors at several places, and mitigates the lock
contention (there is still a ReadHandle being created by the
InDetDenseEnvAmbiTrackSelectionTool for each track).
Lock contention in the InDetDenseEnvAmbiTrackSelectionTool is significantly reduced (at
large number of threads). And there seems to be a small overall improvement of 1-2%.
However the latter may not be significant.https://gitlab.cern.ch/atlas/athena/-/merge_requests/701292024-03-26: merge of 24.0 into main2024-03-28T10:55:02+01:00Edward Moyse2024-03-26: merge of 24.0 into mainThis sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete leg...This sweep contains the following MRs:
* !70090 ATR-28985 Trigger request for Multijet TLA ~Trigger, ~TriggerMenu
* !70113 MuonDQA: remove references to Run-2 monitoring config ~DQ, ~MuonSpectrometer
* !70115 LArMonitoring: delete legacy job options ~DQ, ~LAr
* !70117 Pixel Calibration - adding getters and fixing typos ~InnerDetector
* !70112 ZdcMonitoring: cleanup references to legacy config ~ForwardDetectors
* !70109 Fix CMake warning in AthSimulation builds. ~Build
* !69914 Bug fix to generation of links between neutral FE and muons ~JetEtmiss, ~Reconstruction, ~Run2-DataReco-output-changed, ~Run2-MCReco-output-changed, ~Run3-DataReco-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !70100 Added maxParallelismExtra setting to AvalancheSchedulerSvcCfg ~Trigger
* !70096 Avoid duplicate streamer chain blocks ~Trigger, ~TriggerMenu
* !70108 Remove nullptr initialiser that causes a crashing ~Simulation
* !70048 Adding more test chains for delayed jets ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !70102 AthenaCommon: refactor --profile-python option ~Core
* !70097 remove legacy python config files form Calorimeter/CaloCnv ~Calorimeter
* !70095 ZDC reconstruction ART script, testing on ZDCCalib data ~ForwardDetectors
* !70092 remove obsolete config files from LArEventTest ~LAr
* !70091 remove obsolete config files from LArCondAthenaPool and LArDetMgrDetDescrCnv ~LAr
* !70089 remove obsolete config-files from LArByteStream ~LAr, ~Simulation
* !70074 AFP monitoring update code style ~DQ, ~ForwardDetectors
* !70069 Fix for the multi-threaded event service configuration ~Tools
* !70036 sTGC raw data monitoring: fix problem with shifter occupancy plots ~DQ, ~MuonSpectrometer
* !70060 Update eFexByteStreamTool.cxx - write multislice tobs as xtobs (since only... ~L1Calo, ~Trigger
* !70057 L1calo monitoring improvements ~Core, ~DQ, ~L1Calo, ~Trigger
* !70035 Update gfex parameters in trigger menu ~L1Calo, ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69759 Monitoring of alternative L1 eTAU simulation ~DQ, ~Tau, ~Trigger
* !70030 ATR-28968: Reduce INFO messages from central trigger configuration code ~ACTS, ~Core, ~Tracking, ~Trigger
* !70011 fix failing DataQualityConfigurations tests in dbg build ~DQ
* !70045 CaloSamplingFractionAnalysis: delete legacy job options ~Simulation
* !69994 offline DQ for MMG trigger ~DQ, ~MuonSpectrometer
* !70073 fix StepName ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu
* !70061 IDTrig: do not switch on TRT with ITk, deal with InDet/ITk eta dependant cuts ~Trigger, ~TriggerID
* !70068 Run the TIDA Tier0 monitoring correctly ~Trigger
* !70042 pT filter for groomed jets before moment calculation ~JetEtmiss, ~Reconstruction
* !70044 adding missing et conversion factor for KFMET definition for Ph1Topo ~Trigger, ~TriggerMenu
* !70046 DumpGeo: delete legacy job options ~Geometry
* !69953 New efficiency DQ criteria for HLTmuon hanconfig ~DQ
* !70022 clean out legacy config code from LArCalorimeter/LArClusterRec ~LArhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70132Better data prep test: ACTS ART Test2024-03-27T17:49:33+01:00Carlo Varnicarlo.varni@cern.chBetter data prep test: ACTS ART TestRun also Athena data prep and convert EDM to compare against ACTS-based data prepRun also Athena data prep and convert EDM to compare against ACTS-based data prephttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69655barcode -> ID migration for HGTD/InDet/MuonDigitization.2024-03-27T14:14:49+01:00John Derek Chapmanbarcode -> ID migration for HGTD/InDet/MuonDigitization.Migrate HGTD_Digitization, InDetDigitization and MuonDigitization code to use `GenParticle::id` rather than barcodes internally.
(Should not change Digitization output.)
See ATLASSIM-6978Migrate HGTD_Digitization, InDetDigitization and MuonDigitization code to use `GenParticle::id` rather than barcodes internally.
(Should not change Digitization output.)
See ATLASSIM-6978https://gitlab.cern.ch/atlas/athena/-/merge_requests/70117Pixel Calibration - adding getters and fixing typos2024-03-26T14:38:22+01:00Sergi Rodriguez BoscaPixel Calibration - adding getters and fixing typosThis MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.This MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70098Extend TRT_HitCollectionCnv unit tests2024-03-26T14:15:27+01:00John Derek ChapmanExtend TRT_HitCollectionCnv unit testsThis merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.This merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69753Add algorithm to compute technical performance for Acts tracks.2024-03-26T14:12:21+01:00Goetz GayckenAdd algorithm to compute technical performance for Acts tracks.The algorithm computes particle reconstruction efficiency of particles
which are considered reconstructible, the hit efficiency and purity.
These values are computed in eta bins (or optionally in PDG ID bins),
and can be further divided...The algorithm computes particle reconstruction efficiency of particles
which are considered reconstructible, the hit efficiency and purity.
These values are computed in eta bins (or optionally in PDG ID bins),
and can be further divided by pt. The reference truth particles can be
selected.
Also added algorithm to count measurements associated to truth particles.
The output of the latter is needed for the former.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70023Do not create views at offline level but only RoIs2024-03-26T10:30:38+01:00Carlo Varnicarlo.varni@cern.chDo not create views at offline level but only RoIsThis will replace the ACTS Event View maker with a simple algorithm for creating an RoI for later use in (e.g.) the clustering
Current sequence:
![graphviz__11_](/uploads/2cc97bd7ba463b023533d57ac638c6d3/graphviz__11_.png)This will replace the ACTS Event View maker with a simple algorithm for creating an RoI for later use in (e.g.) the clustering
Current sequence:
![graphviz__11_](/uploads/2cc97bd7ba463b023533d57ac638c6d3/graphviz__11_.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70079main-cppcheck-InDetPhysValMonitoring2024-03-25T14:54:12+01:00Shaun Roemain-cppcheck-InDetPhysValMonitoringMove to at-declaration initialisation of members in InDetPerfPlot_Vertex, solving uninitialised members warning in the processMove to at-declaration initialisation of members in InDetPerfPlot_Vertex, solving uninitialised members warning in the processhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70063Extend SiHitCollectionCnv unit tests2024-03-25T14:49:56+01:00John Derek ChapmanExtend SiHitCollectionCnv unit testsThis merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).This merge request extends the SiHitCollectionCnv unit tests to monitor the level
of compression seen in the persistent formats and check the behaviour for SiHits caused by
delta-rays (i.e. no valid truth link).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70077Revert merge request !69655 (ATLSWUPGR-242)2024-03-25T14:46:45+01:00John Derek ChapmanRevert merge request !69655 (ATLSWUPGR-242)Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70050TRTProcessingOf(Barrel/Endcap)Hits clean-up of error message2024-03-22T14:20:24+01:00John Derek ChapmanTRTProcessingOf(Barrel/Endcap)Hits clean-up of error messageVery minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.Very minor tweak to error message syntax.
NB these classes do not depend on Athena, so it is beyond the scope of this merge request to convert the messages to use the Athena message service.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70021Fix SiHitCollectionCnv unit tests2024-03-22T09:41:47+01:00John Derek ChapmanFix SiHitCollectionCnv unit testsFix the SiHitCollectionCnv unit tests to create multiple hits per particle as this is a better test of the compression
algorithm used in the TP conversion.
Also improve comments in the TRT_HitCollectionCnv unit tests.Fix the SiHitCollectionCnv unit tests to create multiple hits per particle as this is a better test of the compression
algorithm used in the TP conversion.
Also improve comments in the TRT_HitCollectionCnv unit tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69934Add vertex time plots to monitoring2024-03-22T09:40:47+01:00Jernej DebevcAdd vertex time plots to monitoringThis MR adds plots for HGTD timing information of vertices to physics validation monitoring and CampaignsARTTests.
Follow up to !69290 and !69404.
/cc @aleopold @dshope @tstrebleThis MR adds plots for HGTD timing information of vertices to physics validation monitoring and CampaignsARTTests.
Follow up to !69290 and !69404.
/cc @aleopold @dshope @tstrebleJernej DebevcJernej Debevchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60955Add track time to monitoring2024-03-21T15:30:52+01:00David Richard ShopeAdd track time to monitoringThis MR adds the track time determined by the HGTD to InDetPhysValMonitoring and CampaignsARTTests. The bin width is set to 5 ps with a window from -0.4 to 0.4 ns.
Tagging @aleopold, @tstreble, @jmasikThis MR adds the track time determined by the HGTD to InDetPhysValMonitoring and CampaignsARTTests. The bin width is set to 5 ps with a window from -0.4 to 0.4 ns.
Tagging @aleopold, @tstreble, @jmasikhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70009InDetReadoutGeometry+TrkExUtils: Fix cppcheck warnings.2024-03-21T11:40:53+01:00Scott SnyderInDetReadoutGeometry+TrkExUtils: Fix cppcheck warnings.Copying values in range-for.Copying values in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70010ZdcConditions+InDetSimEvent: Fix cppcheck warnings.2024-03-21T11:39:51+01:00Scott SnyderZdcConditions+InDetSimEvent: Fix cppcheck warnings.Pass strings by const reference, not by value.Pass strings by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69968Naming of ACTS collections2024-03-20T15:33:28+01:00Carlo Varnicarlo.varni@cern.chNaming of ACTS collectionsNaming convention for ACTS I/O (seeds, parameters and track) + some cleaning of the JONaming convention for ACTS I/O (seeds, parameters and track) + some cleaning of the JOhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69950GNNTracking: add overlap SP in dump2024-03-20T15:27:22+01:00Alexis VallierGNNTracking: add overlap SP in dumpAdd Overlap Space Points in the GNNTracking RDO->root dumperAdd Overlap Space Points in the GNNTracking RDO->root dumper