athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-08-25T03:05:12+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/45913L1Calo Bitwise Offline Simulation: jFEX Forward Jets completed2021-08-25T03:05:12+02:00Varsiha SothilingamL1Calo Bitwise Offline Simulation: jFEX Forward Jets completedThis MR will unmask the jets algorithm for the forward jFEX modules in the L1CaloFEXSim Simulation.
Changes have been made to algorithms and EDMs to correctly display local and global coordinates.This MR will unmask the jets algorithm for the forward jFEX modules in the L1CaloFEXSim Simulation.
Changes have been made to algorithms and EDMs to correctly display local and global coordinates.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45907More DQ monitoring speedups2021-08-26T03:05:17+02:00Peter OnyisiMore DQ monitoring speedupsA few speedups for ~ 20% improvement in monitoring execution time
Also a few additional APIs for AthenaMonitoringKernel, attn @tbold @fwinklA few speedups for ~ 20% improvement in monitoring execution time
Also a few additional APIs for AthenaMonitoringKernel, attn @tbold @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45906CaloUtils clang-tidy related fixes2021-08-21T03:05:49+02:00Christos Anastopouloschristos.anastopoulos@cern.chCaloUtils clang-tidy related fixesCaloUtils clang-tidy related fixesCaloUtils clang-tidy related fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45892HLTSeeding: spell-check, consistent indentation, clang-tidy, general cleanup2021-08-20T03:02:26+02:00Rafal Bielskirafal.bielski@cern.chHLTSeeding: spell-check, consistent indentation, clang-tidy, general cleanupCode quality improvements in the HLTSeeding package.
Included:
* fix typos
* fix doxygen documentation formatting
* fix inconsistent indentation (style and mix of tabs and spaces)
* try to ensure a bit more consistent formatting within ...Code quality improvements in the HLTSeeding package.
Included:
* fix typos
* fix doxygen documentation formatting
* fix inconsistent indentation (style and mix of tabs and spaces)
* try to ensure a bit more consistent formatting within each file and to some extent also between files
* try to improve readability (e.g. split lines >100 characters, remove excessive newlines and add some where useful)
* remove trailing whitespace
* remove unused code and obsolete comments
* fix a number of potential issues reported by clang-tidy (a separate commit)
The following clang-tidy warnings are fixed:
- warning: statement should be inside braces [readability-braces-around-statements]
- warning: the 'empty' method should be used to check for emptiness [readability-container-size-empty]
- warning: narrowing conversion from 'unsigned long' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
- warning: do not use 'else' after 'return' [readability-else-after-return]
- warning: ... is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
- warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
- warning: statement should be inside braces [readability-braces-around-statements]
- warning: implicit conversion ... -> bool / bool -> ... [readability-implicit-bool-conversion]
- warning: method ... can be made static [readability-convert-member-functions-to-static]
- warning: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find]
- warning: argument name ... in comment does not match parameter name ... [bugprone-argument-comment]
- warning: initializing non-owner argument of type ... with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory] (in other words: don't use `new`)
- warning: redundant void argument list in lambda expression [modernize-redundant-void-arg]
- warning: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage]
- warning: constructor does not initialize these fields: ... [cppcoreguidelines-pro-type-member-init]
- warning: use emplace_back instead of push_back [modernize-use-emplace]
- warning: the parameter ... is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
- warning: macro ... used to declare a constant [cppcoreguidelines-macro-usage]https://gitlab.cern.ch/atlas/athena/-/merge_requests/45878First version of the condition algorithm for applying LAr alignments to GeoModel2021-08-21T22:42:55+02:00Vakhtang TsulaiaFirst version of the condition algorithm for applying LAr alignments to GeoModelIntroduced `LArAlignCondAlg` and `LArAlignHelper`. The latter contains the code for
applying alignment corrections to `LArGeoModel`. It is used by both `LArAlignCondAlg`
and `LArDetectorTool`.
Added `CONDCONT_DEF` for two classes
* `Det...Introduced `LArAlignCondAlg` and `LArAlignHelper`. The latter contains the code for
applying alignment corrections to `LArGeoModel`. It is used by both `LArAlignCondAlg`
and `LArDetectorTool`.
Added `CONDCONT_DEF` for two classes
* `DetCondKeyTrans`
* `CaloCellPositionShift`
Fixed `LArConditionsCommon/python/LArAlignable.py` so that it declares "/LAR/Align" and
"/LAR/LArCellPositionShift" folders to the `CondInputLoader`, and removed the obsolete
`LArConditionsCommon/share/LArAlignable.py`
Switched `CaloMgrDetDescrCnv` from `fabs` to `std::abs`https://gitlab.cern.ch/atlas/athena/-/merge_requests/45873TrigHLTJetHypoUnitTests: Fix compilation warnings.2021-08-19T03:04:27+02:00Scott SnyderTrigHLTJetHypoUnitTests: Fix compilation warnings.Signed/unsigned comparison.Signed/unsigned comparison.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45868PyDumper, etc: Consistent rounding with python 3.9.2021-08-19T03:03:18+02:00Scott SnyderPyDumper, etc: Consistent rounding with python 3.9.Python 3.9 changes how the %g formatting specifier rounds numbers
in some cases. This affects some of the AthenaPool tests. Adjust so that
numbers are printed consistently regardless of python version.Python 3.9 changes how the %g formatting specifier rounds numbers
in some cases. This affects some of the AthenaPool tests. Adjust so that
numbers are printed consistently regardless of python version.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45866FlavorTagDiscriminants: Fix clang warning.2021-08-19T03:05:20+02:00Scott SnyderFlavorTagDiscriminants: Fix clang warning.Unused typedef.Unused typedef.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45855TrigHLTJetHypo+TriggerMenuMT: use exception for empty HypoTool2021-08-19T03:04:07+02:00Frank WinklmeierTrigHLTJetHypo+TriggerMenuMT: use exception for empty HypoToolThrow a `NoHypoToolCreated` exception in case no HypoTool was created in
the generator function. Returning `None` as in the previous code results
in duplicate empty tool names in the ToolHandleArray (ATR-23920).
In addition remove the r...Throw a `NoHypoToolCreated` exception in case no HypoTool was created in
the generator function. Returning `None` as in the previous code results
in duplicate empty tool names in the ToolHandleArray (ATR-23920).
In addition remove the redundant copy of tool names and `getTools` accessors in
`MenuSequence` (the `ToolHandleArrary` already ensures we are not adding
any duplicates).
Also remove a few explicitly set log-levels in various places.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45854Add dictionary to PFlowUtils needed in analysis release.2021-08-19T03:04:35+02:00Mark HodgkinsonAdd dictionary to PFlowUtils needed in analysis release.Add dictionary to PFlowUtils needed in analysis release.Add dictionary to PFlowUtils needed in analysis release.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45840xAODMissingET: Fix cppcheck warnings.2021-08-18T03:03:24+02:00Scott SnyderxAODMissingET: Fix cppcheck warnings.Fix printf format for size_t.Fix printf format for size_t.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45831Use single char find2021-08-18T03:03:33+02:00Adam Edward BartonUse single char findCall the single char find on strings for 20% speed upCall the single char find on strings for 20% speed uphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45825switch to using SysListHandle::systematicsVector() instead of for-each2021-10-01T18:40:45+02:00Nils Erik Krumnackswitch to using SysListHandle::systematicsVector() instead of for-eachOn request of @jburr to make this easier to understand and teach for
beginners. Note that this involved a fair amount of whitespace
changes to make the for-body indentation consistent with the rest of
each file.
Note to shifter: This ...On request of @jburr to make this easier to understand and teach for
beginners. Note that this involved a fair amount of whitespace
changes to make the for-body indentation consistent with the rest of
each file.
Note to shifter: This is actually a fairly straightforward update which looks very large due to the whitespace changes. It ought to be helpful to select the option to ignore white-space changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/45823add remap file to Run3 config to avoid overwriting locked container2021-08-18T03:02:40+02:00Matthew Thomas Anthonyadd remap file to Run3 config to avoid overwriting locked containerHi (cc @mhodgkin @cdelitzs)
PFRun3Config.py test job runs on an ESD which already has links defined in it. To avoid a locked container issue, remap the container using the Remapping service all of the writehandles to a new form.
Thanks...Hi (cc @mhodgkin @cdelitzs)
PFRun3Config.py test job runs on an ESD which already has links defined in it. To avoid a locked container issue, remap the container using the Remapping service all of the writehandles to a new form.
Thanks
Matt A.
NB: this uses the new style Run3 config (e.g. Component Accumulators) so isn't the same as eflowRec/share/RemapItems.py)https://gitlab.cern.ch/atlas/athena/-/merge_requests/45815Fix data dependencies for L1Calo simulation (ATR-20535)2021-08-18T03:03:01+02:00Stewart Martin-HaughFix data dependencies for L1Calo simulation (ATR-20535)Fixes these errors:
```
AvalancheSchedulerSvc 0 FATAL Auto DataLoading not requested, and the following unmet INPUT dependencies were found:
AvalancheSchedulerSvc 0 FATAL o ( 'LAr...Fixes these errors:
```
AvalancheSchedulerSvc 0 FATAL Auto DataLoading not requested, and the following unmet INPUT dependencies were found:
AvalancheSchedulerSvc 0 FATAL o ( 'LArTTL1Container' , 'StoreGateSvc+LArTTL1EM' ) required by Algorithm:
AvalancheSchedulerSvc 0 FATAL * Run2TriggerTowerMaker25ns
AvalancheSchedulerSvc 0 FATAL o ( 'LArTTL1Container' , 'StoreGateSvc+LArTTL1HAD' ) required by Algorithm:
AvalancheSchedulerSvc 0 FATAL * Run2TriggerTowerMaker25ns
AvalancheSchedulerSvc 0 FATAL o ( 'TileTTL1Container' , 'StoreGateSvc+TileTTL1Cnt' ) required by Algorithm:
AvalancheSchedulerSvc 0 FATAL * Run2TriggerTowerMaker25ns
AvalancheSchedulerSvc 0 FATAL o ( 'xAOD::JetElementContainer' , 'StoreGateSvc+JetElements' )
AvalancheSchedulerSvc 0 FATAL * JEMEnergySim
AvalancheSchedulerSvc 0 FATAL * JEMJetSim
AvalancheSchedulerSvc 0 FATAL * RoIBResultToxAOD
```
(warnings in normal jobs that we would like to remove).https://gitlab.cern.ch/atlas/athena/-/merge_requests/45810HLTSeeding Fix clang warning [-Wrange-loop-construct]2021-08-17T03:05:15+02:00Christos Anastopouloschristos.anastopoulos@cern.chHLTSeeding Fix clang warning [-Wrange-loop-construct]Fix clang warning on 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
```
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/...Fix clang warning on 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
```
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/EMRoIsUnpackingTool.cxx:68:23: warning: loop variable 'th' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto th : emThresholds.value().get()) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/EMRoIsUnpackingTool.cxx:68:12: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto th : emThresholds.value().get()) {
^~~~~~~~~~~~~~~
&
/src/HLTSeeding.cxx.o.d -o CMakeFiles/HLTSeeding.dir/src/HLTSeeding.cxx.o -c /build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/HLTSeeding.cxx
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/JRoIsUnpackingTool.cxx:70:23: warning: loop variable 'th' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto th : jetThresholds.value().get()) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/JRoIsUnpackingTool.cxx:70:12: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto th : jetThresholds.value().get()) {
^~~~~~~~~~~~~~~
&
/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/METRoIsUnpackingTool.cxx
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/MURoIsUnpackingTool.cxx:75:21: warning: loop variable 'th' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto th : muThresholds.value().get()) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/MURoIsUnpackingTool.cxx:75:10: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto th : muThresholds.value().get()) {
^~~~~~~~~~~~~~~
&
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/MURoIsUnpackingTool.cxx:151:21: warning: loop variable 'thr' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto thr : muThresholds.value().get()) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/MURoIsUnpackingTool.cxx:151:10: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto thr : muThresholds.value().get()) {
^~~~~~~~~~~~~~~~
&
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/METRoIsUnpackingTool.cxx:62:19: warning: loop variable 'th' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto th: thresholds) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/METRoIsUnpackingTool.cxx:62:8: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto th: thresholds) {
^~~~~~~~~~~~~~
&
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/TAURoIsUnpackingTool.cxx:78:23: warning: loop variable 'th' of type 'const std::shared_ptr<TrigConf::L1Threshold>' creates a copy from type 'const std::shared_ptr<TrigConf::L1Threshold>' [-Wrange-loop-construct]
for (const auto th : tauThresholds.value().get()) {
^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/TrigSteer/HLTSeeding/src/TAURoIsUnpackingTool.cxx:78:12: note: use reference type 'const std::shared_ptr<TrigConf::L1Threshold> &' to prevent copying
for (const auto th : tauThresholds.value().get()) {
^~~~~~~~~~~~~~~
&
```
see
http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7C10AthenaOpt/ARDOC_Log_2021-08-14T2130/Trigger_TrigSteer_HLTSeeding.html
Mentiong @rbielski and @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45802LarCalorimeter unitialized member variables fix , clang-tidy/cppcheck2021-08-17T03:05:52+02:00Christos Anastopouloschristos.anastopoulos@cern.chLarCalorimeter unitialized member variables fix , clang-tidy/cppcheckLarCalorimeter unitialized member variables fix , clang-tidy/cppcheckLarCalorimeter unitialized member variables fix , clang-tidy/cppcheckhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45800PhysValMET clang-tidy related fixes2021-08-17T03:05:27+02:00Christos Anastopouloschristos.anastopoulos@cern.chPhysValMET clang-tidy related fixesPhysValMET clang-tidy related fixesPhysValMET clang-tidy related fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45799PhysValMonitoring clang-tidy related fixes2021-08-17T03:02:56+02:00Christos Anastopouloschristos.anastopoulos@cern.chPhysValMonitoring clang-tidy related fixesPhysValMonitoring clang-tidy related fixesPhysValMonitoring clang-tidy related fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/45783Remove references to TrigBunchCrossingTool2021-08-18T03:05:14+02:00Frank WinklmeierRemove references to TrigBunchCrossingToolSeveral (mostly cosmetic) changes to remove mentions of `TrigBunchCrossingTool` in code that has already been migrated to `BunchCrossingCondData`. Fix a few remaining python fragments and delete commented code mentioning this obsolete to...Several (mostly cosmetic) changes to remove mentions of `TrigBunchCrossingTool` in code that has already been migrated to `BunchCrossingCondData`. Fix a few remaining python fragments and delete commented code mentioning this obsolete tool. Also delete the trigger analysis example code.
Relates to ATR-24013.