athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-01-15T03:02:32+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20307TileRecUtils: Fix Tile data overlay (ATLASSIM-3962)2019-01-15T03:02:32+01:00Siarhei HarkushaTileRecUtils: Fix Tile data overlay (ATLASSIM-3962)During processing data Tile raw channel container from DSP
is needed to find corrections and apply the same ones
to the Tile raw channel container built offline.
But in the case of MC or overlay jobs
DSP corrections should not be applie...During processing data Tile raw channel container from DSP
is needed to find corrections and apply the same ones
to the Tile raw channel container built offline.
But in the case of MC or overlay jobs
DSP corrections should not be applied
and therefore Tile raw channel container from DSP
is not needed in Tile raw channell builders also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20349TileConditions: A few optimizations.2019-01-16T03:02:26+01:00Scott SnyderTileConditions: A few optimizations.Use a move operation, rather than a copy, for setting values
in TileBadChannels.
Use a binary search rather than a linear search in
TileBadChanTool::isDrawerMasked.
TileROD_Decoder was caching flags of masked drawers, updated each run...Use a move operation, rather than a copy, for setting values
in TileBadChannels.
Use a binary search rather than a linear search in
TileBadChanTool::isDrawerMasked.
TileROD_Decoder was caching flags of masked drawers, updated each run,
which is not MT-safe. This should instead be done via a conditions algorithm.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20331TileByteStream: Making TileROD_Decoder const.2019-01-16T03:02:28+01:00Scott SnyderTileByteStream: Making TileROD_Decoder const.Make interfaces of TileROD_Decoder const.
Add code to give an error if the remaining non-MT safe part of the code
is run in MT mode.Make interfaces of TileROD_Decoder const.
Add code to give an error if the remaining non-MT safe part of the code
is run in MT mode.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20346fix memory leak in LArHVPathologyDbCondAlg2019-01-16T03:02:54+01:00Walter Lamplfix memory leak in LArHVPathologyDbCondAlgThe title says it all ...The title says it all ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/20092MET trigger hypo, ctest, and menu interface2019-01-16T03:03:00+01:00Gabriel Gallardogabriel.gallardo@cern.chMET trigger hypo, ctest, and menu interfaceThis MR includes code for the MET trigger hypo, its interface with the trigger menu prototype, and the required ctests.
This branch also has !20031 merged into it to enable monitoring of the met hypo, and to fix a broken muon ctest.
T...This MR includes code for the MET trigger hypo, its interface with the trigger menu prototype, and the required ctests.
This branch also has !20031 merged into it to enable monitoring of the met hypo, and to fix a broken muon ctest.
Tagging codeveloper @mronzani, and watchers @fpastore and @tbold.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20351JetMomentTools: Comply with ATLAS naming conventions.2019-01-16T03:03:12+01:00Scott SnyderJetMomentTools: Comply with ATLAS naming conventions.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20359Sweeping !20301 from 21.3 to 21.9.
test new BCID procedure2019-01-16T03:35:25+01:00Atlas NightlybuildSweeping !20301 from 21.3 to 21.9.
test new BCID proceduretest new BCID procedure
See merge request atlas/athena!20301test new BCID procedure
See merge request atlas/athena!20301https://gitlab.cern.ch/atlas/athena/-/merge_requests/20393Remove copy-paste version of lwtnn2019-01-17T03:03:20+01:00Dan GuestRemove copy-paste version of lwtnnFormer-commit-id: 333e55a2770a44f942af0043ca0994d9ec74263d
We didn't ever cherry pick https://gitlab.cern.ch/atlas/athena/commit/0645de5fe942a832cb262ce00270e9f90afb9290 to 21.2. This should resolve some things we're discussing in https...Former-commit-id: 333e55a2770a44f942af0043ca0994d9ec74263d
We didn't ever cherry pick https://gitlab.cern.ch/atlas/athena/commit/0645de5fe942a832cb262ce00270e9f90afb9290 to 21.2. This should resolve some things we're discussing in https://gitlab.cern.ch/atlas/athena/merge_requests/20305https://gitlab.cern.ch/atlas/athena/-/merge_requests/20241Update packages:TrigHLTJetHypo TrigHLTJetHypoUnitTests from upstream/21.1 to ...2019-01-17T11:01:59+01:00Teng Jian KhooUpdate packages:TrigHLTJetHypo TrigHLTJetHypoUnitTests from upstream/21.1 to masterUpdate packages:TrigHLTJetHypo TrigHLTJetHypoUnitTests from upstream/21.1 to upstream/master via pseudo-merge
Original (private) MR: https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16779Update packages:TrigHLTJetHypo TrigHLTJetHypoUnitTests from upstream/21.1 to upstream/master via pseudo-merge
Original (private) MR: https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16779https://gitlab.cern.ch/atlas/athena/-/merge_requests/20399Sweeping !20263 from 21.3 to 21.9.
Support GSC for FTK b-jet chains2019-01-17T20:47:34+01:00Atlas NightlybuildSweeping !20263 from 21.3 to 21.9.
Support GSC for FTK b-jet chainsSupport GSC for FTK b-jet chains
See merge request atlas/athena!20263Support GSC for FTK b-jet chains
See merge request atlas/athena!20263https://gitlab.cern.ch/atlas/athena/-/merge_requests/20263Support GSC for FTK b-jet chains2019-01-17T20:47:35+01:00Carlo Varnicarlo.varni@cern.chSupport GSC for FTK b-jet chainsFollowing ATR-19193, some code changes in the configuration of FTK b-jet chains are needed in order to support GSC.
This has been tested in 21.3 by adding some FTK+GSC b-jet chains in the Physics v7 menu and with the following command:
...Following ATR-19193, some code changes in the configuration of FTK b-jet chains are needed in order to support GSC.
This has been tested in 21.3 by adding some FTK+GSC b-jet chains in the Physics v7 menu and with the following command:
`trigtest.pl --cleardir --test AthenaTrigRDO_MC_pp_v7_no_prescale_toxAOD_FTK --rundir AthenaTrigRDO_MC_pp_v7_no_prescale_toxAOD_FTK --conf TriggerTest.conf`
Additional code changes have to be applied for addressing ATR-19262, but I'll open another MR for that since it is a different issue.
Tagging @jmontejo, @aranzazu and @baineshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20392Mhodgkin update cal hits dec182019-01-19T03:02:10+01:00Mark HodgkinsonMhodgkin update cal hits dec18Update to calibration hit code, such that the calibration hit moment maker uses xAOD TruthParticles (via ReadHandles) and calculates values of the calibration hit fraction moments.
The PFlow code is updated with a new python flag to make...Update to calibration hit code, such that the calibration hit moment maker uses xAOD TruthParticles (via ReadHandles) and calculates values of the calibration hit fraction moments.
The PFlow code is updated with a new python flag to make use of the calibration hit moment maker in special processings.
It also fixes a bug in the PFlow EDM that was recently introduced, as well introducing a new physics validation module to look at the pflow calibration hit moments.
One additional change to the cluster moment retrieval code is added in the pflow EDM, to ensure we can always get their values back in all scenarios.
Bringing to the attention of @loch , @wlampl ,@menke ,@cyounghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20437HIJetRec: Give an error if HISubtractedCellMaker is used in a MT job.2019-01-19T03:02:18+01:00Scott SnyderHIJetRec: Give an error if HISubtractedCellMaker is used in a MT job.This is in preparation for making ICaloCellMakerTool::process const,
for use in MT. This particular tool hasn't been converted to work
reentrantly, so give an error if someone attempts to do that.This is in preparation for making ICaloCellMakerTool::process const,
for use in MT. This particular tool hasn't been converted to work
reentrantly, so give an error if someone attempts to do that.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20451Remove more references to TileBeamInfoProvider2019-01-21T03:02:08+01:00Scott SnyderRemove more references to TileBeamInfoProviderRemove more references to TileBeamInfoProvider from job options.
Fix a few related job configuration issues.Remove more references to TileBeamInfoProvider from job options.
Fix a few related job configuration issues.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20430TileByteStream: Make BS converters MT-safe.2019-01-21T03:02:14+01:00Scott SnyderTileByteStream: Make BS converters MT-safe.Make BS converters in this package MT-safe (for reading anyway).Make BS converters in this package MT-safe (for reading anyway).https://gitlab.cern.ch/atlas/athena/-/merge_requests/20429LArCellRec: Thread-safety fixes for LArCellMakingTool.2019-01-21T03:02:16+01:00Scott SnyderLArCellRec: Thread-safety fixes for LArCellMakingTool.Working towards making ICaloCellMakerTool::process const.Working towards making ICaloCellMakerTool::process const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20432TileRecUtils: Fix duplicated Gaudi Property.2019-01-21T03:02:19+01:00Scott SnyderTileRecUtils: Fix duplicated Gaudi Property.The TileCondToolTiming property was duplicated between
TileRawChannelBuilderOpt2Filter and its base class
TileRawChannelBuilder.The TileCondToolTiming property was duplicated between
TileRawChannelBuilderOpt2Filter and its base class
TileRawChannelBuilder.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20462LArG4Validation: removed references to EventInfo and moved all headers to src2019-01-22T03:02:27+01:00Vakhtang TsulaiaLArG4Validation: removed references to EventInfo and moved all headers to srcAlso cleaned up old comments from `LArCafJobs/src/LArNoiseBursts.cxx`Also cleaned up old comments from `LArCafJobs/src/LArNoiseBursts.cxx`https://gitlab.cern.ch/atlas/athena/-/merge_requests/20452Dropped the dependency on EventInfo from LArAlignmentAlgs2019-01-22T03:02:41+01:00Vakhtang TsulaiaDropped the dependency on EventInfo from LArAlignmentAlgshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20408Adding Eta requirement on EtHypoTool for AthenaMT2019-01-22T03:02:43+01:00Carlo Varnicarlo.varni@cern.chAdding Eta requirement on EtHypoTool for AthenaMTIn order to avoid hypo configuration bugs, as reported in ATR-18970, the eta requirement has been added to the EtHypoTool in the b-jet AthenaMT code.In order to avoid hypo configuration bugs, as reported in ATR-18970, the eta requirement has been added to the EtHypoTool in the b-jet AthenaMT code.