athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-06-28T19:12:37+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/63996Adding a flag for upgrade2023-06-28T19:12:37+02:00Ying Wun Yvonne NgAdding a flag for upgradeAdding a flag for upgrade, removing EMtopo for regular runAdding a flag for upgrade, removing EMtopo for regular runhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62852changes roc curve y=0 points to 0.01; changing Zprime labels to Extended Zprime2023-06-28T19:08:43+02:00Ying Wun Yvonne Ngchanges roc curve y=0 points to 0.01; changing Zprime labels to Extended Zprime changes roc curve y=0 points to 0.01; changing Zprime labels to Extended Zprime changes roc curve y=0 points to 0.01; changing Zprime labels to Extended Zprimehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63772TrigHLTJetHypo: Use std::set less2023-06-27T14:28:16+02:00Adam Edward BartonTrigHLTJetHypo: Use std::set less@smh 's profiles show TrigHLTJetHypo spending a large amount of time in std::set this seems unnecessary. I have reworked FastReducer to use the slow std::set less.
This should probably be checked quite carefully and maybe more optimizat...@smh 's profiles show TrigHLTJetHypo spending a large amount of time in std::set this seems unnecessary. I have reworked FastReducer to use the slow std::set less.
This should probably be checked quite carefully and maybe more optimizations can be considered.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63874Use MC:: namespace instead of MC::PID:: namespace.2023-06-27T11:40:18+02:00Andrii VerbytskyiUse MC:: namespace instead of MC::PID:: namespace.Use MC:: namespace instead of MC::PID:: namespace.
@jchapmanUse MC:: namespace instead of MC::PID:: namespace.
@jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63505Updates to switch MU5VF_EMPTY to 2MU5VF_EMPTY, the muoncalib chain and fix fo...2023-06-06T21:07:43+02:00Francesco GiuliUpdates to switch MU5VF_EMPTY to 2MU5VF_EMPTY, the muoncalib chain and fix for online NoiseBurst flagging inefficiencyFix z0 calculation in emerging jets trigger
See merge request atlas/athena!63289Fix z0 calculation in emerging jets trigger
See merge request atlas/athena!63289https://gitlab.cern.ch/atlas/athena/-/merge_requests/61979Draft: Optimize HepMC::barcode_to_X using the const references2023-06-06T16:32:43+02:00Andrii VerbytskyiDraft: Optimize HepMC::barcode_to_X using the const referencesOptimize HepMC::barcode_to_X using the const references
Tag @jchapmanOptimize HepMC::barcode_to_X using the const references
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62221Draft: Optimization in Simulation2023-06-06T16:29:38+02:00Andrii VerbytskyiDraft: Optimization in SimulationOptimization in SimulationOptimization in Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63389Draft: hack JetVertexNNTagger to work with new TAuxStore check2023-06-06T10:54:38+02:00Michael HolzbockDraft: hack JetVertexNNTagger to work with new TAuxStore checkMR !62822 introduced a new check in the TAuxStore which makes the recalculation of the NNJvt score via the JetVertexNNTagger (as this uses WriteDecorHandles) crash in AthAnalysis, see the discussion in ATLSUSYBGF-672.
This MR introduces...MR !62822 introduced a new check in the TAuxStore which makes the recalculation of the NNJvt score via the JetVertexNNTagger (as this uses WriteDecorHandles) crash in AthAnalysis, see the discussion in ATLSUSYBGF-672.
This MR introduces a temporary (and ugly) workaround by adding an option to use Decorators instead of WriteDecorHandles.https://gitlab.cern.ch/atlas/athena/-/merge_requests/59033Draft: DMuon ART - Add RawToALL steering2023-06-05T11:05:09+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: DMuon ART - Add RawToALL steeringTagging @mabarel, @tadejTagging @mabarel, @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57853Draft: Adding EventContext to makeHandle2023-06-05T10:44:46+02:00Chris Malena DelitzschDraft: Adding EventContext to makeHandleSimply adding EventContext to makeHandle in JetMomentTools and DerivationFrameworkJetEtMiss as requested some time ago during one of my MRs.Simply adding EventContext to makeHandle in JetMomentTools and DerivationFrameworkJetEtMiss as requested some time ago during one of my MRs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/63288Fix z0 calculation in emerging jets trigger2023-05-25T06:26:35+02:00Jackson Carl BurzynskiFix z0 calculation in emerging jets triggerThe z0 calculation in `TrigJetEJsHypoTool` did not take into account the beamspot z position which led to large rates for periods with significant beamspot shifts (see ATR-27603). The implementation now aligns with the recommended way to...The z0 calculation in `TrigJetEJsHypoTool` did not take into account the beamspot z position which led to large rates for periods with significant beamspot shifts (see ATR-27603). The implementation now aligns with the recommended way to compute z0 (see https://twiki.cern.ch/twiki/bin/view/AtlasProtected/TrackingCPRecsRun2Final#Calculating_z0_and_d0_significan)
This will lead to rate changes. I am not sure the exact protocol for updating active chains so please let me know if there are additional approvals or discussions needed.
Tagging @cpollard, @jmasik, @strom, @dguest, @ggustavi, @mgenesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63115Daily merge of 23.0 into master2023-05-18T19:48:57+02:00Vakhtang TsulaiaDaily merge of 23.0 into masterConflicts:
- `SiClusterizationTool/ClusterMakerTool`. The conflict was caused by !62853 and !62051. It required manual resolution. @cvarni and @smh could you please check that everything is OK there.
- `ActsTrkClusterizationToolsConfig.p...Conflicts:
- `SiClusterizationTool/ClusterMakerTool`. The conflict was caused by !62853 and !62051. It required manual resolution. @cvarni and @smh could you please check that everything is OK there.
- `ActsTrkClusterizationToolsConfig.py`. The file has been deleted in the ~master and modified in the ~23.0. So, I ignored the latter modifications. Hopefully, this was the right thing to do.
This sweep contains the following MRs:
* !63107 Adding noalg eEM9 ~Trigger, ~TriggerMenu
* !63079 Correction to m_trigDec feature container for muon matching ~DQ, ~Trigger
* !63075 Reconstruction - Remove scheduler warning from TTVA tools ~JetEtmiss, ~Reconstruction, ~Tau
* !63072 DerivationFrameworkTruth - Declare truth classifier dependencies & breakup kernels ~Derivation, ~Tau
* !63065 Moving noise filling to the jTower creation ~Trigger
* !62853 Retrieve PixelCalibData ReadCondHandles once per call ~ACTS, ~Digitization, ~InnerDetector, ~Tracking
* !63021 xAODRootAccess: Don't check names of aux variables read from the input. ~Core
* !63069 add inner-coincidence plots to TGC offline DQ ~DQ, ~MuonSpectrometer, ~Trigger
* !62930 New NSW container to dump the trigger processor ~Analysis, ~Build, ~EDM, ~MuonSpectrometer, ~Run3-DataReco-output-changed, ~Tools, ~Trigger, ~frozen-tier0-violating
* !63063 ATR-26675, ATR-26776: Switch Topo3 to AlfaCtpIn by ConfigFlag ~Trigger, ~TriggerMenu
* !63064 Muctpi DQM ~DQ, ~Trigger
* !62983 TrigValidation: update ART inputs (data23 cosmics, MC23a RDOs) ~Trigger, ~changes-trigger-counts
* !63030 Remove barcodes from the reconstruction ~Egamma, ~JetEtmiss, ~Reconstruction
* !63018 Remove barcodes from InnerDetector/InDetValidation ~InnerDetector, ~JetEtmiss
* !63041 quick fix in large-R jet collection name ~Analysis, ~BTagging, ~Derivation, ~JetEtmiss
* !63056 CalibMomentumProvider - Remove PRW tool ~Analysis
* !63058 TrfTestsART: Update conditionstag to CONDBR2-BLKPA-RUN2-11 ~Tools
* !63062 Remove obsolete DigitizationTests and DigitizationTestsMT ART jobs (ATLASSIM-6559) ~Digitization, ~Simulation
* !63052 JetSelectorTools - Declare photon dressing ~Analysis, ~BTagging, ~JetEtmiss
* !62970 OrUtils - Declare data dependencies ~Analysis
* !63055 bug fixes in TGC trigger data decoder ~MuonSpectrometerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63149Draft: Remove truthhelpers, part 32023-05-18T11:24:13+02:00Andrii VerbytskyiDraft: Remove truthhelpers, part 3Draft: Remove truthhelpers, part 3Draft: Remove truthhelpers, part 3https://gitlab.cern.ch/atlas/athena/-/merge_requests/63045Draft: ATR-26821, TrigT1ZDC Package2023-05-12T23:01:29+02:00Matthew Caleb HoppeschDraft: ATR-26821, TrigT1ZDC PackageIntroduces a TrigT1ZDC package containing the Level 1 ZDC Trigger simulation. Covers the case of running Run3 Trigger Simulation on run 2 data. Introduces Trigger.doZDC flag in TriggerConfigFlags.
Supports [ATR-26821](https://its.cern...Introduces a TrigT1ZDC package containing the Level 1 ZDC Trigger simulation. Covers the case of running Run3 Trigger Simulation on run 2 data. Introduces Trigger.doZDC flag in TriggerConfigFlags.
Supports [ATR-26821](https://its.cern.ch/jira/browse/ATR-26821)https://gitlab.cern.ch/atlas/athena/-/merge_requests/62410Remove deprecated LLP1 config2023-04-18T19:19:21+02:00Jackson Carl BurzynskiRemove deprecated LLP1 configThe `LLP1.py` version in `share` is deprecated in favour of the CA config. This MR removes it.
cc @dguestThe `LLP1.py` version in `share` is deprecated in favour of the CA config. This MR removes it.
cc @dguesthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62384store Electron LH (charge ID selector) as float rather than double in derivat...2023-04-16T18:47:48+02:00Giovanni Marchioristore Electron LH (charge ID selector) as float rather than double in derivationsAddresses https://its.cern.ch/jira/browse/ATLASG-2511Addresses https://its.cern.ch/jira/browse/ATLASG-2511https://gitlab.cern.ch/atlas/athena/-/merge_requests/62107DetDescSvc - Some clean up2023-04-15T12:54:42+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDetDescSvc - Some clean up`DetDescrCnvSvc`:
* Use ATH_MSG messaging macros
* Add switches to toggle all muon sub detectors seperately
* Useage of ATH_CHECK macros
`DetDescrConverter`:
* Remove commented code
`IdDictDetDescrCnv`:
* Inherit from `AthMessaging`
*...`DetDescrCnvSvc`:
* Use ATH_MSG messaging macros
* Add switches to toggle all muon sub detectors seperately
* Useage of ATH_CHECK macros
`DetDescrConverter`:
* Remove commented code
`IdDictDetDescrCnv`:
* Inherit from `AthMessaging`
* Factor common structures into seperate methods
`MuonIdHelperSvc`:
* Toggle the remaining subdetectors from the description
Tagging: @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60432Add linear extrapolation in old charge calibration (ATLASRECTS-7337)2023-04-13T09:55:21+02:00Soshi TsunoAdd linear extrapolation in old charge calibration (ATLASRECTS-7337)Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calib...Mainly, there are two changes.
1. adding the functionality of the linear extrapolation also in the old pixel charge calibration. (default: false)
2. change /PIXEL/PixCalib/ to /PIXEL/ChargeCalibration/ also in the old pixel charge calibration.
For (1), the default is false. Thus, no impact at all for this MR. In the time of the reprocessing of RUN1/RUN2 data, it will be activated.
For (2), the new format /PIXEL/ChargeCalibration also keeps contents from /PIXEL/PixCalib/. The /PIXEL/PixCalib/ is obsoleted and it is not practical any more to maintain because maintaining both folders simply leads double burden.
Supposing the contents in both conditions DB are identical used in this CI test, the results should be identical.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62269Daily merge of 23.0 into master2023-04-12T19:25:48+02:00Vakhtang TsulaiaDaily merge of 23.0 into masterNo conflicts.
This sweep contains the following MRs:
* !62259 RpcTrackAnaAlg - Do not flood the log files ~DQ, ~MuonSpectrometer
* !62248 Added missing boost components explicitly where those are used ~Analysis, ~Core, ~Derivation, ~F...No conflicts.
This sweep contains the following MRs:
* !62259 RpcTrackAnaAlg - Do not flood the log files ~DQ, ~MuonSpectrometer
* !62248 Added missing boost components explicitly where those are used ~Analysis, ~Core, ~Derivation, ~ForwardDetectors
* !62254 move to git 2.12 ~Build
* !62250 TruthJetFilter: downgrade INFO messages to DEBUG ~Generators, ~JetEtmiss
* !62246 ATLASRECTS-7583: Ignore more ONNXRuntime warnings ~Analysis, ~BTagging, ~JetEtmiss
* !62245 egamma only. Disable also Lucid and AFP ~Egamma, ~Reconstruction
* !62241 TgcRawMonitoring - Remove tgcDetectorElement retrieval ~DQ, ~MuonSpectrometer
* !62238 ATLASRECTS-7581: VERBOSE is template param so we can use constexpr. ~InnerDetector
* !62237 Drop useless code from OldSpclMcFilterTool ~Analysis
* !62236 Avoid temporary objects in hepmcparticlelink if possible ~Generators
* !62226 CaloClusterMomentsMaker :Reduce verbosity , Print list of moments once ~Calorimeter
* !62140 Avoid duplication of attributes already serialized in other way ~Generators, ~Run2-AF3-output-changed, ~Run2-DataOverlay-output-changed, ~Run2-FullSim-output-changed, ~Run2-MCOverlay-output-changed, ~Run2-MCReco-output-changed, ~Run3-FullSim-output-changed, ~Run3-MCOverlay-output-changed, ~Tools, ~frozen-tier0-violating
* !62212 Egamma : Clang16 tidy related fixes ~Analysis, ~Derivation, ~EDM, ~Egamma
* !60007 FTAG: Adding support in Athena for Gn1 Aux tasks ~Analysis, ~BTagging, ~JetEtmiss
* !62185 rework ID trigger sequence ~Trigger, ~TriggerID
* !62253 L1CaloFEXByteStream: fix unmerged monitoring CA ~Trigger
* !61942 Migrate ALFA and AFP sequences to CA ~Trigger, ~TriggerMenu, ~TriggerMinBias
* !62252 Adding meaningful name-identifier to cell links ~Trigger
* !62242 TriggerEgammaCA: Migrating HI calo sequence to CA ~Egamma, ~JetEtmiss, ~Trigger, ~TriggerMenu
* !62199 Use hasFlag rather than relying on catching `RuntimeError` s ~Simulation, ~Trigger, ~TriggerID
* !62187 Relocating histograms to display only with detailedHistograms condition - TrigEgammaMonitoring ~DQ, ~Egamma, ~Trigger
* !62117 Set the prescale value to -1 when the chain is disabled (ATR-25967) ~Trigger
* !60831 Use the position of the vertex instead of barcode ~Generators, ~Simulationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62251TriggerMenuMT: remove caching of MenuSequenceCA2023-04-11T17:10:19+02:00Frank WinklmeierTriggerMenuMT: remove caching of MenuSequenceCA`MenuSequenceCA` does not play nicely with `AccumulatorCache` because it
contains other CAs. Prevent caching by overwriting the copy methods and
remove remaining uses of the caching in Jets and Photons TLA.
cc @tbold @fpastore`MenuSequenceCA` does not play nicely with `AccumulatorCache` because it
contains other CAs. Prevent caching by overwriting the copy methods and
remove remaining uses of the caching in Jets and Photons TLA.
cc @tbold @fpastore