athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-22T13:20:55+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70043Merge branch 'main-substructure-FPE' into 'main'2024-03-22T09:18:09+01:00Bertrand Martin Dit LatourMerge branch 'main-substructure-FPE' into 'main'pT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a80e86fa64f39a95267)
b4ee62fd pT filter for groomed jets before moment calculationpT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a80e86fa64f39a95267)
b4ee62fd pT filter for groomed jets before moment calculationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69746Add configurable property for jet-fat-jet OR in OverlapAnalysisConfig2024-03-14T09:55:22+01:00Thomas StreblerAdd configurable property for jet-fat-jet OR in OverlapAnalysisConfigSelf-explanatorySelf-explanatoryhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69503Add new code to allow creation of electron and muon free particle flow jets (V2)2024-03-07T14:58:54+01:00Mark HodgkinsonAdd new code to allow creation of electron and muon free particle flow jets (V2)This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functional...This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functionality has been added to allow users to make use of these workflows.
This should not change the output of standard particle flow jets and hence should preserve frozen tier0 for jets.
The new muon free jets rely on an additional decoration that is added to charged FlowElement - thus this aspect violates frozen tier0 and adds a new decoration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69340Draft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopy2024-03-13T12:03:59+01:00Frank WinklmeierDraft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopyThis is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specif...This is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specific files. The actual change to review is in `ChainConfigurationBase.py` .
In addition, do not `deepcopy` the result of the sequence configuration (`ChainStep`) as it is not being re-used or modified afterwards. This was also the behavior of the original `RecoFragmentsPool` before it was migrated to `AccumulatorCache`. The deepcopy can be enabled again by setting `Trigger.fastMenuGeneration=False`.
**Reduces the menu generation time of Dev_pp_run3_v1 by a factor 2**. It does however introduce (harmless) changes in the order of some of the `HypoTools` and `InputMakerInputDecisions` properties. In case we decide to move forward with this we would definitely want to add an ART test that checks the configuration is equivalent with/without `fastMenuGeneration` (see this recent [confTool improvement](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69329 "confTool: add ignoreOrder command line option")).
E.g. in the HI menu, the following properties change order (many more in the pp menu):
```plaintext
IM_EFMuMSReco_RoI.InputMakerInputDecisions
IM_L2MuCombReco.InputMakerInputDecisions
SPCountHypoAlg.HypoTools
TrigHIFwdGapHypoAlg.HypoTools
TrigL2MuCBHypoAlg.HypoTools
TrigL2MufastHypoAlg.HypoTools
TrigMuonEFCombinerHypoAlg.HypoTools
TrigMuonEFMSonlyHypo_RoI.HypoTools
```
cc @tbold @fpastore @tamartin
Relates to [ATR-26996](https://its.cern.ch/jira/browse/ATR-26996).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/69154gFEX: fix bug in gTower class2024-02-22T22:06:42+01:00Cecilia ToscirigFEX: fix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69149Fix bug in gTower class2024-02-22T21:07:56+01:00Cecilia TosciriFix bug in gTower classWith this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for ...With this MR, a bug found in `gTower::getFWID` is fixed. This assigns the correct energy to some gTowers in the forward region, that were previously swapped. Consequently, this solves some mismatches found in the hw vs sw comparison for small-R jets and also improves results for large-R jets and MET quantities.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69095Draft: Move FTagEventSF to standalone analysis config2024-03-08T02:18:58+01:00Thomas StreblerDraft: Move FTagEventSF to standalone analysis configBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69091Fix correlated smearing bug in JER in JetUncertainties in 22.02024-02-23T13:55:29+01:00Christopher YoungFix correlated smearing bug in JER in JetUncertainties in 22.0This is a copy of https://gitlab.cern.ch/atlas/athena/-/merge_requests/68331 but in 22.0
(if 22.0 is closed then we can probably reject this MR)
@markowen found that the JER was using the same seed for smearing jets as is done in JetCal...This is a copy of https://gitlab.cern.ch/atlas/athena/-/merge_requests/68331 but in 22.0
(if 22.0 is closed then we can probably reject this MR)
@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data it is more correct to use the max(MC,data) resolution. This was not anticipated when the tool was originally written but results in very small changes. Finally advanced users can set the seed themselves, but this currently set the seed the same for all jets which is not a usual use-case so this has also been modified.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68912Removal of legacy PrimaryDPDMaker job options part 3: JetValidation2024-02-15T11:27:24+01:00James CatmoreRemoval of legacy PrimaryDPDMaker job options part 3: JetValidationThis MR removes legacy job options from the JetValidation package. Most depend in some way on the PrimaryDPDMaker. Migration to CA was done some time ago.This MR removes legacy job options from the JetValidation package. Most depend in some way on the PrimaryDPDMaker. Migration to CA was done some time ago.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68905DerivationFrameworkJetEtMiss: update JETM1 python config with TrigEventInfoRe...2024-02-28T09:14:56+01:00Maximilian AmerlDerivationFrameworkJetEtMiss: update JETM1 python config with TrigEventInfoRecorderAlg to build `HLT_TCEventInfo_jet` when running on data22# Overview
Changes: update JETM1 python config with TrigEventInfoRecorderAlg instance when running on 2022 data to re-build HLT_TCEventInfo_jet with NumPV decoration. Checks `ConfigFlag` values to ensure running on 2022 data and not on M...# Overview
Changes: update JETM1 python config with TrigEventInfoRecorderAlg instance when running on 2022 data to re-build HLT_TCEventInfo_jet with NumPV decoration. Checks `ConfigFlag` values to ensure running on 2022 data and not on MC.
This change is needed to ensure that the number of primary vertices reconstructed in the HLT is available in JETM1. Previously it was not possible to access this observable because the `trackParticleLinks` for `HLT_IDVertex_FS` aren't stored for the jet trigger content configured in `DerivationFrameworkCore`.
The changes will be required for ongoing Trigger-Level Analysis searches where custom Insitu jet energy scale corrections must be derived on data22 and data23.
Tagging @mmontell @tofitsch
# Size estimates (from running 1000 event tests with `Derivation_tf.py`)
All size estimates from `checkFile.py`
| Data type | Old JETM1 (kB/evt) | Modified JETM1 (kB/evt) | Difference (kB/evt) |
| ------ | ------ | ------ | ------ |
| MC23 (dijet) | 185.481 | 185.481 | ~0 |
| data22 (run 437548) | 32.603 | 32.624 | +0.021 |
| data23 (run 453713) | 38.765 | 38.765 | ~0 |
Negligible increase in size with tests run so far (maybe more events are needed to check?).
**Note: since the change should only affect data22, we expect no size differences on data23 & MC**
# Testing
## Checking content in DAODs with `checkFile.py`
```
[mamerl@lxplus977 test_JETM12022withTCEventInfoandRenounceAll]$ cat run_*/checkFile*.txt | grep "TCEventInfo" --with-filename
(standard input):## opening file [DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_data22/DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root
(standard input): 10.747 kb 1.597 kb 0.003 kb 0.000 497 (B) HLT_TCEventInfo_jet
(standard input): 9.882 kb 1.892 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 11.929 kb 2.004 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
(standard input): 27.284 kb 2.119 kb 0.004 kb 0.000 497 (B) HLT_TCEventInfo_jetAux.
(standard input): 9.882 kb 2.514 kb 0.005 kb 0.000 497 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input):## opening file [DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_data23/DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root
(standard input): 6.954 kb 1.207 kb 0.004 kb 0.000 308 (B) HLT_TCEventInfo_jet
(standard input): 6.368 kb 1.401 kb 0.005 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 17.212 kb 1.469 kb 0.005 kb 0.000 308 (B) HLT_TCEventInfo_jetAux.
(standard input): 6.368 kb 1.779 kb 0.006 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input): 7.837 kb 3.131 kb 0.010 kb 0.000 308 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
(standard input):## opening file [DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root]...
(standard input):File:root://eoshome-m.cern.ch//eos/user/m/mamerl/PhD/PackagesForDevelopmentActivities/test_JETM12022withTCEventInfoandRenounceAll/run_mc23/DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root
(standard input): 21.099 kb 3.203 kb 0.003 kb 0.000 1000 (B) HLT_TCEventInfo_jet
(standard input): 54.356 kb 4.258 kb 0.004 kb 0.000 1000 (B) HLT_TCEventInfo_jetAux.
(standard input): 20.505 kb 5.952 kb 0.006 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.AvgMu
(standard input): 20.505 kb 6.529 kb 0.007 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.NumPV
(standard input): 24.681 kb 10.018 kb 0.010 kb 0.000 1000 (B) HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow
[mamerl@lxplus977 test_JETM12022withTCEventInfoandRenounceAll]$
```
All required attributes for `HLT_TCEventInfo_jet` exist
## Checking values of Aux elements on `HLT_TCEventInfo_jet`
### data22 test
```
root [0]
Attaching file DAOD_JETM1.test_data22_run437548_lb2004_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x414c1c0
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 8 * 33.216655 * 0 * 33.216655 *
* 1 * 0 * 8 * 33.216655 * 0 * 33.216655 *
* 2 * 0 * 7 * 33.216655 * 0 * 33.216655 *
* 3 * 0 * 15 * 33.216655 * 0 * 33.216655 *
* 4 * 0 * 7 * 33.216655 * 0 * 33.216655 *
* 5 * 0 * 12 * 33.216655 * 0 * 33.216655 *
* 6 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 7 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 8 * 0 * 15 * 33.216655 * 0 * 33.216655 *
* 9 * 0 * 17 * 33.216655 * 0 * 33.216655 *
* 10 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 11 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 12 * 0 * 16 * 33.216655 * 0 * 33.216655 *
* 13 * 0 * 9 * 33.216655 * 0 * 33.216655 *
* 14 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 15 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 16 * 0 * 11 * 33.216655 * 0 * 33.216655 *
* 17 * 0 * 16 * 33.216655 * 0 * 33.216655 *
* 18 * 0 * 5 * 33.216655 * 0 * 33.216655 *
* 19 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 20 * 0 * 14 * 33.216655 * 0 * 33.216655 *
* 21 * 0 * 13 * 33.216655 * 0 * 33.216655 *
* 22 * 0 * 10 * 33.216655 * 0 * 33.216655 *
* 23 * 0 * 19 * 33.216655 * 0 * 33.216655 *
* 24 * 0 * 10 * 33.216655 * 0 * 33.216655 *
```
Note:
- `HLT_TCEventInfo_jetAuxDyn.NumPV` is filled as required
- `HLT_TCEventInfo_jetAuxDyn.AvgMu` is identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` → this is likely related to the tools setup (LB Mu tool) in the DerivationFramework / Athena context when running `Derivation_tf.py`
- `HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow` is empty (`0` everywhere) i.e. not filled
### data23 test
```
root [0]
Attaching file DAOD_JETM1.test_data23_run453713_lb1476_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x439b150
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 13 * 35.380664 * 4420.1367 * 35.340515 *
* 1 * 0 * * * * 35.340515 *
* 2 * 0 * 15 * 35.380664 * 6362.5913 * 35.340515 *
* 3 * 0 * 14 * 35.380664 * 4907.5698 * 35.340515 *
* 4 * 0 * 11 * 35.380664 * 3518.6750 * 35.340515 *
* 5 * 0 * 16 * 35.380664 * 8282.9228 * 35.340515 *
* 6 * 0 * 22 * 35.380664 * 6873.4531 * 35.340515 *
* 7 * 0 * 13 * 35.380664 * 2783.1154 * 35.340515 *
* 8 * 0 * 15 * 35.380664 * 4346.9038 * 35.340515 *
* 9 * 0 * * * * 35.340515 *
* 10 * 0 * 14 * 35.380664 * 4867.6264 * 35.340515 *
* 11 * 0 * 18 * 35.380664 * 5058.1831 * 35.340515 *
* 12 * 0 * 11 * 35.380664 * 3905.0180 * 35.340515 *
* 13 * 0 * 12 * 35.380664 * 3506.6855 * 35.340515 *
* 14 * 0 * 8 * 35.380664 * 6581.5629 * 35.340515 *
* 15 * 0 * 16 * 35.380664 * 5168.9941 * 35.340515 *
* 16 * 0 * 13 * 35.380664 * 3372.4897 * 35.340515 *
* 17 * 0 * 13 * 35.380664 * 4090.0913 * 35.340515 *
* 18 * 0 * 8 * 35.380664 * 4835.6259 * 35.340515 *
* 19 * 0 * 17 * 35.380664 * 6507.3862 * 35.340515 *
* 20 * 0 * * * * 35.340515 *
* 21 * 0 * 9 * 35.380664 * 8573.375 * 35.340515 *
* 22 * 0 * 14 * 35.380664 * 6553.0869 * 35.340515 *
* 23 * 0 * 20 * 35.380664 * 8837.2695 * 35.340515 *
* 24 * 0 * 11 * 35.380664 * 5107.9179 * 35.340515 *
```
Note:
- All required `HLT_TCEventInfo_jetAuxDyn` attributes exist & are filled
- The `HLT_TCEventInfo_jetAuxDyn.AvgMu` is NOT identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` - indicates that the code is retrieving the existing TCEventInfo object in the AOD, not re-building the object
### mc23[_valid] test (note: these are old samples with the LAr pile-up issue identified in MC23)
```
root [0]
Attaching file DAOD_JETM1.test_mc23valid_JZ2_e8514e8516s4041s4055r14332_JETM1TCEventInfoRebuild.root as _file0...
(TFile *) 0x3cc83a0
root [1] CollectionTree->Scan("HLT_TCEventInfo_jetAuxDyn.NumPV:HLT_TCEventInfo_jetAuxDyn.AvgMu:HLT_TCEventInfo_jetAuxDyn.JetDensityEMPFlow:EventInfoAuxDyn.averageInteractionsPerCrossing")
***********************************************************************
* Row * Instance * HLT_TCEve * HLT_TCEve * HLT_TCEve * EventInfo *
***********************************************************************
* 0 * 0 * 14 * 45 * 9215.3632 * 45 *
* 1 * 0 * 16 * 45 * 3964.0888 * 45 *
* 2 * 0 * 19 * 44 * 5687.5585 * 44 *
* 3 * 0 * 17 * 45 * 8419.6777 * 45 *
* 4 * 0 * 19 * 44 * 9308.8652 * 44 *
* 5 * 0 * 18 * 45 * 13655.557 * 45 *
* 6 * 0 * 22 * 44 * 4839.5996 * 44 *
* 7 * 0 * 25 * 45 * 9061.6445 * 45 *
* 8 * 0 * 25 * 45 * 9512.0195 * 45 *
* 9 * 0 * 24 * 45 * 12075.797 * 45 *
* 10 * 0 * 16 * 44 * 14746.839 * 44 *
* 11 * 0 * 15 * 44 * 5786.2646 * 44 *
* 12 * 0 * 17 * 44 * 8471.5908 * 44 *
* 13 * 0 * 28 * 44 * 12345.287 * 44 *
* 14 * 0 * 16 * 44 * 5851.1669 * 44 *
* 15 * 0 * 29 * 44 * 8467.7617 * 44 *
* 16 * 0 * 11 * 42.999996 * 3358.1669 * 42.999996 *
* 17 * 0 * 13 * 42.999996 * 4736.9277 * 42.999996 *
* 18 * 0 * 11 * 44 * 5612.0869 * 44 *
* 19 * 0 * 13 * 44 * 6328.5634 * 44 *
* 20 * 0 * 20 * 44 * 13085.851 * 44 *
* 21 * 0 * 19 * 44 * 10142.033 * 44 *
* 22 * 0 * 20 * 45 * 7533.3999 * 45 *
* 23 * 0 * 23 * 42.999996 * 7394.0141 * 42.999996 *
* 24 * 0 * 19 * 42.999996 * 7133.0888 * 42.999996 *
```
Note:
- All required `HLT_TCEventInfo_jetAuxDyn` attributes exist & are filled
- The `HLT_TCEventInfo_jetAuxDyn.AvgMu` is identical to `EventInfoAuxDyn.averageInteractionsPerCrossing` - this is expected on MChttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68892Remove legacy configs from PrimaryDPDMaker2024-02-15T02:10:54+01:00Thomas StreblerRemove legacy configs from PrimaryDPDMakerCA configs are already largely present. Needed for !68501CA configs are already largely present. Needed for !68501https://gitlab.cern.ch/atlas/athena/-/merge_requests/68468Fixed clang warnings in two packages2024-01-31T12:18:15+01:00Vakhtang TsulaiaFixed clang warnings in two packages1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variables1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variableshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68175Dev atr284432024-01-16T18:03:24+01:00Shaoguang Wushaoguang.wu@cern.chDev atr28443update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is ...update chains for [ATR-28443](https://its.cern.ch/jira/browse/ATR-28443)
With available DJMASS cuts, the efficiency is too low, change DJMASS500j35 to DJMASS300j35;
use L1seed L1eEM26M, the trigger efficiency for VBFH-\>Z(-\>qq)y is list in Table attached.
And test the performance of gamma + 3 jets trigger for ggF production modes.
![efficiency and rates](/uploads/cf7d5bb5bed1c0b1f8f11168963af6f7/image.png){width=737 height=294}Shaoguang Wushaoguang.wu@cern.chShaoguang Wushaoguang.wu@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67876Add Calratio trigger algorithm to the 23.0 for the MC production request2023-12-15T16:13:17+01:00Tatiana OvsiannikovaAdd Calratio trigger algorithm to the 23.0 for the MC production requestthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainthe new Run3 calratio triggers
See merge request atlas/athena!66963
I just cherry peaking it from the mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67794gFEX JetAlgo: fix blkOutAB2023-12-13T19:01:29+01:00Cecilia ToscirigFEX JetAlgo: fix blkOutABThe MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.The MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67428Draft: tauRecoTools additional cleanup2023-12-05T14:10:46+01:00Antonio De MariaDraft: tauRecoTools additional cleanuphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67340Correcting for a factor in the outputs of the DIPZ regression in Athena2023-11-30T21:57:36+01:00Mohammed Aboelelamo.abdellrazekk@cern.chCorrecting for a factor in the outputs of the DIPZ regression in AthenaThe original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the...The original current DIPZ output from Athena has a factor of "50" in the outputs that we want to get rid of. Thus we derived another neural network with an extral layer that does such change and validated it. We defined the output of the network with a new timestamp. Here, we modified the files that use DIPZ with the new timestamped variable name, and also pointed athena to the location of the new json file.
These changes passed the `test_trigAna_RDOtoAOD_v1Dev_build.py` tests and the new timestamped output variables were inspected in the output AOD from the test.Dan GuestInes OchoaChris PollardKatharine LeneyMohammed Aboelelamo.abdellrazekk@cern.chDan Guest