athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-20T03:02:58+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20003Updating copyright and private licences2018-12-20T03:02:58+01:00Edward MoyseUpdating copyright and private licencesThis should remove the mistakes that crept back in. Need to compile before accepting.This should remove the mistakes that crept back in. Need to compile before accepting.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20051TileByteStream: Update reference files.2018-12-21T03:02:52+01:00Scott SnyderTileByteStream: Update reference files.Fix failures in master.Fix failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20053TileRecUtils: Update reference files.2018-12-21T03:03:00+01:00Scott SnyderTileRecUtils: Update reference files.Fix failures in master.Fix failures in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20054LArMonTools: Fix LArRawChannelMonTool configuration.2018-12-21T03:02:26+01:00Scott SnyderLArMonTools: Fix LArRawChannelMonTool configuration.The ATLASReadFilterTool tools in LArRawChannelMonTool are still public,
so need to be added to TooSvc.
Needed to fix failures in q220 in master.The ATLASReadFilterTool tools in LArRawChannelMonTool are still public,
so need to be added to TooSvc.
Needed to fix failures in q220 in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20052LArRecUtils: Fix reference to LArHVDB.2018-12-21T03:02:43+01:00Scott SnyderLArRecUtils: Fix reference to LArHVDB.LArHVDB from LArConditionsCommon should be imported, not included.
Needed to get q220 running again.LArHVDB from LArConditionsCommon should be imported, not included.
Needed to get q220 running again.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20055TileRecEx: Adjust for tools moved from CaloD3PDMaker to CaloSysD3PDMaker.2018-12-21T03:03:03+01:00Scott SnyderTileRecEx: Adjust for tools moved from CaloD3PDMaker to CaloSysD3PDMaker.Adjust for tools moved from CaloD3PDMaker to CaloSysD3PDMaker.Adjust for tools moved from CaloD3PDMaker to CaloSysD3PDMaker.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20066JetRec: Fix q220 test.2018-12-21T03:02:28+01:00Scott SnyderJetRec: Fix q220 test.The PFO tools are now private. That implies that we need to set propery
overrides in ctm.modifiersMap _before_ the corresponding call
to ctm.buildConstitModifSequence, or we override will not be effective.The PFO tools are now private. That implies that we need to set propery
overrides in ctm.modifiersMap _before_ the corresponding call
to ctm.buildConstitModifSequence, or we override will not be effective.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20061TrigJetMonitoring: Fix compilation warning.2018-12-21T03:02:49+01:00Scott SnyderTrigJetMonitoring: Fix compilation warning.Compilation warning: Unused function argument.Compilation warning: Unused function argument.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20067CaloMonitoring: Fix BadLBTool configuration for cosmics.2018-12-21T03:02:45+01:00Scott SnyderCaloMonitoring: Fix BadLBTool configuration for cosmics.Fix q220 failure.Fix q220 failure.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20101LArGeoFcal: cmake fix2018-12-26T03:03:08+01:00Scott SnyderLArGeoFcal: cmake fixFix typo in cmake file.Fix typo in cmake file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20102LArGeoMiniFcal: cmake fix.2018-12-26T03:02:22+01:00Scott SnyderLArGeoMiniFcal: cmake fix.CLHEP_LIBRARIES macro was used without the corresponding find_package.
But we don't actually have a direct dependency on CLHEP now, so just remove
the reference.CLHEP_LIBRARIES macro was used without the corresponding find_package.
But we don't actually have a direct dependency on CLHEP now, so just remove
the reference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20106LArG4H6SD: Fix compilation warnings.2018-12-26T09:03:51+01:00Scott SnyderLArG4H6SD: Fix compilation warnings.Compilation warnings: Do not use std::move in a return statement.Compilation warnings: Do not use std::move in a return statement.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20100LArGeoAlgsNV: Remove (again) use of non-bound DataHandle.2018-12-26T03:02:25+01:00Scott SnyderLArGeoAlgsNV: Remove (again) use of non-bound DataHandle.Trying to remove non-const DataHandle operations from StoreGate.Trying to remove non-const DataHandle operations from StoreGate.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20074TileRecUtils: Decrease dependency on TileInfo2018-12-29T03:02:30+01:00Siarhei HarkushaTileRecUtils: Decrease dependency on TileInfoTileInfo is used to return any detector-dependent constants
or information regarding the Tile Calorimeter,
including conditions data via different conditions tools.
It is not good for AthenaMT.
So functionality of TileInfo which is pro...TileInfo is used to return any detector-dependent constants
or information regarding the Tile Calorimeter,
including conditions data via different conditions tools.
It is not good for AthenaMT.
So functionality of TileInfo which is provided via tools
will be removed and clients will be migrated to use tools directly.
It is supposed that TileInfo will keep and provide only constants
which will be initialized during initialization of job.
TileRecUtils package has been migrated to use tools directly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20097TileByteStream: Make OFW access in TileROD_Decoder thread-safe.2018-12-29T03:02:11+01:00Scott SnyderTileByteStream: Make OFW access in TileROD_Decoder thread-safe.TileROD_Decoder caches OFW information.
Make this cache thread-safe.TileROD_Decoder caches OFW information.
Make this cache thread-safe.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20098TileRecUtils+TileRecEx: Update configuration for tile tools being made private.2018-12-29T03:02:24+01:00Scott SnyderTileRecUtils+TileRecEx: Update configuration for tile tools being made private.Probably not complete, but sufficient to get the TileRecEx tests working again.Probably not complete, but sufficient to get the TileRecEx tests working again.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20131LArG4H6SD: Fix gcc9 warnings.2018-12-29T03:02:38+01:00Scott SnyderLArG4H6SD: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20137LArRawConditions: Don't try to generate dictionaries for initializer_list.2018-12-29T03:02:14+01:00Scott SnyderLArRawConditions: Don't try to generate dictionaries for initializer_list.Results in warnings with gcc9.Results in warnings with gcc9.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20140LArGeoTBEC: cmake fix2018-12-31T03:02:11+01:00Scott SnyderLArGeoTBEC: cmake fixRemoving dangling use of CLHEP_LIBRARIES.Removing dangling use of CLHEP_LIBRARIES.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20151TileByteStream: Removing more MT-unsafe mutable data from TileROD_Decoder.2019-01-04T03:02:26+01:00Scott SnyderTileByteStream: Removing more MT-unsafe mutable data from TileROD_Decoder.Remove m_pRwChVec, m_cell2Double.
Create these objects on the stack where needed.
Change from a vector of pointers to a flat vector to remove most of the
allocation/deallocation overhead (which is probably why they were members
in the fi...Remove m_pRwChVec, m_cell2Double.
Create these objects on the stack where needed.
Change from a vector of pointers to a flat vector to remove most of the
allocation/deallocation overhead (which is probably why they were members
in the first place).