athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T13:34:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69620btagging tool for json-based CDI2024-03-28T13:26:55+01:00Binbin Dongbtagging tool for json-based CDItowards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.towards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69604Add new code to allow creation of electron and muon free particle flow jets (V3)2024-03-28T13:22:59+01:00Mark HodgkinsonAdd new code to allow creation of electron and muon free particle flow jets (V3)This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functional...This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functionality has been added to allow users to make use of these workflows.
This should not change the output of standard particle flow jets and hence should preserve frozen tier0 for jets.
The new muon free jets rely on an additional decoration that is added to charged FlowElement - thus this aspect violates frozen tier0 and adds a new decoration:
JetETMissChargedParticleFlowObjectsAuxDyn.FE_efrac_matched_muon
This is used by the new muon-less jet finding configuration included in this MR.
Whilst testing this I found two further unexpected differences in neutral FlowElements:
JetETMissNeutralParticleFlowObjectsAuxDyn.FE_efrac_matched_muon
JetETMissNeutralParticleFlowObjectsAuxDyn.FE_nMatchedMuons
MuonsAuxDyn.muon_efrac_matched_FE
as well as changes in MET container output.
Further investigation revealed an existing bug in the eflowRec code here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/eflowRec/src/PFMuonFlowElementAssoc.cxx?ref_type=heads#L253
whereby an iterator over the muon calormeter clusters cells is not reset to begin() in each loop over a calorimeter clusters cells. Thus only one cell can ever be matched, rather than N. This was (unintentionally) fixed in this MR because the code we redesigned and switched to range based for loops.
Due to the MET changes, this is a bug fix that affects MET output so it ought to go into 24.0? Flagging to @jdandoy and @christos .
I can prepare a MR for 24.0 that only contains the eflowRec bug fix.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68664Draft: Implementation of ONNX model score computation and decoration for Taus...2024-03-28T11:42:23+01:00Nadav Michael TamirDraft: Implementation of ONNX model score computation and decoration for Taus (GNTau)Add tools and wrappers to run ONNX-based models for Tau objects. Details can be found in [FTag software meeting presentation](https://indico.cern.ch/event/1378241/contributions/5792680/attachments/2794403/4874167/GNTau_ftagSW.pdf), but i...Add tools and wrappers to run ONNX-based models for Tau objects. Details can be found in [FTag software meeting presentation](https://indico.cern.ch/event/1378241/contributions/5792680/attachments/2794403/4874167/GNTau_ftagSW.pdf), but in short: a new class and tool are added to tauRecTools along with some new variable calculator functionalities to run model inference and decorate TauJets and TauTracks, and DerivationFrameworkTau + tauRec are modified to call the tools and decorate the DAOD TauJets (if one also decorates the DeepSetID at the moment).https://gitlab.cern.ch/atlas/athena/-/merge_requests/69743Adding the SUSY6 features to LLP1, JIRA: ATLASG-26902024-03-28T11:41:18+01:00Daiya AkiyamaAdding the SUSY6 features to LLP1, JIRA: ATLASG-2690For Whom It May Concern,
The SUSY6 derivations continuation was discussed in the derivation meetings, and it was concluded that this derivation format will be merge with the LLP1 format.
For this reason, we have opened the following Ji...For Whom It May Concern,
The SUSY6 derivations continuation was discussed in the derivation meetings, and it was concluded that this derivation format will be merge with the LLP1 format.
For this reason, we have opened the following Jira Ticket: ATLASG-2690
We have chatted with the LLP1 community and haven't gotten an objection to the merger.
Let us know how you would like to proceed.
Sincerely
Ismet Siral and Daiya Akiyama on Behalf of SUSY dE/dx analysis.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70179Clean up Event/xAOD legacy configs2024-03-28T09:58:33+01:00Thomas StreblerClean up Event/xAOD legacy configs`xAODEventFormatCnv` still to be cleaned up as CI tests need to be migrated to CA
FYI @maszyman`xAODEventFormatCnv` still to be cleaned up as CI tests need to be migrated to CA
FYI @maszymanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69793AthContainers, etc: Move Accessor, etc. classes out of AuxElement.2024-03-28T09:53:38+01:00Scott SnyderAthContainers, etc: Move Accessor, etc. classes out of AuxElement.Accessor and related classes have been members of AuxElement, the original
thinking being that derived classes of AuxElement may want to redefine them.
However, in retrospect, there does not seem to be any circumstance in which
that woul...Accessor and related classes have been members of AuxElement, the original
thinking being that derived classes of AuxElement may want to redefine them.
However, in retrospect, there does not seem to be any circumstance in which
that would actually make sense. Further, it prevents having any specializations
for these classes. So move these classes out of AuxElement into the SG
namespace (but with the names brought into AuxElement via using declarations
for backwards compatibility).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70160fix Large R accessor in jet calibration2024-03-28T09:41:26+01:00Frederic Rennerfix Large R accessor in jet calibrationI ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet ca...I ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet calibrations that might need different truth labels. @khoo
https://its.cern.ch/jira/browse/ATLJETMET-1714https://gitlab.cern.ch/atlas/athena/-/merge_requests/70167TileMonitoring: Remove old Tile monitoring tools for physics events2024-03-28T09:16:55+01:00Siarhei HarkushaTileMonitoring: Remove old Tile monitoring tools for physics eventsOld (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.Old (not thread-safe) Tile monitoring tools for physics events have been removed because
they have been migrated to the corresponding thread-safe monitoring algorithm for Run3
which are actually used now during Run3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70139Less verbose output from BTaggingEfficiencyTool2024-03-27T17:54:32+01:00Dan GuestLess verbose output from BTaggingEfficiencyToolWe should probably only print a lot of info if the user asks for a lot of info.We should probably only print a lot of info if the user asks for a lot of info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70064PhysicsAnalysis: required modifications to allow for online and conditional b...2024-03-27T09:03:42+01:00Sven MenkePhysicsAnalysis: required modifications to allow for online and conditional b-tagging treatment in TopPhysThe recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tag...The recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tagging systematics and MC to data scale factors in 21.1-based top analyses. The proposed changes here allow to combine one offline WP with a online WP via the provided conditional (online given offline) probabilities provided by the CP-group. The offline trigger confirmation requires furthermore to combine two offline WP (from the same tagger) with the online WP. Also this functionality is provided in the MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67994Draft: New Jet package JetToolHelpers2024-03-25T19:58:17+01:00Sebastian Tapia ArayaDraft: New Jet package JetToolHelpersAdding new Jet package "JetToolHelpers" which includes the first work version of the JetCommonFramework
the new package "JetToolHelpers" is also added as part of all Projects
The package is a common framework to read information from x...Adding new Jet package "JetToolHelpers" which includes the first work version of the JetCommonFramework
the new package "JetToolHelpers" is also added as part of all Projects
The package is a common framework to read information from xaod::jet or other, histograms (TH1/2) and text files. It will be used as a unified way to read the information by the JetTools, like JetCalibTools. The next step will be to re-write such tools using the helpers implemented in this MR.
here is the latest presentation in JetEtMiss meeting, https://indico.cern.ch/event/1289635/contributions/5437408/attachments/2670818/4629810/JetEtMiss_CommonFrameWorkV3_jun212023.pdf
tagging JetEtMiss experts, @mswiatlo @bhodkins @delsart @fballi @camachohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69859ConfigBlocks: update how options are set and remove make functions2024-03-22T08:30:18+01:00Joseph Earl LambertConfigBlocks: update how options are set and remove make functionsAll configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functi...All configurable parameters are now options.
Added features to each block and `ConfigFactory` so that
all of the options can be set at the same time as the block is
created in the same way as the make functions.
Removed all make functions that only act to set arguments since this
can be done without any extra code now.
Code using the `TextConfig`, `ConfigFactory` or the block configuration using classes
should be unaffected. Code that calls the make functions that where removed
will need to be update (makeSomeConfig -> SomeBlock and no longer pass the seq).
To create the block and set all options using the factory:
```
from AnalysisAlgorithmsConfig.ConfigFactory import ConfigFactory
config = ConfigFactory()
...
configSeq += config.makeConfig('GeneratorLevelAnalysis',
saveCutBookkeepers=True,
runNumber=284500)
```
Can also pass some this way and then set others individually like before.
To create the block and set all options using the blocks:
```
from AsgAnalysisAlgorithms.AsgAnalysisConfig import GeneratorAnalysisBlock
configSeq.append( GeneratorAnalysisBlock(
saveCutBookkeepers=True,
runNumber=284500) )
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/69062Draft: Try to use templates in the MCtruthClassifier to avoid declatrations o...2024-03-21T23:15:45+01:00Andrii VerbytskyiDraft: Try to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionsTry to use templates in the MCtruthClassifier to avoid declatrations of multiple functionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67271Run3 Derivations for heavy Ion group (part of my QT) v02024-03-19T09:35:52+01:00Sebastian Alonso Infante CabanasRun3 Derivations for heavy Ion group (part of my QT) v0Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migratio...Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migrations not started as of november 21 of 2023
No derivative is made to get truth data as i dont have truth data files for testinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69403Draft: attempt of CA configuration optimization2024-03-08T14:25:11+01:00Francesca PastoreDraft: attempt of CA configuration optimizationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67983Draft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibMode2024-03-06T12:36:41+01:00Thomas StreblerDraft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibModeConfigures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Pl...Configures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Please consider to configure the tool via the 'MuonCalibTool' property.
```
from https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/MET/METUtilities/Root/METSignificance.cxx#L153Thomas StreblerThomas Streblerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69361Draft: add unit test reference files for DL1dv012024-03-01T10:18:21+01:00Ligang XiaDraft: add unit test reference files for DL1dv01- add unit test references for DL1dv01
- The motivation for this MR is to detect (avoid) the impact on using old tagger due to implementing new features, like https://gitlab.cern.ch/atlas/athena/-/merge_requests/68453.
tagging @bdong- add unit test references for DL1dv01
- The motivation for this MR is to detect (avoid) the impact on using old tagger due to implementing new features, like https://gitlab.cern.ch/atlas/athena/-/merge_requests/68453.
tagging @bdonghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68363Draft: Update of truth labels for large-R jets2024-02-19T11:12:05+01:00Barbora EckerovaDraft: Update of truth labels for large-R jetsUpdate of the truth label for large-R jets in R24.Update of the truth label for large-R jets in R24.