athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-12T21:41:53+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69395Draft: update tags for NSW cluster uncertainties in data2024-03-12T21:41:53+01:00Patrick ScholerDraft: update tags for NSW cluster uncertainties in dataUpdating the tag for the NSW cluster uncertainties used in data. The updated tags will also go into the next global conditions tag (ATLGBLCONDTAGS-123). Currently, the folders are not yet present in a conditions tag, therefore they are h...Updating the tag for the NSW cluster uncertainties used in data. The updated tags will also go into the next global conditions tag (ATLGBLCONDTAGS-123). Currently, the folders are not yet present in a conditions tag, therefore they are hardcoded here.
Changes in the output of the data reco tests are expectedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69378MuonReadoutGeometry - Streamline the caching flags & fix B-Lines2024-03-15T08:04:53+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonReadoutGeometry - Streamline the caching flags & fix B-LinesMoin everybody,
this MR is simplifying the cache filling logic of the R3 readout geometry and also unfortunately revealed a bug in the application of the B-Line parameters for the Mdts.
For the Mdts, the B-line parameters are conceptio...Moin everybody,
this MR is simplifying the cache filling logic of the R3 readout geometry and also unfortunately revealed a bug in the application of the B-Line parameters for the Mdts.
For the Mdts, the B-line parameters are conceptionally baked into the transform of the ReadoutElement. Following the paradigms of the ATLAS-EDM the transform needs to be cached, which is happening in the [initCache()](https://gitlab.cern.ch/atlas/athena/-/blob/0edea5ebd6bff5b239bb21b45f67cd28d8a6d81b/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MdtReadoutElement.cxx#L1002) method. So, now the question is when has this method been invoked for the last time, it's when the [A-Line parameters are set](https://gitlab.cern.ch/atlas/athena/-/blob/0edea5ebd6bff5b239bb21b45f67cd28d8a6d81b/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MuonDetectorManager.cxx#L444-445). In contrast, the update of the B-Lines only triggers the caching of the [deformed transformation](https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MuonDetectorManager.cxx#L589-591) and not of the complete transformation which is fed to the surface. Essentially, the same conclusion holds for the as-built parameters. Alright, let's take a look at the order in which the alignment corrections are [parsed](https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorCondAlg.cxx#L109-159):
1. Mdt - As-built
2. Nsw - As built
3. A-Lines
4. B-Lines
--> The B-Lines are not propagated to the surface transformation, but to the globalTubePositions as the corresponding transforms are recalculated at every function call
Tagging from muon side: @kluit, @stavrop, @pscholer, @giraudpf, @amelung, @mvozak, @pfleisch, @plengo
from the software side: @jcatmore, @nstyles, @jchapman, @jdandoy, @christos, @dta, @ahabouelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/693632024-02-29: merge of 24.0 into main2024-02-29T11:07:11+01:00Tadej Novaktadej.novak@cern.ch2024-02-29: merge of 24.0 into mainThis sweep contains the following MRs:
* !69347 TrigValTools: fix for running transforms ~Trigger
* !69312 B-jet physics menu fastDIPS+GN1 -> fastGN2+GN2 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69300 IOVSvc+IOVDbSvc: delete...This sweep contains the following MRs:
* !69347 TrigValTools: fix for running transforms ~Trigger
* !69312 B-jet physics menu fastDIPS+GN1 -> fastGN2+GN2 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69300 IOVSvc+IOVDbSvc: delete legacy job options ~Analysis, ~Calorimeter, ~Core, ~Database, ~HGTD, ~InnerDetector, ~MuonSpectrometer, ~Test, ~Trigger
* !69289 B-physics trigger: move HLT_e5_lhvloose_e3_lhvloose_bBeeM6000 R(K*) trigger chains from Dev_pp_run3_v1 to Physics_pp_run3_v1 (ATR-19501, ATR-28162) ~Trigger, ~TriggerMenu
* !69235 Fix egamma HI HLT config ~Egamma, ~Trigger, ~TriggerMenu
* !69272 TrigP1Test: update test_trigP1_v1Dev_build to match reprocessing setup ~Trigger
* !69326 Demote ERROR to WARNING and ignore status check ~MuonSpectrometer
* !69322 LumiBlockComps: restore txt configuration for tests ~DQ
* !69301 Add additional monitoring to displaced jet trigger ~JetEtmiss, ~Trigger
* !69316 ATR-28712 Lowering MET preselection in the isolated high-pT trigger chains ~Trigger, ~TriggerMenu
* !69280 PyJobTransforms: Automatically run with CA if only CA skeleton available ~Tools
* !69303 AthenaMonitoring: don't monitor AntiKt10UFOCSSKSoftDropBeta100Zcut10Jets in cosmics ~Core, ~DQ
* !69315 ATR-28198, more b+tau triggers for HH->bbtt ~Trigger, ~TriggerMenu, ~changes-trigger-countshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69328MuonRecRTT: Fix typo in mkdir command2024-03-01T20:36:14+01:00Marten Zefanja BarelMuonRecRTT: Fix typo in mkdir commandSmall fix to changes made in yesterdays MR !69278Small fix to changes made in yesterdays MR !69278https://gitlab.cern.ch/atlas/athena/-/merge_requests/69326Demote ERROR to WARNING and ignore status check2024-02-29T07:27:17+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDemote ERROR to WARNING and ignore status checkDemote the ERROR messages to WARNINGS and ignore the returned status code for the time being. @epasqual has a better understanding of the decoder than me and he might want to assess the severity of the particular failure codes.
Tagging...Demote the ERROR messages to WARNINGS and ignore the returned status code for the time being. @epasqual has a better understanding of the decoder than me and he might want to assess the severity of the particular failure codes.
Tagging: @kluit
Closes ATLASRECTS-7920https://gitlab.cern.ch/atlas/athena/-/merge_requests/693202024-02-28: merge of 24.0 into main2024-02-28T15:08:53+01:00Tadej Novaktadej.novak@cern.ch2024-02-28: merge of 24.0 into mainThis sweep contains the following MRs:
* !69302 Uncomment Larnoiseburst chains, fix BGRP typo ~Trigger, ~TriggerMenu
* !69305 Replacing L1BTAG-MU5VFjJ50 with L1BTAG-MU5VFjJ80. ATR-24698 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
...This sweep contains the following MRs:
* !69302 Uncomment Larnoiseburst chains, fix BGRP typo ~Trigger, ~TriggerMenu
* !69305 Replacing L1BTAG-MU5VFjJ50 with L1BTAG-MU5VFjJ80. ATR-24698 ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69275 ATR-28571: Extend Trig_reco_tf.py functionality to allow athenaHLT running with legacy release inside a container ~Trigger
* !69106 AthenaConfiguration: remove global ConfigFlags instance ~Core, ~Derivation, ~Generators, ~Overlay, ~Reconstruction, ~Simulation, ~Tools, ~Trigger, ~TriggerMenu
* !69245 Removed obsolete DIPS, JetFitter and SV1 taggers and added spaceholders to... ~DQ, ~Trigger
* !69286 Fixup SiliconHitsTruthRelink ~Simulation
* !69296 CaloRingerAlgs: delete legacy job options ~CaloRinger, ~Reconstruction
* !69278 MuonRecRTT: Prevent cross-talk of Reco_tf runs ~MuonSpectrometer
* !69281 Minor fix for SimConfigFlags when running outside of ISF ~Simulation
* !69233 Inner Detector alignment monitoring (Run3) new npixhits_per_track_barrel histogram ~DQ, ~InnerDetector
* !69282 fix LArConditions2Ntuple.py, remove its legacy counterpart ~LAr
* !69277 delete LArConditionsCommon_H8_jobOptions.py and remaining (dysfunctional) clients ~LAr
* !69283 TrkVertexSeedFinderTools: run unit tests in their own directory ~Tracking
* !69168 TrigValTools: remove support of setting flags in legacy jobs ~Trigger
* !69291 B-physics trigger: move HLT_mu4_ivarloose_2mu3noL1_L1BPH-7M14-0DR25-MU5VFMU3VF chain from Dev_pp_run3_v1 to Physics_pp_run3_v1 (ATR-28868) ~Trigger, ~TriggerMenu
* !69293 L1CaloFEXSim: remove legacy job options and update unit tests ~L1Calo, ~Trigger
* !69284 ATR-28443 moving H->Z->qq/vv chains to Physics from Dev ~Trigger, ~TriggerMenu
* !69273 TriggerMenuMT+TriggerJobOpts: cleanup usage of CFElements ~Trigger, ~TriggerMenu
* !69201 maxmultfilter now filters jets depending on eta ~JetEtmiss, ~Trigger, ~TriggerJet, ~TriggerMenu, ~changes-trigger-counts
* !69249 Clean up legacy configs in JetTagging ~Analysis, ~BTagging, ~DQ, ~Derivation, ~JetEtmiss, ~Trigger
* !69248 Clean up legacy configs in PhysValMonitoring ~Analysis, ~JetEtmiss, ~Tau, ~Trigger
* !69244 TriggerMenuMT: remove caching of pebSequenceCfg ~Trigger, ~TriggerMenu
* !69220 Add L1BTAG-MU3VjJ40 seeded muon + bjet chains and the corresponding validation support chains to physics ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69270 WorkflowTestRunner: Add ability for detailed comparison ~Tools
* !69173 AthenaConfiguration: delete OldFlags2NewFlags ~Core
* !69268 TrfTestsART: Fix configuration of serial merge tests ~Tools
* !68913 Improve implementation of flags cloneAndReplace ~ACTS, ~Core, ~Tracking
* !69257 update trig section of TauCP monitoring ~DQ, ~Reconstruction
* !69242 MagFieldUtils: delete legacy job options ~Magnetshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69317MuonRdoToPrepData - Disable seeded decoding when trigger is offline2024-03-01T20:36:13+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonRdoToPrepData - Disable seeded decoding when trigger is offlineCloses ATLASRECTS-7889Closes ATLASRECTS-7889https://gitlab.cern.ch/atlas/athena/-/merge_requests/69314R4 sTGC Geometry - Adding Pad Readout Element2024-03-28T07:37:46+01:00Ishan Kiritbhai VyasR4 sTGC Geometry - Adding Pad Readout ElementAdding Pads to sTgc similar to wireGroup and Strips.
@alainb @jojungge @pscholerAdding Pads to sTgc similar to wireGroup and Strips.
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69304Make number of bunch crossings for RPC L1 simulation configurable2024-03-08T23:01:52+01:00Savanna ShawMake number of bunch crossings for RPC L1 simulation configurableAs discussed in ATR-28396, the number of bunch crossings being readout by the RPCs changed partway through 2023, but the L1 trigger simulation uses hardcoded values for the number of bunch crossings, and which bunch crossing is the centr...As discussed in ATR-28396, the number of bunch crossings being readout by the RPCs changed partway through 2023, but the L1 trigger simulation uses hardcoded values for the number of bunch crossings, and which bunch crossing is the central one. This makes both values configurable via flags so that the L1 simulation can be run on data from both before and after the readout changes.
Overall this is done by setting configurable properties in a few places (the DigitToRDO conversion, the RDO decoder, and the RPC trigger simlation alg), and then using two added flags to configure these properties consistently. The values for the number of bunch crossings and central value are then passed through to other places that need them (the Matrix, sector logic, etc).
One thing to note is that there are a lot of arrays that depend on the number of bunch crossings when setting the array lengths. I assumed that we wouldn't go back to reading out more than 8 bunch crossings, and kept the dependence on the number of bunch crossings on the array lengths in the comments in case it needs to be adjusted in the future. In the end, when we use the arrays, we always loop over up to the configured number of bunch crossings. So we are defining arrays that have a length longer than needed, but the only other way around this would be to move everything to vectors, and that was a larger intervention than I was willing to do for this.
Validation plots added to ATR-28396.
cc @mcorradihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69300IOVSvc+IOVDbSvc: delete legacy job options2024-02-29T07:27:17+01:00Frank WinklmeierIOVSvc+IOVDbSvc: delete legacy job optionsDelete include-style legacy job options and empty text options.Delete include-style legacy job options and empty text options.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69298MuonR4 geometry - Move the chamber to be part of the ReadoutGeometry2024-02-29T19:48:27+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonR4 geometry - Move the chamber to be part of the ReadoutGeometryIn R4, the `MuonChambers` are created post-readout geometry by the MuonStationGeoHelpers and cached in a set. That has 2 caveats:
* The useage of them is quite cumbersome because one needs always to call the MuonChamberTool
* Non-standa...In R4, the `MuonChambers` are created post-readout geometry by the MuonStationGeoHelpers and cached in a set. That has 2 caveats:
* The useage of them is quite cumbersome because one needs always to call the MuonChamberTool
* Non-standard grouping of readout elements to a chamber is not quite trivial
--> Move the chamber creation to the readout geometry creation and directly associate them with the readoutelement.
--> Delete the MuonStationGeoHelpers package
Tagging: @goblirsc, @damperia, @maharris, @pscholer, @ivyas, @smerianohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69278MuonRecRTT: Prevent cross-talk of Reco_tf runs2024-02-28T10:00:26+01:00Marten Zefanja BarelMuonRecRTT: Prevent cross-talk of Reco_tf runsPart of ATLASRECTS-7092
This MR will fix a bug that occurred in the nightly ART run of test_q443_RAWtoALL_MT.sh, where RAWtoALL Substep of the 1-threaded Reco_tf run used output of the RDOtoRDOTrigger step of the serial Reco_tf run, whi...Part of ATLASRECTS-7092
This MR will fix a bug that occurred in the nightly ART run of test_q443_RAWtoALL_MT.sh, where RAWtoALL Substep of the 1-threaded Reco_tf run used output of the RDOtoRDOTrigger step of the serial Reco_tf run, which lead to a crash. By running each Reco_tf in its own directory, this will no longer be possible. This change is also implemented in all other tests that run multiple instances of Reco_tf in the same test. These were running fine as is, but it will prevent any such issues from occurring in the future.https://gitlab.cern.ch/atlas/athena/-/merge_requests/692692024-02-27: merge of 24.0 into main2024-02-27T17:31:26+01:00Tadej Novaktadej.novak@cern.ch2024-02-27: merge of 24.0 into mainThis sweep contains the following MRs:
* !69232 ATR-28838 Remaining MET chains duplication clean up - HLT / ATR-28563 A Phase I L1Topo LLP Trigger ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69237 Monitoring Improvement: use gen...This sweep contains the following MRs:
* !69232 ATR-28838 Remaining MET chains duplication clean up - HLT / ATR-28563 A Phase I L1Topo LLP Trigger ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !69237 Monitoring Improvement: use generic fillers for TProfile2D so that they support bin labels and bin extension ~Core, ~DQ
* !69192 AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup ~Test
* !69239 LumiBlockComps: delete obsolete files ~DQ
* !69241 Remove legacy job options from TGC_Digitization package ~Digitization, ~MuonSpectrometer
* !69234 main-coverity-TRT_CalibTools ~InnerDetector
* !68959 Cleanup transform setup of legacy config + TAG format ~Analysis, ~Calorimeter, ~Derivation, ~LAr, ~Overlay, ~Reconstruction, ~Simulation, ~Tools, ~Trigger
* !68848 Update ASG test files for DAOD_PHYS ~Analysis, ~CPAlgorithms, ~Core
* !69155 Add BRAN module digitization ~Digitization, ~ForwardDetectors, ~Simulation
* !69148 IOVDbTestAlg: migrate tests to CA ~Test
* !69211 B-physics trigger: move bBmux_BdmuDstarX trigger chains from Dev_pp_run3_v1 to Physics_pp_run3_v1 (ATR-27341) ~Trigger, ~TriggerMenu
* !69219 Fix offline tau distributions in the Tau Trigger Monitoring ~DQ, ~Tau, ~Trigger
* !67694 InDetTrigRecAlgs - remove obsolete package ~InnerDetector, ~Trigger, ~TriggerID
* !69198 Increase eta range for track selection ~Trigger
* !69013 DumpGeo: migrate it to CA and add a filter to dump DetectorManagers ~EventDisplay, ~Geometry
* !69215 LArConditionsTest: remove POOL catalog on test re-run ~LArhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69261Fixed Clang warnings2024-02-27T07:04:36+01:00Vakhtang TsulaiaFixed Clang warnings1. `MuonReadoutGeometryR4/RadialStripDesign.icc`: lambda capture 'this' is not used (triggered warnings in 19 client packages :smile:)
2. `DiTauRec/ElMuFinder.h`: unused private data member1. `MuonReadoutGeometryR4/RadialStripDesign.icc`: lambda capture 'this' is not used (triggered warnings in 19 client packages :smile:)
2. `DiTauRec/ElMuFinder.h`: unused private data memberhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69259MuonR4 Fast digi - Fix atomic summary count2024-02-27T07:13:04+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonR4 Fast digi - Fix atomic summary counthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69258MuonGeoModelR4 - Save the TGC sector mapping to StoreGate2024-02-27T07:11:47+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonGeoModelR4 - Save the TGC sector mapping to StoreGateSector mapping is needed by the idHelperSvc to map the 48-fold stationPhi of the TGCs onto the 16-fold sector symmetry of the MS.Sector mapping is needed by the idHelperSvc to map the 48-fold stationPhi of the TGCs onto the 16-fold sector symmetry of the MS.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69241Remove legacy job options from TGC_Digitization package2024-02-27T09:34:05+01:00John Derek ChapmanRemove legacy job options from TGC_Digitization packageRemoving one legacy job options file and the corresponding reference in the package CMakeLists.txt file.Removing one legacy job options file and the corresponding reference in the package CMakeLists.txt file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69228Updating LAr EM NTuple creation to CA based configuration2024-02-26T13:13:58+01:00Mustafa Andre SchmidtUpdating LAr EM NTuple creation to CA based configurationThe configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.The configuration script for the LAr EM NTuple creation as well as the README file was changed to be compatible with the new CA-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69223MicroMega fast digi for Phase II -- Fix chamber assignment2024-02-26T15:00:55+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMicroMega fast digi for Phase II -- Fix chamber assignmenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69218MuonR4 - Fast digitization restructure Rpc & Tgc2024-02-26T11:38:43+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonR4 - Fast digitization restructure Rpc & Tgc* **Rpc fast digitization** : Remove duplicated code creating a prd and filling it into the container. Insert several checks to ensure that the digit is well within the active area
* **Tgc fast digitization**: Broaden the width of the ...* **Rpc fast digitization** : Remove duplicated code creating a prd and filling it into the container. Insert several checks to ensure that the digit is well within the active area
* **Tgc fast digitization**: Broaden the width of the Gaussian to the Width of the complete wire group / to the width of the radial strip. Remove duplicated code to create & fill the Tgc Prd.