athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-20T03:02:58+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20003Updating copyright and private licences2018-12-20T03:02:58+01:00Edward MoyseUpdating copyright and private licencesThis should remove the mistakes that crept back in. Need to compile before accepting.This should remove the mistakes that crept back in. Need to compile before accepting.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20008migrate PileUpEventInfo to xAOD::EvenInfo2019-02-13T03:02:35+01:00Marcin Nowakmigrate PileUpEventInfo to xAOD::EvenInfoMigrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633Migrated PileUpEventInfo to xAOD::EvenInfo
Jira: https://its.cern.ch/jira/browse/ATLASSIM-2633https://gitlab.cern.ch/atlas/athena/-/merge_requests/20024Adding MM and STGC clusterization packages for the NSW, with interfaces and e...2019-01-09T01:50:13+01:00Stefano RosatiAdding MM and STGC clusterization packages for the NSW, with interfaces and example toolsThis merge request provides a structure to be followed in the future to implement the cluster builders tools, that will have various developers.
We also have a first version of the "simple" cluster builder, right now implemented in th...This merge request provides a structure to be followed in the future to implement the cluster builders tools, that will have various developers.
We also have a first version of the "simple" cluster builder, right now implemented in the converters, this will be added as soon as this merge request is merged. But this will also imply modifying the clients, so a few more packages involved, it is neater to stage the two MR's.
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/CMakeLists.txt
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/MMClusterization/IMMClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/SimpleMMClusterBuilderTool.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/SimpleMMClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/components/MMClusterization_entries.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/MMClusterization/src/components/MMClusterization_load.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/CMakeLists.txt
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/STgcClusterization/ISTgcClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/SimpleSTgcClusterBuilderTool.cxx
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/SimpleSTgcClusterBuilderTool.h
new file: MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization/src/components/STgcClusterization_entries.cxxhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20047Initial signal-only overlay output for MT (ATLASSIM-3820)2018-12-26T03:03:22+01:00Tadej Novaktadej.novak@cern.chInitial signal-only overlay output for MT (ATLASSIM-3820)This is an initial step to still support signal-only overlay output (but only when running in MT):
- remove the support from current transforms
- add output file flag and modify the existing `doSignal`->`signalOnlyOutput` to make it cl...This is an initial step to still support signal-only overlay output (but only when running in MT):
- remove the support from current transforms
- add output file flag and modify the existing `doSignal`->`signalOnlyOutput` to make it clearer
- cleanup MuonOverlay code from obsolete flag related to this
- update job options to work only with MThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20075Add Muon ART Tests for Standalone Setup and NSW2019-01-09T01:50:13+01:00Zhidong ZhangAdd Muon ART Tests for Standalone Setup and NSWThree ART tests are added into MuonRecRTT:
test_muonrec_sa_setup_normal.sh: normal test for standalone muon setup;
test_muonrec_sa_setup_simple.sh: simplest test for standalone muon setup;
test_nsw_singlemuon_recon.sh: muon reconst...Three ART tests are added into MuonRecRTT:
test_muonrec_sa_setup_normal.sh: normal test for standalone muon setup;
test_muonrec_sa_setup_simple.sh: simplest test for standalone muon setup;
test_nsw_singlemuon_recon.sh: muon reconstruction test for New Small Wheel.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20096Muon efficiency correction feature updates2020-04-11T18:10:15+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuon efficiency correction feature updatesHi everybody,
this MR is going to prepare the next round of recommendations for the reconstruction, TTVA and isolation scale-factors. The tool will be augmented with the following features
```
*** Break down of the systematics pe...Hi everybody,
this MR is going to prepare the next round of recommendations for the reconstruction, TTVA and isolation scale-factors. The tool will be augmented with the following features
```
*** Break down of the systematics per source (I.e. truth-closure/ fit-template/ isolation WP/ etc.
*** Decorrelation of the systematics per bin as it's already done for the statistical error if it's possible
*** Cleaning up depreciated classes
*** Minimize the number histograms to be loaded in the memory.
```
Cheers,
Johannes
Adding: @goblirsc, @fsforza, @szambito and our well admired friend the @atlasbot
![image](/uploads/91c09a1e79fa15433e6e06d0cde9bbf2/image.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/20105TGCcabling: Comply with ATLAS naming conventions.2018-12-26T03:02:19+01:00Scott SnyderTGCcabling: Comply with ATLAS naming conventions.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20109Decouple TGC BS conversion from RDO->PRD decoding2019-01-08T03:02:12+01:00Neil Warrackneil.warrack@cern.chDecouple TGC BS conversion from RDO->PRD decoding_Description:_
Decouple the BS conversion from the RDO->PRD decoding for the Muon Spectrometer TGCs by removing the BS convert function and replacing it directly in the trigger algorithms prior to the RDO->PRD decode function.
_Mo..._Description:_
Decouple the BS conversion from the RDO->PRD decoding for the Muon Spectrometer TGCs by removing the BS convert function and replacing it directly in the trigger algorithms prior to the RDO->PRD decode function.
_Motivation:_
This work is carried as part of the AthenaMT migration, specifically to allow the BS conversion to be carried out completely separately from the RDO->PRD process. The BS conversion can then be carried out by trigger and offline in the same manner.
_Tests:_
The work has been tested by running the unit tests in the MuonConfig and TrigValidation packages as well as running the q221 Reco_tf.py test and comparing the output myAOD.pool.root leaves with acmd.py diff-roothttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20121MuonConfig: More patterns to ignore.2019-01-04T12:03:06+01:00Scott SnyderMuonConfig: More patterns to ignore.Output can change depending on whether or not FRONTIER_SERVER
is defined. Add extra patterns to ignore these diferences.
Should fix failures need in nightlies.Output can change depending on whether or not FRONTIER_SERVER
is defined. Add extra patterns to ignore these diferences.
Should fix failures need in nightlies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20138MuonGeoModel: Fix clang warning.2018-12-31T03:02:19+01:00Scott SnyderMuonGeoModel: Fix clang warning.clang warning: unused variable.clang warning: unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20142MuonCondSvc: Comply with ATLAS naming convention.2018-12-31T03:02:22+01:00Scott SnyderMuonCondSvc: Comply with ATLAS naming convention.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20158MuonCondTool: Comply with ATLAS naming conventions.2019-01-04T03:02:21+01:00Scott SnyderMuonCondTool: Comply with ATLAS naming conventions.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20162MuonConfig: Increase test timeout.2019-01-05T03:02:16+01:00Scott SnyderMuonConfig: Increase test timeout.Test has been timing out in nightlies.Test has been timing out in nightlies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20165MuonG4SD: Comply with ATLAS naming conventions.2019-01-05T03:02:14+01:00Scott SnyderMuonG4SD: Comply with ATLAS naming conventions.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20168Move OutputStream to output Sequence to help AthenaMT scheduling.2019-02-22T10:35:41+01:00Peter Van GemmerenMove OutputStream to output Sequence to help AthenaMT scheduling.This MR moves OutputStreams (that have the asAlg flag set, most of them) into the Athena Output Sequence to help with MT scheduling (@leggett , @tsulaia ).
It also adds a mutex for writing that is currently needed if more than one strea...This MR moves OutputStreams (that have the asAlg flag set, most of them) into the Athena Output Sequence to help with MT scheduling (@leggett , @tsulaia ).
It also adds a mutex for writing that is currently needed if more than one stream is used (because writing modifies the SG proxy of the objects in the ItemList, conversion service caches file name for object placement, to be fixed later).
Some tests for Registration Stream may need updating or they could be obsolete anyway (@cranshaw ).https://gitlab.cern.ch/atlas/athena/-/merge_requests/20174Muon BS to RDO caching for multi-threading - CSC technology2019-06-04T23:09:58+02:00Ian Allan ConnellyMuon BS to RDO caching for multi-threading - CSC technologyThis MR (WIP for now) continues the work initiated by @markowen, and was closed during the private->public repository migration (see athenaprivate1!16700). As this was a branch off of Mark's fork, it was not straight-forward to patch so ...This MR (WIP for now) continues the work initiated by @markowen, and was closed during the private->public repository migration (see athenaprivate1!16700). As this was a branch off of Mark's fork, it was not straight-forward to patch so I have had to do a manual diff/merge procedure to bring into the new repository. The code is currently compiling correctly but will need to be tested as it is further developed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20180MuonTrackPerformance: Fix clang warnings.2019-01-08T03:02:18+01:00Scott SnyderMuonTrackPerformance: Fix clang warnings.clang warnings: missing override keywords.clang warnings: missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20182MuonMDT_Cabling: Avoid use of non-bound DataHandle.2019-01-09T16:17:18+01:00Scott SnyderMuonMDT_Cabling: Avoid use of non-bound DataHandle.Deprecating use of non-bound DataHandle, especially non-const.Deprecating use of non-bound DataHandle, especially non-const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20186Migration of condition db interface of TrigT1TGC2019-01-11T03:02:35+01:00Tomoe KishimotoMigration of condition db interface of TrigT1TGCTrigT1TGC retrive the trigger coincidence map from the condition db.
Condition algorithm (TGCTriggerDbAlg) and condition object (TGCTriggerData)
have been added to manage the condition data in AthenaMT. TrigT1TGC has
beed modified to use...TrigT1TGC retrive the trigger coincidence map from the condition db.
Condition algorithm (TGCTriggerDbAlg) and condition object (TGCTriggerData)
have been added to manage the condition data in AthenaMT. TrigT1TGC has
beed modified to use the new TGCTriggerDbAlg and TGCTriggerData.
RunTier0Tests.py passed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20189Sweep r-t smearing functionality to master from 21.32019-05-23T16:24:42+02:00William Axel LeightSweep r-t smearing functionality to master from 21.3Please see https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/12101 for details.Please see https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/12101 for details.