athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-16T20:25:28+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66329Draft: Nsw fast segment maker2024-03-16T20:25:28+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: Nsw fast segment makerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66616Draft: TgcReadoutGeometry clean up & removal of a couple of bugs2024-03-27T00:33:16+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: TgcReadoutGeometry clean up & removal of a couple of bugs- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative z- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative zhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67388Try to use C++20 starts_with2024-03-21T13:16:05+01:00Andrii VerbytskyiTry to use C++20 starts_withTry to use C++20 starts_withTry to use C++20 starts_withhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67578Draft: MuonReadoutGeomtetryCnv - Add translation of Rpc detectors2024-03-24T09:32:22+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: MuonReadoutGeomtetryCnv - Add translation of Rpc detectorshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67875Draft: MuonTrackingGeometry - Add internal structure to the chambers2024-03-01T16:05:57+01:00Dimitra Amperiadoudimitra.amperiadou@cern.chDraft: MuonTrackingGeometry - Add internal structure to the chambersBarrel chambers are fully in place:
![image](/uploads/c2338783ac2cbc057fa947a8fa4b732f/image.png)
[Merry christmas](https://www.youtube.com/watch?v=P96Lo8TJN8g)
Tagging: @goblirsc, @jojungge, @maharris, @ncalace, @asalzbur, @emoyseBarrel chambers are fully in place:
![image](/uploads/c2338783ac2cbc057fa947a8fa4b732f/image.png)
[Merry christmas](https://www.youtube.com/watch?v=P96Lo8TJN8g)
Tagging: @goblirsc, @jojungge, @maharris, @ncalace, @asalzbur, @emoysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67983Draft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibMode2024-03-06T12:36:41+01:00Thomas StreblerDraft: Explicitly configure MuonCalibTool in MetAnalysisConfig with calibModeConfigures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Pl...Configures calibMode in muon analysis config + pass config to MET analysis config
Clears the warning with CP alg config
```
MetSignificanceAlg.significanceTool WARNING Setup the muon calibration tool with calib mode 1. Please consider to configure the tool via the 'MuonCalibTool' property.
```
from https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/MET/METUtilities/Root/METSignificance.cxx#L153Thomas StreblerThomas Streblerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69076Draft: HepMcParticleLink: Flag whether link points to suppressed pile-up truth2024-02-23T17:38:05+01:00John Derek ChapmanDraft: HepMcParticleLink: Flag whether link points to suppressed pile-up truthFollows !69055Follows !69055https://gitlab.cern.ch/atlas/athena/-/merge_requests/69203Draft: HepMcParticleLink: Testing the adaption to GenParticle::id2024-02-29T14:08:28+01:00John Derek ChapmanDraft: HepMcParticleLink: Testing the adaption to GenParticle::idFollows !69076Follows !69076https://gitlab.cern.ch/atlas/athena/-/merge_requests/69395Draft: update tags for NSW cluster uncertainties in data2024-03-12T21:41:53+01:00Patrick ScholerDraft: update tags for NSW cluster uncertainties in dataUpdating the tag for the NSW cluster uncertainties used in data. The updated tags will also go into the next global conditions tag (ATLGBLCONDTAGS-123). Currently, the folders are not yet present in a conditions tag, therefore they are h...Updating the tag for the NSW cluster uncertainties used in data. The updated tags will also go into the next global conditions tag (ATLGBLCONDTAGS-123). Currently, the folders are not yet present in a conditions tag, therefore they are hardcoded here.
Changes in the output of the data reco tests are expectedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69732Draft: Pin the NCB segment onto th calo exit2024-03-28T08:23:27+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: Pin the NCB segment onto th calo exitFirst attempt to reduce the beam background by adding a new constraint to the NCB segment. Introduce the additional constraint that the particle is roughly horizontal and crossed the calorimeter at z=0 roughly at the same height. This co...First attempt to reduce the beam background by adding a new constraint to the NCB segment. Introduce the additional constraint that the particle is roughly horizontal and crossed the calorimeter at z=0 roughly at the same height. This constaint drastically reduces the number of built NCB segments (cf. plots below - back is the current release and red are the patched distributions). Plots have been produced using one file from the heavy ion data-taking.
![image](/uploads/c46e78ee3a9769a62ec386694afbfa57/image.png)
![image](/uploads/854f83055693012100e031b2f38b1f55/image.png)
Tagging: @wlampl, @ekay, @pscholer, @calpigia, @verduccihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70056Draft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.2024-03-25T18:35:35+01:00John Derek ChapmanDraft: Extend unit tests for HepMcParticleLink and SiHitCollectionCnv_pX.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70106Draft: ActsGeometryContext - Non const access2024-03-27T08:20:11+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: ActsGeometryContext - Non const accesshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70152Draft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)2024-03-28T11:16:53+01:00John Derek ChapmanDraft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the i...The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the initial HepMcParticleLink member variables of the transient hit classes generated from the persistent classes to know whether they should be linking to an event other than the first event in the McEventCollection (The hard-scatter GenEvent is always first in the McEventCollection). This meant that calls to `HepMcParticleLink::id()` would return zero as the links often appear to be invalid.
This second version of the migration is less aggressive as it allows the possibility of barcode-based inputs. It avoids the issue seen in ATLSWUPGR-242 according to my local tests, but I will avoid marking the merge request as ready until we have a CI test to catch such an issue.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70174adding NSW combined offline DQ2024-03-29T09:14:24+01:00Michela Bigliettiadding NSW combined offline DQthis package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.this package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70195refine Phase-2 eta hough transform2024-03-29T08:40:39+01:00Maximilian Emanuel Goblirsch-Kolbrefine Phase-2 eta hough transformMake the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
...Make the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
CC @jojungge and @minionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70204Draft: sTgcReadoutElement - Fixing wireGroup Positions2024-03-28T21:09:21+01:00Ishan Kiritbhai VyasDraft: sTgcReadoutElement - Fixing wireGroup Positions- Changing localChannelPosition function in the readout element to replicate the R3 wireGroup positions.
- Fixing the beam line radius
@alainb @jojungge @pscholer- Changing localChannelPosition function in the readout element to replicate the R3 wireGroup positions.
- Fixing the beam line radius
@alainb @jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70205CscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixes2024-03-29T08:58:56+01:00Christos Anastopouloschristos.anastopoulos@cern.chCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixesCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixesCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixes