athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-01-08T16:36:56+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/62141AF3: mirror showers for positrons and negative hadrons2024-01-08T16:36:56+01:00Christopher YoungAF3: mirror showers for positrons and negative hadronsWhen we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the cod...When we derived the showers for AF3 we derived them for electrons and positive hadrons. We should therefore impose a phi -> -phi change for positrons and negative hadrons rather than all negative particles which was previously in the code.
These changes are pretty small but might help some electron ID agreement. Tests of the change on the angle of topoclusters are shown here;
https://indico.cern.ch/event/1274181/
indicating that this will be a small change to the physics but is in the correct direction.
Note that this will change the AF3 nightly output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65401Externals Update, main branch (2023.08.29)2023-09-02T20:45:16+02:00Marilena BandieramonteExternals Update, main branch (2023.08.29)Update to Atlas externals 2.0.168.
Update(s) since 2.0.167:
- Updated Geant4 to version 10.6.patch03.atlas08;
- Fixed a mistake in FindCppcheck.cmake with a variable name.
I expect that the CI will fail and a reference update will b...Update to Atlas externals 2.0.168.
Update(s) since 2.0.167:
- Updated Geant4 to version 10.6.patch03.atlas08;
- Fixed a mistake in FindCppcheck.cmake with a variable name.
I expect that the CI will fail and a reference update will be needed.
cc @tlari and @jchapmanFrank WinklmeierFrank Winklmeierhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62363AF3: Change logic for energy deposits outside of calorimeters2023-04-28T17:05:24+02:00Christopher YoungAF3: Change logic for energy deposits outside of calorimetersIn physics validation we saw that there are spikes topocluster distribution in AF3. This is a result of energy building up in the edge cells of calorimeters that get assigned all the energy beyond the calorimeter boundary. This MR change...In physics validation we saw that there are spikes topocluster distribution in AF3. This is a result of energy building up in the edge cells of calorimeters that get assigned all the energy beyond the calorimeter boundary. This MR changes the logic to scale up the energy within the calorimeter rather than re-assigning the energy in cells outside the calorimeter. Further details can be found in; https://indico.cern.ch/event/1274181/https://gitlab.cern.ch/atlas/athena/-/merge_requests/62140Avoid duplication of attributes already serialized in other way2023-04-13T17:18:04+02:00Andrii VerbytskyiAvoid duplication of attributes already serialized in other wayAvoid duplication of attributes already serialized in other way. Part of fixes for ATLASSIM-6217.
Tag @jchapmanAvoid duplication of attributes already serialized in other way. Part of fixes for ATLASSIM-6217.
Tag @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62144AF3: use IDCaloBoundary for extrapolation, improve CaloSurface list, suppress...2023-04-10T20:30:24+02:00Christopher YoungAF3: use IDCaloBoundary for extrapolation, improve CaloSurface list, suppress warningsWe want to use the IDCaloBoundary for the extrapolation of particles and only fall back to the CaloSurface when this doesn't work. Furthermore the CaloSurface should include the cases where the first calorimeter encountered is not in the...We want to use the IDCaloBoundary for the extrapolation of particles and only fall back to the CaloSurface when this doesn't work. Furthermore the CaloSurface should include the cases where the first calorimeter encountered is not in the previous list. Additionally we should further suppress the number of WARNINGS printed by adjusting the pT thresholds to give a WARNING in the CaloSurface determination.
This change should have minimal physics impact as seen by the matching between electrons and clusters here; https://indico.cern.ch/event/1269259/
Note that these are the same changes as in https://gitlab.cern.ch/atlas/athena/-/merge_requests/62055 which is already merged into master but here we target 23.0https://gitlab.cern.ch/atlas/athena/-/merge_requests/60507Externals Update, master branch (2023.02.08.)2023-03-05T18:14:38+01:00Attila KrasznahorkayExternals Update, master branch (2023.02.08.)Upgraded all projects to [atlasexternals-2.0.150](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.150). The changes wrt. [atlasexternals-2.0.148](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.148) are (https://gitlab.cern...Upgraded all projects to [atlasexternals-2.0.150](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.150). The changes wrt. [atlasexternals-2.0.148](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.148) are (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.148...2.0.150):
- Upgraded [PyModules](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/PyModules) and [flake8_atlas](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/flake8_atlas) to [flake8](https://pypi.org/project/flake8/) `6.0.0` (thanks to @fwinkl);
- Updated the [TBB](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/TBB) and [PyAnalysis](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/PyAnalysis) builds to work correctly with Clang ~~(on macOS)~~ (thanks to @tadej);
- Upgraded [Geant4](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/Geant4) to version `10.6.3.6` (thanks to @mbandier);
- Upgraded the versions of [Acts](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/Acts), [CLHEP](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/CLHEP), [Davix](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/Davix), [Gaudi](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/Gaudi) and [GeoModel](https://gitlab.cern.ch/atlas/atlasexternals/-/tree/master/External/GeoModel) to the ones used already through "`build_externals.sh` overrides".
At the same time removed all CMake flags from the `build_externals.sh` scripts that became unnecessary with the new tag.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61130Externals Update, master branch (2023.03.01)2023-03-02T21:42:31+01:00Marilena BandieramonteExternals Update, master branch (2023.03.01)Update externals version to 2.0.151.
This should fix: ATLASSIM-6403Update externals version to 2.0.151.
This should fix: ATLASSIM-6403https://gitlab.cern.ch/atlas/athena/-/merge_requests/59837Add meta-diff to most of CI tests with a reference2023-01-17T15:42:31+01:00Tadej Novaktadej.novak@cern.chAdd meta-diff to most of CI tests with a referenceEnable `meta-diff` in all tests with reference but reco (will be added separately). Only Athena release, file size and file GUID are ignored. It only runs if CA is not overridden (so the default tag that is also used as a reference) as w...Enable `meta-diff` in all tests with reference but reco (will be added separately). Only Athena release, file size and file GUID are ignored. It only runs if CA is not overridden (so the default tag that is also used as a reference) as we do not plan to have 100 % matching metadata.
Will need some reference updates due to AMI tag changes, but let's not ignore it as it will also validate the machinery.
Related to ATEAM-880.
/cc @nstyles @jcatmore @tlari @mbandier @jchapman @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/59083Move to McEventCollectionCnv_p62022-12-12T08:50:43+01:00Tadej Novaktadej.novak@cern.chMove to McEventCollectionCnv_p6Move to `McEventCollectionCnv_p6`.
/cc @jchapman @ewelina @mgignac @dhirsch @jcatmore @nstylesMove to `McEventCollectionCnv_p6`.
/cc @jchapman @ewelina @mgignac @dhirsch @jcatmore @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/53741Add Run 3 data digests2022-05-31T09:42:44+02:00Tadej Novaktadej.novak@cern.chAdd Run 3 data digestsThis is a ~master equivalent of !53740. It adds Run 3 data digests but does not enable ESD/AOD comparisons.
/cc @nstyles, @elmsheus, @pberta, @jmaurerThis is a ~master equivalent of !53740. It adds Run 3 data digests but does not enable ESD/AOD comparisons.
/cc @nstyles, @elmsheus, @pberta, @jmaurerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/52397Fix Tile Sampling Fraction in AF2 and AF3 jobs (ATLASSIM-5727)2022-05-18T14:36:54+02:00John Derek ChapmanFix Tile Sampling Fraction in AF2 and AF3 jobs (ATLASSIM-5727)These changes bring the old and new style configuration of AF3 and AF2 jobs into agreement.
Tagging @harkusha - is this safe to be merged or would you prefer to fix the old-style configuration in a different way?These changes bring the old and new style configuration of AF3 and AF2 jobs into agreement.
Tagging @harkusha - is this safe to be merged or would you prefer to fix the old-style configuration in a different way?https://gitlab.cern.ch/atlas/athena/-/merge_requests/50332add xAOD::EventInfo to HIT files instead of old EventInfo2022-04-26T18:24:57+02:00John Derek Chapmanadd xAOD::EventInfo to HIT files instead of old EventInfoFor the simulation of several beam spot sizes for Run3 it is needed to store the beam spot size of an event already in the HIT files. This MR stores the xAOD::EventInfo with the beam spot information instead of the old EventInfo in the H...For the simulation of several beam spot sizes for Run3 it is needed to store the beam spot size of an event already in the HIT files. This MR stores the xAOD::EventInfo with the beam spot information instead of the old EventInfo in the HIT files.
Workflows confirmed working so far:
- Simulation running on EVNT containing EventInfo
- Digitization w/o pile-up running in AthenaMT on HITS containing EventInfo
- Digitization w/o pile-up running in AthenaMT on HITS containing xAOD::EventInfo and TAG
- Digitization w/o pile-up running in serial Athena on HITS containing EventInfo
- Digitization w/o pile-up running in serial Athena on HITS containing xAOD::EventInfo and TAG
- Pile-up Digitization running in serial Athena on HS& PU HITS containing EventInfo
- Pile-up Digitization running in serial Athena on HITS containing xAOD::EventInfo and TAG & PU HITS containing EventInfo
- Pile-up Digitization running in AthenaMP on HS & PU HITS containing EventInfo
- Pile-up Digitization running in AthenaMP on HS HITS containing xAOD::EventInfo and TAG & PU HITS containing EventInfo
- Pile-up Digitization running in serial Athena on HS & PU HITS containing xAOD::EventInfo and TAG
- MC Overlay running in serial Athena on HITS containing EventInfo
- MC Overlay running in serial Athena on HITS containing xAOD::EventInfo and TAG
- MC Overlay running in AthenaMT on HITS containing EventInfo
- MC Overlay running in AthenaMT on HITS containing xAOD::EventInfo and TAG
- Data Overlay running in serial Athena on HITS containing EventInfo
- Data Overlay running in serial Athena on HITS containing xAOD::EventInfo and TAG
Workflows to test/implement:
- Simulation running on EVNT containing xAOD::EventInfo and TAG
- Pile-up Digitization running in AthenaMP on HS & PU HITS containing xAOD::EventInfo and TAG
- Data Overlay running in AthenaMT on HITS containing EventInfo
- Data Overlay running in AthenaMT on HITS containing xAOD::EventInfo and TAG
Based on !49806. Relates to ATEAM-804.https://gitlab.cern.ch/atlas/athena/-/merge_requests/49714Update RNG seeding to use stronger seeds2022-02-07T16:15:06+01:00Michael Duehrssen-DeblingUpdate RNG seeding to use stronger seedsUpdate of the RNG seeding in master together with a test that calcualtes how often seeds are re-used. The current standard seeding leads to the same seed being used by the random number generator in up to 0.3% of cases, see ATLASSIM-5338...Update of the RNG seeding in master together with a test that calcualtes how often seeds are re-used. The current standard seeding leads to the same seed being used by the random number generator in up to 0.3% of cases, see ATLASSIM-5338. The new seeding method leads to a substantilly reduced rate of producing the same seeds.
This MR is a copy of !46194 and needs to be merged as the only MR for a specific nightly. See the discussion in !46194 for the past reviewhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/50263Update reference for Trigger_athena_MC-test after RNG seeding changes in !497142022-02-07T08:55:20+01:00John Derek ChapmanUpdate reference for Trigger_athena_MC-test after RNG seeding changes in !49714FYI @elmsheus, @tadej.FYI @elmsheus, @tadej.https://gitlab.cern.ch/atlas/athena/-/merge_requests/50258Update expected values in AddNoiseCellBuilderTool_test after !497142022-02-06T15:42:42+01:00John Derek ChapmanUpdate expected values in AddNoiseCellBuilderTool_test after !49714Should be merged at the same time as !50257.
FYI @elmsheus and @tadejShould be merged at the same time as !50257.
FYI @elmsheus and @tadejhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/46194Update RNG seeding2022-01-17T16:53:10+01:00Michael Duehrssen-DeblingUpdate RNG seedingUpdate of the RNG seeding in master together with a test that calcualtes how often seeds are re-used. The current standard seeding leads to the same seed being used by the random number generator in up to 0.3% of cases, see ATLASSIM-5338...Update of the RNG seeding in master together with a test that calcualtes how often seeds are re-used. The current standard seeding leads to the same seed being used by the random number generator in up to 0.3% of cases, see ATLASSIM-5338. The new seeding method leads to a substantilly reduced rate of producing the same seeds.