athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-07-03T03:06:16+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/44898Closing LUT file2021-07-03T03:06:16+02:00Lisa Marie BaltesClosing LUT fileIn order to avoid to have too many open files at a time, I included a line, which closes the open LUT file.In order to avoid to have too many open files at a time, I included a line, which closes the open LUT file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44882Apply patch from master for GTower size2021-07-03T03:06:13+02:00Ben CarlsonApply patch from master for GTower sizehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44410
ATR-23086 https://gitlab.cern.ch/atlas/athena/-/merge_requests/44410
ATR-23086 https://gitlab.cern.ch/atlas/athena/-/merge_requests/44690gFEX Mapping2022-07-13T14:04:27+02:00Cecilia ToscirigFEX MappingThis is the bitwise simulation for gFEX. It includes the gFEX JetFinder algorithm. TOB words are created within the AlgoTool, and saved in the OutputCollection. The gTowers mapping has been validated.This is the bitwise simulation for gFEX. It includes the gFEX JetFinder algorithm. TOB words are created within the AlgoTool, and saved in the OutputCollection. The gTowers mapping has been validated.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44410Fix issue where invalid tower IDs were being used2021-07-01T17:33:04+02:00Jon BurrFix issue where invalid tower IDs were being usedFixes ATR-23086. The issue was that the forward g towers aren't in the database so the ID helper returns nonsense from them. I added a check for that case and now it shouldn't try and access invalid information.Fixes ATR-23086. The issue was that the forward g towers aren't in the database so the ID helper returns nonsense from them. I added a check for that case and now it shouldn't try and access invalid information.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44352jFEX jet algorithm2021-06-23T12:39:27+02:00Ben CarlsonjFEX jet algorithmImplementing the cleaned up jFEX jet algorithms in preparation of migration to rel22. ATR-23713
- Seeding algorithm
- Small jets
- Large jets
- Saves all of the above to the trigger EDM
Also cleaned up the WARNING messages in EFexEMCl...Implementing the cleaned up jFEX jet algorithms in preparation of migration to rel22. ATR-23713
- Seeding algorithm
- Small jets
- Large jets
- Saves all of the above to the trigger EDM
Also cleaned up the WARNING messages in EFexEMClusterToolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44046Fixing a loop hole in FwdCell Reader2021-06-04T11:23:00+02:00Ben CarlsonFixing a loop hole in FwdCell ReaderATR-23416ATR-23416https://gitlab.cern.ch/atlas/athena/-/merge_requests/44044Fix FPEs and INFO messages in TrigT1CaloFexPerf2021-06-03T03:03:37+02:00Ben CarlsonFix FPEs and INFO messages in TrigT1CaloFexPerfATR-23450
ATR-23449ATR-23450
ATR-23449https://gitlab.cern.ch/atlas/athena/-/merge_requests/43799Bug fixes related to jFEX forward region supercell mapping.2021-05-27T03:02:19+02:00Jacob Julian KempsterBug fixes related to jFEX forward region supercell mapping.This commit resolves bugs related to the mapping of the jFEX forward region for the bitwise simulation. The bugs originated both from the user code and from the MC supercell record which should/could also be repaired in the future (for ...This commit resolves bugs related to the mapping of the jFEX forward region for the bitwise simulation. The bugs originated both from the user code and from the MC supercell record which should/could also be repaired in the future (for now this code simply avoids the issue).
@afaulkne @vasothil @serodrighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43684Add getters for eta/phi indices in format used by L1Topo2021-05-22T03:03:33+02:00Alan WatsonAdd getters for eta/phi indices in format used by L1TopoThis update adds 2 getters to xAOD::eFexEMRoI_v1, which provide eta and phi indices with the ranges and granularities used by, and requested by, L1Topo. It also changes the range of the existing iEta() getter (integer eta index at tower ...This update adds 2 getters to xAOD::eFexEMRoI_v1, which provide eta and phi indices with the ranges and granularities used by, and requested by, L1Topo. It also changes the range of the existing iEta() getter (integer eta index at tower granularity) to use a consistent convention (signed). The data content of the object is not changed, so it has no implications for persistency.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43616L1Calo efex thresholds now from the menu, finer granularity tob eta range, an...2021-05-22T03:03:13+02:00Alison ElliotL1Calo efex thresholds now from the menu, finer granularity tob eta range, and code cleanupSeveral updates for the L1Calo eFEX bitwise simulation:
-- the thresholds are now taken from the L1Menu, and set the reta rhad and wstot working points in the tob, and EDM.
-- the TOB words in the EDM now use the eta seed as well, mean...Several updates for the L1Calo eFEX bitwise simulation:
-- the thresholds are now taken from the L1Menu, and set the reta rhad and wstot working points in the tob, and EDM.
-- the TOB words in the EDM now use the eta seed as well, meaning they should have the finer granularity from 0.1 to 0.025
-- several bugs fixed:
---- TOB sorting and resizing no longer requires 6 tobs (can have fewer).
---- code requiring TOBs to have a seed was commented out for debugging - and is now reinstated.
-- some deprecated histogram testing code removedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43599L1Calo Bitwise Offline Software Simulation: Sum ET and MET EDMs2021-05-22T03:07:06+02:00Varsiha SothilingamL1Calo Bitwise Offline Software Simulation: Sum ET and MET EDMsL1Calo Bitwise EDMs created for Sum ET and MET algorithms in jFEX simulation.
The EDM containers and aux containers are created but are not filled yet from the algorithms
The only variables currently in the EDM are from the TOB words wh...L1Calo Bitwise EDMs created for Sum ET and MET algorithms in jFEX simulation.
The EDM containers and aux containers are created but are not filled yet from the algorithms
The only variables currently in the EDM are from the TOB words which jFEX firmware will send.
Code changes are in xAODTrigger and xAODTriggerAthenaPoolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43433Update EDM (eFEX numbering and remove threshold mask)2021-05-16T14:59:55+02:00Alan WatsonUpdate EDM (eFEX numbering and remove threshold mask)Updates to eFEX e/gamma EDM:
* update eFEX numbering to match new firmware
* change some aux member variables: replace integer coordinates with float (ints calculated on the fly when requested), remove threshold pattern (will become a de...Updates to eFEX e/gamma EDM:
* update eFEX numbering to match new firmware
* change some aux member variables: replace integer coordinates with float (ints calculated on the fly when requested), remove threshold pattern (will become a decoration)
* fix xAOD persistency
Updates to eFEX simulation to use new eFEX numbering in EDM creationAlan WatsonAlan Watsonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43382Minor changes in Small R Jet algorithm in L1Calo Bitwise Offline software sim...2021-05-18T03:03:03+02:00Varsiha SothilingamMinor changes in Small R Jet algorithm in L1Calo Bitwise Offline software simulationMinor changes made to algorithm, fixing bugs in algorithm. Changes will be needed for L1Topo simulation.
Additional variables have been added to the small R, large R and tau EDM to return global coordiantes.Minor changes made to algorithm, fixing bugs in algorithm. Changes will be needed for L1Topo simulation.
Additional variables have been added to the small R, large R and tau EDM to return global coordiantes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42961Cleanup of eFEX tau algorithm to work with cells2021-04-30T16:51:36+02:00Ben CarlsonCleanup of eFEX tau algorithm to work with cellshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42842inclusion of more detailed timing and bitmasks for BCID max and a la LATOME. ...2021-04-26T03:02:29+02:00Denis Oliveira Damazioinclusion of more detailed timing and bitmasks for BCID max and a la LATOME. Related to ATR-23147.The title should be quite easy to understand.
We calculate, for Super-Cell, three energies, one with [0,5], another with [1,6] and a final one with [2,7] simples. If the [1,6] gives higher amplitude, this is the good one.
Also, moved the...The title should be quite easy to understand.
We calculate, for Super-Cell, three energies, one with [0,5], another with [1,6] and a final one with [2,7] simples. If the [1,6] gives higher amplitude, this is the good one.
Also, moved the saved samples from short to float and pre-subtracted the pedestal to avoid
issues.
The time, for the Super-Cells, is calculated with [1,6] always.
The code passed local ctest, meaning that the LArRawChannels reconstruction is working.
@pavol will certainly want to talk about this.
Related to https://its.cern.ch/jira/browse/ATR-23147
Cheers,
Denishttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42794Turn off debug lines by default2021-04-23T03:05:28+02:00Ben CarlsonTurn off debug lines by defaultATR-23270ATR-23270https://gitlab.cern.ch/atlas/athena/-/merge_requests/42733Addition and modification of Trigger ATR python executables (ATR-23287)2021-04-23T03:04:41+02:00Yasuyuki OkumuraAddition and modification of Trigger ATR python executables (ATR-23287)This MR is for:
- Addition of new ART test executable python script (`Trigger/TrigValidation/TriggerTest/test/test_trig_data_v1Dev_rerunL1_phase1_build.py`) and
- Modification of input data samples in an existing test of `Trigger/TrigVa...This MR is for:
- Addition of new ART test executable python script (`Trigger/TrigValidation/TriggerTest/test/test_trig_data_v1Dev_rerunL1_phase1_build.py`) and
- Modification of input data samples in an existing test of `Trigger/TrigValidation/TriggerTest/test/test_trig_mc_v1Dev_slice_muon_phase1_build.py`.
The details are mentioned in ATR-23287.
No impact on others is expected with this modification.
Best regards,
Yasu Okumura
for trigger validation teamhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42421Add some flags so we can work with phase II2021-04-14T14:57:57+02:00Ben CarlsonAdd some flags so we can work with phase IIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42412SC emulation: fixing a loop hole2021-04-10T03:02:25+02:00Ben CarlsonSC emulation: fixing a loop holehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42393L1Calo bitwise jFEX Bug Fix2021-04-14T03:03:21+02:00Jacob Julian KempsterL1Calo bitwise jFEX Bug Fix- Fixes many bugs in forward jFEX jTower to jFPGA mapping.
- Inserts code for future use for eFEX CSV file production. (This will be used once I work out how to implement configuration flags at run time which is presently beyond me - bu...- Fixes many bugs in forward jFEX jTower to jFPGA mapping.
- Inserts code for future use for eFEX CSV file production. (This will be used once I work out how to implement configuration flags at run time which is presently beyond me - but it is important to make the code accessible to colleagues already).
@afaulkne @vasothil